coreboot-gerrit January 2018

coreboot-gerrit@coreboot.org

1 participants
2315 discussions

Change in coreboot[master]: drvs/lenovo/h8: Morse death message
by Patrick Rudolph (Code Review) 04 Jan '18

04 Jan '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23072 to look at the new patch set (#2). Change subject: drvs/lenovo/h8: Morse death message ...................................................................... drvs/lenovo/h8: Morse death message Add a morse generator and use it on Lenovo devices to beep the death message. Using a morse-to-text application like "Morse Tools" the message can be easily analysed using a mobile phone and helps a lot more than just flashing LEDs. The morse encoding was done by Tom Russo. Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> Change-Id: Iccf6a43a28d0eb515051b5be0a0f23d40e82c2d2 --- M src/console/die.c A src/drivers/generic/morse.h M src/ec/lenovo/h8/Kconfig M src/ec/lenovo/h8/panic.c M src/include/console/console.h 5 files changed, 124 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/23072/2 -- To view, visit https://review.coreboot.org/23072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iccf6a43a28d0eb515051b5be0a0f23d40e82c2d2 Gerrit-Change-Number: 23072 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: google/reef: Add babymako
by Patrick Georgi (Code Review) 04 Jan '18

04 Jan '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/23086 ) Change subject: google/reef: Add babymako ...................................................................... Patch Set 2: We don't allow symlinks because (among other reasons) the code base is usable with Windows, where symlinks are... irksome -- To view, visit https://review.coreboot.org/23086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia055b55dbdbc8c3f1e1e25089170f77039aeb15d Gerrit-Change-Number: 23086 Gerrit-PatchSet: 2 Gerrit-Owner: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 10:40:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 59: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19990/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65257/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 59 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 09:32:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ifdtool: refactor region-permission-related functions
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related functions ...................................................................... Patch Set 62: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19989/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65256/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 62 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 09:21:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ifdtool: Port the feature to jail ME from me_cleaner
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21607 ) Change subject: ifdtool: Port the feature to jail ME from me_cleaner ...................................................................... Patch Set 27: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/65255/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/19988/ : SUCCESS -- To view, visit https://review.coreboot.org/21607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00533f4e2569c4763fbfc302bb460db1e60e5564 Gerrit-Change-Number: 21607 Gerrit-PatchSet: 27 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 09:15:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/reef: Add babymako
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23086 ) Change subject: google/reef: Add babymako ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/65254/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/19987/ : SUCCESS -- To view, visit https://review.coreboot.org/23086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia055b55dbdbc8c3f1e1e25089170f77039aeb15d Gerrit-Change-Number: 23086 Gerrit-PatchSet: 2 Gerrit-Owner: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 09:00:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/reef: Add babymako
by Marco Chen (Code Review) 04 Jan '18

04 Jan '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23086 to look at the new patch set (#2). Change subject: google/reef: Add babymako ...................................................................... google/reef: Add babymako A new variant from reef. All files are sym-linked to coral. Change-Id: Ia055b55dbdbc8c3f1e1e25089170f77039aeb15d Signed-off-by: Marco Chen <marcochen(a)google.com> --- M src/mainboard/google/reef/Kconfig M src/mainboard/google/reef/Kconfig.name A src/mainboard/google/reef/variants/babymako/Makefile.inc A src/mainboard/google/reef/variants/babymako/devicetreee.cb A src/mainboard/google/reef/variants/babymako/gpio.c A src/mainboard/google/reef/variants/babymako/include A src/mainboard/google/reef/variants/babymako/mainboard.c 7 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/23086/2 -- To view, visit https://review.coreboot.org/23086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia055b55dbdbc8c3f1e1e25089170f77039aeb15d Gerrit-Change-Number: 23086 Gerrit-PatchSet: 2 Gerrit-Owner: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: google/reef: Add babymako
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23086 ) Change subject: google/reef: Add babymako ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/65253/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/19986/ : SUCCESS -- To view, visit https://review.coreboot.org/23086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia055b55dbdbc8c3f1e1e25089170f77039aeb15d Gerrit-Change-Number: 23086 Gerrit-PatchSet: 1 Gerrit-Owner: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 08:55:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/reef: Add babymako
by Marco Chen (Code Review) 04 Jan '18

04 Jan '18

Marco Chen has uploaded this change for review. ( https://review.coreboot.org/23086 Change subject: google/reef: Add babymako ...................................................................... google/reef: Add babymako A new variant from reef. All files are sym-linked to coral. Change-Id: Ia055b55dbdbc8c3f1e1e25089170f77039aeb15d Signed-off-by: Marco Chen <marcochen(a)google.com> --- M src/mainboard/google/reef/Kconfig M src/mainboard/google/reef/Kconfig.name A src/mainboard/google/reef/variants/babymako/Makefile.inc A src/mainboard/google/reef/variants/babymako/devicetreee.cb A src/mainboard/google/reef/variants/babymako/gpio.c A src/mainboard/google/reef/variants/babymako/include A src/mainboard/google/reef/variants/babymako/mainboard.c 7 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/23086/1 diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index bea7fd0..cbd3fb1 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -59,9 +59,11 @@ default "snappy" if BOARD_GOOGLE_SNAPPY default "nasher" if BOARD_GOOGLE_NASHER default "coral" if BOARD_GOOGLE_CORAL + default "babymako" if BOARD_GOOGLE_BABYMAKO config DEVICETREE string + default "variants/babymako/devicetree.cb" if BOARD_GOOGLE_BABY default "variants/coral/devicetree.cb" if BOARD_GOOGLE_CORAL default "variants/pyro/devicetree.cb" if BOARD_GOOGLE_PYRO default "variants/sand/devicetree.cb" if BOARD_GOOGLE_SAND @@ -76,10 +78,12 @@ default "Snappy" if BOARD_GOOGLE_SNAPPY default "Nasher" if BOARD_GOOGLE_NASHER default "Coral" if BOARD_GOOGLE_CORAL + default "BabyMako" if BOARD_GOOGLE_BABYMAKO config MAINBOARD_FAMILY string default "Google_Coral" if BOARD_GOOGLE_CORAL + default "Google_Coral" if BOARD_GOOGLE_BABYMAKO default "Google_Reef" config GBB_HWID @@ -91,6 +95,7 @@ default "SNAPPY TEST 1088" if BOARD_GOOGLE_SNAPPY default "NASHER TEST 4258" if BOARD_GOOGLE_NASHER default "CORAL TEST 8594" if BOARD_GOOGLE_CORAL + default "CORAL TEST 8594" if BOARD_GOOGLE_BABYMAKO config MAX_CPUS int diff --git a/src/mainboard/google/reef/Kconfig.name b/src/mainboard/google/reef/Kconfig.name index abbeb70..619acdc 100644 --- a/src/mainboard/google/reef/Kconfig.name +++ b/src/mainboard/google/reef/Kconfig.name @@ -27,3 +27,8 @@ bool "Coral" select BOARD_GOOGLE_BASEBOARD_REEF select BASEBOARD_REEF_LAPTOP + +config BOARD_GOOGLE_BABYMAKO + bool "BabyMako" + select BOARD_GOOGLE_BASEBOARD_REEF + select BASEBOARD_REEF_LAPTOP diff --git a/src/mainboard/google/reef/variants/babymako/Makefile.inc b/src/mainboard/google/reef/variants/babymako/Makefile.inc new file mode 120000 index 0000000..3d30189 --- /dev/null +++ b/src/mainboard/google/reef/variants/babymako/Makefile.inc @@ -0,0 +1 @@ +../coral/Makefile.inc \ No newline at end of file diff --git a/src/mainboard/google/reef/variants/babymako/devicetreee.cb b/src/mainboard/google/reef/variants/babymako/devicetreee.cb new file mode 120000 index 0000000..f84b5a6 --- /dev/null +++ b/src/mainboard/google/reef/variants/babymako/devicetreee.cb @@ -0,0 +1 @@ +../coral/devicetree.cb \ No newline at end of file diff --git a/src/mainboard/google/reef/variants/babymako/gpio.c b/src/mainboard/google/reef/variants/babymako/gpio.c new file mode 120000 index 0000000..dc76e2f --- /dev/null +++ b/src/mainboard/google/reef/variants/babymako/gpio.c @@ -0,0 +1 @@ +../coral/gpio.c \ No newline at end of file diff --git a/src/mainboard/google/reef/variants/babymako/include b/src/mainboard/google/reef/variants/babymako/include new file mode 120000 index 0000000..c56ad1b --- /dev/null +++ b/src/mainboard/google/reef/variants/babymako/include @@ -0,0 +1 @@ +../coral/include \ No newline at end of file diff --git a/src/mainboard/google/reef/variants/babymako/mainboard.c b/src/mainboard/google/reef/variants/babymako/mainboard.c new file mode 120000 index 0000000..c7b7854 --- /dev/null +++ b/src/mainboard/google/reef/variants/babymako/mainboard.c @@ -0,0 +1 @@ +../coral/mainboard.c \ No newline at end of file -- To view, visit https://review.coreboot.org/23086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia055b55dbdbc8c3f1e1e25089170f77039aeb15d Gerrit-Change-Number: 23086 Gerrit-PatchSet: 1 Gerrit-Owner: Marco Chen <marcochen(a)google.com>

1 0

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 58: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19985/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65252/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 58 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 08:01:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2018