coreboot-gerrit January 2018

coreboot-gerrit@coreboot.org

1 participants
2315 discussions

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 60: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20002/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65269/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 60 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 17:03:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: google/kahlee/variants/(kahlee/baseboard)/gpio.c: Convert GPIO table
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22988 ) Change subject: google/kahlee/variants/(kahlee/baseboard)/gpio.c: Convert GPIO table ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20001/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65268/ : SUCCESS -- To view, visit https://review.coreboot.org/22988 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88bf2c855105a6bc458aedfc6da7725662695667 Gerrit-Change-Number: 22988 Gerrit-PatchSet: 4 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 16:58:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ifdtool: Port the feature to jail ME from me_cleaner
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21607 ) Change subject: ifdtool: Port the feature to jail ME from me_cleaner ...................................................................... Patch Set 28: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/65271/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/20004/ : SUCCESS -- To view, visit https://review.coreboot.org/21607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00533f4e2569c4763fbfc302bb460db1e60e5564 Gerrit-Change-Number: 21607 Gerrit-PatchSet: 28 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 16:55:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/gitconfig: Don't require `remake`
by Alex Thiessen (Code Review) 04 Jan '18

04 Jan '18

Alex Thiessen has abandoned this change. ( https://review.coreboot.org/23093 ) Change subject: util/gitconfig: Don't require `remake` ...................................................................... Abandoned doesn't work -- To view, visit https://review.coreboot.org/23093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ic5ee9a0770e173ef0ffacc773c7f30f38cf478e9 Gerrit-Change-Number: 23093 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com>

1 0

Change in coreboot[master]: drvs/lenovo/h8: Morse death message
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23072 ) Change subject: drvs/lenovo/h8: Morse death message ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20000/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65267/ : SUCCESS -- To view, visit https://review.coreboot.org/23072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iccf6a43a28d0eb515051b5be0a0f23d40e82c2d2 Gerrit-Change-Number: 23072 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 16:05:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/sandybridge: Reduce storage size
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23088 ) Change subject: nb/intel/sandybridge: Reduce storage size ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19998/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65265/ : SUCCESS -- To view, visit https://review.coreboot.org/23088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3bb026fb1bd81b66f8a5be333760990d924071f Gerrit-Change-Number: 23088 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 16:03:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mrc_cache.h: Include <commonlib/region.h>
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23092 ) Change subject: mrc_cache.h: Include <commonlib/region.h> ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19997/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65264/ : SUCCESS -- To view, visit https://review.coreboot.org/23092 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id99da3a54daf96b04f3ee7c41e73cceb4432c5b3 Gerrit-Change-Number: 23092 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 15:44:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/gitconfig: Don't require `remake`
by Alex Thiessen (Code Review) 04 Jan '18

04 Jan '18

Alex Thiessen has uploaded this change for review. ( https://review.coreboot.org/23093 Change subject: util/gitconfig: Don't require `remake` ...................................................................... util/gitconfig: Don't require `remake` As the code was moved from the Makefile.inc to a separate file, `$(MAKE)` was replaced by `remake`, introducing dependency on this tool which is basically a `make` with debugging capabilities. Many developers don't have `remake` installed, leading to pre-commit hooks being not executed properly. Apparently this was an unintentional change in commit 9ab8ae6a (util/gitconfig: Make gitconfig a bash script) and so it is reverted. Change-Id: Ic5ee9a0770e173ef0ffacc773c7f30f38cf478e9 Signed-off-by: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> --- M util/gitconfig/gitconfig.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/23093/1 diff --git a/util/gitconfig/gitconfig.sh b/util/gitconfig/gitconfig.sh index 5f91a69..b80a2e9 100755 --- a/util/gitconfig/gitconfig.sh +++ b/util/gitconfig/gitconfig.sh @@ -7,7 +7,8 @@ for hook in commit-msg pre-commit ; do if [ util/gitconfig/$hook -nt .git/hooks/$hook ] || \ [ ! -x .git/hooks/$hook ]; then - sed -e "s,%MAKE%,remake,g" util/gitconfig/$hook > .git/hooks/$hook + sed -e "s,%MAKE%,$(MAKE),g" util/gitconfig/$hook \ + > .git/hooks/$hook chmod +x .git/hooks/$hook fi done -- To view, visit https://review.coreboot.org/23093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic5ee9a0770e173ef0ffacc773c7f30f38cf478e9 Gerrit-Change-Number: 23093 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com>

1 0

Change in coreboot[master]: mrc_cache.h: Include <commonlib/region.h>
by Arthur Heymans (Code Review) 04 Jan '18

04 Jan '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23092 Change subject: mrc_cache.h: Include <commonlib/region.h> ...................................................................... mrc_cache.h: Include <commonlib/region.h> No definition for the struct 'region_device' is given in this file, which means that other files that include this header will have to include <commonlib/region.h> before it, making header inclusion fragile. Change-Id: Id99da3a54daf96b04f3ee7c41e73cceb4432c5b3 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/include/mrc_cache.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/23092/1 diff --git a/src/include/mrc_cache.h b/src/include/mrc_cache.h index 4511fc3..498ecbf 100644 --- a/src/include/mrc_cache.h +++ b/src/include/mrc_cache.h @@ -18,6 +18,7 @@ #include <stddef.h> #include <stdint.h> +#include <commonlib/region.h> enum { MRC_TRAINING_DATA, -- To view, visit https://review.coreboot.org/23092 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id99da3a54daf96b04f3ee7c41e73cceb4432c5b3 Gerrit-Change-Number: 23092 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: sb/intel/i82801ix: Don't select HAVE_INTEL_FIRMWARE on Q35-QEMU
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23090 ) Change subject: sb/intel/i82801ix: Don't select HAVE_INTEL_FIRMWARE on Q35-QEMU ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19996/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65263/ : SUCCESS -- To view, visit https://review.coreboot.org/23090 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89b0c2a7b3e9c163ce4b4eb5b38ab5fa70ba3cfa Gerrit-Change-Number: 23090 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 13:54:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2018