build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19917 )
Change subject: nb/intel/x4x/raminit: Add DDR3 enhanced mode and power settings
......................................................................
Patch Set 9:
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/20020/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/65287/ : SUCCESS
--
To view, visit https://review.coreboot.org/19917
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d34154d3ac1dd1e5400d692d4dcce70d95662c8
Gerrit-Change-Number: 19917
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 04 Jan 2018 20:21:21 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/23096
to look at the new patch set (#2).
Change subject: util/gitconfig: Use `make` in git hooks
......................................................................
util/gitconfig: Use `make` in git hooks
As the code was moved from the Makefile.inc to a separate file in
commit 9ab8ae6a (util/gitconfig: Make gitconfig a bash script),`$(MAKE)`
was replaced by `remake`, introducing dependency on this tool which is
basically a `make` with debugging capabilities. Many developers don't
have `remake` installed, leading to pre-commit hooks being not executed
properly. Apparently this was an unintentional change.
Furthermore, special treatment of `make` tool via the `%MAKE%`
substitution performed during hooks' deployment doesn't seem justified.
It was introduced in commit f3947152 (gitconfig: Use the right make
executable in git hooks) and back then, `make` was called via `exec`.
This is not the case anymore since commit b18f522b (lint/gitconfig:
Enable checkpatch.pl checking of commits) and I think it's obsolete now.
Replace `sed` and `chmod +x` with `install` for brevity.
Change-Id: Ia78e06567b904b342dc9b7778569201fe02e6897
Signed-off-by: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com>
---
M util/gitconfig/gitconfig.sh
M util/gitconfig/pre-commit
2 files changed, 3 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/23096/2
--
To view, visit https://review.coreboot.org/23096
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia78e06567b904b342dc9b7778569201fe02e6897
Gerrit-Change-Number: 23096
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19871 )
Change subject: nb/intel/x4x/raminit: Make programming crossclock support DDR3
......................................................................
Patch Set 8:
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/20010/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/65277/ : SUCCESS
--
To view, visit https://review.coreboot.org/19871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86b70e06c81817854994b7feddf9f3638fd16198
Gerrit-Change-Number: 19871
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 04 Jan 2018 20:08:58 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No