build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21703 )
Change subject: soc/intel/common/opregion: Get rid of opregion.c
......................................................................
Patch Set 9: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/21313/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/66706/ : SUCCESS
--
To view, visit https://review.coreboot.org/21703
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f78e9030df12da5369d142dda5c59e576ebcef7
Gerrit-Change-Number: 21703
Gerrit-PatchSet: 9
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 29 Jan 2018 10:22:48 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/23486 )
Change subject: autoport: Don't do writes to FD
......................................................................
autoport: Don't do writes to FD
This is properly done in ramstage, so no need to do it in romstage.
Change-Id: I4edb75569ceec2d2f1308755a66d286202ca0ae6
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M util/autoport/bd82x6x.go
1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/23486/2
--
To view, visit https://review.coreboot.org/23486
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4edb75569ceec2d2f1308755a66d286202ca0ae6
Gerrit-Change-Number: 23486
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23486
Change subject: autoport: Don't do write to FD
......................................................................
autoport: Don't do write to FD
This is properly done in ramstage, so no need to do it in romstage.
Change-Id: I4edb75569ceec2d2f1308755a66d286202ca0ae6
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M util/autoport/bd82x6x.go
1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/23486/1
diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go
index d342a79..c7862cf 100644
--- a/util/autoport/bd82x6x.go
+++ b/util/autoport/bd82x6x.go
@@ -336,12 +336,8 @@
void rcba_config(void)
{
- /* Disable devices. */
`)
- RestoreRCBA32(sb, inteltool, 0x3414)
- RestoreRCBA32(sb, inteltool, 0x3418)
-
- sb.WriteString("\n}\n")
+ sb.WriteString("}\n\n")
sb.WriteString("const struct southbridge_usb_port mainboard_usb_ports[] = {\n")
--
To view, visit https://review.coreboot.org/23486
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4edb75569ceec2d2f1308755a66d286202ca0ae6
Gerrit-Change-Number: 23486
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>