coreboot-gerrit January 2018

coreboot-gerrit@coreboot.org

1 participants
2315 discussions

Change in coreboot[master]: mainboard/google/kahlee: Update Grunt devicetree.
by Justin TerAvest (Code Review) 04 Jan '18

04 Jan '18

Justin TerAvest has uploaded this change for review. ( https://review.coreboot.org/23099 Change subject: mainboard/google/kahlee: Update Grunt devicetree. ...................................................................... mainboard/google/kahlee: Update Grunt devicetree. Grunt's devicetree dropped some entries when it was split from the kahlee variant. This commit restores: spd_addr_lookup - memory information for AGESA dram_clear_on_reset - keeps DRAM contents on reset uma_mode - needed for vbios uma_size - needed for vbios Change-Id: I1d8cdc97594867f1d706318370055087976a5104 Signed-off-by: Justin TerAvest <teravest(a)chromium.org> --- M src/mainboard/google/kahlee/variants/grunt/devicetree.cb 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/23099/1 diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb index 6558dec..d35467f 100644 --- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb @@ -13,6 +13,14 @@ # GNU General Public License for more details. # chip soc/amd/stoneyridge + register "spd_addr_lookup" = " + { + { {0xA0, 0x00} }, // socket 0 - Channel 0, slot 0 + }" + register "dram_clear_on_reset" = "DRAM_CONTENTS_KEEP" + register "uma_mode" = "UMAMODE_SPECIFIED_SIZE" + register "uma_size" = "128 * MiB" + device cpu_cluster 0 on device lapic 10 on end end -- To view, visit https://review.coreboot.org/23099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1d8cdc97594867f1d706318370055087976a5104 Gerrit-Change-Number: 23099 Gerrit-PatchSet: 1 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org>

1 0

Change in coreboot[master]: util/lint: Check license headers of git hooks
by Alex Thiessen (Code Review) 04 Jan '18

04 Jan '18

Alex Thiessen has uploaded this change for review. ( https://review.coreboot.org/23098 Change subject: util/lint: Check license headers of git hooks ...................................................................... util/lint: Check license headers of git hooks Now that all the files under util/gitconfig have their license headers, enable lint-000-license-headers to check the directory too. Change-Id: I242256f72ac70553535509f83166c6d1ddb16fdc Signed-off-by: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> --- M util/lint/lint-000-license-headers 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/23098/1 diff --git a/util/lint/lint-000-license-headers b/util/lint/lint-000-license-headers index d8d04be..103c1f0 100755 --- a/util/lint/lint-000-license-headers +++ b/util/lint/lint-000-license-headers @@ -23,7 +23,6 @@ ^util/kconfig/|\ ^util/romcc/tests|\ ^util/romcc/results|\ -^util/gitconfig|\ Kconfig|\ \<COPYING\>|\ \<LICENSE\>|\ -- To view, visit https://review.coreboot.org/23098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I242256f72ac70553535509f83166c6d1ddb16fdc Gerrit-Change-Number: 23098 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com>

1 0

Change in coreboot[master]: util/gitconfig: Add missing license headers
by Alex Thiessen (Code Review) 04 Jan '18

04 Jan '18

Alex Thiessen has uploaded this change for review. ( https://review.coreboot.org/23097 Change subject: util/gitconfig: Add missing license headers ...................................................................... util/gitconfig: Add missing license headers License header for the `gitconfig.sh` was copied from the Makefile it was extracted from in commit 9ab8ae6a (util/gitconfig: Make gitconfig a bash script). License header for the pre-commit hook names Patrik Georgy as the copyright holder as he is the original author. Change-Id: Ie051e5e6ae7571050ece383e6be8236ed7d1ddd9 Signed-off-by: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> --- M util/gitconfig/gitconfig.sh M util/gitconfig/pre-commit 2 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/23097/1 diff --git a/util/gitconfig/gitconfig.sh b/util/gitconfig/gitconfig.sh index 5f91a69..2f96fd4 100755 --- a/util/gitconfig/gitconfig.sh +++ b/util/gitconfig/gitconfig.sh @@ -1,4 +1,20 @@ #!/bin/bash + +## +## This file is part of the coreboot project. +## +## Copyright (C) 2011 secunet Security Networks AG +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + if [ ! -d .git ]; then echo "Error: Not in a git repository" exit 1 diff --git a/util/gitconfig/pre-commit b/util/gitconfig/pre-commit index 1c04bc3..ac0db4a 100755 --- a/util/gitconfig/pre-commit +++ b/util/gitconfig/pre-commit @@ -1,4 +1,20 @@ #!/bin/sh + +## +## This file is part of the coreboot project. +## +## Copyright (C) 2015 Patrick Georgi <patrick(a)georgi-clan.de> +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + %MAKE% lint-stable PATCHDIFF=$(git diff --cached) -- To view, visit https://review.coreboot.org/23097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie051e5e6ae7571050ece383e6be8236ed7d1ddd9 Gerrit-Change-Number: 23097 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add audio NHLT support
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22134 ) Change subject: soc/intel/cannonlake: Add audio NHLT support ...................................................................... Patch Set 14: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20025/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65293/ : SUCCESS -- To view, visit https://review.coreboot.org/22134 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8561cc64412bef54329b317874a8fe12e0bf889 Gerrit-Change-Number: 22134 Gerrit-PatchSet: 14 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 20:41:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/gitconfig: Use `make` in git hooks
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23096 ) Change subject: util/gitconfig: Use `make` in git hooks ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/65292/ : SUCCESS -- To view, visit https://review.coreboot.org/23096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia78e06567b904b342dc9b7778569201fe02e6897 Gerrit-Change-Number: 23096 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Reviewer: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 20:34:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x: Adapt post JEDEC for DDR3
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19918 ) Change subject: nb/intel/x4x: Adapt post JEDEC for DDR3 ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20021/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65288/ : SUCCESS -- To view, visit https://review.coreboot.org/19918 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I708f98dc2f36af73bb5933d186b4984649e149a1 Gerrit-Change-Number: 19918 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 20:32:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x: Disable watchdog, halt TCO timer and clear timeout
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22997 ) Change subject: nb/intel/x4x: Disable watchdog, halt TCO timer and clear timeout ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20022/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65289/ : SUCCESS -- To view, visit https://review.coreboot.org/22997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfd3789312704f61000a417f23a121d02d2e7fbe Gerrit-Change-Number: 22997 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 20:28:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x: Limit DDR3 speed to 400MHz
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22998 ) Change subject: nb/intel/x4x: Limit DDR3 speed to 400MHz ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20023/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65290/ : SUCCESS -- To view, visit https://review.coreboot.org/22998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11f663a50a42c70ed63ba045bd89fcd96cd047ce Gerrit-Change-Number: 22998 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 20:27:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/gitconfig: Use `make` in git hooks
by Patrick Georgi (Code Review) 04 Jan '18

04 Jan '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/23096 ) Change subject: util/gitconfig: Use `make` in git hooks ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/23096/2/util/gitconfig/gitconfig.sh File util/gitconfig/gitconfig.sh: https://review.coreboot.org/#/c/23096/2/util/gitconfig/gitconfig.sh@a10 PS2, Line 10: or add MAKE?=make somewhere and use s,%MAKE%,${MAKE},g here? that way it uses make by default and whatever the build system was called with in case of "make gitconfig". -- To view, visit https://review.coreboot.org/23096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia78e06567b904b342dc9b7778569201fe02e6897 Gerrit-Change-Number: 23096 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Reviewer: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 20:24:18 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/intel/dg41wv: Add mainboard
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20003 ) Change subject: mb/intel/dg41wv: Add mainboard ...................................................................... Patch Set 10: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/65291/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/20024/ : SUCCESS -- To view, visit https://review.coreboot.org/20003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If01bf658e52d273c3c203d362f21c3cb9c623f40 Gerrit-Change-Number: 20003 Gerrit-PatchSet: 10 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 20:24:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2018