coreboot-gerrit January 2018

coreboot-gerrit@coreboot.org

1 participants
2315 discussions

Change in coreboot[master]: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES
by Srinidhi N Kaushik (Code Review) 05 Jan '18

05 Jan '18

Srinidhi N Kaushik has removed Shaunak Saha from this change. ( https://review.coreboot.org/23066 ) Change subject: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES ...................................................................... Removed reviewer Shaunak Saha. -- To view, visit https://review.coreboot.org/23066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: Ib454f10a144d600a87d2f69d80d5d46f16c407f8 Gerrit-Change-Number: 23066 Gerrit-PatchSet: 4 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES
by Srinidhi N Kaushik (Code Review) 05 Jan '18

05 Jan '18

Srinidhi N Kaushik has removed Paul Menzel from this change. ( https://review.coreboot.org/23066 ) Change subject: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES ...................................................................... Removed reviewer Paul Menzel. -- To view, visit https://review.coreboot.org/23066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: Ib454f10a144d600a87d2f69d80d5d46f16c407f8 Gerrit-Change-Number: 23066 Gerrit-PatchSet: 4 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES
by build bot (Jenkins) (Code Review) 05 Jan '18

05 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23066 ) Change subject: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/65300/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/20032/ : SUCCESS -- To view, visit https://review.coreboot.org/23066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib454f10a144d600a87d2f69d80d5d46f16c407f8 Gerrit-Change-Number: 23066 Gerrit-PatchSet: 4 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 05 Jan 2018 00:08:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload: add a function to dump cbmem console buffer to UART
by build bot (Jenkins) (Code Review) 05 Jan '18

05 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23100 ) Change subject: libpayload: add a function to dump cbmem console buffer to UART ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20031/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65299/ : SUCCESS -- To view, visit https://review.coreboot.org/23100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a2d7b1dd6566ae2c42323c77408c7112e0e1974 Gerrit-Change-Number: 23100 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 23:06:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/kahlee/BiosCallOuts.c: Remove platform_FchParams_reset
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22989 ) Change subject: google/kahlee/BiosCallOuts.c: Remove platform_FchParams_reset ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20030/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65298/ : SUCCESS -- To view, visit https://review.coreboot.org/22989 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f3efc072a2e198433d0e261dacbbd4a8ff327d7 Gerrit-Change-Number: 22989 Gerrit-PatchSet: 6 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 22:55:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: libpayload: add a function to dump cbmem console buffer to UART
by Vadim Bendebury (Code Review) 04 Jan '18

04 Jan '18

Vadim Bendebury has uploaded this change for review. ( https://review.coreboot.org/23100 Change subject: libpayload: add a function to dump cbmem console buffer to UART ...................................................................... libpayload: add a function to dump cbmem console buffer to UART This function could be handy if someone stops the payload at a CLI prompt or if a vboot device falls into recovery. BRANCH=none BUG=none TEST=with accompanying changes in depthcharge printed cbmem console buffer to the UART console. Change-Id: I3a2d7b1dd6566ae2c42323c77408c7112e0e1974 Signed-off-by: Vadim Bendebury <vbendeb(a)chromium.org> --- M payloads/libpayload/drivers/cbmem_console.c M payloads/libpayload/include/libpayload.h 2 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/23100/1 diff --git a/payloads/libpayload/drivers/cbmem_console.c b/payloads/libpayload/drivers/cbmem_console.c index 9435e1c..09043d4 100644 --- a/payloads/libpayload/drivers/cbmem_console.c +++ b/payloads/libpayload/drivers/cbmem_console.c @@ -75,3 +75,22 @@ do_write(buffer, count); } + +static void dump_buffer_to_uart(const uint8_t *buffer, size_t size) +{ + size_t i; + + for (i = 0; i < size; i++) + serial_putchar(*buffer++); +} + +void cbmem_console_dump_buffer_to_uart(void) +{ + uint32_t cursor = cbmem_console_p->cursor & CURSOR_MASK; + + if (cbmem_console_p->cursor & OVERFLOW) + dump_buffer_to_uart(cbmem_console_p->body + cursor, + cbmem_console_p->size - cursor); + + dump_buffer_to_uart(cbmem_console_p->body, cursor); +} diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h index 83658d1..86e3e1b 100644 --- a/payloads/libpayload/include/libpayload.h +++ b/payloads/libpayload/include/libpayload.h @@ -245,6 +245,7 @@ */ void cbmem_console_init(void); void cbmem_console_write(const void *buffer, size_t count); +void cbmem_console_dump_buffer_to_uart(void); /** @} */ /* drivers/option.c */ -- To view, visit https://review.coreboot.org/23100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3a2d7b1dd6566ae2c42323c77408c7112e0e1974 Gerrit-Change-Number: 23100 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org>

1 0

Change in coreboot[master]: amd/gardenia/bootblock/BiosCallOuts.c: Replace GPIO table
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22990 ) Change subject: amd/gardenia/bootblock/BiosCallOuts.c: Replace GPIO table ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20029/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65297/ : SUCCESS -- To view, visit https://review.coreboot.org/22990 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2ea63656a7d2f20f55fc5a4c75457db85b80cbd Gerrit-Change-Number: 22990 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 22:25:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Update Grunt devicetree.
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23099 ) Change subject: mainboard/google/kahlee: Update Grunt devicetree. ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20028/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65296/ : SUCCESS -- To view, visit https://review.coreboot.org/23099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d8cdc97594867f1d706318370055087976a5104 Gerrit-Change-Number: 23099 Gerrit-PatchSet: 1 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 21:05:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/lint: Check license headers of git hooks
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23098 ) Change subject: util/lint: Check license headers of git hooks ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20027/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65295/ : SUCCESS -- To view, visit https://review.coreboot.org/23098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I242256f72ac70553535509f83166c6d1ddb16fdc Gerrit-Change-Number: 23098 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 21:04:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/gitconfig: Add missing license headers
by build bot (Jenkins) (Code Review) 04 Jan '18

04 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23097 ) Change subject: util/gitconfig: Add missing license headers ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20026/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65294/ : SUCCESS -- To view, visit https://review.coreboot.org/23097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie051e5e6ae7571050ece383e6be8236ed7d1ddd9 Gerrit-Change-Number: 23097 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 20:59:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2018