coreboot-gerrit January 2018

coreboot-gerrit@coreboot.org

1 participants
2315 discussions

Change in coreboot[master]: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES
by Srinidhi N Kaushik (Code Review) 05 Jan '18

05 Jan '18

Srinidhi N Kaushik has uploaded a new patch set (#2). ( https://review.coreboot.org/23127 ) Change subject: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES ...................................................................... mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES This patch adds the EC_GOOGLE_CHROMEEC_SWITCHES option so that we use the common switch.c file Change-Id: Iecf9d06eef8ed06546b6c4f09efd52ea45b32495 Signed-off-by: Shaunak Saha <shaunak.saha(a)intel.com> --- M src/mainboard/intel/glkrvp/Kconfig M src/mainboard/intel/glkrvp/chromeos.c M src/soc/amd/common/block/pi/agesawrapper.c M src/vendorcode/amd/pi/00670F00/Makefile.inc M src/vendorcode/amd/pi/Kconfig 5 files changed, 104 insertions(+), 30 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/23127/2 -- To view, visit https://review.coreboot.org/23127 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iecf9d06eef8ed06546b6c4f09efd52ea45b32495 Gerrit-Change-Number: 23127 Gerrit-PatchSet: 2 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>

1 0

Change in coreboot[master]: fsp/fsp2_0/coffeelake: Add CFL FSP UPD Headers
by Srinidhi N Kaushik (Code Review) 05 Jan '18

05 Jan '18

Srinidhi N Kaushik has abandoned this change. ( https://review.coreboot.org/23123 ) Change subject: fsp/fsp2_0/coffeelake: Add CFL FSP UPD Headers ...................................................................... Abandoned not needed -- To view, visit https://review.coreboot.org/23123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I7233b79af25ec981c8aec2cf693741aa8a08863b Gerrit-Change-Number: 23123 Gerrit-PatchSet: 1 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>

1 0

Change in coreboot[master]: mainboard/intel/coffeelake_rvp: Initial mainboard commit
by Srinidhi N Kaushik (Code Review) 05 Jan '18

05 Jan '18

Srinidhi N Kaushik has abandoned this change. ( https://review.coreboot.org/23102 ) Change subject: mainboard/intel/coffeelake_rvp: Initial mainboard commit ...................................................................... Abandoned not needed -- To view, visit https://review.coreboot.org/23102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: If57cb2077561f93c3ea67cc35a5ff0043e8fe734 Gerrit-Change-Number: 23102 Gerrit-PatchSet: 1 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/coffeelake: Initial SoC commit
by Srinidhi N Kaushik (Code Review) 05 Jan '18

05 Jan '18

Srinidhi N Kaushik has abandoned this change. ( https://review.coreboot.org/23101 ) Change subject: soc/intel/coffeelake: Initial SoC commit ...................................................................... Abandoned not needed -- To view, visit https://review.coreboot.org/23101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I7c47682f08dd8d4119778af0027cc0289c7b2f5c Gerrit-Change-Number: 23101 Gerrit-PatchSet: 1 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>

1 0

Change in coreboot[master]: src/soc/intel/apollolake: Add gpio groups
by build bot (Jenkins) (Code Review) 05 Jan '18

05 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23126 ) Change subject: src/soc/intel/apollolake: Add gpio groups ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20035/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65303/ : SUCCESS -- To view, visit https://review.coreboot.org/23126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib730d2c69f0f611dfbc0949f51eaba8ba1d0fba4 Gerrit-Change-Number: 23126 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 05 Jan 2018 01:06:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: 3rdparty/blobs/soc/amd/stoneyridge: Use new blob
by Martin Roth (Code Review) 05 Jan '18

05 Jan '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/23125 ) Change subject: 3rdparty/blobs/soc/amd/stoneyridge: Use new blob ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/23125/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23125/1//COMMIT_MSG@7 PS1, Line 7: Use new blob These aren't actually new files, are they? I thought they were just moved to the new location. -- To view, visit https://review.coreboot.org/23125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1784824dc7767c620e2fcbad7c6e5674934832ff Gerrit-Change-Number: 23125 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 05 Jan 2018 00:52:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: 3rdparty/blobs/soc/amd/stoneyridge: Use new blob
by build bot (Jenkins) (Code Review) 05 Jan '18

05 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23125 ) Change subject: 3rdparty/blobs/soc/amd/stoneyridge: Use new blob ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/20033/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65301/ : SUCCESS -- To view, visit https://review.coreboot.org/23125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1784824dc7767c620e2fcbad7c6e5674934832ff Gerrit-Change-Number: 23125 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 05 Jan 2018 00:45:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/soc/intel/apollolake: Add gpio groups
by Bora Guvendik (Code Review) 05 Jan '18

05 Jan '18

Bora Guvendik has uploaded this change for review. ( https://review.coreboot.org/23126 Change subject: src/soc/intel/apollolake: Add gpio groups ...................................................................... src/soc/intel/apollolake: Add gpio groups Add the information about groups within each community. Change-Id: Ib730d2c69f0f611dfbc0949f51eaba8ba1d0fba4 Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> --- M src/soc/intel/apollolake/gpio_apl.c 1 file changed, 36 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/23126/1 diff --git a/src/soc/intel/apollolake/gpio_apl.c b/src/soc/intel/apollolake/gpio_apl.c index a774470..c01e153 100644 --- a/src/soc/intel/apollolake/gpio_apl.c +++ b/src/soc/intel/apollolake/gpio_apl.c @@ -21,12 +21,40 @@ #include <soc/pcr_ids.h> #include <soc/pm.h> +#define APL_GPP(s, e) \ + { \ + .first_pad = (s), \ + .size = ((e) - (s) + 1), \ + } + static const struct reset_mapping rst_map[] = { { .logical = PAD_CFG0_LOGICAL_RESET_PWROK, .chipset = 0U << 30 }, { .logical = PAD_CFG0_LOGICAL_RESET_DEEP, .chipset = 1U << 30 }, { .logical = PAD_CFG0_LOGICAL_RESET_PLTRST, .chipset = 2U << 30 }, }; +static const struct pad_group apl_community_n_groups[] = { + APL_GPP(N_OFFSET, GPIO_31), /* NORTH 0 */ + APL_GPP(GPIO_32, TRST_B), /* NORTH 1 */ + APL_GPP(TMS, SVID0_CLK), /* NORTH 2 */ +}; + +static const struct pad_group apl_community_w_groups[] = { + APL_GPP(W_OFFSET, OSC_CLK_OUT_1),/* WEST 0 */ + APL_GPP(OSC_CLK_OUT_2, SUSPWRDNACK),/* WEST 1 */ +}; + +static const struct pad_group apl_community_sw_groups[] = { + APL_GPP(SW_OFFSET, SMB_ALERTB), /* SOUTHWEST 0 */ + APL_GPP(SMB_CLK, LPC_FRAMEB), /* SOUTHWEST 1 */ +}; + +static const struct pad_group apl_community_nw_groups[] = { + APL_GPP(NW_OFFSET, PROCHOT_B), /* NORTHWEST 0 */ + APL_GPP(PMIC_I2C_SCL, GPIO_106),/* NORTHWEST 1 */ + APL_GPP(GPIO_109, GPIO_123), /* NORTHWEST 2 */ +}; + static const struct pad_community apl_gpio_communities[] = { { .port = PID_GPIO_SW, @@ -43,6 +71,8 @@ .acpi_path = "\\_SB.GPO3", .reset_map = rst_map, .num_reset_vals = ARRAY_SIZE(rst_map), + .groups = apl_community_sw_groups, + .num_groups = ARRAY_SIZE(apl_community_sw_groups), }, { .port = PID_GPIO_W, .first_pad = W_OFFSET, @@ -58,6 +88,8 @@ .acpi_path = "\\_SB.GPO2", .reset_map = rst_map, .num_reset_vals = ARRAY_SIZE(rst_map), + .groups = apl_community_w_groups, + .num_groups = ARRAY_SIZE(apl_community_w_groups), }, { .port = PID_GPIO_NW, .first_pad = NW_OFFSET, @@ -73,6 +105,8 @@ .acpi_path = "\\_SB.GPO1", .reset_map = rst_map, .num_reset_vals = ARRAY_SIZE(rst_map), + .groups = apl_community_nw_groups, + .num_groups = ARRAY_SIZE(apl_community_nw_groups), }, { .port = PID_GPIO_N, .first_pad = N_OFFSET, @@ -89,6 +123,8 @@ .acpi_path = "\\_SB.GPO0", .reset_map = rst_map, .num_reset_vals = ARRAY_SIZE(rst_map), + .groups = apl_community_n_groups, + .num_groups = ARRAY_SIZE(apl_community_n_groups), } }; -- To view, visit https://review.coreboot.org/23126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib730d2c69f0f611dfbc0949f51eaba8ba1d0fba4 Gerrit-Change-Number: 23126 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com>

1 0

Change in coreboot[master]: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES
by Srinidhi N Kaushik (Code Review) 05 Jan '18

05 Jan '18

Srinidhi N Kaushik has abandoned this change. ( https://review.coreboot.org/23066 ) Change subject: mainboard/glkrvp: Add EC_GOOGLE_CHROMEEC_SWITCHES ...................................................................... Abandoned Not needed -- To view, visit https://review.coreboot.org/23066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ib454f10a144d600a87d2f69d80d5d46f16c407f8 Gerrit-Change-Number: 23066 Gerrit-PatchSet: 5 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: 3rdparty/blobs/soc/amd/stoneyridge: Use new blob
by Richard Spiegel (Code Review) 05 Jan '18

05 Jan '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/23125 Change subject: 3rdparty/blobs/soc/amd/stoneyridge: Use new blob ...................................................................... 3rdparty/blobs/soc/amd/stoneyridge: Use new blob Stoneyridge related contents of 3rdparty/blobs/southbridge/amd/kern were moved to 3rdparty/blobs/southbridge/amd/stoneyridge. Commit the new blob to coreboot, and modify src/soc/amd/stoneyridge/Kconfig to use it. BUG=b:69613465 TEST=Build and run kahlee. Change-Id: I1784824dc7767c620e2fcbad7c6e5674934832ff Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M 3rdparty/blobs M src/soc/amd/stoneyridge/Kconfig 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/23125/1 diff --git a/3rdparty/blobs b/3rdparty/blobs index d2e558a..8eb92ba 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit d2e558a81f95f7b9149bea6b8362bb43ade82584 +Subproject commit 8eb92ba947e171df11b3c62f5f257ce69b9e2d55 diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig index 8b9111e..1cc580c 100644 --- a/src/soc/amd/stoneyridge/Kconfig +++ b/src/soc/amd/stoneyridge/Kconfig @@ -185,12 +185,12 @@ config STONEYRIDGE_XHCI_FWM_FILE string "XHCI firmware path and filename" - default "3rdparty/blobs/southbridge/amd/kern/xhci.bin" + default "3rdparty/blobs/soc/amd/stoneyridge/xhci.bin" depends on STONEYRIDGE_XHCI_FWM config STONEYRIDGE_IMC_FWM_FILE string "IMC firmware path and filename" - default "3rdparty/blobs/southbridge/amd/kern/imc.bin" + default "3rdparty/blobs/soc/amd/stoneyridge/imc.bin" depends on STONEYRIDGE_IMC_FWM config STONEYRIDGE_GEC_FWM_FILE @@ -199,7 +199,7 @@ config AMD_PUBKEY_FILE string "AMD public Key" - default "3rdparty/blobs/southbridge/amd/kern/PSP/AmdPubKeyST.bin" + default "3rdparty/blobs/soc/amd/stoneyridge/PSP/AmdPubKeyST.bin" config STONEYRIDGE_SATA_MODE int "SATA Mode" -- To view, visit https://review.coreboot.org/23125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1784824dc7767c620e2fcbad7c6e5674934832ff Gerrit-Change-Number: 23125 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2018