coreboot-gerrit January 2018

coreboot-gerrit@coreboot.org

1 participants
2315 discussions

Change in coreboot[master]: google/fizz: Adjust PL2 and PsysPl2 values for power loss
by build bot (Jenkins) (Code Review) 29 Jan '18

29 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23457 ) Change subject: google/fizz: Adjust PL2 and PsysPl2 values for power loss ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21324/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66719/ : SUCCESS -- To view, visit https://review.coreboot.org/23457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8425c6d4d669449eccb9324ff58ff6d1662c5c43 Gerrit-Change-Number: 23457 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 29 Jan 2018 18:19:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/sandybridge: Always use the same MMCONF_BASE_ADDRESS
by build bot (Jenkins) (Code Review) 29 Jan '18

29 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23490 ) Change subject: nb/intel/sandybridge: Always use the same MMCONF_BASE_ADDRESS ...................................................................... Patch Set 3: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/66718/ : FAILURE -- To view, visit https://review.coreboot.org/23490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d0648fe36c88bd9279ac19e5c710055327599fd Gerrit-Change-Number: 23490 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 29 Jan 2018 16:36:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/lenovo/x220: Allow optional use of the mrc.bin
by build bot (Jenkins) (Code Review) 29 Jan '18

29 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23489 ) Change subject: mb/lenovo/x220: Allow optional use of the mrc.bin ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21322/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66715/ : SUCCESS -- To view, visit https://review.coreboot.org/23489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d71fb7bc5f7b0976157be146c0e4c39a3ed5602 Gerrit-Change-Number: 23489 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 29 Jan 2018 15:52:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/sandybridge: Always use the same MMCONF_BASE_ADDRESS
by build bot (Jenkins) (Code Review) 29 Jan '18

29 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23490 ) Change subject: nb/intel/sandybridge: Always use the same MMCONF_BASE_ADDRESS ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/66717/ : FAILURE -- To view, visit https://review.coreboot.org/23490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d0648fe36c88bd9279ac19e5c710055327599fd Gerrit-Change-Number: 23490 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 29 Jan 2018 15:50:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/sandybridge: Always use the same MMCONF_BASE_ADDRESS
by build bot (Jenkins) (Code Review) 29 Jan '18

29 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23490 ) Change subject: nb/intel/sandybridge: Always use the same MMCONF_BASE_ADDRESS ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/66716/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/21323/ : SUCCESS -- To view, visit https://review.coreboot.org/23490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d0648fe36c88bd9279ac19e5c710055327599fd Gerrit-Change-Number: 23490 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 29 Jan 2018 15:50:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/sandybridge: Always use the same MMCONF_BASE_ADDRESS
by Arthur Heymans (Code Review) 29 Jan '18

29 Jan '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23490 Change subject: nb/intel/sandybridge: Always use the same MMCONF_BASE_ADDRESS ...................................................................... nb/intel/sandybridge: Always use the same MMCONF_BASE_ADDRESS 'Optimizing' MMCONF_BASE_ADDRESS for the native codepath prevents the use of fallback/normal with both the native raminit and the mrc.bin. This means that 128MB less is available to devices using the native raminit. Most devices reserve 2048M for non memory resources below 4G, which in most cases is more than adequate. Devices with only 1024M (and that don't use the mrc.bin) are: * lenovo/x220 * lenovo/x230 * lenovo/x131e * lenovo/x1_carbon_gen1 Those could fail to allocate PCI resources, but on at least x220 with a somewhat default configuration (USB3 expresscard, Wireless PCIe card) still boots fine, so one should not expect much problem from this change. Change-Id: I1d0648fe36c88bd9279ac19e5c710055327599fd Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/sandybridge/Kconfig 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/23490/1 diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig index 36cf940..fce1a49 100644 --- a/src/northbridge/intel/sandybridge/Kconfig +++ b/src/northbridge/intel/sandybridge/Kconfig @@ -94,11 +94,9 @@ config MMCONF_BASE_ADDRESS hex - default 0xf8000000 if USE_NATIVE_RAMINIT default 0xf0000000 help - We can optimize the native case but the MRC blob requires it - to be at 0xf0000000. + The MRC blob requires it to be at 0xf0000000. if USE_NATIVE_RAMINIT -- To view, visit https://review.coreboot.org/23490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1d0648fe36c88bd9279ac19e5c710055327599fd Gerrit-Change-Number: 23490 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: [TEST]mb/lenovo/x220: Use mrc.bin
by build bot (Jenkins) (Code Review) 29 Jan '18

29 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23489 ) Change subject: [TEST]mb/lenovo/x220: Use mrc.bin ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21321/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66714/ : SUCCESS -- To view, visit https://review.coreboot.org/23489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d71fb7bc5f7b0976157be146c0e4c39a3ed5602 Gerrit-Change-Number: 23489 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 29 Jan 2018 14:03:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [TEST]mb/lenovo/x220: Use mrc.bin
by Arthur Heymans (Code Review) 29 Jan '18

29 Jan '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23489 Change subject: [TEST]mb/lenovo/x220: Use mrc.bin ...................................................................... [TEST]mb/lenovo/x220: Use mrc.bin Does not work Change-Id: I2d71fb7bc5f7b0976157be146c0e4c39a3ed5602 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x220/romstage.c 2 files changed, 57 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/23489/1 diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig index 4b9451b..ad59987 100644 --- a/src/mainboard/lenovo/x220/Kconfig +++ b/src/mainboard/lenovo/x220/Kconfig @@ -5,7 +5,7 @@ select SYSTEM_TYPE_LAPTOP select CPU_INTEL_SOCKET_RPGA989 select NORTHBRIDGE_INTEL_SANDYBRIDGE - select USE_NATIVE_RAMINIT +# select USE_NATIVE_RAMINIT select SOUTHBRIDGE_INTEL_C216 select EC_LENOVO_PMH7 select EC_LENOVO_H8 diff --git a/src/mainboard/lenovo/x220/romstage.c b/src/mainboard/lenovo/x220/romstage.c index a6c5793..16605f0 100644 --- a/src/mainboard/lenovo/x220/romstage.c +++ b/src/mainboard/lenovo/x220/romstage.c @@ -27,6 +27,7 @@ #include <arch/acpi.h> #include <console/console.h> #include <northbridge/intel/sandybridge/sandybridge.h> +#include <northbridge/intel/sandybridge/raminit.h> #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> @@ -52,6 +53,56 @@ RCBA32(BUC) = 0; } +void mainboard_fill_pei_data(struct pei_data *pei_data) +{ + struct pei_data pei_data_template = { + .pei_version = PEI_VERSION, + .mchbar = (uintptr_t)DEFAULT_MCHBAR, + .dmibar = (uintptr_t)DEFAULT_DMIBAR, + .epbar = DEFAULT_EPBAR, + .pciexbar = CONFIG_MMCONF_BASE_ADDRESS, + .smbusbar = SMBUS_IO_BASE, + .wdbbar = 0x4000000, + .wdbsize = 0x1000, + .hpet_address = CONFIG_HPET_ADDRESS, + .rcba = (uintptr_t)DEFAULT_RCBABASE, + .pmbase = DEFAULT_PMBASE, + .gpiobase = DEFAULT_GPIOBASE, + .thermalbase = 0xfed08000, + .system_type = 0, // 0 Mobile, 1 Desktop/Server + .tseg_size = CONFIG_SMM_TSEG_SIZE, + .spd_addresses = { 0xa0, 0x00,0xa2,0x00 }, + .ts_addresses = { 0x00, 0x00, 0x00, 0x00 }, + .ec_present = 1, + .gbe_enable = 1, + // 0 = leave channel enabled + // 1 = disable dimm 0 on channel + // 2 = disable dimm 1 on channel + // 3 = disable dimm 0+1 on channel + .dimm_channel0_disabled = 2, + .dimm_channel1_disabled = 2, + .max_ddr3_freq = 1333, + .usb_port_config = { + { 1, 0, 0x0040 }, + { 1, 1, 0x0080 }, + { 1, 3, 0x0080 }, + { 1, 3, 0x0080 }, + { 1, 0, 0x0080 }, + { 1, 0, 0x0080 }, + { 1, 2, 0x0040 }, + { 1, 2, 0x0040 }, + { 1, 6, 0x0080 }, + { 1, 5, 0x0080 }, + { 1, 6, 0x0080 }, + { 1, 6, 0x0080 }, + { 1, 7, 0x0080 }, + { 1, 6, 0x0080 }, + }, + }; + *pei_data = pei_data_template; + // leave onboard dimm address at f0, and copy spd data there. +} + const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 0, 0 }, { 1, 1, 1 }, @@ -82,3 +133,8 @@ void mainboard_config_superio(void) { } + +int mainboard_should_reset_usb(int s3resume) +{ + return !s3resume; +} -- To view, visit https://review.coreboot.org/23489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2d71fb7bc5f7b0976157be146c0e4c39a3ed5602 Gerrit-Change-Number: 23489 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: autoport: Don't do writes to FD in romstage
by build bot (Jenkins) (Code Review) 29 Jan '18

29 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23486 ) Change subject: autoport: Don't do writes to FD in romstage ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21319/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66712/ : SUCCESS -- To view, visit https://review.coreboot.org/23486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4edb75569ceec2d2f1308755a66d286202ca0ae6 Gerrit-Change-Number: 23486 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 29 Jan 2018 11:25:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/*.h: Remove left-over register definitions
by build bot (Jenkins) (Code Review) 29 Jan '18

29 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23487 ) Change subject: nb/intel/*.h: Remove left-over register definitions ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/21318/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/66711/ : SUCCESS -- To view, visit https://review.coreboot.org/23487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I122affffd5108052ed7a95b34d0d66a6d3279d41 Gerrit-Change-Number: 23487 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 29 Jan 2018 11:05:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2018