coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: google/snappy: Override SKU ID by VPD
by build bot (Jenkins) (Code Review) 14 Sep '17

14 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21533 ) Change subject: google/snappy: Override SKU ID by VPD ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/60438/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15649/ : SUCCESS -- To view, visit https://review.coreboot.org/21533 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55ab741354797e022dd945da9c8499ee5e041316 Gerrit-Change-Number: 21533 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quantatw.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Sep 2017 08:40:16 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/scripts/cross-repo-cherrypick: improve cros-side rewrite
by build bot (Jenkins) (Code Review) 14 Sep '17

14 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21534 ) Change subject: util/scripts/cross-repo-cherrypick: improve cros-side rewrite ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15648/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60437/ : SUCCESS -- To view, visit https://review.coreboot.org/21534 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37171bf6764b64e0ab0e81297a03f4d8b7744256 Gerrit-Change-Number: 21534 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Sep 2017 07:56:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/scripts/cross-repo-cherrypick: improve cros-side rewrite
by Patrick Georgi (Code Review) 14 Sep '17

14 Sep '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/21534 Change subject: util/scripts/cross-repo-cherrypick: improve cros-side rewrite ...................................................................... util/scripts/cross-repo-cherrypick: improve cros-side rewrite Sometimes the BUG/BRANCH/TEST metadata isn't separated by a newline from the later git/gerrit metadata, which messes up further processing. Add that newline to minimize the amount of human intervention required. Change-Id: I37171bf6764b64e0ab0e81297a03f4d8b7744256 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/scripts/cross-repo-cherrypick 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/21534/1 diff --git a/util/scripts/cross-repo-cherrypick b/util/scripts/cross-repo-cherrypick index 0f2acf8..38d4f46 100755 --- a/util/scripts/cross-repo-cherrypick +++ b/util/scripts/cross-repo-cherrypick @@ -65,6 +65,12 @@ '"${SPLICE_CMD}"' } end=1 + }; /^(BUG|BRANCH|TEST|CQ-DEPEND)=/ { + if (end==0) { + print "Original-Commit-Id: '"${CID}"'\nSigned-off-by: '"${GUID}"'"; + print ""; + } + end=1 }; { if (end==0) print "Original-" $0; -- To view, visit https://review.coreboot.org/21534 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I37171bf6764b64e0ab0e81297a03f4d8b7744256 Gerrit-Change-Number: 21534 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: mb/google/poppy: Add lens_focus property for OV13858 camera module
by build bot (Jenkins) (Code Review) 14 Sep '17

14 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21512 ) Change subject: mb/google/poppy: Add lens_focus property for OV13858 camera module ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15647/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60436/ : SUCCESS -- To view, visit https://review.coreboot.org/21512 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib22403f668dd07d6b9226fe2c22b533223b69473 Gerrit-Change-Number: 21512 Gerrit-PatchSet: 3 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Sep 2017 06:12:38 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/snappy: Override SKU ID by VPD
by build bot (Jenkins) (Code Review) 14 Sep '17

14 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21533 ) Change subject: google/snappy: Override SKU ID by VPD ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/60435/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/15646/ : SUCCESS -- To view, visit https://review.coreboot.org/21533 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55ab741354797e022dd945da9c8499ee5e041316 Gerrit-Change-Number: 21533 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Sep 2017 03:13:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/snappy: Override SKU ID by VPD
by Kevin Chiu (Code Review) 14 Sep '17

14 Sep '17

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/21533 Change subject: google/snappy: Override SKU ID by VPD ...................................................................... google/snappy: Override SKU ID by VPD since snappy PCB may have over 9 SKU and current GPIO board ID GP16/GP17 is insufficient to use. Using VPD to control could prevent H/W change. BUG=b:65339688 BRANCH=reef TEST=emerge-snappy coreboot Change-Id: I55ab741354797e022dd945da9c8499ee5e041316 signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com> --- M src/mainboard/google/reef/variants/snappy/mainboard.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/21533/1 diff --git a/src/mainboard/google/reef/variants/snappy/mainboard.c b/src/mainboard/google/reef/variants/snappy/mainboard.c index a04f61a..9633faa 100644 --- a/src/mainboard/google/reef/variants/snappy/mainboard.c +++ b/src/mainboard/google/reef/variants/snappy/mainboard.c @@ -15,8 +15,29 @@ #include <baseboard/variants.h> #include <ec/google/chromeec/ec.h> +#include <vendorcode/google/chromeos/cros_vpd.h> void variant_board_ec_set_skuid(void) { google_chromeec_set_sku_id(variant_board_sku()); } + +/* + * override SKU ID by VPD definition + */ +uint8_t variant_board_sku(void) +{ + static int board_sku_num = -1; + char vpd_skuid[] = "skuid"; + char vpd_skuid_buffer[2]; + + if(!cros_vpd_gets(vpd_skuid, vpd_skuid_buffer, + ARRAY_SIZE(vpd_skuid_buffer))) { + board_sku_num = 8; + } + else { + board_sku_num = vpd_skuid_buffer[0] - '0'; + } + + return board_sku_num; +} -- To view, visit https://review.coreboot.org/21533 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I55ab741354797e022dd945da9c8499ee5e041316 Gerrit-Change-Number: 21533 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com>

1 0

Change in coreboot[master]: ifdtool: refactor region-permission-related feature
by build bot (Jenkins) (Code Review) 14 Sep '17

14 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related feature ...................................................................... Patch Set 23: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15644/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60432/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 23 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Sep 2017 01:22:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Leave Hda enabled for GLK
by build bot (Jenkins) (Code Review) 14 Sep '17

14 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21529 ) Change subject: soc/intel/apollolake: Leave Hda enabled for GLK ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60434/ : SUCCESS -- To view, visit https://review.coreboot.org/21529 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d3872e86623763e20ee6464897f47792c731642 Gerrit-Change-Number: 21529 Gerrit-PatchSet: 2 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Sep 2017 01:16:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 14 Sep '17

14 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 17: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15645/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60433/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 17 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Sep 2017 01:09:26 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refacter some code
by build bot (Jenkins) (Code Review) 14 Sep '17

14 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21511 ) Change subject: ifdtool: refacter some code ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15642/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60431/ : SUCCESS -- To view, visit https://review.coreboot.org/21511 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98965711e4cb9792e5cc86cc4c1035559e0274f5 Gerrit-Change-Number: 21511 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Sep 2017 01:07:38 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017