coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: soc/amd/common: Move AGESA related source files
by build bot (Jenkins) (Code Review) 11 Dec '17

11 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22792 ) Change subject: soc/amd/common: Move AGESA related source files ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19191/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64381/ : SUCCESS -- To view, visit https://review.coreboot.org/22792 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I497cdefe64e8dff00aaff7153c4ffa9c57c9acf8 Gerrit-Change-Number: 22792 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Dec 2017 23:11:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Move AGESA related source files
by Richard Spiegel (Code Review) 11 Dec '17

11 Dec '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22792 to look at the new patch set (#3). Change subject: soc/amd/common: Move AGESA related source files ...................................................................... soc/amd/common: Move AGESA related source files Move AGESA related source files in soc/amd/common under block directory. Folder soc/amd/common/block subfolders should mimic soc/intel/common/block subfolders (one subfolder per subject). BUG=b:69262110 TEST=Build with no error gardenia and kahlee (no code change, just folder reorg). Change-Id: I497cdefe64e8dff00aaff7153c4ffa9c57c9acf8 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/soc/amd/common/Makefile.inc A src/soc/amd/common/block/pi/Kconfig A src/soc/amd/common/block/pi/Makefile.inc R src/soc/amd/common/block/pi/agesawrapper.c R src/soc/amd/common/block/pi/amd_late_init.c R src/soc/amd/common/block/pi/def_callouts.c R src/soc/amd/common/block/pi/heapmanager.c M src/soc/amd/stoneyridge/Kconfig 8 files changed, 22 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/22792/3 -- To view, visit https://review.coreboot.org/22792 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I497cdefe64e8dff00aaff7153c4ffa9c57c9acf8 Gerrit-Change-Number: 22792 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/amd/common: Move Agesa related headers
by build bot (Jenkins) (Code Review) 11 Dec '17

11 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22772 ) Change subject: soc/amd/common: Move Agesa related headers ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19190/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64380/ : SUCCESS -- To view, visit https://review.coreboot.org/22772 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d3064625ddf8caaf370aabaf93165c6817f1ca0 Gerrit-Change-Number: 22772 Gerrit-PatchSet: 5 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Dec 2017 21:55:47 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/cbmem: Print timestamp frequency in verbose mode
by build bot (Jenkins) (Code Review) 11 Dec '17

11 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22821 ) Change subject: util/cbmem: Print timestamp frequency in verbose mode ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19189/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64379/ : SUCCESS -- To view, visit https://review.coreboot.org/22821 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02286fa67919e70a3592cdbcc1c9ca2991b7f385 Gerrit-Change-Number: 22821 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Dec 2017 21:43:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/cbmem: Print timestamp frequency in verbose mode
by Martin Roth (Code Review) 11 Dec '17

11 Dec '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22821 ) Change subject: util/cbmem: Print timestamp frequency in verbose mode ...................................................................... Patch Set 1: Another option I considered was separate debug statements to also indicate how the frequency was found: From the timestamp table, or from the arch_tick_frequency() call. I decided that level of information wasn't generally needed, but if others disagree, I can update the patch. -- To view, visit https://review.coreboot.org/22821 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02286fa67919e70a3592cdbcc1c9ca2991b7f385 Gerrit-Change-Number: 22821 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Mon, 11 Dec 2017 21:38:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/cbmem: Print timestamp frequency in verbose mode
by Martin Roth (Code Review) 11 Dec '17

11 Dec '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/22821 Change subject: util/cbmem: Print timestamp frequency in verbose mode ...................................................................... util/cbmem: Print timestamp frequency in verbose mode The code flow is changed slightly to print the timestamp frequency from either method of determining it. BUG=b:70432544 TEST=Build and test cbmem -t -V Change-Id: I02286fa67919e70a3592cdbcc1c9ca2991b7f385 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M util/cbmem/cbmem.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/22821/1 diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c index dea2c0b..09957ba 100644 --- a/util/cbmem/cbmem.c +++ b/util/cbmem/cbmem.c @@ -501,16 +501,16 @@ { tick_freq_mhz = table_tick_freq_mhz; - /* Honor table frequency. */ - if (tick_freq_mhz) - return; - - tick_freq_mhz = arch_tick_frequency(); + /* Honor table frequency if present. */ + if (!tick_freq_mhz) + tick_freq_mhz = arch_tick_frequency(); if (!tick_freq_mhz) { fprintf(stderr, "Cannot determine timestamp tick frequency.\n"); exit(1); } + + debug("Timestamp tick frequency: %ld MHz\n", tick_freq_mhz); } u64 arch_convert_raw_ts_entry(u64 ts) -- To view, visit https://review.coreboot.org/22821 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I02286fa67919e70a3592cdbcc1c9ca2991b7f385 Gerrit-Change-Number: 22821 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: soc/amd/common: Move files to common/block
by build bot (Jenkins) (Code Review) 11 Dec '17

11 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22765 ) Change subject: soc/amd/common: Move files to common/block ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19188/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64378/ : SUCCESS -- To view, visit https://review.coreboot.org/22765 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f965afa21124d4874d3b7bfe0f404a58b070e23 Gerrit-Change-Number: 22765 Gerrit-PatchSet: 6 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Dec 2017 19:46:47 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Move files to common/block
by build bot (Jenkins) (Code Review) 11 Dec '17

11 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22765 ) Change subject: soc/amd/common: Move files to common/block ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19187/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64377/ : SUCCESS -- To view, visit https://review.coreboot.org/22765 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f965afa21124d4874d3b7bfe0f404a58b070e23 Gerrit-Change-Number: 22765 Gerrit-PatchSet: 5 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Dec 2017 18:14:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/x4x/raminit: Rewrite SPD decode and timing selection
by build bot (Jenkins) (Code Review) 11 Dec '17

11 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19143 ) Change subject: nb/x4x/raminit: Rewrite SPD decode and timing selection ...................................................................... Patch Set 29: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19186/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64376/ : SUCCESS -- To view, visit https://review.coreboot.org/19143 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I760eeaa3bd4f2bc25a517ddb1b9533c971454071 Gerrit-Change-Number: 19143 Gerrit-PatchSet: 29 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Comment-Date: Mon, 11 Dec 2017 17:15:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: commonlib: Add timestamp codes for AGESA
by build bot (Jenkins) (Code Review) 11 Dec '17

11 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22797 ) Change subject: commonlib: Add timestamp codes for AGESA ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19185/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64375/ : SUCCESS -- To view, visit https://review.coreboot.org/22797 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bf691a0fb1f5c09e7b6c9965c9e506393ec31f6 Gerrit-Change-Number: 22797 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Dec 2017 16:45:18 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017