coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: soc/intel/apollolake: add _RMV attributes to eMMC device ACPI
by build bot (Jenkins) (Code Review) 12 Dec '17

12 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22830 ) Change subject: soc/intel/apollolake: add _RMV attributes to eMMC device ACPI ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19244/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64437/ : SUCCESS -- To view, visit https://review.coreboot.org/22830 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0822d767ada872d55357ff229e47e08fbe778a36 Gerrit-Change-Number: 22830 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 19:10:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: security/tpm: Add TPM_PCRRead tss function
by build bot (Jenkins) (Code Review) 12 Dec '17

12 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22831 ) Change subject: security/tpm: Add TPM_PCRRead tss function ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19245/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64438/ : SUCCESS -- To view, visit https://review.coreboot.org/22831 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic85517a8a69f352a02d20a67fbba3d910ef03a1c Gerrit-Change-Number: 22831 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 19:07:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: security/tpm: Change TPM naming for different layers.
by build bot (Jenkins) (Code Review) 12 Dec '17

12 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22104 ) Change subject: security/tpm: Change TPM naming for different layers. ...................................................................... Patch Set 12: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19238/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64431/ : SUCCESS -- To view, visit https://review.coreboot.org/22104 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I206dd6a32dbd303a6d4d987e424407ebf5c518fa Gerrit-Change-Number: 22104 Gerrit-PatchSet: 12 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 19:02:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: security/tpm: Implement hashing function in TSS
by build bot (Jenkins) (Code Review) 12 Dec '17

12 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22735 ) Change subject: security/tpm: Implement hashing function in TSS ...................................................................... Patch Set 10: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19243/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64436/ : SUCCESS -- To view, visit https://review.coreboot.org/22735 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib84513e8cbfe1ef11f495b873de0331178915c59 Gerrit-Change-Number: 22735 Gerrit-PatchSet: 10 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 18:58:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: security/tpm: Fix coding style and uninitialized variable
by build bot (Jenkins) (Code Review) 12 Dec '17

12 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22734 ) Change subject: security/tpm: Fix coding style and uninitialized variable ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19242/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64435/ : SUCCESS -- To view, visit https://review.coreboot.org/22734 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa93c91aab97c663df66dfdc4d1afb3a43736adb Gerrit-Change-Number: 22734 Gerrit-PatchSet: 3 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 18:53:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: security/tpm: Refactor TSS 1.2 and 2.0 implementation
by build bot (Jenkins) (Code Review) 12 Dec '17

12 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22374 ) Change subject: security/tpm: Refactor TSS 1.2 and 2.0 implementation ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19241/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64434/ : SUCCESS -- To view, visit https://review.coreboot.org/22374 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97bbc7b7b025500b49c743b0c303543c33627c88 Gerrit-Change-Number: 22374 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 18:50:56 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: security/tpm: Add TPM_PCRRead tss function
by Philipp Deppenwiese (Code Review) 12 Dec '17

12 Dec '17

Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/22831 Change subject: security/tpm: Add TPM_PCRRead tss function ...................................................................... security/tpm: Add TPM_PCRRead tss function Change-Id: Ic85517a8a69f352a02d20a67fbba3d910ef03a1c Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/security/tpm/tss.h M src/security/tpm/tss/tcg-1.2/tss.c M src/security/tpm/tss/tcg-2.0/tss.c 3 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/22831/1 diff --git a/src/security/tpm/tss.h b/src/security/tpm/tss.h index 3cc50ef..612df0f 100644 --- a/src/security/tpm/tss.h +++ b/src/security/tpm/tss.h @@ -151,6 +151,11 @@ uint8_t *out_digest); /** + * Read current PCR digest + */ +uint32_t tlcl_pcr_read(int pcr_num, uint8_t *out_digest); + +/** * Get the entire set of permanent flags. */ uint32_t tlcl_get_permanent_flags(TPM_PERMANENT_FLAGS *pflags); diff --git a/src/security/tpm/tss/tcg-1.2/tss.c b/src/security/tpm/tss/tcg-1.2/tss.c index b74abd0..2bb2269 100644 --- a/src/security/tpm/tss/tcg-1.2/tss.c +++ b/src/security/tpm/tss/tcg-1.2/tss.c @@ -411,3 +411,20 @@ return result; } + +uint32_t tlcl_pcr_read(int pcr_num, uint8_t *out_digest) +{ + struct s_tpm_pcr_read_cmd cmd; + uint8_t response[TPM_LARGE_ENOUGH_COMMAND_SIZE]; + uint32_t result; + + memcpy(&cmd, &tpm_pcr_read_cmd, sizeof(cmd)); + to_tpm_uint32(cmd.buffer + tpm_pcr_read_cmd.pcrNum, pcr_num); + + result = tlcl_send_receive(cmd.buffer, response, sizeof(response)); + if (result == TPM_SUCCESS) + memcpy(out_digest, response + kTpmResponseHeaderLength, + kPcrDigestLength); + + return result; +} diff --git a/src/security/tpm/tss/tcg-2.0/tss.c b/src/security/tpm/tss/tcg-2.0/tss.c index 0dbf8c8..0bee09b 100644 --- a/src/security/tpm/tss/tcg-2.0/tss.c +++ b/src/security/tpm/tss/tcg-2.0/tss.c @@ -416,3 +416,8 @@ { return TPM_SUCCESS; } + +uint32_t tlcl_pcr_read(int pcr_num, uint8_t *out_digest) +{ + return TPM_SUCCESS; +} -- To view, visit https://review.coreboot.org/22831 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic85517a8a69f352a02d20a67fbba3d910ef03a1c Gerrit-Change-Number: 22831 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>

1 0

Change in coreboot[master]: security/tpm: Move TSS stacks into sub-directory
by build bot (Jenkins) (Code Review) 12 Dec '17

12 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22105 ) Change subject: security/tpm: Move TSS stacks into sub-directory ...................................................................... Patch Set 14: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19239/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64432/ : SUCCESS -- To view, visit https://review.coreboot.org/22105 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e20d98665c17d39f3f69772093a062bb905f6f9 Gerrit-Change-Number: 22105 Gerrit-PatchSet: 14 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 18:46:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: security/tpm: Move tpm TSS and TSPI layer to security section
by build bot (Jenkins) (Code Review) 12 Dec '17

12 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22103 ) Change subject: security/tpm: Move tpm TSS and TSPI layer to security section ...................................................................... Patch Set 11: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19237/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64430/ : SUCCESS -- To view, visit https://review.coreboot.org/22103 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id15a9aa6bd367560318dfcfd450bf5626ea0ec2b Gerrit-Change-Number: 22103 Gerrit-PatchSet: 11 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 18:44:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Move ACPI HKEY device to new file
by build bot (Jenkins) (Code Review) 12 Dec '17

12 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22463 ) Change subject: ec/lenovo/h8/acpi: Move ACPI HKEY device to new file ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19232/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64425/ : SUCCESS -- To view, visit https://review.coreboot.org/22463 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie59b59e5a4148807125c71a362161026f685a97e Gerrit-Change-Number: 22463 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Dec 2017 18:27:12 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017