coreboot-gerrit December 2017

coreboot-gerrit@coreboot.org

1 participants
1557 discussions

Change in coreboot[master]: soc/amd/stoneyridge: Enable SPI writes
by build bot (Jenkins) (Code Review) 09 Dec '17

09 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22636 ) Change subject: soc/amd/stoneyridge: Enable SPI writes ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19135/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64319/ : SUCCESS -- To view, visit https://review.coreboot.org/22636 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I595a27ac27daa42c2499de1a343bc30be9a89fa6 Gerrit-Change-Number: 22636 Gerrit-PatchSet: 9 Gerrit-Owner: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Dec 2017 03:59:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Add amdblocks/spi.h
by build bot (Jenkins) (Code Review) 09 Dec '17

09 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22793 ) Change subject: soc/amd/common: Add amdblocks/spi.h ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19134/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64318/ : SUCCESS -- To view, visit https://review.coreboot.org/22793 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dbb5bf84cc3462a7aa58a5531d6b8b8bc8ca4df Gerrit-Change-Number: 22793 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Dec 2017 03:52:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Add amdblocks/spi.h
by Marc Jones (Code Review) 09 Dec '17

09 Dec '17

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/22793 Change subject: soc/amd/common: Add amdblocks/spi.h ...................................................................... soc/amd/common: Add amdblocks/spi.h Add the spi header for spi function prototypes. Fixes spi.c build error for the missing header. Change-Id: I0dbb5bf84cc3462a7aa58a5531d6b8b8bc8ca4df Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- A src/soc/amd/common/block/include/amdblocks/spi.h M src/soc/amd/common/spi.c 2 files changed, 24 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/22793/1 diff --git a/src/soc/amd/common/block/include/amdblocks/spi.h b/src/soc/amd/common/block/include/amdblocks/spi.h new file mode 100644 index 0000000..1825f62 --- /dev/null +++ b/src/soc/amd/common/block/include/amdblocks/spi.h @@ -0,0 +1,23 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2017 Advanced Micro Devices, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __AMD_SPI_H__ +#define __AMD_SPI_H__ + +#include <stdint.h> + +void spi_SaveS3info(u32 pos, u32 size, u8 *buf, u32 len); + +#endif /* __AMD_SPI_H__ */ diff --git a/src/soc/amd/common/spi.c b/src/soc/amd/common/spi.c index 44c86e6..f72416a 100644 --- a/src/soc/amd/common/spi.c +++ b/src/soc/amd/common/spi.c @@ -16,7 +16,7 @@ #include <console/console.h> #include <spi-generic.h> #include <spi_flash.h> -#include "s3_resume.h" +#include <amdblocks/spi.h> void spi_SaveS3info(u32 pos, u32 size, u8 *buf, u32 len) { -- To view, visit https://review.coreboot.org/22793 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0dbb5bf84cc3462a7aa58a5531d6b8b8bc8ca4df Gerrit-Change-Number: 22793 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Enable SPI writes
by build bot (Jenkins) (Code Review) 09 Dec '17

09 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22636 ) Change subject: soc/amd/stoneyridge: Enable SPI writes ...................................................................... Patch Set 8: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/64317/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/19133/ : SUCCESS -- To view, visit https://review.coreboot.org/22636 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I595a27ac27daa42c2499de1a343bc30be9a89fa6 Gerrit-Change-Number: 22636 Gerrit-PatchSet: 8 Gerrit-Owner: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Dec 2017 03:20:01 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Stop mucking with unused I2S0 pins in codec config
by Brian Norris (Code Review) 09 Dec '17

09 Dec '17

Brian Norris has posted comments on this change. ( https://review.coreboot.org/22791 ) Change subject: google/gru: Stop mucking with unused I2S0 pins in codec config ...................................................................... Patch Set 1: works for me -- To view, visit https://review.coreboot.org/22791 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9314617e725fe83d254984529f269d4442e736f1 Gerrit-Change-Number: 22791 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Dec 2017 02:57:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Move AGESA related source files
by build bot (Jenkins) (Code Review) 09 Dec '17

09 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22792 ) Change subject: soc/amd/common: Move AGESA related source files ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19132/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64316/ : SUCCESS -- To view, visit https://review.coreboot.org/22792 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I497cdefe64e8dff00aaff7153c4ffa9c57c9acf8 Gerrit-Change-Number: 22792 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Dec 2017 01:36:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Move AGESA related source files
by Richard Spiegel (Code Review) 09 Dec '17

09 Dec '17

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22792 ) Change subject: soc/amd/common: Move AGESA related source files ...................................................................... Patch Set 2: Had to do in 2 patches, first one just amd_late_init.c which had formatting OK. If I used the -n option when committing, Change-Id would not be generated and I could not push. So I needed a initial small commit which had good formatting in order not to use the -n option, do a commit generating the Change-Id, then do an amend with the -n option. -- To view, visit https://review.coreboot.org/22792 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I497cdefe64e8dff00aaff7153c4ffa9c57c9acf8 Gerrit-Change-Number: 22792 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Dec 2017 01:36:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Move AGESA related source files
by Richard Spiegel (Code Review) 09 Dec '17

09 Dec '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22792 to look at the new patch set (#2). Change subject: soc/amd/common: Move AGESA related source files ...................................................................... soc/amd/common: Move AGESA related source files Move AGESA related source files in soc/amd/common under block directory. Folder soc/amd/common/block subfolders should mimic soc/intel/common/block subfolders (one subfolder per subject). BUG=b:69262110 TEST=Build with no error gardenia and kahlee (no code change, just folder reorg). Change-Id: I497cdefe64e8dff00aaff7153c4ffa9c57c9acf8 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/soc/amd/common/Makefile.inc A src/soc/amd/common/block/pi/Kconfig A src/soc/amd/common/block/pi/Makefile.inc R src/soc/amd/common/block/pi/agesawrapper.c R src/soc/amd/common/block/pi/amd_late_init.c R src/soc/amd/common/block/pi/def_callouts.c R src/soc/amd/common/block/pi/heapmanager.c M src/soc/amd/stoneyridge/Kconfig 8 files changed, 22 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/22792/2 -- To view, visit https://review.coreboot.org/22792 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I497cdefe64e8dff00aaff7153c4ffa9c57c9acf8 Gerrit-Change-Number: 22792 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/amd/common: Move AGESA related source files
by build bot (Jenkins) (Code Review) 09 Dec '17

09 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22792 ) Change subject: soc/amd/common: Move AGESA related source files ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19131/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/64315/ : SUCCESS -- To view, visit https://review.coreboot.org/22792 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I497cdefe64e8dff00aaff7153c4ffa9c57c9acf8 Gerrit-Change-Number: 22792 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Dec 2017 01:27:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Stop mucking with unused I2S0 pins in codec config
by David Schneider (Code Review) 09 Dec '17

09 Dec '17

David Schneider has posted comments on this change. ( https://review.coreboot.org/22791 ) Change subject: google/gru: Stop mucking with unused I2S0 pins in codec config ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/22791 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9314617e725fe83d254984529f269d4442e736f1 Gerrit-Change-Number: 22791 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Dec 2017 01:22:25 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2017