coreboot-gerrit October 2017

coreboot-gerrit@coreboot.org

1 participants
1771 discussions

Change in coreboot[master]: mb/dell: Add Dell Optiplex 790
by build bot (Jenkins) (Code Review) 03 Oct '17

03 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21774 ) Change subject: mb/dell: Add Dell Optiplex 790 ...................................................................... Patch Set 10: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/61505/ : ABORTED -- To view, visit https://review.coreboot.org/21774 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3d3a13163d5da1368259a7498019d42fb3ed57f Gerrit-Change-Number: 21774 Gerrit-PatchSet: 10 Gerrit-Owner: Christoph Pomaska <cp_public(a)posteo.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christoph Pomaska <cp_public(a)posteo.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 03 Oct 2017 11:03:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/dell/optiplex_790: add libgfxinit (NOT WORKING)
by build bot (Jenkins) (Code Review) 03 Oct '17

03 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21861 ) Change subject: mb/dell/optiplex_790: add libgfxinit (NOT WORKING) ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61504/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16627/ : SUCCESS -- To view, visit https://review.coreboot.org/21861 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58570c239492b2a15b1599ca6d03714bbd8dc387 Gerrit-Change-Number: 21861 Gerrit-PatchSet: 2 Gerrit-Owner: Christoph Pomaska <cp_public(a)posteo.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 03 Oct 2017 11:01:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/soraka: Reduce Wacom resume time
by build bot (Jenkins) (Code Review) 03 Oct '17

03 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21692 ) Change subject: mainboard/google/soraka: Reduce Wacom resume time ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61503/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16626/ : SUCCESS -- To view, visit https://review.coreboot.org/21692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59d070977a95316414018af69d5b43e3147ccf4e Gerrit-Change-Number: 21692 Gerrit-PatchSet: 2 Gerrit-Owner: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com> Gerrit-Reviewer: Anshuman Gupta <anshuman.gupta(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.corp-partner.google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 03 Oct 2017 09:07:37 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/net/r8168: Add customized LED mode
by Arthur Heymans (Code Review) 03 Oct '17

03 Oct '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21862 ) Change subject: drivers/net/r8168: Add customized LED mode ...................................................................... Patch Set 1: Code-Review-1 (4 comments) https://review.coreboot.org/#/c/21862/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/21862/1//COMMIT_MSG@17 PS1, Line 17: RT8111H_CUSOMIZED_LED_VALUE in Kconfig file : under target board Board specific settings should go into devicetree as much as possible. https://review.coreboot.org/#/c/21862/1/src/drivers/net/r8168.c File src/drivers/net/r8168.c: https://review.coreboot.org/#/c/21862/1/src/drivers/net/r8168.c@218 PS1, Line 218: #if IS_ENABLED(CONFIG_RT8111H_SET_LED_MODE) if (!IS_ENABLED(...)) return; https://review.coreboot.org/#/c/21862/1/src/drivers/net/r8168.c@221 PS1, Line 221: /* check the VPD for the mac address */ : setting = CONFIG_RT8111H_CUSTOMIZED_LED_VALUE; this is a Kconfig option, not VPD. Also if it is mainboard specific it should go into devicetree, not Kconfig. https://review.coreboot.org/#/c/21862/1/src/drivers/net/r8168.c@228 PS1, Line 228: /* Refer to datasheet 7.2, starting from offset 0x18 add title please -- To view, visit https://review.coreboot.org/21862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3d4f2cd98ac391e1661a891d604bdd1974d07f6 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Kevin Cheng <kevin.cheng(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 03 Oct 2017 08:25:17 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: drivers/net/r8168: Add customized LED mode
by build bot (Jenkins) (Code Review) 03 Oct '17

03 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21862 ) Change subject: drivers/net/r8168: Add customized LED mode ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61502/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16625/ : SUCCESS -- To view, visit https://review.coreboot.org/21862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3d4f2cd98ac391e1661a891d604bdd1974d07f6 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Kevin Cheng <kevin.cheng(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 03 Oct 2017 07:33:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/net/r8168: Add customized LED mode
by Gaggery Tsai (Code Review) 03 Oct '17

03 Oct '17

Gaggery Tsai has uploaded this change for review. ( https://review.coreboot.org/21862 Change subject: drivers/net/r8168: Add customized LED mode ...................................................................... drivers/net/r8168: Add customized LED mode This patch is to add a function for programming cusotmized LEDs setting to Realtek 81xx family. It reads RT8111H_CUSTOMIZED_LED_VALUE from target board config file and programs the setting to offset 0x18 and 0x19. BUG=b:65437780 TEST=Add RT8111H_CUSOMIZED_LED_VALUE in Kconfig file under target board and make sure the setting is programmed correctly to offset 0x18 and 0x19. Observed the LEDs were behaving as expected. Executed suspend/resume and the LEDs were still working as expected. Change-Id: Ib3d4f2cd98ac391e1661a891d604bdd1974d07f6 Signed-off-by: Gaggery Tsai <gaggery.tsai(a)intel.com> --- M src/drivers/net/Kconfig M src/drivers/net/r8168.c 2 files changed, 45 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/21862/1 diff --git a/src/drivers/net/Kconfig b/src/drivers/net/Kconfig index 67a1389..61f1788 100644 --- a/src/drivers/net/Kconfig +++ b/src/drivers/net/Kconfig @@ -18,3 +18,8 @@ bool default n select REALTEK_8168_RESET + +config RT8111H_SET_LED_MODE + bool + default n + select REALTEK_8168_RESET diff --git a/src/drivers/net/r8168.c b/src/drivers/net/r8168.c index 3727ccd..a8a2500 100644 --- a/src/drivers/net/r8168.c +++ b/src/drivers/net/r8168.c @@ -36,6 +36,8 @@ #define CMD_REG 0x37 #define CMD_REG_RESET 0x10 +#define CMD_LED0_LED1 0x18 +#define CMD_LED2_FC 0x19 #define CFG_9346 0x50 #define CFG_9346_LOCK 0x00 @@ -211,6 +213,41 @@ printk(BIOS_DEBUG, "done\n"); } +static void r8111h_set_customized_led(u16 io_base) +{ +#if IS_ENABLED(CONFIG_RT8111H_SET_LED_MODE) + u16 setting = 0; + + /* check the VPD for the mac address */ + setting = CONFIG_RT8111H_CUSTOMIZED_LED_VALUE; + printk(BIOS_DEBUG, "r8111h: Customized LED 0x%x\n", setting); + + /* Disable register protection */ + outb(CFG_9346_UNLOCK, io_base + CFG_9346); + + /* Refer to datasheet 7.2, starting from offset 0x18 + * Bit[15:12] LED Feature Control(FC) + * Bit[11:08] LED Select for PINLED2 + * Bit[07:04] LED Select for PINLED1 + * Bit[03:00] LED Select for PINLED0 + * + * Speed Link10M Link100M Link1000M ACT/Full + * LED0 Bit0 Bit1 Bit2 Bit3 + * LED1 Bit4 Bit5 Bit6 Bit7 + * LED2 Bit8 Bit9 Bit10 Bit11 + * FC Bit12 Bit13 Bit14 Bit15 + */ + + /* Set customized LED registers */ + outw(setting & 0xffff, io_base + CMD_LED0_LED1); + printk(BIOS_DEBUG, "r8111h: read back LED setting as 0x%x\n", + inw(io_base + CMD_LED0_LED1)); + + /* Lock config regs */ + outb(CFG_9346_LOCK, io_base + CFG_9346); +#endif +} + static void r8168_init(struct device *dev) { /* Get the resource of the NIC mmio */ @@ -223,8 +260,10 @@ /* Program MAC address based on CBFS "macaddress" containing * a string AA:BB:CC:DD:EE:FF */ - if (io_base) + if (io_base) { program_mac_address(dev, io_base); + r8111h_set_customized_led(io_base); + } else printk(BIOS_ERR, "r8168: Error cant find MMIO resource\n"); } -- To view, visit https://review.coreboot.org/21862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib3d4f2cd98ac391e1661a891d604bdd1974d07f6 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 1 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com>

1 0

Change in coreboot[master]: mb/dell/optiplex_790: add libgfxinit (NOT WORKING)
by Arthur Heymans (Code Review) 03 Oct '17

03 Oct '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21861 ) Change subject: mb/dell/optiplex_790: add libgfxinit (NOT WORKING) ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/21861/1/src/mainboard/dell/optiplex_790/Kco… File src/mainboard/dell/optiplex_790/Kconfig: https://review.coreboot.org/#/c/21861/1/src/mainboard/dell/optiplex_790/Kco… PS1, Line 10: select NORTHBRIDGE_INTEL_IVYBRIDGE # (Actually SANDYBRIDGE) probably bad idea since it really is SANDY_BRIDGE. please try without. (actually it's poorly named/used since it should reflect the PCH version instead CPU for libgfxinit to work) -- To view, visit https://review.coreboot.org/21861 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58570c239492b2a15b1599ca6d03714bbd8dc387 Gerrit-Change-Number: 21861 Gerrit-PatchSet: 1 Gerrit-Owner: Christoph Pomaska <cp_public(a)posteo.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 03 Oct 2017 06:54:04 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: intel/common: CAR setup CQOS
by build bot (Jenkins) (Code Review) 03 Oct '17

03 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21701 ) Change subject: intel/common: CAR setup CQOS ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61501/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16624/ : SUCCESS -- To view, visit https://review.coreboot.org/21701 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic736dba1a46629ff5bf3183082799c0c1468e6d9 Gerrit-Change-Number: 21701 Gerrit-PatchSet: 8 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 03 Oct 2017 04:13:44 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/common: CAR setup CQOS
by build bot (Jenkins) (Code Review) 03 Oct '17

03 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21701 ) Change subject: intel/common: CAR setup CQOS ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61500/ : SUCCESS -- To view, visit https://review.coreboot.org/21701 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic736dba1a46629ff5bf3183082799c0c1468e6d9 Gerrit-Change-Number: 21701 Gerrit-PatchSet: 8 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 03 Oct 2017 04:12:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/common: CAR setup CQOS
by Naresh Solanki (Code Review) 03 Oct '17

03 Oct '17

Naresh Solanki has uploaded a new patch set (#8). ( https://review.coreboot.org/21701 ) Change subject: intel/common: CAR setup CQOS ...................................................................... intel/common: CAR setup CQOS Enable CQOS on Geminilake. In Apololake, CBM_LEN is 0x7. Whereas the same in Geminilake is 0xF. Thus get CBM_LEN using cpuid instruction & generate CBM_LEN_MASK. Later use the CBM_LEN_MASK when writing to IA32_L2_MASK_* to set right bits. BUG=None TEST= Build for Geminilake platform i.e., glkrvp & check for successful CAR setup. Even verified the same on APL platform i.e., on Reef Change-Id: Ic736dba1a46629ff5bf3183082799c0c1468e6d9 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com --- M src/soc/intel/common/block/cpu/car/cache_as_ram.S 1 file changed, 28 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/21701/8 -- To view, visit https://review.coreboot.org/21701 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic736dba1a46629ff5bf3183082799c0c1468e6d9 Gerrit-Change-Number: 21701 Gerrit-PatchSet: 8 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2017