coreboot-gerrit October 2017

coreboot-gerrit@coreboot.org

1 participants
1771 discussions

Change in coreboot[master]: util/amdfwtool: Add option for directory location
by build bot (Jenkins) (Code Review) 04 Oct '17

04 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21865 ) Change subject: util/amdfwtool: Add option for directory location ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61559/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16670/ : SUCCESS -- To view, visit https://review.coreboot.org/21865 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief32e5e37d56088946b623d305c6e93bfd6abeaf Gerrit-Change-Number: 21865 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Oct 2017 18:47:26 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Replace magic registers
by build bot (Jenkins) (Code Review) 04 Oct '17

04 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21767 ) Change subject: soc/amd/stoneyridge: Replace magic registers ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61557/ : SUCCESS -- To view, visit https://review.coreboot.org/21767 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9187ba1c41ebb1201ddc177e8184672c60cd5f5d Gerrit-Change-Number: 21767 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Oct 2017 15:09:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/{common, apollolake}: Add checks to handle negative values
by build bot (Jenkins) (Code Review) 04 Oct '17

04 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21875 ) Change subject: soc/intel/{common,apollolake}: Add checks to handle negative values ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61556/ : SUCCESS -- To view, visit https://review.coreboot.org/21875 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic65400c934631e3dcd3aa664c24cb451616e7f4d Gerrit-Change-Number: 21875 Gerrit-PatchSet: 2 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Oct 2017 14:50:01 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/{common, apollolake}: fix coverity issues
by build bot (Jenkins) (Code Review) 04 Oct '17

04 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21875 ) Change subject: soc/intel/{common,apollolake}: fix coverity issues ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61555/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16668/ : SUCCESS -- To view, visit https://review.coreboot.org/21875 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic65400c934631e3dcd3aa664c24cb451616e7f4d Gerrit-Change-Number: 21875 Gerrit-PatchSet: 1 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Oct 2017 13:40:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/{common, apollolake}: fix coverity issues
by Rizwan Qureshi (Code Review) 04 Oct '17

04 Oct '17

Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/21875 Change subject: soc/intel/{common,apollolake}: fix coverity issues ...................................................................... soc/intel/{common,apollolake}: fix coverity issues fix issues reported by coverity scan in the below files src/soc/intel/common/block/i2c 1375440: Improper use of negative value 1375441: Improper use of negative value 1375444: Improper use of negative value src/soc/intel/apollolake/i2c.c 1375442: Unsigned compared against 0 Change-Id: Ic65400c934631e3dcd3aa664c24cb451616e7f4d Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> --- M src/soc/intel/apollolake/i2c.c M src/soc/intel/common/block/i2c/i2c.c 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/21875/1 diff --git a/src/soc/intel/apollolake/i2c.c b/src/soc/intel/apollolake/i2c.c index 2b6cbf9..4ae500e 100644 --- a/src/soc/intel/apollolake/i2c.c +++ b/src/soc/intel/apollolake/i2c.c @@ -44,7 +44,7 @@ /* Convert I2C bus number to PCI device and function */ int i2c_soc_bus_to_devfn(unsigned int bus) { - if (bus >= 0 && bus <= 3) + if (bus <= 3) return PCI_DEVFN(PCH_DEV_SLOT_SIO1, bus); else if (bus >= 4 && bus <= 7) return PCI_DEVFN(PCH_DEV_SLOT_SIO2, (bus - 4)); diff --git a/src/soc/intel/common/block/i2c/i2c.c b/src/soc/intel/common/block/i2c/i2c.c index 625bb99..c6f3be2 100644 --- a/src/soc/intel/common/block/i2c/i2c.c +++ b/src/soc/intel/common/block/i2c/i2c.c @@ -96,9 +96,12 @@ const struct lpss_i2c_bus_config *config; int bus = lpss_i2c_dev_to_bus(dev); + if (bus < 0) + return; + config = i2c_get_soc_cfg(bus, dev); - if (!config || bus < 0) + if (!config) return; lpss_i2c_init(bus, config); @@ -126,6 +129,9 @@ bus = lpss_i2c_dev_to_bus(dev); + if (bus < 0) + return; + bcfg = i2c_get_soc_cfg(bus, dev); if (!bcfg) -- To view, visit https://review.coreboot.org/21875 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic65400c934631e3dcd3aa664c24cb451616e7f4d Gerrit-Change-Number: 21875 Gerrit-PatchSet: 1 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com>

1 0

Change in coreboot[master]: src/device: Update LTR configuration scheme
by build bot (Jenkins) (Code Review) 04 Oct '17

04 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21868 ) Change subject: src/device: Update LTR configuration scheme ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61554/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16667/ : SUCCESS -- To view, visit https://review.coreboot.org/21868 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be99c3b590c1457adf88bc1b40f128fcade3fbe Gerrit-Change-Number: 21868 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Wed, 04 Oct 2017 13:22:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vendor/intel/skykabylake: Update FSP header files to version 2.7.2
by build bot (Jenkins) (Code Review) 04 Oct '17

04 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21679 ) Change subject: vendor/intel/skykabylake: Update FSP header files to version 2.7.2 ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61553/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16665/ : SUCCESS -- To view, visit https://review.coreboot.org/21679 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4eca011bc9a3b1a50e49d6d86a09d05a0cbf151 Gerrit-Change-Number: 21679 Gerrit-PatchSet: 5 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Oct 2017 13:04:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Add config for mbx command for Intersil VR C-state...
by build bot (Jenkins) (Code Review) 04 Oct '17

04 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21680 ) Change subject: soc/intel/skylake: Add config for mbx command for Intersil VR C-state issues ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61552/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16666/ : SUCCESS -- To view, visit https://review.coreboot.org/21680 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibcced31b7ba473ffa7368c90c945d07a81a368d4 Gerrit-Change-Number: 21680 Gerrit-PatchSet: 5 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Oct 2017 13:03:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [NOTFORMERGE]: biostar/a68n_5200: Enable IDS tracing
by build bot (Jenkins) (Code Review) 04 Oct '17

04 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21873 ) Change subject: [NOTFORMERGE]: biostar/a68n_5200: Enable IDS tracing ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61551/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16664/ : SUCCESS -- To view, visit https://review.coreboot.org/21873 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06a9699e5c8844652c1db389adea671ecdca5cc0 Gerrit-Change-Number: 21873 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Oct 2017 09:59:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: biostar/a68n_5200: Port to working UART console
by build bot (Jenkins) (Code Review) 04 Oct '17

04 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21872 ) Change subject: biostar/a68n_5200: Port to working UART console ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61550/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16663/ : SUCCESS -- To view, visit https://review.coreboot.org/21872 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id44b81345ba189f82413042760d570a746294a1e Gerrit-Change-Number: 21872 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Oct 2017 09:41:50 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2017