the following patch was just integrated into master:
commit f100700a149d1a1d4c87f63e50b8f4d89a8c2650
Author: Elyes HAOUAS <ehaouas(a)noos.fr>
Date: Wed Nov 23 19:00:14 2016 +0100
sb/broadcom/bcm5785/reset.c: Use tab for indents
Change-Id: If4350da1c9a7af5228be01a063486433860781e0
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
Reviewed-on: https://review.coreboot.org/17583
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/17583 for details.
-gerrit
the following patch was just integrated into master:
commit 2220f0d7c79b2f22ccdc93e8fa643e8928c1ff3c
Author: Elyes HAOUAS <ehaouas(a)noos.fr>
Date: Wed Nov 23 18:54:34 2016 +0100
sb/ricoh/rl5c476/rl5c476.c: Use tab for indents
Change-Id: I3967d1ff0623037efa66927843e0c47f408832d7
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
Reviewed-on: https://review.coreboot.org/17582
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/17582 for details.
-gerrit
the following patch was just integrated into master:
commit 1b593e5ad76bb66298c6f39b2cfb6fdf1f784c38
Author: Patrick Georgi <pgeorgi(a)chromium.org>
Date: Fri Nov 25 15:27:41 2016 +0100
util/crossgcc: fix using -D
Otherwise errors similar to "touch: cannot touch
'${TARGETDIR}/.GMP.6.1.0.success': No such file
or directory" might occur.
Change-Id: I4f24c93a25b7d567d3ce14a0415d20fd0778c9c8
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Reviewed-on: https://review.coreboot.org/17603
Tested-by: build bot (Jenkins)
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
See https://review.coreboot.org/17603 for details.
-gerrit
Matt DeVillier (matt.devillier(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17456
-gerrit
commit b6fb9fe2640f2d9f7e32b0124adfeee20f3aef93
Author: Matt DeVillier <matt.devillier(a)gmail.com>
Date: Wed Nov 16 23:37:43 2016 -0600
soc/broadwell/igd.c: limit max CD clock to 450MHz
limit the max CD clock frequency to 450MHz for ULT SoCs, as
higher values result in HDMI audio speedup, failure to pass
HD audio bitstreams, and other related issues under Windows
(8/8.1/10).
The Linux i915 driver renegotiates the cdclk to 337.5Mhz for Broadwell
ULT regardless, so isn't affected by the value set in firmware.
Change-Id: Ibf253f7ab3ba340b4ab6fd97225155ffb112d74d
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
src/soc/intel/broadwell/igd.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/src/soc/intel/broadwell/igd.c b/src/soc/intel/broadwell/igd.c
index ccb1e93..db4f126 100644
--- a/src/soc/intel/broadwell/igd.c
+++ b/src/soc/intel/broadwell/igd.c
@@ -407,24 +407,18 @@ static void igd_cdclk_init_broadwell(struct device *dev)
gtt_write(0x138124, 0x80000018);
/* Poll GT driver mailbox for run/busy clear */
- if (!gtt_poll(0x138124, (1 << 31), (0 << 31)))
- cdclk = GT_CDCLK_450;
+ gtt_poll(0x138124, (1 << 31), (0 << 31));
if (gtt_read(0x42014) & 0x1000000) {
/* If CD clock is fixed then set to 450MHz */
cdclk = GT_CDCLK_450;
} else {
- /* Program CD clock to highest supported freq */
+ /* Limit ULT to 450Mhz, as Windows drivers can't handle higher
+ speed, and Linux drivers will negotiate down to 337.5Mhz anyway */
if (cpu_is_ult())
- cdclk = GT_CDCLK_540;
- else
- cdclk = GT_CDCLK_675;
+ cdclk = GT_CDCLK_450;
}
- /* CD clock frequency 675MHz not supported on ULT */
- if (cpu_is_ult() && cdclk == GT_CDCLK_675)
- cdclk = GT_CDCLK_540;
-
/* Set variables based on CD Clock setting */
switch (cdclk) {
case GT_CDCLK_337:
Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17624
-gerrit
commit 077cb9859bfd6ec79d8bee8da4c85c57d382f0e8
Author: Arthur Heymans <arthur(a)aheymans.xyz>
Date: Sun Nov 27 22:29:01 2016 +0100
nb/x4x: Fix raminit reset
All the other Intel raminits reset when bit7 of pmcon2 is set to 1.
NOT TESTED.
Change-Id: Ic014533aef7e75742ff7685020d9777dbdd1369f
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
src/northbridge/intel/x4x/raminit_ddr2.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/northbridge/intel/x4x/raminit_ddr2.c b/src/northbridge/intel/x4x/raminit_ddr2.c
index b3ee34a..9638ad7 100644
--- a/src/northbridge/intel/x4x/raminit_ddr2.c
+++ b/src/northbridge/intel/x4x/raminit_ddr2.c
@@ -260,8 +260,9 @@ static void checkreset_ddr2(struct sysinfo *s)
u8 reset = 0;
pmcon2 = pci_read_config8(PCI_DEV(0, 0x1f, 0), 0xa2);
- if (!(pmcon2 & 0x80)) {
- pmcon2 |= 0x80;
+ /* Do we want to reset at S4-assertion-width violation (1 << 2)? */
+ if (pmcon2 & 0x80) {
+ pmcon2 &= ~0x80;
pci_write_config8(PCI_DEV(0, 0x1f, 0), 0xa2, pmcon2);
reset = 1;
Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17624
-gerrit
commit 12d92e3f469fb1217350bbd4373ddc636d77c7dd
Author: Arthur Heymans <arthur(a)aheymans.xyz>
Date: Sun Nov 27 22:29:01 2016 +0100
nb/x4x: Fix raminit reboot
All the other Intel raminits reboot when bit7 of pmcon2 is set to 1.
NOT TESTED.
Change-Id: Ic014533aef7e75742ff7685020d9777dbdd1369f
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
src/northbridge/intel/x4x/raminit_ddr2.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/northbridge/intel/x4x/raminit_ddr2.c b/src/northbridge/intel/x4x/raminit_ddr2.c
index b3ee34a..9638ad7 100644
--- a/src/northbridge/intel/x4x/raminit_ddr2.c
+++ b/src/northbridge/intel/x4x/raminit_ddr2.c
@@ -260,8 +260,9 @@ static void checkreset_ddr2(struct sysinfo *s)
u8 reset = 0;
pmcon2 = pci_read_config8(PCI_DEV(0, 0x1f, 0), 0xa2);
- if (!(pmcon2 & 0x80)) {
- pmcon2 |= 0x80;
+ /* Do we want to reset at S4-assertion-width violation (1 << 2)? */
+ if (pmcon2 & 0x80) {
+ pmcon2 &= ~0x80;
pci_write_config8(PCI_DEV(0, 0x1f, 0), 0xa2, pmcon2);
reset = 1;
Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17623
-gerrit
commit 2150ab51f9e5ebd1f657e95ea3a11b7678c15be0
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sun Nov 27 22:17:44 2016 +0100
nb/intel/i945/gma: Declare count variable outside 'for' loop
Building an image for the Lenovo X60 on Debian 8.5 (jessie) with GCC 4.9.2,
compilation fails with the error below.
```
$ gcc --version
gcc (Debian 4.9.2-10) 4.9.2
[…]
$ make # lenovo/x60 with native graphics initialization
[…]
CC ramstage/northbridge/intel/i945/gma.o
src/northbridge/intel/i945/gma.c: In function 'probe_edid':
src/northbridge/intel/i945/gma.c:570:2: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
for (int i = 0; i < 8; i++) {
^
src/northbridge/intel/i945/gma.c:570:2: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code
Makefile:316: recipe for target 'build/ramstage/northbridge/intel/i945/gma.o' failed
make: *** [build/ramstage/northbridge/intel/i945/gma.o] Error 1
```
Fix this by declaring the count variable outside the 'for' loop.
Change-Id: Icf69337ee46c86bafc4e1320fd99f8f8f5155bfe
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
---
src/northbridge/intel/i945/gma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c
index e3ff478..b9a37e4 100644
--- a/src/northbridge/intel/i945/gma.c
+++ b/src/northbridge/intel/i945/gma.c
@@ -563,11 +563,12 @@ static int intel_gma_init_vga(struct northbridge_intel_i945_config *conf,
/* if vga is not connected it should have a correct header */
static int probe_edid(u8 *pmmio, u8 slave)
{
+ int i;
u8 vga_edid[128];
u8 header[8] = {0x00, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00};
intel_gmbus_read_edid(pmmio + GMBUS0, slave, 0x50, vga_edid, 128);
intel_gmbus_stop(pmmio + GMBUS0);
- for (int i = 0; i < 8; i++) {
+ for (i = 0; i < 8; i++) {
if (vga_edid[i] != header[i]) {
printk(BIOS_DEBUG, "No display connected on slave %d\n",
slave);
Matt DeVillier (matt.devillier(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17620
-gerrit
commit f1d148fc5a5dee30b42d1548d7f846fba10c91f8
Author: CoolStar <coolstarorganization(a)gmail.com>
Date: Thu Jul 14 12:34:33 2016 -0700
sb/intel/lynxpoint: add missing I2C ACPI SSCN/FMCN methods
The SSCN and FMCN methods provide the optimal HCNT/LCNT timing values to
the driver, and are necessary when using I2C devices (eg, trackpad and
touchscreen) in ACPI (vs PCI) mode. Add these methods using the
timing values from Broadwell, which work for Haswell/Lynxpoint as well.
TEST: build google/peppy with trackpad/touchscreen devices in ACPI mode,
observe proper operation under Windows and Linux
Change-Id: I25f07ac474b041358315530e5f391bb33d9c4d04
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
src/southbridge/intel/lynxpoint/acpi/serialio.asl | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/southbridge/intel/lynxpoint/acpi/serialio.asl b/src/southbridge/intel/lynxpoint/acpi/serialio.asl
index 930a8ee..e4d8659 100644
--- a/src/southbridge/intel/lynxpoint/acpi/serialio.asl
+++ b/src/southbridge/intel/lynxpoint/acpi/serialio.asl
@@ -127,6 +127,9 @@ Device (SDMA)
Name (_UID, 1)
Name (_ADR, 0x00150000)
+ Name (SSCN, Package () { 432, 507, 30 })
+ Name (FMCN, Package () { 72, 160, 30 })
+
// BAR0 is assigned during PCI enumeration and saved into NVS
Name (RBUF, ResourceTemplate ()
{
@@ -165,6 +168,9 @@ Device (I2C0)
Name (_UID, 1)
Name (_ADR, 0x00150001)
+ Name (SSCN, Package () { 432, 507, 30 })
+ Name (FMCN, Package () { 72, 160, 30 })
+
// BAR0 is assigned during PCI enumeration and saved into NVS
Name (RBUF, ResourceTemplate ()
{