coreboot-gerrit January 2016

coreboot-gerrit@coreboot.org

1 participants
2471 discussions

Patch merged into coreboot/master: xcompile: Quote variables to prevent globbing and splitting.
by gerrit＠coreboot.org 07 Jan '16

07 Jan '16

the following patch was just integrated into master: commit 2ba837d8c7b5d929ae898006b4355649d7ea8b39 Author: Martin Roth <martinroth(a)google.com> Date: Tue Jan 5 15:55:44 2016 -0700 xcompile: Quote variables to prevent globbing and splitting. Quoting variables prevents word splitting and glob expansion, and prevents the script from breaking when input contains spaces, line feeds, glob characters and such. See shellcheck warning SC2086 Change-Id: Ib6ca46b64a621c4bea5c33ac312f2824b0386235 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12845 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/12845 for details. -gerrit

1 0

Patch merged into coreboot/master: xcompile: Use local variables in the test functions
by gerrit＠coreboot.org 07 Jan '16

07 Jan '16

the following patch was just integrated into master: commit 7051dea5f4863ff1d1a08fe89dbb23bd18898974 Author: Martin Roth <martinroth(a)google.com> Date: Tue Jan 5 15:49:32 2016 -0700 xcompile: Use local variables in the test functions Using the local variables instead of positional parameters helps readability. - Add and use the local variables in testcc. - Use the existing local variables in testld. Change-Id: Ice13288b830a7aa043b360eaee8e36f060589a18 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12844 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/12844 for details. -gerrit

1 0

Patch merged into coreboot/master: xcompile: use $() instead of backticks
by gerrit＠coreboot.org 07 Jan '16

07 Jan '16

the following patch was just integrated into master: commit 033abe5e690d2533b768eae9c236bde70d514980 Author: Martin Roth <martinroth(a)google.com> Date: Tue Jan 5 15:44:02 2016 -0700 xcompile: use $() instead of backticks While the backtick syntax isn't actually deprecated, the $() syntax is preferred. Since both styles were being used in this script, settle on the new standard for all cases. Change-Id: I33770d666781b4fa34c909411e0d220c2540dbb4 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12843 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/12843 for details. -gerrit

1 0

Patch merged into coreboot/master: xcompile: Only include arm64 erratum check in arm64 section
by gerrit＠coreboot.org 07 Jan '16

07 Jan '16

the following patch was just integrated into master: commit af0216f1b87b22580bb652bb7ad5071d57e63ad6 Author: Martin Roth <martinroth(a)google.com> Date: Tue Jan 5 14:56:13 2016 -0700 xcompile: Only include arm64 erratum check in arm64 section Clean up the output file a bit by only including the erratum for arm64 into the that architecture section instead of every architecture. Change-Id: Ib6276f12aee5deb92a03e1c4fa2ad57db46bdc8f Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12842 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/12842 for details. -gerrit

1 0

Patch merged into coreboot/master: xcompile: Put compiler variables outside of 'if' to allow checking
by gerrit＠coreboot.org 07 Jan '16

07 Jan '16

the following patch was just integrated into master: commit c4b684ebee0ccbf1b67064317f68f5287e720642 Author: Martin Roth <martinroth(a)google.com> Date: Tue Jan 5 14:47:59 2016 -0700 xcompile: Put compiler variables outside of 'if' to allow checking In order to be able to check the compiler versions, we need to be able to access the compiler variables. Move the original assignments outside of the GCC check, and assign either the GCC or CLANG compiler to the actual CC_ environment variable later. This ends up with the same value set, while allowing the compiler versions to be checked. Change-Id: Iffad02d526420ebbdfb15ed45eb51187caaa94fb Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12841 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/12841 for details. -gerrit

1 0

Patch merged into coreboot/master: xcompile: Separate flags from clang executable
by gerrit＠coreboot.org 07 Jan '16

07 Jan '16

the following patch was just integrated into master: commit f3e60d0d6957b7d12b09c4e13d63275e493bb7bc Author: Martin Roth <martinroth(a)google.com> Date: Tue Jan 5 14:34:59 2016 -0700 xcompile: Separate flags from clang executable We already have a CFLAGS variable - Use it for all of the flags. Change-Id: I22b4c5cf24b8743e85ffab29ddcccdc6c732ea3b Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12840 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/12840 for details. -gerrit

1 0

Patch merged into coreboot/master: xcompile: Add XGCCPATH to clang compiler
by gerrit＠coreboot.org 07 Jan '16

07 Jan '16

the following patch was just integrated into master: commit 51d4de818dfd92ab7a17c473fd4c5b6bd32837f8 Author: Martin Roth <martinroth(a)google.com> Date: Tue Jan 5 14:30:22 2016 -0700 xcompile: Add XGCCPATH to clang compiler The XGCCPATH prefix is on all the other tools and compilers, so add it to clang as well, so it can be found correctly. Change-Id: Ibc250a81433f37bbb0555d32605aebe3a68aaf40 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12839 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/12839 for details. -gerrit

1 0

Patch merged into coreboot/master: xcompile: Add separation for architectures to improve readability
by gerrit＠coreboot.org 07 Jan '16

07 Jan '16

the following patch was just integrated into master: commit 03f7a49f5a745ee749ee0e3ea9e8b66ec2b0c731 Author: Martin Roth <martinroth(a)google.com> Date: Tue Jan 5 14:21:02 2016 -0700 xcompile: Add separation for architectures to improve readability - Add bar at the top of each architecture - Make the architecture name and the TARCH_SEARCH to two lines - Add a second line at the bottom of each architecture - Add a comment about the two blank lines so they don't get accidentally removed. Change-Id: Ib4326bd94fe39b979244816ce54b752d083f6b16 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12838 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/12838 for details. -gerrit

1 0

Patch merged into coreboot/master: xcompile: Use tabs for indentation
by gerrit＠coreboot.org 07 Jan '16

07 Jan '16

the following patch was just integrated into master: commit c2054f321285ee107c5a6abda826274eb3009dd9 Author: Martin Roth <martinroth(a)google.com> Date: Tue Jan 5 14:16:57 2016 -0700 xcompile: Use tabs for indentation Change-Id: I96a5048050f8016c3c569f20318b4d421a4470a7 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12837 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/12837 for details. -gerrit

1 0

Patch merged into coreboot/master: Makefile.inc: update location of dsdt
by gerrit＠coreboot.org 07 Jan '16

07 Jan '16

the following patch was just integrated into master: commit 4fdd8030a4ad5ad87192303d2bdff23950209042 Author: Martin Roth <martinroth(a)google.com> Date: Mon Jan 4 10:44:13 2016 -0700 Makefile.inc: update location of dsdt The dsdt file moved from the mainboard directory to the top level of the build directory. Remove it from the new location when cleaning. Change-Id: If9f72c78e5c03e0db384b3181c169aa2ecbb5c18 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/12822 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See https://review.coreboot.org/12822 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2016