Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12857
-gerrit
commit e31c91f959670f702d30c5e00f634d09f25f0472
Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Date: Wed Nov 18 15:21:34 2015 -0800
Drop abuild.disabled files for Skylake boards
Make sure the latest & greatest Intel targets actually
build in our build system.
Change-Id: Ie784628a57257cea30e5e47074648198b884f6db
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
src/mainboard/google/chell/abuild.disabled | 2 --
src/mainboard/google/glados/abuild.disabled | 2 --
src/mainboard/google/lars/abuild.disabled | 2 --
src/mainboard/intel/kunimitsu/abuild.disabled | 2 --
src/mainboard/intel/sklrvp/abuild.disabled | 2 --
5 files changed, 10 deletions(-)
diff --git a/src/mainboard/google/chell/abuild.disabled b/src/mainboard/google/chell/abuild.disabled
deleted file mode 100644
index 7d1725a..0000000
--- a/src/mainboard/google/chell/abuild.disabled
+++ /dev/null
@@ -1,2 +0,0 @@
-Successful builds for this board require the Skylake FSP binary and header files
-along with the Skylake microcode files from Intel.
diff --git a/src/mainboard/google/glados/abuild.disabled b/src/mainboard/google/glados/abuild.disabled
deleted file mode 100644
index 7d1725a..0000000
--- a/src/mainboard/google/glados/abuild.disabled
+++ /dev/null
@@ -1,2 +0,0 @@
-Successful builds for this board require the Skylake FSP binary and header files
-along with the Skylake microcode files from Intel.
diff --git a/src/mainboard/google/lars/abuild.disabled b/src/mainboard/google/lars/abuild.disabled
deleted file mode 100644
index 7d1725a..0000000
--- a/src/mainboard/google/lars/abuild.disabled
+++ /dev/null
@@ -1,2 +0,0 @@
-Successful builds for this board require the Skylake FSP binary and header files
-along with the Skylake microcode files from Intel.
diff --git a/src/mainboard/intel/kunimitsu/abuild.disabled b/src/mainboard/intel/kunimitsu/abuild.disabled
deleted file mode 100644
index 7d1725a..0000000
--- a/src/mainboard/intel/kunimitsu/abuild.disabled
+++ /dev/null
@@ -1,2 +0,0 @@
-Successful builds for this board require the Skylake FSP binary and header files
-along with the Skylake microcode files from Intel.
diff --git a/src/mainboard/intel/sklrvp/abuild.disabled b/src/mainboard/intel/sklrvp/abuild.disabled
deleted file mode 100644
index 7d1725a..0000000
--- a/src/mainboard/intel/sklrvp/abuild.disabled
+++ /dev/null
@@ -1,2 +0,0 @@
-Successful builds for this board require the Skylake FSP binary and header files
-along with the Skylake microcode files from Intel.
Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12463
-gerrit
commit 04123783d85c908875f4d75a161b7238d9fa917b
Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Date: Wed Nov 18 15:21:34 2015 -0800
Drop abuild.disabled files for Braswell boards
Make sure the latest & greatest Intel targets actually
build in our build system.
Change-Id: I479ad473c260fc914d224cb58f4be1837aff2502
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
---
src/mainboard/google/cyan/abuild.disabled | 2 --
src/mainboard/intel/strago/abuild.disabled | 2 --
2 files changed, 4 deletions(-)
diff --git a/src/mainboard/google/cyan/abuild.disabled b/src/mainboard/google/cyan/abuild.disabled
deleted file mode 100644
index 025ebea..0000000
--- a/src/mainboard/google/cyan/abuild.disabled
+++ /dev/null
@@ -1,2 +0,0 @@
-Successful builds for this board require the Braswell FSP binary and header
-files along with the Braswell microcode files from Intel.
diff --git a/src/mainboard/intel/strago/abuild.disabled b/src/mainboard/intel/strago/abuild.disabled
deleted file mode 100644
index 025ebea..0000000
--- a/src/mainboard/intel/strago/abuild.disabled
+++ /dev/null
@@ -1,2 +0,0 @@
-Successful builds for this board require the Braswell FSP binary and header
-files along with the Braswell microcode files from Intel.
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12856
-gerrit
commit 950c736b28966820671dee586ccbece1c59d703e
Author: Martin Roth <martinroth(a)google.com>
Date: Thu Jan 7 11:03:36 2016 -0700
buildgcc: Print out all missing tools then halt
Instead of printing out a single tool that needs to be installed
each time buildgcc is run, print out the entire list of tools
to be installed, then halt.
Change-Id: I7761760eef3c45ba371f882a4f987408945bb3e5
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
util/crossgcc/buildgcc | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 5628a3a..25a7149 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -92,6 +92,7 @@ CYAN='\033[1;36m'
NC='\033[0m' # No Color
UNAME=$(uname | grep -iq cygwin && echo Cygwin || uname)
+HALT_FOR_TOOLS=0
normalize_dirs()
{
@@ -106,6 +107,7 @@ normalize_dirs()
please_install()
{
+ HALT_FOR_TOOLS=1
test -r /etc/os-release && . /etc/os-release
case "$ID_LIKE" in
debian) solution="sudo apt-get install $1" ;;
@@ -171,7 +173,7 @@ searchtool()
fi
fi
- [ -z "$3" ] && please_install $1 $4 && exit 1
+ [ -z "$3" ] && please_install $1 $4
false
}
@@ -652,6 +654,10 @@ searchtool clang "LLVM" "" "g++" > /dev/null
searchtool wget > /dev/null
searchtool bzip2 "bzip2," > /dev/null
+if [ "$HALT_FOR_TOOLS" -ne 0 ]; then
+ exit 1
+fi
+
# This initial cleanup is useful when updating the toolchain script.
if [ "$clean" = "1" ]; then
the following patch was just integrated into master:
commit 2e0d9447db22183e2d3393d84e221e8bb1613d45
Author: Paul Menzel <paulepanter(a)users.sourceforge.net>
Date: Sat Jan 25 15:59:31 2014 +0100
src/vendorcode/amd: correct spelling of MTRR
Change-Id: I7576591b42fa62da2b3bd74f961fb297b85e250d
Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
Reviewed-on: https://review.coreboot.org/4806
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
See https://review.coreboot.org/4806 for details.
-gerrit
the following patch was just integrated into master:
commit f8532b16bec1743b0528a215c71f67c8845e2a0c
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Tue Jul 21 14:37:13 2015 -0700
f14: Increase AP stack to 8k on 64bit
This has been broken out from http://review.coreboot.org/#/c/10581/
Change-Id: Ia6153115ff75e21657fa8c244c9eb993d0d63772
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Signed-off-by: Stefan Reinauer <reinauer(a)chromium.org>
Reviewed-on: https://review.coreboot.org/11025
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi(a)google.com>
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/11025 for details.
-gerrit
Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/11025
-gerrit
commit 3344470df408caba97255ac24a5317bab6c2c019
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Tue Jul 21 14:37:13 2015 -0700
f14: Increase AP stack to 8k on 64bit
This has been broken out from http://review.coreboot.org/#/c/10581/
Change-Id: Ia6153115ff75e21657fa8c244c9eb993d0d63772
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Signed-off-by: Stefan Reinauer <reinauer(a)chromium.org>
---
src/vendorcode/amd/agesa/f14/gcccar.inc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/vendorcode/amd/agesa/f14/gcccar.inc b/src/vendorcode/amd/agesa/f14/gcccar.inc
index 2104c27..8f395ce 100644
--- a/src/vendorcode/amd/agesa/f14/gcccar.inc
+++ b/src/vendorcode/amd/agesa/f14/gcccar.inc
@@ -42,7 +42,11 @@ BSP_STACK_SIZE = 0x10000 /* 64KB for BSP core
CORE0_STACK_BASE_ADDR = 0x80000 /* Base address for primary cores stack */
CORE0_STACK_SIZE = 0x4000 /* 16KB for primary cores */
CORE1_STACK_BASE_ADDR = 0x40000 /* Base address for AP cores */
+#ifdef __x86_64__
+CORE1_STACK_SIZE = 0x2000 /* 8KB for each AP cores */
+#else
CORE1_STACK_SIZE = 0x1000 /* 4KB for each AP cores */
+#endif
APIC_BASE_ADDRESS = 0x0000001B
APIC_BSC = 8 /* Boot Strap Core */
the following patch was just integrated into master:
commit 24ca41d074cac0d1274821a250696dc35227821a
Author: Martin Roth <martinroth(a)google.com>
Date: Mon Jan 4 14:07:35 2016 -0700
google/cyan, intel/strago Kconfig: Only ask to display SPD once
Change-Id: Ic3df9bf7d7f3c4c39789f3f496bcb7fc2ee50931
Signed-off-by: Martin Roth <martinroth(a)google.com>
Reviewed-on: https://review.coreboot.org/12827
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi(a)google.com>
See https://review.coreboot.org/12827 for details.
-gerrit
Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12846
-gerrit
commit 9b39b42facb8ff000667fdded76b8a287a1cc715
Author: Martin Roth <martinroth(a)google.com>
Date: Tue Jan 5 16:07:42 2016 -0700
Makefile: Add toolchain version check
This is an initial check for the coreboot toolchain versions. It
currently checks binutils, gcc, clang, and iasl. The other components
are slightly more difficult to test, but should follow on shortly.
This supplies two targets to check the toolchain:
test_toolchain_and_halt - dies if the toolchain is not
the current version that is specified in the tree.
test_toolchain - will print the status of the toolchain, but
will continue to build if called as one of several targets.
For example 'make test_toolchain all' will print the status,
and then build the tree even if a toolchain component is out
of date.
Change-Id: I41daf6c4545c01dc21231d78fd081bbcf77c4726
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
Makefile.inc | 11 +++++++++++
toolchain.inc | 15 +++++++++++++++
2 files changed, 26 insertions(+)
diff --git a/Makefile.inc b/Makefile.inc
index 000ad63..fb7bed9 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -486,6 +486,7 @@ help_toolchain help::
@echo ' crossgcc-clean - Remove all built coreboot cross-compilers'
@echo ' iasl - Build coreboot IASL compiler (built by all cross targets)'
@echo ' clang - Build coreboot clang compiler'
+ @echo ' test_toolchain - Reports if toolchain components are out of date'
@echo ' crossgcc-ARCH - Build cross-compiler for specific architecture'
@echo ' crosstools-ARCH - Build cross-compiler with GDB for specific architecture'
@echo ' ARCH can be "i386", "x64", "arm", "aarch64", "mips", "riscv", or "power8"'
@@ -559,6 +560,16 @@ crossgcc-clean: clean-for-update
tools: $(objutil)/kconfig/conf $(CBFSTOOL) $(FMAPTOOL) $(RMODTOOL) $(objutil)/nvramtool/nvramtool $(ROMCC_BIN) $(objutil)/sconfig/sconfig $(IFDTOOL) $(IFDFAKE) $(CBOOTIMAGE) $(AMDFWTOOL)
+test_toolchain_and_halt test_toolchain:
+ifeq ($(COMPILER_OUT_OF_DATE),1)
+ echo "The coreboot toolchain is not the current version"
+ifneq ($(filter test_toolchain_and_halt,$(MAKECMDGOALS)),)
+$(error )
+endif # ifneq ($(filter crossgcc_check_and_halt,$(MAKECMDGOALS)),)
+else
+ echo "The coreboot tools are the current version"
+endif # ifeq ($(COMPILER_OUT_OF_DATE),1)
+
###########################################################################
# Common recipes for all stages
###########################################################################
diff --git a/toolchain.inc b/toolchain.inc
index f2a6232..609fe44 100644
--- a/toolchain.inc
+++ b/toolchain.inc
@@ -185,3 +185,18 @@ $(error Halting the build)
endif #($(COMPILERFAIL),1)
endif #($(NOCOMPILE),1)
+
+ifneq ($(MAKECMDGOALS),)
+ifneq ($(filter test_toolchain%,$(MAKECMDGOALS)),)
+$(foreach arch, $(ARCH_SUPPORTED), \
+ $(if $(shell if [ -n "$(GCC_CC_$(arch))" ]; then $(GCC_CC_$(arch)) -v 2>&1 | grep -q "$(shell util/crossgcc/buildgcc -s gcc)" || echo not-current; fi), \
+ $(eval COMPILER_OUT_OF_DATE:=1)$(warning The coreboot toolchain version of gcc for '$(arch)' architecture is not the current version.)) \
+ $(if $(shell if [ -n "$(CLANG_CC_$(arch))" ]; then $(CLANG_CC_$(arch)) -v 2>&1 | grep -q "$(shell util/crossgcc/buildgcc -s clang)" || echo not-current; fi), \
+ $(eval COMPILER_OUT_OF_DATE:=1)$(warning The coreboot toolchain version of clang for '$(arch)' architecture is not the current version.)) \
+ $(if $(shell if [ "$(OBJDUMP_$(arch))" != "invalidobjdump" ]; then $(OBJDUMP_$(arch)) -v 2>&1 | grep -q "$(shell util/crossgcc/buildgcc -s binutils)" || echo not-current; fi), \
+ $(eval COMPILER_OUT_OF_DATE:=1)$(warning The coreboot toolchain version of binutils for '$(arch)' architecture is not the current version.)) \
+)
+$(if $(shell if [ -n "$(IASL)" ]; then $(IASL) -v 2>&1 | grep -q "$(shell util/crossgcc/buildgcc -s iasl)" || echo not-coreboot; fi), \
+ $(eval COMPILER_OUT_OF_DATE:=1)$(warning The coreboot toolchain version of iasl is not the current version))
+endif # ifneq ($(filter crossgcc_check%,$(MAKECMDGOALS)),)
+endif # ifneq ($(MAKECMDGOALS),)