Martin Roth (martinroth(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12335
-gerrit
commit 4d51be9681d908b1a3b1966b828c5dc78e4eadf8
Author: Martin Roth <martinroth(a)google.com>
Date: Thu Nov 5 09:00:20 2015 -0700
fsp_model_406dx: use external microcode .h files for rangeley
The microcode for the Rangeley chip is supplied as .h files in the
Rangeley FSP POSTGOLD4 package.
When the rangeley microcode gets put into the blobs directory, this
can be reverted and the binary file put into the makefile.
Change-Id: I30e7436f26a247bc9431f249becfa5fe8c581be7
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
src/cpu/intel/fsp_model_406dx/Kconfig | 18 +++++++-----------
src/cpu/intel/fsp_model_406dx/Makefile.inc | 3 ---
src/cpu/intel/fsp_model_406dx/model_406dx_init.c | 3 ++-
3 files changed, 9 insertions(+), 15 deletions(-)
diff --git a/src/cpu/intel/fsp_model_406dx/Kconfig b/src/cpu/intel/fsp_model_406dx/Kconfig
index c36851d..edf18f5 100644
--- a/src/cpu/intel/fsp_model_406dx/Kconfig
+++ b/src/cpu/intel/fsp_model_406dx/Kconfig
@@ -33,6 +33,9 @@ config CPU_SPECIFIC_OPTIONS
select TSC_SYNC_MFENCE
select LAPIC_MONOTONIC_TIMER
+ # Microcode header files are delivered in FSP package
+ select USES_MICROCODE_HEADER_FILES if HAVE_FSP_BIN
+
choice
prompt "Rangeley CPU Stepping"
default FSP_MODEL_406DX_B0
@@ -53,16 +56,9 @@ config ENABLE_VMX
bool "Enable VMX for virtualization"
default n
-config HAVE_CPU_MICROCODE_FILE
- bool "Add microcode file"
- help
- The microcode binary
-
-config CPU_MICROCODE_FILE
- string "Path and filename of CPU microcode"
- default "microcode.bin"
- depends on HAVE_CPU_MICROCODE_FILE
- help
- The path and filename of the file containing the CPU microcode.
+#set up microcode for rangeley POSTGOLD4 release
+config CPU_MICROCODE_HEADER_FILES
+ string
+ default "../intel/cpu/rangeley/microcode/microcode-m01406d000e.h ../intel/cpu/rangeley/microcode/microcode-m01406d8128.h"
endif #CPU_INTEL_FSP_MODEL_406DX
diff --git a/src/cpu/intel/fsp_model_406dx/Makefile.inc b/src/cpu/intel/fsp_model_406dx/Makefile.inc
index 91c7d96..3e29348 100644
--- a/src/cpu/intel/fsp_model_406dx/Makefile.inc
+++ b/src/cpu/intel/fsp_model_406dx/Makefile.inc
@@ -23,6 +23,3 @@ cpu_microcode_bins += $(call strip_quotes,$(CONFIG_CPU_MICROCODE_FILE))
endif
CPPFLAGS_romstage += -I$(src)/cpu/intel/fsp_model_406dx
-# We don't have microcode for this CPU
-# Use CONFIG_CPU_MICROCODE_CBFS_EXTERNAL with a binary microcode file
-# cpu_microcode_bins += ???
diff --git a/src/cpu/intel/fsp_model_406dx/model_406dx_init.c b/src/cpu/intel/fsp_model_406dx/model_406dx_init.c
index 5482e74..17c46b3 100644
--- a/src/cpu/intel/fsp_model_406dx/model_406dx_init.c
+++ b/src/cpu/intel/fsp_model_406dx/model_406dx_init.c
@@ -170,7 +170,8 @@ static void model_406dx_init(struct device *cpu)
x86_enable_cache();
/* Load microcode */
- intel_update_microcode_from_cbfs();
+ if (IS_ENABLED(CONFIG_SUPPORT_CPU_UCODE_IN_CBFS))
+ intel_update_microcode_from_cbfs();
/* Clear out pending MCEs */
configure_mca();
Ronald G. Minnich (rminnich(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12624
-gerrit
commit 375d75d2015224d44cc756b7163c2360dbc27850
Author: Ronald G. Minnich <rminnich(a)gmail.com>
Date: Wed Dec 2 20:24:15 2015 +0000
add support for power8 to xcompile script
power8 is set up by ibm as a powerpc subset, so we follow
that rule here: we call it a powerpc but require -mcpu=power8
Change-Id: Ib5212be22db9584b0dc0eeed5c06ec1924347067
Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com>
---
util/xcompile/xcompile | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index 76c3698..af4e3f3 100755
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -231,7 +231,7 @@ EOF
}
# Architecture definitions
-SUPPORTED_ARCHITECTURES="arm arm64 mipsel riscv x64 x86"
+SUPPORTED_ARCHITECTURES="arm arm64 mipsel riscv x64 x86 power8"
arch_config_arm() {
TARCH="arm"
@@ -286,6 +286,16 @@ arch_config_mipsel() {
TENDIAN="EL"
}
+arch_config_power8() {
+ TARCH="powerpc"
+ TBFDARCHS="powerpc"
+ TCLIST="powerpc"
+ TWIDTH="64"
+ TSUPP="power8"
+ TABI="elf"
+ CC_RT_EXTRA_GCC="-mcpu=power8"
+}
+
test_architecture() {
local architecture=$1
local endian gccprefix search
Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12463
-gerrit
commit 89e0b7a0299674dee924bd95380c2cbedd265697
Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Date: Wed Nov 18 15:21:34 2015 -0800
Drop abuild.disabled files for Braswell / Skylake boards
Make sure the latest & greatest Intel targets actually
build in our build system.
Change-Id: I479ad473c260fc914d224cb58f4be1837aff2502
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
---
src/mainboard/google/chell/abuild.disabled | 2 --
src/mainboard/google/cyan/abuild.disabled | 2 --
src/mainboard/google/glados/abuild.disabled | 2 --
src/mainboard/google/lars/abuild.disabled | 2 --
src/mainboard/intel/kunimitsu/abuild.disabled | 2 --
src/mainboard/intel/sklrvp/abuild.disabled | 2 --
src/mainboard/intel/strago/abuild.disabled | 2 --
7 files changed, 14 deletions(-)
diff --git a/src/mainboard/google/chell/abuild.disabled b/src/mainboard/google/chell/abuild.disabled
deleted file mode 100644
index 7d1725a..0000000
--- a/src/mainboard/google/chell/abuild.disabled
+++ /dev/null
@@ -1,2 +0,0 @@
-Successful builds for this board require the Skylake FSP binary and header files
-along with the Skylake microcode files from Intel.
diff --git a/src/mainboard/google/cyan/abuild.disabled b/src/mainboard/google/cyan/abuild.disabled
deleted file mode 100644
index 025ebea..0000000
--- a/src/mainboard/google/cyan/abuild.disabled
+++ /dev/null
@@ -1,2 +0,0 @@
-Successful builds for this board require the Braswell FSP binary and header
-files along with the Braswell microcode files from Intel.
diff --git a/src/mainboard/google/glados/abuild.disabled b/src/mainboard/google/glados/abuild.disabled
deleted file mode 100644
index 7d1725a..0000000
--- a/src/mainboard/google/glados/abuild.disabled
+++ /dev/null
@@ -1,2 +0,0 @@
-Successful builds for this board require the Skylake FSP binary and header files
-along with the Skylake microcode files from Intel.
diff --git a/src/mainboard/google/lars/abuild.disabled b/src/mainboard/google/lars/abuild.disabled
deleted file mode 100644
index 7d1725a..0000000
--- a/src/mainboard/google/lars/abuild.disabled
+++ /dev/null
@@ -1,2 +0,0 @@
-Successful builds for this board require the Skylake FSP binary and header files
-along with the Skylake microcode files from Intel.
diff --git a/src/mainboard/intel/kunimitsu/abuild.disabled b/src/mainboard/intel/kunimitsu/abuild.disabled
deleted file mode 100644
index 7d1725a..0000000
--- a/src/mainboard/intel/kunimitsu/abuild.disabled
+++ /dev/null
@@ -1,2 +0,0 @@
-Successful builds for this board require the Skylake FSP binary and header files
-along with the Skylake microcode files from Intel.
diff --git a/src/mainboard/intel/sklrvp/abuild.disabled b/src/mainboard/intel/sklrvp/abuild.disabled
deleted file mode 100644
index 7d1725a..0000000
--- a/src/mainboard/intel/sklrvp/abuild.disabled
+++ /dev/null
@@ -1,2 +0,0 @@
-Successful builds for this board require the Skylake FSP binary and header files
-along with the Skylake microcode files from Intel.
diff --git a/src/mainboard/intel/strago/abuild.disabled b/src/mainboard/intel/strago/abuild.disabled
deleted file mode 100644
index 025ebea..0000000
--- a/src/mainboard/intel/strago/abuild.disabled
+++ /dev/null
@@ -1,2 +0,0 @@
-Successful builds for this board require the Braswell FSP binary and header
-files along with the Braswell microcode files from Intel.
the following patch was just integrated into master:
commit 16c7e0f56c1d76bfca7b46306a0ceddc8ea7842e
Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Date: Tue Dec 1 17:58:58 2015 -0800
cbfstool: Fix checkpatch error
ERROR: code indent should use tabs where possible
+^I trampoline_len);$
Change-Id: If46f977e2e07d73e6cfd3038912a172236a7e571
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Reviewed-on: https://review.coreboot.org/12620
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/12620 for details.
-gerrit
the following patch was just integrated into master:
commit 5dda4df4246ff4b4fe4e84311c6fc7b723ad7efb
Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Date: Tue Dec 1 17:58:08 2015 -0800
cbfstool: remove trampoline_start and trampoline_size
It's not needed, so we can remove some extra file mangling, too.
Change-Id: I80d707708e70c07a29653258b4cb6e9cd88d3de3
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Reviewed-on: https://review.coreboot.org/12508
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/12508 for details.
-gerrit
the following patch was just integrated into master:
commit 0316e1a69fa5d60f70afca00686d4b18a04e6dd2
Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Date: Fri Nov 20 17:58:59 2015 +0100
cbfstool: autocreate trampoline
Add the code necessary to create the linux trampoline blob.
Don't enforce this for the in-coreboot build or use objcopy
to produce linux_trampoline.o as it is a bit trickier to get
all the details right than I had hoped:
- you have to know the elf architecture of the host machine
- you might have to have more tools (xxd, perl, etc) installed
Change-Id: I9b7877c58d90f9fb21d16e0061a31e19fffa2470
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Reviewed-on: https://review.coreboot.org/12505
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/12505 for details.
-gerrit
the following patch was just integrated into master:
commit cbce4de97644e810251358fb212615a5b5244d42
Author: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Date: Wed Nov 18 15:28:19 2015 -0800
drivers/intel/fsp1_1: Don't hide build related options behind HAVE_FSP_BIN
The right thing to do is to hide them behind PLATFORM_USES_FSP1_1.
The only things that should depend on HAVE_FSP_BIN is the code
that actually adds the file to CBFS, and the path to the file in Kconfig.
Removing the HAVE_FSP_BIN check requires some default values
for two Kconfig variables.
Change-Id: I9b6c3ed0cdfb0e02421d7b98c488a66e39add947
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Reviewed-on: https://review.coreboot.org/12465
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/12465 for details.
-gerrit
Michael Tasche (michael.tasche(a)esd.eu) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12622
-gerrit
commit 079d8ea1f17ccd5921da5027e12afdf0ef656a88
Author: Michael Tasche <michael.tasche(a)esd.eu>
Date: Wed Dec 2 17:34:47 2015 +0100
intel/minnowmax: Fix IRQ connection for legacy uart at 0x3f8
The E38xx legacy uart fires IRQ4, not IRQ3.
PCI based IRQ A is switched from IRQ4 to IRQ3,
to get a working IRQ for the legacy uart.
Change-Id: Ibc8e824c92bf1b9a92594ddc5d8a06726c9f1744
Signed-off-by: Michael Tasche <michael.tasche(a)esd.eu>
---
src/mainboard/intel/minnowmax/irqroute.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mainboard/intel/minnowmax/irqroute.h b/src/mainboard/intel/minnowmax/irqroute.h
index bdf3d94..f866069 100644
--- a/src/mainboard/intel/minnowmax/irqroute.h
+++ b/src/mainboard/intel/minnowmax/irqroute.h
@@ -70,7 +70,7 @@
* Floppy: 6
*/
#define PIRQ_PIC_ROUTES \
- PIRQ_PIC(A, 4), \
+ PIRQ_PIC(A, 3), \
PIRQ_PIC(B, 5), \
PIRQ_PIC(C, 7), \
PIRQ_PIC(D, 10), \