coreboot-gerrit November 2015

coreboot-gerrit@coreboot.org

1 participants
1544 discussions

Patch set updated for coreboot: cbfstool: Comparing enum causes error when cc=clang
by Zheng Bao 05 Nov '15

05 Nov '15

Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12330 -gerrit commit 33fb34b209151864ef3848922ecd6cf34c167576 Author: zbao <fishbaozi(a)gmail.com> Date: Thu Nov 5 14:35:57 2015 +0800 cbfstool: Comparing enum causes error when cc=clang If HOSTCC=clang, the -Wtautological-constant-out-of-range-compare is set automaticaaly. That assume the value of type enum is in the defined range. Then testing if a type enum is out of range causes build error. Error: coreboot/util/cbfstool/cbfs_image.c:1387:16: error: comparison of constant 4 with expression of type 'enum vb2_hash_algorithm' is always false [-Werror,-Wtautological-constant-out-of-range-compare] if (hash_type >= CBFS_NUM_SUPPORTED_HASHES) ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. clang version: FreeBSD clang version 3.4.1 (tags/RELEASE_34/dot1-final 208032) 20140512 Target: x86_64-unknown-freebsd10.2 Thread model: posix Change-Id: I3e1722bf6f9553793a9f0c7f4e790706b6938522 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- util/cbfstool/cbfs_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index f5ef680..1ff88eb 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -1384,7 +1384,7 @@ struct cbfs_file_attribute *cbfs_add_file_attr(struct cbfs_file *header, int cbfs_add_file_hash(struct cbfs_file *header, struct buffer *buffer, enum vb2_hash_algorithm hash_type) { - if (hash_type >= CBFS_NUM_SUPPORTED_HASHES) + if ((uint32_t)hash_type >= (uint32_t)CBFS_NUM_SUPPORTED_HASHES) return -1; unsigned hash_size = widths_cbfs_hash[hash_type];

1 0

New patch to review for coreboot: Makefile: Set HOSTCC as gcc or cc respectively
by Zheng Bao 05 Nov '15

05 Nov '15

Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12331 -gerrit commit 2094edcbcc387fef5991cdf660943bbbaa0cd08b Author: zbao <fishbaozi(a)gmail.com> Date: Thu Nov 5 15:33:33 2015 +0800 Makefile: Set HOSTCC as gcc or cc respectively The HOSTCC should be set in .xcompile, which tests the existence of gcc and cc. But the .xcompile has to be included after kconfig/Makefile. So building util/kconfig uses the seperated HOSTCC definition above it, instead of the one in .xcompile. For the system which clang is the default host compiler, gcc is not installed by default. In that case, we need to set HOSTCC as cc. Change-Id: I1e51a37c4426e2c97d36a31f26a18ab4b0d0608d Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 421e919..d108654 100644 --- a/Makefile +++ b/Makefile @@ -79,7 +79,7 @@ endif # Disable implicit/built-in rules to make Makefile errors fail fast. .SUFFIXES: -HOSTCC := gcc +HOSTCC := $(if $(shell type gcc 2>/dev/null), gcc, cc) HOSTCXX = g++ HOSTCFLAGS := -g HOSTCXXFLAGS := -g

1 0

New patch to review for coreboot: cbfstool: clang build error when comparing enum
by Zheng Bao 05 Nov '15

05 Nov '15

Zheng Bao (zheng.bao(a)amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12330 -gerrit commit 5a1d9695766528a6dcf92978a683575cb33a24e1 Author: zbao <fishbaozi(a)gmail.com> Date: Thu Nov 5 14:35:57 2015 +0800 cbfstool: clang build error when comparing enum If HOSTCC=clang, the -Wtautological-constant-out-of-range-compare is set automaticaaly. That assume the value of type enum is in the defined range. Then testing if a type enum is out of range causes build error. Error: coreboot/util/cbfstool/cbfs_image.c:1387:16: error: comparison of constant 4 with expression of type 'enum vb2_hash_algorithm' is always false [-Werror,-Wtautological-constant-out-of-range-compare] if (hash_type >= CBFS_NUM_SUPPORTED_HASHES) ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. clang version: FreeBSD clang version 3.4.1 (tags/RELEASE_34/dot1-final 208032) 20140512 Target: x86_64-unknown-freebsd10.2 Thread model: posix Change-Id: I3e1722bf6f9553793a9f0c7f4e790706b6938522 Signed-off-by: zbao <fishbaozi(a)gmail.com> --- util/cbfstool/cbfs_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index f5ef680..1ff88eb 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -1384,7 +1384,7 @@ struct cbfs_file_attribute *cbfs_add_file_attr(struct cbfs_file *header, int cbfs_add_file_hash(struct cbfs_file *header, struct buffer *buffer, enum vb2_hash_algorithm hash_type) { - if (hash_type >= CBFS_NUM_SUPPORTED_HASHES) + if ((uint32_t)hash_type >= (uint32_t)CBFS_NUM_SUPPORTED_HASHES) return -1; unsigned hash_size = widths_cbfs_hash[hash_type];

1 0

Patch merged into coreboot/master: cpu/microcode: Remove EXTERNAL / ADDED_DURING_BUILD variables
by gerrit＠coreboot.org 05 Nov '15

05 Nov '15

the following patch was just integrated into master: commit 855fc1fcdbf1e40931d31f25ca7091a7b0aeace5 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Wed Oct 14 15:41:49 2015 -0500 cpu/microcode: Remove EXTERNAL / ADDED_DURING_BUILD variables There has been a concerted effort to clean up coreboot's microcode handling that has included a move away from coreboot-specific microcode file collections. As a result, the ability to specify a single microcode file to be added to the image is of less utility than before. NOTE: This patch remove the built-in external microcode feature, however the user can still specify no microcode during build and manually add the correct microcode file(s) to the CBFS image after the build is complete. Change-Id: Ifea94c21e531a74953f5a0e2f489378c20ef3b5c Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/11903 Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/11903 for details. -gerrit

1 0

Patch merged into coreboot/master: mainboard: Remove last_boot NVRAM option
by gerrit＠coreboot.org 05 Nov '15

05 Nov '15

the following patch was just integrated into master: commit 24391321e8afe74063b1c4216732b66ad6d1ed36 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Tue Nov 3 17:02:25 2015 -0600 mainboard: Remove last_boot NVRAM option The last_boot NVRAM option was deprecated and removed in commit 3bfd7cc6. Remove the last_boot option from all affected mainboards to eliminate user confusion. Change-Id: I7e201b9cf21dfe5dda156785bad078524098626d Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/12316 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) See http://review.coreboot.org/12316 for details. -gerrit

1 0

Patch merged into coreboot/master: src/amd: Increase maximum blootblock execution count
by gerrit＠coreboot.org 05 Nov '15

05 Nov '15

the following patch was just integrated into master: commit 5a1f3370ea61ef13e7f5ef703e39ed8a71f69700 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Tue Nov 3 19:02:26 2015 -0600 src/amd: Increase maximum blootblock execution count Most AMD hardware requires at minimum two warm resets when booting from S5 (power off). This is uncomfortably close to the maximum bootblock execution count, and has resulted in unstable normal/fallback operation on some machines. Increase the default max bootblock execution count before fallback to 6. This translates to roughly 2 - 3 failed boots before fallback mode will engage, with an absolute worst case of pushing the reset button 5 times to engage fallback mode in the absence of a dedicated recovery jumper. Change-Id: I1911f1b77f168835b516e6a915d5b6949f47219a Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/12317 Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/12317 for details. -gerrit

1 0

Patch set updated for coreboot: kconfig: Some terms or curses libraries treat backspace as 0x08
by Stefan Reinauer 05 Nov '15

05 Nov '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11725 -gerrit commit a4933c7136ae94eca1314481fea7962f4d98f8aa Author: zbao <fishbaozi(a)gmail.com> Date: Sat Sep 26 06:24:09 2015 -0400 kconfig: Some terms or curses libraries treat backspace as 0x08 Change-Id: I8e4ea493afa88019fd299651af1df2fb992ab97b Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- util/kconfig/lxdialog/inputbox.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/kconfig/lxdialog/inputbox.c b/util/kconfig/lxdialog/inputbox.c index d58de1d..2ec124e 100644 --- a/util/kconfig/lxdialog/inputbox.c +++ b/util/kconfig/lxdialog/inputbox.c @@ -127,6 +127,7 @@ do_resize: break; case KEY_BACKSPACE: case 127: + case '\b': if (pos) { wattrset(dialog, dlg.inputbox.atr); if (input_x == 0) {

1 0

Patch set updated for coreboot: util/kconfig: Remove utsname for mingw
by Stefan Reinauer 05 Nov '15

05 Nov '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11724 -gerrit commit 06b4d233e4ee8fb43b148b7915093009d8b24953 Author: zbao <fishbaozi(a)gmail.com> Date: Sat Sep 26 06:22:11 2015 -0400 util/kconfig: Remove utsname for mingw Change-Id: I640ea61ff24fba812e3f10771dd7e468dcfc63dd Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- util/kconfig/symbol.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/util/kconfig/symbol.c b/util/kconfig/symbol.c index 65ba465..99dc0db 100644 --- a/util/kconfig/symbol.c +++ b/util/kconfig/symbol.c @@ -7,7 +7,9 @@ #include <stdlib.h> #include <string.h> #include <regex.h> +#ifndef __MINGW32__ #include <sys/utsname.h> +#endif #include "lkc.h" @@ -45,19 +47,27 @@ static void sym_add_default(struct symbol *sym, const char *def) void sym_init(void) { struct symbol *sym; +#ifndef __MINGW32__ struct utsname uts; +#endif static bool inited = false; if (inited) return; inited = true; +#ifndef __MINGW32__ uname(&uts); +#endif sym = sym_lookup("UNAME_RELEASE", 0); sym->type = S_STRING; sym->flags |= SYMBOL_AUTO; +#ifndef __MINGW32__ sym_add_default(sym, uts.release); +#else + sym_add_default(sym, "mingw-unknow"); +#endif } enum symbol_type sym_get_type(struct symbol *sym)

1 0

Patch set updated for coreboot: util/kconfig: Set parameter of mkdir to only one for mingw.
by Stefan Reinauer 05 Nov '15

05 Nov '15

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11723 -gerrit commit b8f5457aefd6401df0d3feaec9caf01a8858bbd6 Author: zbao <fishbaozi(a)gmail.com> Date: Sat Sep 26 06:20:53 2015 -0400 util/kconfig: Set parameter of mkdir to only one for mingw. Change-Id: I88e317f075e8a39f0a280b3dd6e597d119f0f741 Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- util/kconfig/confdata.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/util/kconfig/confdata.c b/util/kconfig/confdata.c index a39a716..e582463 100644 --- a/util/kconfig/confdata.c +++ b/util/kconfig/confdata.c @@ -27,6 +27,10 @@ static int conf_lineno, conf_warnings, conf_unsaved; const char conf_defname[] = "arch/$ARCH/defconfig"; +#ifdef __MINGW32__ +#define mkdir(_n,_p) mkdir((_n)) +#endif + static void conf_warning(const char *fmt, ...) { va_list ap;

1 0

Patch merged into coreboot/master: util/kconfig: fill glob_t with 0 before calling glob
by gerrit＠coreboot.org 05 Nov '15

05 Nov '15

the following patch was just integrated into master: commit 91ba80dd798ba09a06282196bcd0bc5e40ec4504 Author: zbao <fishbaozi(a)gmail.com> Date: Sat Sep 26 06:49:47 2015 -0400 util/kconfig: fill glob_t with 0 before calling glob On mingw, the function glob has some default options which are not compliant with man page. If gl_offs is not set as 0, there may be some slots which is reserved. If gl_pathc or gl_pathv is not set as 0, the result might be appended to the list instead of being added as new ones. Change-Id: I03110c4cdda70578828d6499262a085a81d26313 Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> Reviewed-on: http://review.coreboot.org/11711 Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/11711 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2015