coreboot-gerrit July 2014

coreboot-gerrit@coreboot.org

1 participants
861 discussions

New patch to review for coreboot: fc09790 superio: Trivial - drop trailing blank lines at EOF
by Edward O'Callaghan 07 Jul '14

07 Jul '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6202 -gerrit commit fc0979095c70a1f98efc8624f4795577b9a8b220 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Jul 7 23:45:39 2014 +1000 superio: Trivial - drop trailing blank lines at EOF Change-Id: I8633d331d095fe9506a8f01969060ba9889c8eac Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/superio/smsc/mec1308/mec1308.h | 1 - src/superio/smsc/mec1308/superio.c | 1 - src/superio/smsc/sch4037/sch4037_early_init.c | 1 - src/superio/smsc/sio1036/sio1036.h | 1 - src/superio/smsc/sio1036/sio1036_early_init.c | 1 - src/superio/smsc/sio1036/superio.c | 1 - src/superio/smsc/sio10n268/sio10n268.c | 1 - 7 files changed, 7 deletions(-) diff --git a/src/superio/smsc/mec1308/mec1308.h b/src/superio/smsc/mec1308/mec1308.h index 0b0a0a1..a242153 100644 --- a/src/superio/smsc/mec1308/mec1308.h +++ b/src/superio/smsc/mec1308/mec1308.h @@ -24,4 +24,3 @@ #define MEC1308_KBC 7 #define MEC1308_EC0 8 #define MEC1308_MBX 9 - diff --git a/src/superio/smsc/mec1308/superio.c b/src/superio/smsc/mec1308/superio.c index 9e293bd..bc20ed5 100644 --- a/src/superio/smsc/mec1308/superio.c +++ b/src/superio/smsc/mec1308/superio.c @@ -72,4 +72,3 @@ struct chip_operations superio_smsc_mec1308_ops = { CHIP_NAME("SMSC MEC1308 EC SuperIO Interface") .enable_dev = enable_dev }; - diff --git a/src/superio/smsc/sch4037/sch4037_early_init.c b/src/superio/smsc/sch4037/sch4037_early_init.c index dfacd24..29517ed 100644 --- a/src/superio/smsc/sch4037/sch4037_early_init.c +++ b/src/superio/smsc/sch4037/sch4037_early_init.c @@ -66,4 +66,3 @@ static inline void sch4037_early_init(unsigned port) pnp_exit_conf_state(dev); } - diff --git a/src/superio/smsc/sio1036/sio1036.h b/src/superio/smsc/sio1036/sio1036.h index e30cd76..a926ca4 100644 --- a/src/superio/smsc/sio1036/sio1036.h +++ b/src/superio/smsc/sio1036/sio1036.h @@ -22,4 +22,3 @@ #define UART_POWER_DOWN (1 << 7) #define LPT_POWER_DOWN (1 << 2) #define IR_OUPUT_MUX (1 << 6) - diff --git a/src/superio/smsc/sio1036/sio1036_early_init.c b/src/superio/smsc/sio1036/sio1036_early_init.c index 314ea75..52232a5 100644 --- a/src/superio/smsc/sio1036/sio1036_early_init.c +++ b/src/superio/smsc/sio1036/sio1036_early_init.c @@ -98,4 +98,3 @@ static inline void sio1036_early_init(unsigned port) sio1036_exit_conf_state(dev); } - diff --git a/src/superio/smsc/sio1036/superio.c b/src/superio/smsc/sio1036/superio.c index 7fac79c..d2bfd8d 100644 --- a/src/superio/smsc/sio1036/superio.c +++ b/src/superio/smsc/sio1036/superio.c @@ -73,4 +73,3 @@ static void sio1036_init(device_t dev) break; } } - diff --git a/src/superio/smsc/sio10n268/sio10n268.c b/src/superio/smsc/sio10n268/sio10n268.c index f69e3bf..fab7c41 100644 --- a/src/superio/smsc/sio10n268/sio10n268.c +++ b/src/superio/smsc/sio10n268/sio10n268.c @@ -64,4 +64,3 @@ struct chip_operations superio_smsc_sio10n268_ops = { CHIP_NAME("SMSC SIO10N268 Super I/O") .enable_dev = enable_dev, }; -

1 0

New patch to review for coreboot: a11ca48 mainboard: Trivial - drop trailing blank lines at EOF in .h
by Edward O'Callaghan 07 Jul '14

07 Jul '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6201 -gerrit commit a11ca48a04fa8a1567a1843145d205d12d6d7c23 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Jul 7 23:44:40 2014 +1000 mainboard: Trivial - drop trailing blank lines at EOF in .h Change-Id: I4a4ee99468e5f1dae8412ae565a34290493db726 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/amd/mahogany_fam10/mb_sysconf.h | 1 - src/mainboard/amd/serengeti_cheetah/mb_sysconf.h | 1 - src/mainboard/amd/serengeti_cheetah_fam10/mb_sysconf.h | 1 - src/mainboard/amd/tilapia_fam10/mb_sysconf.h | 1 - src/mainboard/amd/torpedo/Oem.h | 1 - src/mainboard/asus/m2n-e/hda_verb.h | 1 - src/mainboard/asus/m4a78-em/mb_sysconf.h | 1 - src/mainboard/asus/m4a785-m/mb_sysconf.h | 1 - src/mainboard/getac/p470/ec_oem.h | 1 - src/mainboard/getac/p470/hda_verb.h | 1 - src/mainboard/gigabyte/ma785gm/mb_sysconf.h | 1 - src/mainboard/google/bolt/hda_verb.h | 1 - src/mainboard/google/butterfly/hda_verb.h | 2 -- src/mainboard/google/falco/hda_verb.h | 1 - src/mainboard/google/link/i915io.h | 1 - src/mainboard/google/peppy/hda_verb.h | 1 - src/mainboard/google/slippy/hda_verb.h | 1 - src/mainboard/google/snow/exynos5250.h | 1 - src/mainboard/hp/dl145_g1/mb_sysconf.h | 1 - src/mainboard/hp/dl145_g3/mb_sysconf.h | 1 - src/mainboard/hp/dl165_g6_fam10/mb_sysconf.h | 1 - src/mainboard/iei/kino-780am2-fam10/mb_sysconf.h | 1 - src/mainboard/intel/baskingridge/hda_verb.h | 1 - src/mainboard/intel/cougar_canyon2/hda_verb.h | 1 - src/mainboard/intel/emeraldlake2/hda_verb.h | 1 - src/mainboard/intel/wtm2/hda_verb.h | 1 - src/mainboard/iwill/dk8_htx/mb_sysconf.h | 1 - src/mainboard/lenovo/t520/hda_verb.h | 2 -- src/mainboard/lenovo/t530/hda_verb.h | 2 -- src/mainboard/lenovo/x230/hda_verb.h | 2 -- src/mainboard/msi/ms9185/mb_sysconf.h | 1 - src/mainboard/msi/ms9282/mb_sysconf.h | 1 - src/mainboard/msi/ms9652_fam10/mb_sysconf.h | 1 - src/mainboard/nvidia/l1_2pvv/hda_verb.h | 1 - src/mainboard/nvidia/l1_2pvv/mb_sysconf.h | 1 - src/mainboard/supermicro/h8dmr_fam10/mb_sysconf.h | 1 - src/mainboard/supermicro/h8qme_fam10/mb_sysconf.h | 1 - src/mainboard/supermicro/h8scm_fam10/mb_sysconf.h | 1 - src/mainboard/tyan/s2912/mb_sysconf.h | 1 - src/mainboard/tyan/s2912_fam10/mb_sysconf.h | 1 - 40 files changed, 44 deletions(-) diff --git a/src/mainboard/amd/mahogany_fam10/mb_sysconf.h b/src/mainboard/amd/mahogany_fam10/mb_sysconf.h index 6921d75..768ffd1 100644 --- a/src/mainboard/amd/mahogany_fam10/mb_sysconf.h +++ b/src/mainboard/amd/mahogany_fam10/mb_sysconf.h @@ -42,4 +42,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/amd/serengeti_cheetah/mb_sysconf.h b/src/mainboard/amd/serengeti_cheetah/mb_sysconf.h index 3042dd0..ef3dace 100644 --- a/src/mainboard/amd/serengeti_cheetah/mb_sysconf.h +++ b/src/mainboard/amd/serengeti_cheetah/mb_sysconf.h @@ -25,4 +25,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/mb_sysconf.h b/src/mainboard/amd/serengeti_cheetah_fam10/mb_sysconf.h index 31f959a..4fb3f18 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/mb_sysconf.h +++ b/src/mainboard/amd/serengeti_cheetah_fam10/mb_sysconf.h @@ -40,4 +40,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/amd/tilapia_fam10/mb_sysconf.h b/src/mainboard/amd/tilapia_fam10/mb_sysconf.h index 6921d75..768ffd1 100644 --- a/src/mainboard/amd/tilapia_fam10/mb_sysconf.h +++ b/src/mainboard/amd/tilapia_fam10/mb_sysconf.h @@ -42,4 +42,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/amd/torpedo/Oem.h b/src/mainboard/amd/torpedo/Oem.h index 1812921..915182e 100644 --- a/src/mainboard/amd/torpedo/Oem.h +++ b/src/mainboard/amd/torpedo/Oem.h @@ -221,4 +221,3 @@ * */ #define PCIB_SSID 0x780F1022 - diff --git a/src/mainboard/asus/m2n-e/hda_verb.h b/src/mainboard/asus/m2n-e/hda_verb.h index 2f4f434..ec288ba 100644 --- a/src/mainboard/asus/m2n-e/hda_verb.h +++ b/src/mainboard/asus/m2n-e/hda_verb.h @@ -120,4 +120,3 @@ static const u32 mainboard_cim_verb_data[] = { extern const u32 *cim_verb_data; extern u32 cim_verb_data_size; - diff --git a/src/mainboard/asus/m4a78-em/mb_sysconf.h b/src/mainboard/asus/m4a78-em/mb_sysconf.h index 6921d75..768ffd1 100644 --- a/src/mainboard/asus/m4a78-em/mb_sysconf.h +++ b/src/mainboard/asus/m4a78-em/mb_sysconf.h @@ -42,4 +42,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/asus/m4a785-m/mb_sysconf.h b/src/mainboard/asus/m4a785-m/mb_sysconf.h index 6921d75..768ffd1 100644 --- a/src/mainboard/asus/m4a785-m/mb_sysconf.h +++ b/src/mainboard/asus/m4a785-m/mb_sysconf.h @@ -42,4 +42,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/getac/p470/ec_oem.h b/src/mainboard/getac/p470/ec_oem.h index 14f7484..d48aa3d 100644 --- a/src/mainboard/getac/p470/ec_oem.h +++ b/src/mainboard/getac/p470/ec_oem.h @@ -50,4 +50,3 @@ int ec_oem_write(u8 addr, u8 data); int ec_dump_status(void); int ec_oem_dump_status(void); #endif - diff --git a/src/mainboard/getac/p470/hda_verb.h b/src/mainboard/getac/p470/hda_verb.h index 98a77c6..b7578cc 100644 --- a/src/mainboard/getac/p470/hda_verb.h +++ b/src/mainboard/getac/p470/hda_verb.h @@ -106,4 +106,3 @@ static const u32 mainboard_cim_verb_data[] = { extern const u32 *cim_verb_data; extern u32 cim_verb_data_size; - diff --git a/src/mainboard/gigabyte/ma785gm/mb_sysconf.h b/src/mainboard/gigabyte/ma785gm/mb_sysconf.h index 6921d75..768ffd1 100644 --- a/src/mainboard/gigabyte/ma785gm/mb_sysconf.h +++ b/src/mainboard/gigabyte/ma785gm/mb_sysconf.h @@ -42,4 +42,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/google/bolt/hda_verb.h b/src/mainboard/google/bolt/hda_verb.h index 958b6c2..f27480d 100644 --- a/src/mainboard/google/bolt/hda_verb.h +++ b/src/mainboard/google/bolt/hda_verb.h @@ -92,4 +92,3 @@ static const u32 mainboard_cim_verb_data[] = { 0x02171f03, // connector, left panel }; - diff --git a/src/mainboard/google/butterfly/hda_verb.h b/src/mainboard/google/butterfly/hda_verb.h index 1901a68..6455de6 100644 --- a/src/mainboard/google/butterfly/hda_verb.h +++ b/src/mainboard/google/butterfly/hda_verb.h @@ -262,5 +262,3 @@ static const u32 mainboard_pc_beep_verbs[] = { static const u32 mainboard_pc_beep_verbs_size = sizeof(mainboard_pc_beep_verbs) / sizeof(mainboard_pc_beep_verbs[0]); - - diff --git a/src/mainboard/google/falco/hda_verb.h b/src/mainboard/google/falco/hda_verb.h index 958b6c2..f27480d 100644 --- a/src/mainboard/google/falco/hda_verb.h +++ b/src/mainboard/google/falco/hda_verb.h @@ -92,4 +92,3 @@ static const u32 mainboard_cim_verb_data[] = { 0x02171f03, // connector, left panel }; - diff --git a/src/mainboard/google/link/i915io.h b/src/mainboard/google/link/i915io.h index dd97fff..6533c81 100644 --- a/src/mainboard/google/link/i915io.h +++ b/src/mainboard/google/link/i915io.h @@ -84,4 +84,3 @@ u32 pack_aux(u32 *src, int src_bytes); void unpack_aux(u32 src, u32 *dst, int dst_bytes); int intel_dp_aux_ch(u32 ch_ctl, u32 ch_data, u32 *send, int send_bytes, u32 *recv, int recv_size); - diff --git a/src/mainboard/google/peppy/hda_verb.h b/src/mainboard/google/peppy/hda_verb.h index 3f45790..d3a63bf 100644 --- a/src/mainboard/google/peppy/hda_verb.h +++ b/src/mainboard/google/peppy/hda_verb.h @@ -97,4 +97,3 @@ static const u32 mainboard_cim_verb_data[] = { 0x02171f03, // connector, left panel }; - diff --git a/src/mainboard/google/slippy/hda_verb.h b/src/mainboard/google/slippy/hda_verb.h index 958b6c2..f27480d 100644 --- a/src/mainboard/google/slippy/hda_verb.h +++ b/src/mainboard/google/slippy/hda_verb.h @@ -92,4 +92,3 @@ static const u32 mainboard_cim_verb_data[] = { 0x02171f03, // connector, left panel }; - diff --git a/src/mainboard/google/snow/exynos5250.h b/src/mainboard/google/snow/exynos5250.h index 98d36f9..0f71a36 100644 --- a/src/mainboard/google/snow/exynos5250.h +++ b/src/mainboard/google/snow/exynos5250.h @@ -30,4 +30,3 @@ #define VDD_LDO3_MV 1800 // 1.8V #define VDD_LDO5_MV 1800 // 1.8V #define VDD_LDO10_MV 1800 // 1.8V - diff --git a/src/mainboard/hp/dl145_g1/mb_sysconf.h b/src/mainboard/hp/dl145_g1/mb_sysconf.h index 9d373b3..3dfd5de 100644 --- a/src/mainboard/hp/dl145_g1/mb_sysconf.h +++ b/src/mainboard/hp/dl145_g1/mb_sysconf.h @@ -21,4 +21,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/hp/dl145_g3/mb_sysconf.h b/src/mainboard/hp/dl145_g3/mb_sysconf.h index 2c579fa..733258a 100644 --- a/src/mainboard/hp/dl145_g3/mb_sysconf.h +++ b/src/mainboard/hp/dl145_g3/mb_sysconf.h @@ -39,4 +39,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/hp/dl165_g6_fam10/mb_sysconf.h b/src/mainboard/hp/dl165_g6_fam10/mb_sysconf.h index 2c579fa..733258a 100644 --- a/src/mainboard/hp/dl165_g6_fam10/mb_sysconf.h +++ b/src/mainboard/hp/dl165_g6_fam10/mb_sysconf.h @@ -39,4 +39,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/iei/kino-780am2-fam10/mb_sysconf.h b/src/mainboard/iei/kino-780am2-fam10/mb_sysconf.h index 6921d75..768ffd1 100644 --- a/src/mainboard/iei/kino-780am2-fam10/mb_sysconf.h +++ b/src/mainboard/iei/kino-780am2-fam10/mb_sysconf.h @@ -42,4 +42,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/intel/baskingridge/hda_verb.h b/src/mainboard/intel/baskingridge/hda_verb.h index 9a4a740..52e5a3d 100644 --- a/src/mainboard/intel/baskingridge/hda_verb.h +++ b/src/mainboard/intel/baskingridge/hda_verb.h @@ -96,4 +96,3 @@ static const u32 mainboard_cim_verb_data[] = { 0x30771e56, 0x30771f18 }; - diff --git a/src/mainboard/intel/cougar_canyon2/hda_verb.h b/src/mainboard/intel/cougar_canyon2/hda_verb.h index e2dd843..f8e83b4 100644 --- a/src/mainboard/intel/cougar_canyon2/hda_verb.h +++ b/src/mainboard/intel/cougar_canyon2/hda_verb.h @@ -47,4 +47,3 @@ static const u32 mainboard_cim_verb_data[] = { 0x30771e56, 0x30771f18 }; - diff --git a/src/mainboard/intel/emeraldlake2/hda_verb.h b/src/mainboard/intel/emeraldlake2/hda_verb.h index 9a4a740..52e5a3d 100644 --- a/src/mainboard/intel/emeraldlake2/hda_verb.h +++ b/src/mainboard/intel/emeraldlake2/hda_verb.h @@ -96,4 +96,3 @@ static const u32 mainboard_cim_verb_data[] = { 0x30771e56, 0x30771f18 }; - diff --git a/src/mainboard/intel/wtm2/hda_verb.h b/src/mainboard/intel/wtm2/hda_verb.h index c34d0f5..cb33add 100644 --- a/src/mainboard/intel/wtm2/hda_verb.h +++ b/src/mainboard/intel/wtm2/hda_verb.h @@ -96,4 +96,3 @@ static const u32 mainboard_cim_verb_data[] = { 0x30771e56, 0x30771f18 }; - diff --git a/src/mainboard/iwill/dk8_htx/mb_sysconf.h b/src/mainboard/iwill/dk8_htx/mb_sysconf.h index 3042dd0..ef3dace 100644 --- a/src/mainboard/iwill/dk8_htx/mb_sysconf.h +++ b/src/mainboard/iwill/dk8_htx/mb_sysconf.h @@ -25,4 +25,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/lenovo/t520/hda_verb.h b/src/mainboard/lenovo/t520/hda_verb.h index 7999932..7d5e75a 100644 --- a/src/mainboard/lenovo/t520/hda_verb.h +++ b/src/mainboard/lenovo/t520/hda_verb.h @@ -313,5 +313,3 @@ static const u32 mainboard_pc_beep_verbs[] = { static const u32 mainboard_pc_beep_verbs_size = ARRAY_SIZE(mainboard_pc_beep_verbs); - - diff --git a/src/mainboard/lenovo/t530/hda_verb.h b/src/mainboard/lenovo/t530/hda_verb.h index a319c28..e5b14f9 100644 --- a/src/mainboard/lenovo/t530/hda_verb.h +++ b/src/mainboard/lenovo/t530/hda_verb.h @@ -313,5 +313,3 @@ static const u32 mainboard_pc_beep_verbs[] = { static const u32 mainboard_pc_beep_verbs_size = sizeof(mainboard_pc_beep_verbs) / sizeof(mainboard_pc_beep_verbs[0]); - - diff --git a/src/mainboard/lenovo/x230/hda_verb.h b/src/mainboard/lenovo/x230/hda_verb.h index a319c28..e5b14f9 100644 --- a/src/mainboard/lenovo/x230/hda_verb.h +++ b/src/mainboard/lenovo/x230/hda_verb.h @@ -313,5 +313,3 @@ static const u32 mainboard_pc_beep_verbs[] = { static const u32 mainboard_pc_beep_verbs_size = sizeof(mainboard_pc_beep_verbs) / sizeof(mainboard_pc_beep_verbs[0]); - - diff --git a/src/mainboard/msi/ms9185/mb_sysconf.h b/src/mainboard/msi/ms9185/mb_sysconf.h index 63528ca..4b27fc3 100644 --- a/src/mainboard/msi/ms9185/mb_sysconf.h +++ b/src/mainboard/msi/ms9185/mb_sysconf.h @@ -35,4 +35,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/msi/ms9282/mb_sysconf.h b/src/mainboard/msi/ms9282/mb_sysconf.h index 5346fc4..a1ad772 100644 --- a/src/mainboard/msi/ms9282/mb_sysconf.h +++ b/src/mainboard/msi/ms9282/mb_sysconf.h @@ -31,4 +31,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/msi/ms9652_fam10/mb_sysconf.h b/src/mainboard/msi/ms9652_fam10/mb_sysconf.h index 7fead36..ad78ef6 100644 --- a/src/mainboard/msi/ms9652_fam10/mb_sysconf.h +++ b/src/mainboard/msi/ms9652_fam10/mb_sysconf.h @@ -28,4 +28,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/nvidia/l1_2pvv/hda_verb.h b/src/mainboard/nvidia/l1_2pvv/hda_verb.h index 054a369..763840b 100644 --- a/src/mainboard/nvidia/l1_2pvv/hda_verb.h +++ b/src/mainboard/nvidia/l1_2pvv/hda_verb.h @@ -106,4 +106,3 @@ static u32 mainboard_cim_verb_data[] = { extern u32 *cim_verb_data; extern u32 cim_verb_data_size; - diff --git a/src/mainboard/nvidia/l1_2pvv/mb_sysconf.h b/src/mainboard/nvidia/l1_2pvv/mb_sysconf.h index 77acd1b..8091bba 100644 --- a/src/mainboard/nvidia/l1_2pvv/mb_sysconf.h +++ b/src/mainboard/nvidia/l1_2pvv/mb_sysconf.h @@ -31,4 +31,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/supermicro/h8dmr_fam10/mb_sysconf.h b/src/mainboard/supermicro/h8dmr_fam10/mb_sysconf.h index 7fead36..ad78ef6 100644 --- a/src/mainboard/supermicro/h8dmr_fam10/mb_sysconf.h +++ b/src/mainboard/supermicro/h8dmr_fam10/mb_sysconf.h @@ -28,4 +28,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/supermicro/h8qme_fam10/mb_sysconf.h b/src/mainboard/supermicro/h8qme_fam10/mb_sysconf.h index bc32cf1..5a75677 100644 --- a/src/mainboard/supermicro/h8qme_fam10/mb_sysconf.h +++ b/src/mainboard/supermicro/h8qme_fam10/mb_sysconf.h @@ -34,4 +34,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/supermicro/h8scm_fam10/mb_sysconf.h b/src/mainboard/supermicro/h8scm_fam10/mb_sysconf.h index 6921d75..768ffd1 100644 --- a/src/mainboard/supermicro/h8scm_fam10/mb_sysconf.h +++ b/src/mainboard/supermicro/h8scm_fam10/mb_sysconf.h @@ -42,4 +42,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/tyan/s2912/mb_sysconf.h b/src/mainboard/tyan/s2912/mb_sysconf.h index 7fead36..ad78ef6 100644 --- a/src/mainboard/tyan/s2912/mb_sysconf.h +++ b/src/mainboard/tyan/s2912/mb_sysconf.h @@ -28,4 +28,3 @@ struct mb_sysconf_t { }; #endif - diff --git a/src/mainboard/tyan/s2912_fam10/mb_sysconf.h b/src/mainboard/tyan/s2912_fam10/mb_sysconf.h index 7fead36..ad78ef6 100644 --- a/src/mainboard/tyan/s2912_fam10/mb_sysconf.h +++ b/src/mainboard/tyan/s2912_fam10/mb_sysconf.h @@ -28,4 +28,3 @@ struct mb_sysconf_t { }; #endif -

1 0

New patch to review for coreboot: f0b3ac8 mainboard: Trivial - drop trailing blank lines at EOF
by Edward O'Callaghan 07 Jul '14

07 Jul '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6200 -gerrit commit f0b3ac83cbfb0fd037f8d9277064156154530e80 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Jul 7 23:42:58 2014 +1000 mainboard: Trivial - drop trailing blank lines at EOF Change-Id: I05d6d22664155ac8478e665733f816776e277c22 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/amd/dinar/buildOpts.c | 2 -- src/mainboard/amd/dinar/rd890_cfg.c | 1 - src/mainboard/amd/dinar/romstage.c | 1 - src/mainboard/amd/dinar/sb700_cfg.c | 1 - src/mainboard/amd/inagua/PlatformGnbPcie.c | 1 - src/mainboard/amd/mahogany_fam10/resourcemap.c | 1 - src/mainboard/amd/persimmon/buildOpts.c | 2 -- src/mainboard/amd/rumba/mainboard.c | 1 - src/mainboard/amd/serengeti_cheetah/acpi_tables.c | 1 - src/mainboard/amd/serengeti_cheetah/resourcemap.c | 1 - src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c | 1 - src/mainboard/amd/serengeti_cheetah_fam10/resourcemap.c | 1 - src/mainboard/amd/south_station/PlatformGnbPcie.c | 1 - src/mainboard/amd/south_station/buildOpts.c | 2 -- src/mainboard/amd/south_station/romstage.c | 1 - src/mainboard/amd/tilapia_fam10/resourcemap.c | 1 - src/mainboard/amd/torpedo/PlatformGnbPcie.c | 1 - src/mainboard/amd/torpedo/buildOpts.c | 2 -- src/mainboard/amd/union_station/PlatformGnbPcie.c | 1 - src/mainboard/amd/union_station/buildOpts.c | 2 -- src/mainboard/amd/union_station/romstage.c | 1 - src/mainboard/aopen/dxplplusu/acpi_tables.c | 1 - src/mainboard/arima/hdama/mptable.c | 1 - src/mainboard/asrock/e350m1/PlatformGnbPcie.c | 1 - src/mainboard/asrock/e350m1/buildOpts.c | 2 -- src/mainboard/asus/dsbf/mainboard.c | 1 - src/mainboard/asus/k8v-x/mainboard.c | 1 - src/mainboard/asus/m2v/mainboard.c | 1 - src/mainboard/asus/m4a78-em/resourcemap.c | 1 - src/mainboard/asus/m4a785-m/resourcemap.c | 1 - src/mainboard/bifferos/bifferboard/romstage.c | 1 - src/mainboard/broadcom/blast/resourcemap.c | 1 - src/mainboard/digitallogic/msm586seg/mainboard.c | 1 - src/mainboard/digitallogic/msm800sev/mainboard.c | 1 - src/mainboard/emulation/qemu-armv7/mainboard.c | 1 - src/mainboard/getac/p470/ec_oem.c | 1 - src/mainboard/getac/p470/irq_tables.c | 1 - src/mainboard/getac/p470/mainboard.c | 1 - src/mainboard/getac/p470/smihandler.c | 1 - src/mainboard/gigabyte/ga_2761gxdk/resourcemap.c | 1 - src/mainboard/gigabyte/m57sli/resourcemap.c | 1 - src/mainboard/gigabyte/ma785gm/resourcemap.c | 1 - src/mainboard/gigabyte/ma785gmt/resourcemap.c | 1 - src/mainboard/gigabyte/ma78gm/resourcemap.c | 1 - src/mainboard/gizmosphere/gizmo/buildOpts.c | 2 -- src/mainboard/google/bolt/mainboard.c | 1 - src/mainboard/google/falco/mainboard.c | 1 - src/mainboard/google/link/intel_dp.c | 1 - src/mainboard/google/peppy/mainboard.c | 1 - src/mainboard/google/pit/wakeup.c | 1 - src/mainboard/google/rambi/chromeos.c | 1 - src/mainboard/google/rambi/mainboard.c | 1 - src/mainboard/google/slippy/i915io.c | 1 - src/mainboard/google/slippy/mainboard.c | 1 - src/mainboard/google/snow/wakeup.c | 1 - src/mainboard/hp/dl145_g1/resourcemap.c | 1 - src/mainboard/hp/dl145_g3/irq_tables.c | 1 - src/mainboard/ibm/e325/mptable.c | 1 - src/mainboard/ibm/e326/mptable.c | 1 - src/mainboard/iei/kino-780am2-fam10/resourcemap.c | 1 - src/mainboard/intel/baskingridge/chromeos.c | 1 - src/mainboard/intel/baskingridge/mainboard.c | 1 - src/mainboard/intel/cougar_canyon2/mainboard.c | 1 - src/mainboard/intel/cougar_canyon2/romstage.c | 1 - src/mainboard/intel/d945gclf/irq_tables.c | 1 - src/mainboard/intel/d945gclf/smihandler.c | 2 -- src/mainboard/intel/emeraldlake2/chromeos.c | 1 - src/mainboard/intel/emeraldlake2/mainboard.c | 1 - src/mainboard/intel/jarrell/irq_tables.c | 1 - src/mainboard/intel/jarrell/jarrell_fixups.c | 1 - src/mainboard/intel/jarrell/mptable.c | 1 - src/mainboard/intel/mtarvon/irq_tables.c | 1 - src/mainboard/intel/mtarvon/mptable.c | 1 - src/mainboard/intel/truxton/irq_tables.c | 1 - src/mainboard/intel/truxton/mptable.c | 1 - src/mainboard/intel/wtm2/chromeos.c | 1 - src/mainboard/intel/wtm2/graphics.c | 2 -- src/mainboard/intel/wtm2/mainboard.c | 1 - src/mainboard/intel/xe7501devkit/acpi_tables.c | 1 - src/mainboard/iwill/dk8_htx/acpi_tables.c | 1 - src/mainboard/iwill/dk8_htx/resourcemap.c | 1 - src/mainboard/iwill/dk8s2/mptable.c | 1 - src/mainboard/iwill/dk8x/mptable.c | 1 - src/mainboard/jetway/pa78vm5/resourcemap.c | 1 - src/mainboard/kontron/986lcd-m/irq_tables.c | 1 - src/mainboard/kontron/986lcd-m/mainboard.c | 1 - src/mainboard/kontron/986lcd-m/smihandler.c | 2 -- src/mainboard/lenovo/t60/mainboard.c | 1 - src/mainboard/lenovo/t60/smihandler.c | 1 - src/mainboard/lenovo/x60/mainboard.c | 1 - src/mainboard/lippert/frontrunner-af/buildOpts.c | 2 -- src/mainboard/lippert/toucan-af/buildOpts.c | 2 -- src/mainboard/msi/ms9185/resourcemap.c | 1 - src/mainboard/msi/ms9282/resourcemap.c | 1 - src/mainboard/msi/ms9652_fam10/resourcemap.c | 1 - src/mainboard/newisys/khepri/mptable.c | 1 - src/mainboard/newisys/khepri/resourcemap.c | 1 - src/mainboard/nvidia/l1_2pvv/resourcemap.c | 1 - src/mainboard/pcengines/alix1c/mainboard.c | 1 - src/mainboard/pcengines/alix2d/mainboard.c | 1 - src/mainboard/roda/rk886ex/irq_tables.c | 1 - src/mainboard/roda/rk886ex/m3885.c | 1 - src/mainboard/roda/rk886ex/mainboard.c | 1 - src/mainboard/roda/rk886ex/smihandler.c | 1 - src/mainboard/roda/rk9/mainboard.c | 1 - src/mainboard/roda/rk9/romstage.c | 1 - src/mainboard/roda/rk9/ti_pci7xx1.c | 1 - src/mainboard/samsung/lumpy/mainboard.c | 1 - src/mainboard/samsung/stumpy/mainboard.c | 1 - src/mainboard/siemens/sitemp_g1p1/romstage.c | 1 - src/mainboard/sunw/ultra40/resourcemap.c | 1 - src/mainboard/supermicro/h8dme/resourcemap.c | 1 - src/mainboard/supermicro/h8dmr/resourcemap.c | 1 - src/mainboard/supermicro/h8dmr_fam10/resourcemap.c | 1 - src/mainboard/supermicro/h8qgi/agesawrapper.c | 1 - src/mainboard/supermicro/h8qgi/buildOpts.c | 1 - src/mainboard/supermicro/h8qgi/fadt.c | 1 - src/mainboard/supermicro/h8qgi/platform_oem.c | 1 - src/mainboard/supermicro/h8qgi/rd890_cfg.c | 1 - src/mainboard/supermicro/h8qgi/romstage.c | 1 - src/mainboard/supermicro/h8qgi/sb700_cfg.c | 1 - src/mainboard/supermicro/h8qme_fam10/resourcemap.c | 1 - src/mainboard/supermicro/h8scm/agesawrapper.c | 1 - src/mainboard/supermicro/h8scm/buildOpts.c | 1 - src/mainboard/supermicro/h8scm/fadt.c | 1 - src/mainboard/supermicro/h8scm/platform_oem.c | 1 - src/mainboard/supermicro/h8scm/rd890_cfg.c | 1 - src/mainboard/supermicro/h8scm/romstage.c | 1 - src/mainboard/supermicro/h8scm/sb700_cfg.c | 1 - src/mainboard/supermicro/h8scm_fam10/resourcemap.c | 1 - src/mainboard/supermicro/x6dai_g/irq_tables.c | 1 - src/mainboard/supermicro/x6dai_g/mptable.c | 1 - src/mainboard/supermicro/x6dai_g/watchdog.c | 1 - src/mainboard/supermicro/x6dhe_g/irq_tables.c | 1 - src/mainboard/supermicro/x6dhe_g/mptable.c | 1 - src/mainboard/supermicro/x6dhe_g/watchdog.c | 1 - src/mainboard/supermicro/x6dhe_g2/irq_tables.c | 1 - src/mainboard/supermicro/x6dhe_g2/mptable.c | 1 - src/mainboard/supermicro/x6dhe_g2/watchdog.c | 1 - src/mainboard/supermicro/x6dhr_ig/irq_tables.c | 1 - src/mainboard/supermicro/x6dhr_ig/mptable.c | 1 - src/mainboard/supermicro/x6dhr_ig/watchdog.c | 1 - src/mainboard/supermicro/x6dhr_ig2/irq_tables.c | 1 - src/mainboard/supermicro/x6dhr_ig2/mptable.c | 1 - src/mainboard/supermicro/x6dhr_ig2/watchdog.c | 1 - src/mainboard/supermicro/x7db8/mainboard.c | 1 - src/mainboard/technologic/ts5300/mainboard.c | 1 - src/mainboard/tyan/s2881/resourcemap.c | 1 - src/mainboard/tyan/s2885/resourcemap.c | 1 - src/mainboard/tyan/s2891/resourcemap.c | 1 - src/mainboard/tyan/s2912/get_bus_conf.c | 1 - src/mainboard/tyan/s2912/resourcemap.c | 1 - src/mainboard/tyan/s2912_fam10/resourcemap.c | 1 - src/mainboard/tyan/s4880/resourcemap.c | 1 - src/mainboard/tyan/s4882/resourcemap.c | 1 - src/mainboard/tyan/s8226/agesawrapper.c | 1 - src/mainboard/tyan/s8226/buildOpts.c | 1 - src/mainboard/tyan/s8226/fadt.c | 1 - src/mainboard/tyan/s8226/platform_oem.c | 1 - src/mainboard/tyan/s8226/rd890_cfg.c | 1 - src/mainboard/tyan/s8226/romstage.c | 1 - src/mainboard/tyan/s8226/sb700_cfg.c | 1 - src/mainboard/via/epia-m/acpi_tables.c | 1 - src/mainboard/via/epia-m700/acpi_tables.c | 1 - src/mainboard/via/epia-n/acpi_tables.c | 1 - src/mainboard/wyse/s50/mainboard.c | 1 - 166 files changed, 178 deletions(-) diff --git a/src/mainboard/amd/dinar/buildOpts.c b/src/mainboard/amd/dinar/buildOpts.c index 41f5415..637debc 100644 --- a/src/mainboard/amd/dinar/buildOpts.c +++ b/src/mainboard/amd/dinar/buildOpts.c @@ -551,5 +551,3 @@ UINT8 SizeOfTableHy = sizeof (AGESA_MEM_TABLE_HY) / sizeof (AGESA_MEM_TABLE_HY[0 // /* platform code to read an SPD... */ // return Status; //} - - diff --git a/src/mainboard/amd/dinar/rd890_cfg.c b/src/mainboard/amd/dinar/rd890_cfg.c index ebcc40f..783c130 100644 --- a/src/mainboard/amd/dinar/rd890_cfg.c +++ b/src/mainboard/amd/dinar/rd890_cfg.c @@ -271,4 +271,3 @@ void rd890_cimx_config(AMD_NB_CONFIG_BLOCK *pConfig, NB_CONFIG *nbConfig, HT_CON } #endif } - diff --git a/src/mainboard/amd/dinar/romstage.c b/src/mainboard/amd/dinar/romstage.c index 8851e8c..ba3e1ef 100644 --- a/src/mainboard/amd/dinar/romstage.c +++ b/src/mainboard/amd/dinar/romstage.c @@ -137,4 +137,3 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx) post_code(0x45); // Should never see this post code. } - diff --git a/src/mainboard/amd/dinar/sb700_cfg.c b/src/mainboard/amd/dinar/sb700_cfg.c index c9a0949..6629e37 100644 --- a/src/mainboard/amd/dinar/sb700_cfg.c +++ b/src/mainboard/amd/dinar/sb700_cfg.c @@ -142,4 +142,3 @@ void sb700_cimx_config(AMDSBCFG *sb_config) #endif //!__PRE_RAM__ printk(BIOS_DEBUG, "SB700 - Cfg.c - %s - End.\n", __func__); } - diff --git a/src/mainboard/amd/inagua/PlatformGnbPcie.c b/src/mainboard/amd/inagua/PlatformGnbPcie.c index bf07ff3..6c1a3f9 100644 --- a/src/mainboard/amd/inagua/PlatformGnbPcie.c +++ b/src/mainboard/amd/inagua/PlatformGnbPcie.c @@ -140,4 +140,3 @@ OemCustomizeInitEarly ( InitEarly->GnbConfig.PcieComplexList = BrazosPcieComplexListPtr; InitEarly->GnbConfig.PsppPolicy = 0; } - diff --git a/src/mainboard/amd/mahogany_fam10/resourcemap.c b/src/mainboard/amd/mahogany_fam10/resourcemap.c index b7a4b4f..fc92f62 100644 --- a/src/mainboard/amd/mahogany_fam10/resourcemap.c +++ b/src/mainboard/amd/mahogany_fam10/resourcemap.c @@ -278,4 +278,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/amd/persimmon/buildOpts.c b/src/mainboard/amd/persimmon/buildOpts.c index c6383a2..211be56 100644 --- a/src/mainboard/amd/persimmon/buildOpts.c +++ b/src/mainboard/amd/persimmon/buildOpts.c @@ -454,5 +454,3 @@ CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABL // /* platform code to read an SPD... */ // return Status; //} - - diff --git a/src/mainboard/amd/rumba/mainboard.c b/src/mainboard/amd/rumba/mainboard.c index 8c97109..5725c78 100644 --- a/src/mainboard/amd/rumba/mainboard.c +++ b/src/mainboard/amd/rumba/mainboard.c @@ -35,4 +35,3 @@ static void mainboard_enable(struct device *dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/amd/serengeti_cheetah/acpi_tables.c b/src/mainboard/amd/serengeti_cheetah/acpi_tables.c index 1637c9b..a429c1f 100644 --- a/src/mainboard/amd/serengeti_cheetah/acpi_tables.c +++ b/src/mainboard/amd/serengeti_cheetah/acpi_tables.c @@ -275,4 +275,3 @@ unsigned long write_acpi_tables(unsigned long start) printk(BIOS_INFO, "ACPI: done.\n"); return current; } - diff --git a/src/mainboard/amd/serengeti_cheetah/resourcemap.c b/src/mainboard/amd/serengeti_cheetah/resourcemap.c index be11b68..aedc45c 100644 --- a/src/mainboard/amd/serengeti_cheetah/resourcemap.c +++ b/src/mainboard/amd/serengeti_cheetah/resourcemap.c @@ -261,4 +261,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c b/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c index e7fa815..f624424 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c +++ b/src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c @@ -299,4 +299,3 @@ unsigned long write_acpi_tables(unsigned long start) printk(BIOS_INFO, "ACPI: done.\n"); return current; } - diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/resourcemap.c b/src/mainboard/amd/serengeti_cheetah_fam10/resourcemap.c index 7cac10e..b27bdc6 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/resourcemap.c +++ b/src/mainboard/amd/serengeti_cheetah_fam10/resourcemap.c @@ -278,4 +278,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/amd/south_station/PlatformGnbPcie.c b/src/mainboard/amd/south_station/PlatformGnbPcie.c index 4ad49be..5c0aba6 100644 --- a/src/mainboard/amd/south_station/PlatformGnbPcie.c +++ b/src/mainboard/amd/south_station/PlatformGnbPcie.c @@ -148,4 +148,3 @@ PCIe_COMPLEX_DESCRIPTOR Brazos = { InitEarly->GnbConfig.PcieComplexList = BrazosPcieComplexListPtr; InitEarly->GnbConfig.PsppPolicy = 0; } - diff --git a/src/mainboard/amd/south_station/buildOpts.c b/src/mainboard/amd/south_station/buildOpts.c index 87f9b88..f1346bd 100644 --- a/src/mainboard/amd/south_station/buildOpts.c +++ b/src/mainboard/amd/south_station/buildOpts.c @@ -454,5 +454,3 @@ CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABL // /* platform code to read an SPD... */ // return Status; //} - - diff --git a/src/mainboard/amd/south_station/romstage.c b/src/mainboard/amd/south_station/romstage.c index be340aa..13c096f 100644 --- a/src/mainboard/amd/south_station/romstage.c +++ b/src/mainboard/amd/south_station/romstage.c @@ -119,4 +119,3 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx) post_code(0x54); /* Should never see this post code. */ } - diff --git a/src/mainboard/amd/tilapia_fam10/resourcemap.c b/src/mainboard/amd/tilapia_fam10/resourcemap.c index b7a4b4f..fc92f62 100644 --- a/src/mainboard/amd/tilapia_fam10/resourcemap.c +++ b/src/mainboard/amd/tilapia_fam10/resourcemap.c @@ -278,4 +278,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/amd/torpedo/PlatformGnbPcie.c b/src/mainboard/amd/torpedo/PlatformGnbPcie.c index 1639393..3978786 100644 --- a/src/mainboard/amd/torpedo/PlatformGnbPcie.c +++ b/src/mainboard/amd/torpedo/PlatformGnbPcie.c @@ -171,4 +171,3 @@ OemCustomizeInitEarly ( InitEarly->GnbConfig.PcieComplexList = LlanoPcieComplexListPtr; InitEarly->GnbConfig.PsppPolicy = 0; } - diff --git a/src/mainboard/amd/torpedo/buildOpts.c b/src/mainboard/amd/torpedo/buildOpts.c index 91718ed..1a75cd2 100644 --- a/src/mainboard/amd/torpedo/buildOpts.c +++ b/src/mainboard/amd/torpedo/buildOpts.c @@ -383,5 +383,3 @@ UINT8 SizeOfTableLN = sizeof (AGESA_MEM_TABLE_LN) / sizeof (AGESA_MEM_TABLE_LN[0 // /* platform code to read an SPD... */ // return Status; //} - - diff --git a/src/mainboard/amd/union_station/PlatformGnbPcie.c b/src/mainboard/amd/union_station/PlatformGnbPcie.c index be1c3a5..aa0eedb 100644 --- a/src/mainboard/amd/union_station/PlatformGnbPcie.c +++ b/src/mainboard/amd/union_station/PlatformGnbPcie.c @@ -150,4 +150,3 @@ PCIe_COMPLEX_DESCRIPTOR Brazos = { InitEarly->GnbConfig.PcieComplexList = BrazosPcieComplexListPtr; InitEarly->GnbConfig.PsppPolicy = 0; } - diff --git a/src/mainboard/amd/union_station/buildOpts.c b/src/mainboard/amd/union_station/buildOpts.c index 87f9b88..f1346bd 100644 --- a/src/mainboard/amd/union_station/buildOpts.c +++ b/src/mainboard/amd/union_station/buildOpts.c @@ -454,5 +454,3 @@ CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABL // /* platform code to read an SPD... */ // return Status; //} - - diff --git a/src/mainboard/amd/union_station/romstage.c b/src/mainboard/amd/union_station/romstage.c index 0a7ef7c..05acf52 100644 --- a/src/mainboard/amd/union_station/romstage.c +++ b/src/mainboard/amd/union_station/romstage.c @@ -113,4 +113,3 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx) post_code(0x54); /* Should never see this post code. */ } - diff --git a/src/mainboard/aopen/dxplplusu/acpi_tables.c b/src/mainboard/aopen/dxplplusu/acpi_tables.c index a4fa012..2985e86 100644 --- a/src/mainboard/aopen/dxplplusu/acpi_tables.c +++ b/src/mainboard/aopen/dxplplusu/acpi_tables.c @@ -160,4 +160,3 @@ unsigned long write_acpi_tables(unsigned long start) printk(BIOS_INFO, "ACPI: done.\n"); return current; } - diff --git a/src/mainboard/arima/hdama/mptable.c b/src/mainboard/arima/hdama/mptable.c index f67327e..dc5fd45 100644 --- a/src/mainboard/arima/hdama/mptable.c +++ b/src/mainboard/arima/hdama/mptable.c @@ -260,4 +260,3 @@ unsigned long write_smp_table(unsigned long addr) v = smp_write_floating_table(addr, 0); return (unsigned long)smp_write_config_table(v); } - diff --git a/src/mainboard/asrock/e350m1/PlatformGnbPcie.c b/src/mainboard/asrock/e350m1/PlatformGnbPcie.c index ed20b59..eefd27f 100644 --- a/src/mainboard/asrock/e350m1/PlatformGnbPcie.c +++ b/src/mainboard/asrock/e350m1/PlatformGnbPcie.c @@ -150,4 +150,3 @@ PCIe_COMPLEX_DESCRIPTOR Brazos = { InitEarly->GnbConfig.PcieComplexList = BrazosPcieComplexListPtr; InitEarly->GnbConfig.PsppPolicy = 0; } - diff --git a/src/mainboard/asrock/e350m1/buildOpts.c b/src/mainboard/asrock/e350m1/buildOpts.c index 19ba4f3..c69d504 100644 --- a/src/mainboard/asrock/e350m1/buildOpts.c +++ b/src/mainboard/asrock/e350m1/buildOpts.c @@ -454,5 +454,3 @@ CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABL // /* platform code to read an SPD... */ // return Status; //} - - diff --git a/src/mainboard/asus/dsbf/mainboard.c b/src/mainboard/asus/dsbf/mainboard.c index 34a355e..1d666c9 100644 --- a/src/mainboard/asus/dsbf/mainboard.c +++ b/src/mainboard/asus/dsbf/mainboard.c @@ -34,4 +34,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/asus/k8v-x/mainboard.c b/src/mainboard/asus/k8v-x/mainboard.c index 98b75a8..cd45213 100644 --- a/src/mainboard/asus/k8v-x/mainboard.c +++ b/src/mainboard/asus/k8v-x/mainboard.c @@ -57,4 +57,3 @@ u32 vt8237_ide_80pin_detect(struct device *dev) return res; } - diff --git a/src/mainboard/asus/m2v/mainboard.c b/src/mainboard/asus/m2v/mainboard.c index 9516523..21adac0 100644 --- a/src/mainboard/asus/m2v/mainboard.c +++ b/src/mainboard/asus/m2v/mainboard.c @@ -53,4 +53,3 @@ u32 vt8237_ide_80pin_detect(struct device *dev) return res; } - diff --git a/src/mainboard/asus/m4a78-em/resourcemap.c b/src/mainboard/asus/m4a78-em/resourcemap.c index b7a4b4f..fc92f62 100644 --- a/src/mainboard/asus/m4a78-em/resourcemap.c +++ b/src/mainboard/asus/m4a78-em/resourcemap.c @@ -278,4 +278,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/asus/m4a785-m/resourcemap.c b/src/mainboard/asus/m4a785-m/resourcemap.c index b7a4b4f..fc92f62 100644 --- a/src/mainboard/asus/m4a785-m/resourcemap.c +++ b/src/mainboard/asus/m4a785-m/resourcemap.c @@ -278,4 +278,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/bifferos/bifferboard/romstage.c b/src/mainboard/bifferos/bifferboard/romstage.c index cdf2544..dd2553e 100644 --- a/src/mainboard/bifferos/bifferboard/romstage.c +++ b/src/mainboard/bifferos/bifferboard/romstage.c @@ -60,4 +60,3 @@ static void main(void) /* Route Cseg, Dseg, Eseg and Fseg to RAM */ pci_write_config32(PCI_DEV(0,0,0), 0x84, 0x3ffffff0); } - diff --git a/src/mainboard/broadcom/blast/resourcemap.c b/src/mainboard/broadcom/blast/resourcemap.c index 71f0bba..43a4904 100644 --- a/src/mainboard/broadcom/blast/resourcemap.c +++ b/src/mainboard/broadcom/blast/resourcemap.c @@ -262,4 +262,3 @@ static void setup_blast_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/digitallogic/msm586seg/mainboard.c b/src/mainboard/digitallogic/msm586seg/mainboard.c index 6cb5f07..0310176 100644 --- a/src/mainboard/digitallogic/msm586seg/mainboard.c +++ b/src/mainboard/digitallogic/msm586seg/mainboard.c @@ -131,4 +131,3 @@ static void mainboard_enable(struct device *dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/digitallogic/msm800sev/mainboard.c b/src/mainboard/digitallogic/msm800sev/mainboard.c index 6d4a4ac..352353f 100644 --- a/src/mainboard/digitallogic/msm800sev/mainboard.c +++ b/src/mainboard/digitallogic/msm800sev/mainboard.c @@ -34,4 +34,3 @@ static void mainboard_enable(struct device *dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/emulation/qemu-armv7/mainboard.c b/src/mainboard/emulation/qemu-armv7/mainboard.c index 603d00e..83a55e3 100644 --- a/src/mainboard/emulation/qemu-armv7/mainboard.c +++ b/src/mainboard/emulation/qemu-armv7/mainboard.c @@ -24,4 +24,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/getac/p470/ec_oem.c b/src/mainboard/getac/p470/ec_oem.c index f742f3f..7777291 100644 --- a/src/mainboard/getac/p470/ec_oem.c +++ b/src/mainboard/getac/p470/ec_oem.c @@ -127,4 +127,3 @@ int ec_oem_dump_status(void) return ec_sc; } - diff --git a/src/mainboard/getac/p470/irq_tables.c b/src/mainboard/getac/p470/irq_tables.c index a1b9625..5390741 100644 --- a/src/mainboard/getac/p470/irq_tables.c +++ b/src/mainboard/getac/p470/irq_tables.c @@ -60,4 +60,3 @@ unsigned long write_pirq_routing_table(unsigned long addr) { return copy_pirq_routing_table(addr, &intel_irq_routing_table); } - diff --git a/src/mainboard/getac/p470/mainboard.c b/src/mainboard/getac/p470/mainboard.c index edaf301..ead665e 100644 --- a/src/mainboard/getac/p470/mainboard.c +++ b/src/mainboard/getac/p470/mainboard.c @@ -99,4 +99,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/getac/p470/smihandler.c b/src/mainboard/getac/p470/smihandler.c index c66abad..cc28bd6 100644 --- a/src/mainboard/getac/p470/smihandler.c +++ b/src/mainboard/getac/p470/smihandler.c @@ -199,4 +199,3 @@ void mainboard_smi_gpi(u32 gpi_sts) printk(BIOS_DEBUG, "EC SMI source: %02x\n", source); } } - diff --git a/src/mainboard/gigabyte/ga_2761gxdk/resourcemap.c b/src/mainboard/gigabyte/ga_2761gxdk/resourcemap.c index ee8119e..96879de 100644 --- a/src/mainboard/gigabyte/ga_2761gxdk/resourcemap.c +++ b/src/mainboard/gigabyte/ga_2761gxdk/resourcemap.c @@ -280,4 +280,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/gigabyte/m57sli/resourcemap.c b/src/mainboard/gigabyte/m57sli/resourcemap.c index ee8119e..96879de 100644 --- a/src/mainboard/gigabyte/m57sli/resourcemap.c +++ b/src/mainboard/gigabyte/m57sli/resourcemap.c @@ -280,4 +280,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/gigabyte/ma785gm/resourcemap.c b/src/mainboard/gigabyte/ma785gm/resourcemap.c index b7a4b4f..fc92f62 100644 --- a/src/mainboard/gigabyte/ma785gm/resourcemap.c +++ b/src/mainboard/gigabyte/ma785gm/resourcemap.c @@ -278,4 +278,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/gigabyte/ma785gmt/resourcemap.c b/src/mainboard/gigabyte/ma785gmt/resourcemap.c index b7a4b4f..fc92f62 100644 --- a/src/mainboard/gigabyte/ma785gmt/resourcemap.c +++ b/src/mainboard/gigabyte/ma785gmt/resourcemap.c @@ -278,4 +278,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/gigabyte/ma78gm/resourcemap.c b/src/mainboard/gigabyte/ma78gm/resourcemap.c index b7a4b4f..fc92f62 100644 --- a/src/mainboard/gigabyte/ma78gm/resourcemap.c +++ b/src/mainboard/gigabyte/ma78gm/resourcemap.c @@ -278,4 +278,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/gizmosphere/gizmo/buildOpts.c b/src/mainboard/gizmosphere/gizmo/buildOpts.c index ba9a350..5e496e1 100755 --- a/src/mainboard/gizmosphere/gizmo/buildOpts.c +++ b/src/mainboard/gizmosphere/gizmo/buildOpts.c @@ -466,5 +466,3 @@ CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABL // /* platform code to read an SPD... */ // return Status; //} - - diff --git a/src/mainboard/google/bolt/mainboard.c b/src/mainboard/google/bolt/mainboard.c index d421301..39a85ff 100644 --- a/src/mainboard/google/bolt/mainboard.c +++ b/src/mainboard/google/bolt/mainboard.c @@ -199,4 +199,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/google/falco/mainboard.c b/src/mainboard/google/falco/mainboard.c index d421301..39a85ff 100644 --- a/src/mainboard/google/falco/mainboard.c +++ b/src/mainboard/google/falco/mainboard.c @@ -199,4 +199,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/google/link/intel_dp.c b/src/mainboard/google/link/intel_dp.c index 9fb66f6..f74743a 100644 --- a/src/mainboard/google/link/intel_dp.c +++ b/src/mainboard/google/link/intel_dp.c @@ -164,4 +164,3 @@ intel_dp_aux_ch(u32 ch_ctl, u32 ch_data, u32 *send, int send_bytes, return recv_bytes; } - diff --git a/src/mainboard/google/peppy/mainboard.c b/src/mainboard/google/peppy/mainboard.c index d421301..39a85ff 100644 --- a/src/mainboard/google/peppy/mainboard.c +++ b/src/mainboard/google/peppy/mainboard.c @@ -199,4 +199,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/google/pit/wakeup.c b/src/mainboard/google/pit/wakeup.c index 02305b5..a2f5f42 100644 --- a/src/mainboard/google/pit/wakeup.c +++ b/src/mainboard/google/pit/wakeup.c @@ -26,4 +26,3 @@ int wakeup_need_reset(void) * reset if the TPM reset mask GPIO value is high. */ return gpio_get_value(GPIO_X06); } - diff --git a/src/mainboard/google/rambi/chromeos.c b/src/mainboard/google/rambi/chromeos.c index cf52f20..27af118 100644 --- a/src/mainboard/google/rambi/chromeos.c +++ b/src/mainboard/google/rambi/chromeos.c @@ -99,4 +99,3 @@ int get_write_protect_state(void) /* WP is enabled when the pin is reading high. */ return ssus_get_gpio(WP_STATUS_PAD); } - diff --git a/src/mainboard/google/rambi/mainboard.c b/src/mainboard/google/rambi/mainboard.c index 2e0652f..49e9ab5 100644 --- a/src/mainboard/google/rambi/mainboard.c +++ b/src/mainboard/google/rambi/mainboard.c @@ -176,4 +176,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/google/slippy/i915io.c b/src/mainboard/google/slippy/i915io.c index 668094f..92cb0d3 100644 --- a/src/mainboard/google/slippy/i915io.c +++ b/src/mainboard/google/slippy/i915io.c @@ -262,4 +262,3 @@ void runio(struct intel_dp *dp) io_i915_write32(0x00000000,DEIIR); io_i915_write32(0x00001800,0x4f044); } - diff --git a/src/mainboard/google/slippy/mainboard.c b/src/mainboard/google/slippy/mainboard.c index d421301..39a85ff 100644 --- a/src/mainboard/google/slippy/mainboard.c +++ b/src/mainboard/google/slippy/mainboard.c @@ -199,4 +199,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/google/snow/wakeup.c b/src/mainboard/google/snow/wakeup.c index 2fe1ab0..e3cd2ba 100644 --- a/src/mainboard/google/snow/wakeup.c +++ b/src/mainboard/google/snow/wakeup.c @@ -26,4 +26,3 @@ int wakeup_need_reset(void) * reset if GPIO value is high. */ return gpio_get_value(GPIO_Y10); } - diff --git a/src/mainboard/hp/dl145_g1/resourcemap.c b/src/mainboard/hp/dl145_g1/resourcemap.c index 4cc08f5..65a4610 100644 --- a/src/mainboard/hp/dl145_g1/resourcemap.c +++ b/src/mainboard/hp/dl145_g1/resourcemap.c @@ -266,4 +266,3 @@ static void setup_dl145g1_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/hp/dl145_g3/irq_tables.c b/src/mainboard/hp/dl145_g3/irq_tables.c index 2d2394b..b5ea725 100644 --- a/src/mainboard/hp/dl145_g3/irq_tables.c +++ b/src/mainboard/hp/dl145_g3/irq_tables.c @@ -56,4 +56,3 @@ unsigned long write_pirq_routing_table(unsigned long addr) { return copy_pirq_routing_table(addr, &intel_irq_routing_table); } - diff --git a/src/mainboard/ibm/e325/mptable.c b/src/mainboard/ibm/e325/mptable.c index 7d1b8f3..6eb6390 100644 --- a/src/mainboard/ibm/e325/mptable.c +++ b/src/mainboard/ibm/e325/mptable.c @@ -129,4 +129,3 @@ unsigned long write_smp_table(unsigned long addr) v = smp_write_floating_table(addr, 0); return (unsigned long)smp_write_config_table(v); } - diff --git a/src/mainboard/ibm/e326/mptable.c b/src/mainboard/ibm/e326/mptable.c index b963a0c..f271166 100644 --- a/src/mainboard/ibm/e326/mptable.c +++ b/src/mainboard/ibm/e326/mptable.c @@ -128,4 +128,3 @@ unsigned long write_smp_table(unsigned long addr) v = smp_write_floating_table(addr, 0); return (unsigned long)smp_write_config_table(v); } - diff --git a/src/mainboard/iei/kino-780am2-fam10/resourcemap.c b/src/mainboard/iei/kino-780am2-fam10/resourcemap.c index b7a4b4f..fc92f62 100644 --- a/src/mainboard/iei/kino-780am2-fam10/resourcemap.c +++ b/src/mainboard/iei/kino-780am2-fam10/resourcemap.c @@ -278,4 +278,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/intel/baskingridge/chromeos.c b/src/mainboard/intel/baskingridge/chromeos.c index c667fd4..c1cea63 100644 --- a/src/mainboard/intel/baskingridge/chromeos.c +++ b/src/mainboard/intel/baskingridge/chromeos.c @@ -124,4 +124,3 @@ int get_write_protect_state(void) { return 0; } - diff --git a/src/mainboard/intel/baskingridge/mainboard.c b/src/mainboard/intel/baskingridge/mainboard.c index 42c96b2..9d08099 100644 --- a/src/mainboard/intel/baskingridge/mainboard.c +++ b/src/mainboard/intel/baskingridge/mainboard.c @@ -154,4 +154,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/intel/cougar_canyon2/mainboard.c b/src/mainboard/intel/cougar_canyon2/mainboard.c index c51abed..f633279 100644 --- a/src/mainboard/intel/cougar_canyon2/mainboard.c +++ b/src/mainboard/intel/cougar_canyon2/mainboard.c @@ -166,4 +166,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/intel/cougar_canyon2/romstage.c b/src/mainboard/intel/cougar_canyon2/romstage.c index add6ddc..cc956a7 100644 --- a/src/mainboard/intel/cougar_canyon2/romstage.c +++ b/src/mainboard/intel/cougar_canyon2/romstage.c @@ -358,4 +358,3 @@ void romstage_fsp_rt_buffer_callback(FSP_INIT_RT_BUFFER *FspRtBuffer) /* No overrides needed */ return; } - diff --git a/src/mainboard/intel/d945gclf/irq_tables.c b/src/mainboard/intel/d945gclf/irq_tables.c index ce2a14a..08108f8 100644 --- a/src/mainboard/intel/d945gclf/irq_tables.c +++ b/src/mainboard/intel/d945gclf/irq_tables.c @@ -58,4 +58,3 @@ unsigned long write_pirq_routing_table(unsigned long addr) { return copy_pirq_routing_table(addr, &intel_irq_routing_table); } - diff --git a/src/mainboard/intel/d945gclf/smihandler.c b/src/mainboard/intel/d945gclf/smihandler.c index 0643ad9..8ebf635 100644 --- a/src/mainboard/intel/d945gclf/smihandler.c +++ b/src/mainboard/intel/d945gclf/smihandler.c @@ -47,5 +47,3 @@ int mainboard_io_trap_handler(int smif) //gnvs->smif = 0; return 1; } - - diff --git a/src/mainboard/intel/emeraldlake2/chromeos.c b/src/mainboard/intel/emeraldlake2/chromeos.c index bc99667..0c6e862 100644 --- a/src/mainboard/intel/emeraldlake2/chromeos.c +++ b/src/mainboard/intel/emeraldlake2/chromeos.c @@ -112,4 +112,3 @@ int get_recovery_mode_switch(void) /* Recovery: GPIO22, active low */ return !((gp_lvl >> 22) & 1); } - diff --git a/src/mainboard/intel/emeraldlake2/mainboard.c b/src/mainboard/intel/emeraldlake2/mainboard.c index f995697..cd8fc80 100644 --- a/src/mainboard/intel/emeraldlake2/mainboard.c +++ b/src/mainboard/intel/emeraldlake2/mainboard.c @@ -166,4 +166,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/intel/jarrell/irq_tables.c b/src/mainboard/intel/jarrell/irq_tables.c index 6e88d48..fdeae8c 100644 --- a/src/mainboard/intel/jarrell/irq_tables.c +++ b/src/mainboard/intel/jarrell/irq_tables.c @@ -40,4 +40,3 @@ unsigned long write_pirq_routing_table(unsigned long addr) { return copy_pirq_routing_table(addr, &intel_irq_routing_table); } - diff --git a/src/mainboard/intel/jarrell/jarrell_fixups.c b/src/mainboard/intel/jarrell/jarrell_fixups.c index 9a57746..90e3ff1 100644 --- a/src/mainboard/intel/jarrell/jarrell_fixups.c +++ b/src/mainboard/intel/jarrell/jarrell_fixups.c @@ -114,4 +114,3 @@ static void mainboard_set_e7520_leds(void) return; } - diff --git a/src/mainboard/intel/jarrell/mptable.c b/src/mainboard/intel/jarrell/mptable.c index 6662329..21664ce 100644 --- a/src/mainboard/intel/jarrell/mptable.c +++ b/src/mainboard/intel/jarrell/mptable.c @@ -236,4 +236,3 @@ unsigned long write_smp_table(unsigned long addr) v = smp_write_floating_table(addr, 0); return (unsigned long)smp_write_config_table(v); } - diff --git a/src/mainboard/intel/mtarvon/irq_tables.c b/src/mainboard/intel/mtarvon/irq_tables.c index 424f4f3..6f5b0a2 100644 --- a/src/mainboard/intel/mtarvon/irq_tables.c +++ b/src/mainboard/intel/mtarvon/irq_tables.c @@ -41,4 +41,3 @@ unsigned long write_pirq_routing_table(unsigned long addr) { return copy_pirq_routing_table(addr, &intel_irq_routing_table); } - diff --git a/src/mainboard/intel/mtarvon/mptable.c b/src/mainboard/intel/mtarvon/mptable.c index 7398f00..4dd13f9 100644 --- a/src/mainboard/intel/mtarvon/mptable.c +++ b/src/mainboard/intel/mtarvon/mptable.c @@ -109,4 +109,3 @@ unsigned long write_smp_table(unsigned long addr) v = smp_write_floating_table(addr, 0); return (unsigned long)smp_write_config_table(v); } - diff --git a/src/mainboard/intel/truxton/irq_tables.c b/src/mainboard/intel/truxton/irq_tables.c index 9c5ca41..4bda346 100644 --- a/src/mainboard/intel/truxton/irq_tables.c +++ b/src/mainboard/intel/truxton/irq_tables.c @@ -41,4 +41,3 @@ unsigned long write_pirq_routing_table(unsigned long addr) { return copy_pirq_routing_table(addr, &intel_irq_routing_table); } - diff --git a/src/mainboard/intel/truxton/mptable.c b/src/mainboard/intel/truxton/mptable.c index 1c4b602..9ad6ea6 100644 --- a/src/mainboard/intel/truxton/mptable.c +++ b/src/mainboard/intel/truxton/mptable.c @@ -137,4 +137,3 @@ unsigned long write_smp_table(unsigned long addr) v = smp_write_floating_table(addr, 0); return (unsigned long)smp_write_config_table(v); } - diff --git a/src/mainboard/intel/wtm2/chromeos.c b/src/mainboard/intel/wtm2/chromeos.c index 1c11876..1461a15 100644 --- a/src/mainboard/intel/wtm2/chromeos.c +++ b/src/mainboard/intel/wtm2/chromeos.c @@ -64,4 +64,3 @@ int get_write_protect_state(void) { return 0; } - diff --git a/src/mainboard/intel/wtm2/graphics.c b/src/mainboard/intel/wtm2/graphics.c index 6d375e6..f0f2fcf 100644 --- a/src/mainboard/intel/wtm2/graphics.c +++ b/src/mainboard/intel/wtm2/graphics.c @@ -85,5 +85,3 @@ void graphics_register_reset(u32 aux_ctl, u32 aux_data, int verbose) /* end not yet documented. */ io_i915_write32(0x10000000,SDEISR+0x30); } - - diff --git a/src/mainboard/intel/wtm2/mainboard.c b/src/mainboard/intel/wtm2/mainboard.c index 5aecffc..68b8c7d 100644 --- a/src/mainboard/intel/wtm2/mainboard.c +++ b/src/mainboard/intel/wtm2/mainboard.c @@ -154,4 +154,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/intel/xe7501devkit/acpi_tables.c b/src/mainboard/intel/xe7501devkit/acpi_tables.c index b3c20ba..a14d24f 100644 --- a/src/mainboard/intel/xe7501devkit/acpi_tables.c +++ b/src/mainboard/intel/xe7501devkit/acpi_tables.c @@ -134,4 +134,3 @@ unsigned long write_acpi_tables(unsigned long start) printk(BIOS_INFO, "ACPI: done.\n"); return current; } - diff --git a/src/mainboard/iwill/dk8_htx/acpi_tables.c b/src/mainboard/iwill/dk8_htx/acpi_tables.c index a9eac0d..3d180eb 100644 --- a/src/mainboard/iwill/dk8_htx/acpi_tables.c +++ b/src/mainboard/iwill/dk8_htx/acpi_tables.c @@ -285,4 +285,3 @@ unsigned long write_acpi_tables(unsigned long start) printk(BIOS_INFO, "ACPI: done.\n"); return current; } - diff --git a/src/mainboard/iwill/dk8_htx/resourcemap.c b/src/mainboard/iwill/dk8_htx/resourcemap.c index d60c379..11e80ea 100644 --- a/src/mainboard/iwill/dk8_htx/resourcemap.c +++ b/src/mainboard/iwill/dk8_htx/resourcemap.c @@ -261,4 +261,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/iwill/dk8s2/mptable.c b/src/mainboard/iwill/dk8s2/mptable.c index f22fd9d..c7bb33d 100644 --- a/src/mainboard/iwill/dk8s2/mptable.c +++ b/src/mainboard/iwill/dk8s2/mptable.c @@ -162,4 +162,3 @@ unsigned long write_smp_table(unsigned long addr) v = smp_write_floating_table(addr, 0); return (unsigned long)smp_write_config_table(v); } - diff --git a/src/mainboard/iwill/dk8x/mptable.c b/src/mainboard/iwill/dk8x/mptable.c index f22fd9d..c7bb33d 100644 --- a/src/mainboard/iwill/dk8x/mptable.c +++ b/src/mainboard/iwill/dk8x/mptable.c @@ -162,4 +162,3 @@ unsigned long write_smp_table(unsigned long addr) v = smp_write_floating_table(addr, 0); return (unsigned long)smp_write_config_table(v); } - diff --git a/src/mainboard/jetway/pa78vm5/resourcemap.c b/src/mainboard/jetway/pa78vm5/resourcemap.c index f4717b5..78d00f8 100644 --- a/src/mainboard/jetway/pa78vm5/resourcemap.c +++ b/src/mainboard/jetway/pa78vm5/resourcemap.c @@ -279,4 +279,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/kontron/986lcd-m/irq_tables.c b/src/mainboard/kontron/986lcd-m/irq_tables.c index ab1f2e5..a585122 100644 --- a/src/mainboard/kontron/986lcd-m/irq_tables.c +++ b/src/mainboard/kontron/986lcd-m/irq_tables.c @@ -58,4 +58,3 @@ unsigned long write_pirq_routing_table(unsigned long addr) { return copy_pirq_routing_table(addr, &intel_irq_routing_table); } - diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c index ce0d5de..4f0dcdd 100644 --- a/src/mainboard/kontron/986lcd-m/mainboard.c +++ b/src/mainboard/kontron/986lcd-m/mainboard.c @@ -232,4 +232,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/kontron/986lcd-m/smihandler.c b/src/mainboard/kontron/986lcd-m/smihandler.c index 064109b..9c86697 100644 --- a/src/mainboard/kontron/986lcd-m/smihandler.c +++ b/src/mainboard/kontron/986lcd-m/smihandler.c @@ -47,5 +47,3 @@ int mainboard_io_trap_handler(int smif) //gnvs->smif = 0; return 1; } - - diff --git a/src/mainboard/lenovo/t60/mainboard.c b/src/mainboard/lenovo/t60/mainboard.c index ae6240b..6dac819 100644 --- a/src/mainboard/lenovo/t60/mainboard.c +++ b/src/mainboard/lenovo/t60/mainboard.c @@ -152,4 +152,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/lenovo/t60/smihandler.c b/src/mainboard/lenovo/t60/smihandler.c index 093996b..130ad96 100644 --- a/src/mainboard/lenovo/t60/smihandler.c +++ b/src/mainboard/lenovo/t60/smihandler.c @@ -195,4 +195,3 @@ int mainboard_smi_apmc(u8 data) } return 0; } - diff --git a/src/mainboard/lenovo/x60/mainboard.c b/src/mainboard/lenovo/x60/mainboard.c index 8143ece..cc89047 100644 --- a/src/mainboard/lenovo/x60/mainboard.c +++ b/src/mainboard/lenovo/x60/mainboard.c @@ -168,4 +168,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/lippert/frontrunner-af/buildOpts.c b/src/mainboard/lippert/frontrunner-af/buildOpts.c index 45ffac6..8ffae29 100644 --- a/src/mainboard/lippert/frontrunner-af/buildOpts.c +++ b/src/mainboard/lippert/frontrunner-af/buildOpts.c @@ -455,5 +455,3 @@ CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABL // /* platform code to read an SPD... */ // return Status; //} - - diff --git a/src/mainboard/lippert/toucan-af/buildOpts.c b/src/mainboard/lippert/toucan-af/buildOpts.c index 45ffac6..8ffae29 100644 --- a/src/mainboard/lippert/toucan-af/buildOpts.c +++ b/src/mainboard/lippert/toucan-af/buildOpts.c @@ -455,5 +455,3 @@ CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABL // /* platform code to read an SPD... */ // return Status; //} - - diff --git a/src/mainboard/msi/ms9185/resourcemap.c b/src/mainboard/msi/ms9185/resourcemap.c index 2bac8d0..7d051bf 100644 --- a/src/mainboard/msi/ms9185/resourcemap.c +++ b/src/mainboard/msi/ms9185/resourcemap.c @@ -288,4 +288,3 @@ static void setup_ms9185_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/msi/ms9282/resourcemap.c b/src/mainboard/msi/ms9282/resourcemap.c index a16eb2e..7a6329c 100644 --- a/src/mainboard/msi/ms9282/resourcemap.c +++ b/src/mainboard/msi/ms9282/resourcemap.c @@ -296,4 +296,3 @@ static void setup_ms9282_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/msi/ms9652_fam10/resourcemap.c b/src/mainboard/msi/ms9652_fam10/resourcemap.c index 56522b9..3751183 100644 --- a/src/mainboard/msi/ms9652_fam10/resourcemap.c +++ b/src/mainboard/msi/ms9652_fam10/resourcemap.c @@ -284,4 +284,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/newisys/khepri/mptable.c b/src/mainboard/newisys/khepri/mptable.c index 8ee6e15..1d7c79e 100644 --- a/src/mainboard/newisys/khepri/mptable.c +++ b/src/mainboard/newisys/khepri/mptable.c @@ -163,4 +163,3 @@ unsigned long write_smp_table(unsigned long addr) v = smp_write_floating_table(addr, 0); return (unsigned long)smp_write_config_table(v); } - diff --git a/src/mainboard/newisys/khepri/resourcemap.c b/src/mainboard/newisys/khepri/resourcemap.c index 81bdefa..6f9a54a 100644 --- a/src/mainboard/newisys/khepri/resourcemap.c +++ b/src/mainboard/newisys/khepri/resourcemap.c @@ -268,4 +268,3 @@ static void setup_khepri_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/nvidia/l1_2pvv/resourcemap.c b/src/mainboard/nvidia/l1_2pvv/resourcemap.c index b06aaf3..52bae71 100644 --- a/src/mainboard/nvidia/l1_2pvv/resourcemap.c +++ b/src/mainboard/nvidia/l1_2pvv/resourcemap.c @@ -280,4 +280,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/pcengines/alix1c/mainboard.c b/src/mainboard/pcengines/alix1c/mainboard.c index 7c67fce..8f2031d 100644 --- a/src/mainboard/pcengines/alix1c/mainboard.c +++ b/src/mainboard/pcengines/alix1c/mainboard.c @@ -34,4 +34,3 @@ static void mainboard_enable(struct device *dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/pcengines/alix2d/mainboard.c b/src/mainboard/pcengines/alix2d/mainboard.c index b65c6c5..3cd08c8 100644 --- a/src/mainboard/pcengines/alix2d/mainboard.c +++ b/src/mainboard/pcengines/alix2d/mainboard.c @@ -34,4 +34,3 @@ static void mainboard_enable(struct device *dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/roda/rk886ex/irq_tables.c b/src/mainboard/roda/rk886ex/irq_tables.c index d2e4f78..0f838af 100644 --- a/src/mainboard/roda/rk886ex/irq_tables.c +++ b/src/mainboard/roda/rk886ex/irq_tables.c @@ -60,4 +60,3 @@ unsigned long write_pirq_routing_table(unsigned long addr) { return copy_pirq_routing_table(addr, &intel_irq_routing_table); } - diff --git a/src/mainboard/roda/rk886ex/m3885.c b/src/mainboard/roda/rk886ex/m3885.c index 29d12bc..2489a3c 100644 --- a/src/mainboard/roda/rk886ex/m3885.c +++ b/src/mainboard/roda/rk886ex/m3885.c @@ -413,4 +413,3 @@ u8 m3885_gpio(u8 value) return 0; #endif } - diff --git a/src/mainboard/roda/rk886ex/mainboard.c b/src/mainboard/roda/rk886ex/mainboard.c index a792d5b..7f188d4 100644 --- a/src/mainboard/roda/rk886ex/mainboard.c +++ b/src/mainboard/roda/rk886ex/mainboard.c @@ -136,4 +136,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/roda/rk886ex/smihandler.c b/src/mainboard/roda/rk886ex/smihandler.c index 1470511..0377564 100644 --- a/src/mainboard/roda/rk886ex/smihandler.c +++ b/src/mainboard/roda/rk886ex/smihandler.c @@ -49,4 +49,3 @@ int mainboard_io_trap_handler(int smif) //gnvs->smif = 0; return 1; } - diff --git a/src/mainboard/roda/rk9/mainboard.c b/src/mainboard/roda/rk9/mainboard.c index 0627a5e..2bdec28 100644 --- a/src/mainboard/roda/rk9/mainboard.c +++ b/src/mainboard/roda/rk9/mainboard.c @@ -139,4 +139,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/roda/rk9/romstage.c b/src/mainboard/roda/rk9/romstage.c index 63d55a3..0ebd5da 100644 --- a/src/mainboard/roda/rk9/romstage.c +++ b/src/mainboard/roda/rk9/romstage.c @@ -207,4 +207,3 @@ void main(unsigned long bist) #endif printk(BIOS_SPEW, "exit main()\n"); } - diff --git a/src/mainboard/roda/rk9/ti_pci7xx1.c b/src/mainboard/roda/rk9/ti_pci7xx1.c index 9ffc9fc..f1af9f6 100644 --- a/src/mainboard/roda/rk9/ti_pci7xx1.c +++ b/src/mainboard/roda/rk9/ti_pci7xx1.c @@ -68,4 +68,3 @@ static const struct pci_driver ti_pci7xx1 __pci_driver = { .vendor = 0x104c, .device = 0x8031, }; - diff --git a/src/mainboard/samsung/lumpy/mainboard.c b/src/mainboard/samsung/lumpy/mainboard.c index c5fe45c..1c7be3b 100644 --- a/src/mainboard/samsung/lumpy/mainboard.c +++ b/src/mainboard/samsung/lumpy/mainboard.c @@ -216,4 +216,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/samsung/stumpy/mainboard.c b/src/mainboard/samsung/stumpy/mainboard.c index d6a7b55..3afb2d4 100644 --- a/src/mainboard/samsung/stumpy/mainboard.c +++ b/src/mainboard/samsung/stumpy/mainboard.c @@ -157,4 +157,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/siemens/sitemp_g1p1/romstage.c b/src/mainboard/siemens/sitemp_g1p1/romstage.c index eca7af2..3332999 100644 --- a/src/mainboard/siemens/sitemp_g1p1/romstage.c +++ b/src/mainboard/siemens/sitemp_g1p1/romstage.c @@ -192,4 +192,3 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx) post_cache_as_ram(); } - diff --git a/src/mainboard/sunw/ultra40/resourcemap.c b/src/mainboard/sunw/ultra40/resourcemap.c index eae21b4..964be50 100644 --- a/src/mainboard/sunw/ultra40/resourcemap.c +++ b/src/mainboard/sunw/ultra40/resourcemap.c @@ -263,4 +263,3 @@ static void setup_ultra40_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/supermicro/h8dme/resourcemap.c b/src/mainboard/supermicro/h8dme/resourcemap.c index 4451521..3d12cda 100644 --- a/src/mainboard/supermicro/h8dme/resourcemap.c +++ b/src/mainboard/supermicro/h8dme/resourcemap.c @@ -280,4 +280,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/supermicro/h8dmr/resourcemap.c b/src/mainboard/supermicro/h8dmr/resourcemap.c index 4451521..3d12cda 100644 --- a/src/mainboard/supermicro/h8dmr/resourcemap.c +++ b/src/mainboard/supermicro/h8dmr/resourcemap.c @@ -280,4 +280,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/supermicro/h8dmr_fam10/resourcemap.c b/src/mainboard/supermicro/h8dmr_fam10/resourcemap.c index 4692ea0..eef1811 100644 --- a/src/mainboard/supermicro/h8dmr_fam10/resourcemap.c +++ b/src/mainboard/supermicro/h8dmr_fam10/resourcemap.c @@ -283,4 +283,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/supermicro/h8qgi/agesawrapper.c b/src/mainboard/supermicro/h8qgi/agesawrapper.c index 95fcece..ba23b4d 100644 --- a/src/mainboard/supermicro/h8qgi/agesawrapper.c +++ b/src/mainboard/supermicro/h8qgi/agesawrapper.c @@ -1187,4 +1187,3 @@ UINT32 agesawrapper_amdreadeventlog(UINT8 HeapStatus) printk(BIOS_DEBUG, "exit %s \n", __func__); return (UINT32)Status; } - diff --git a/src/mainboard/supermicro/h8qgi/buildOpts.c b/src/mainboard/supermicro/h8qgi/buildOpts.c index 7584e4f..d9e9222 100644 --- a/src/mainboard/supermicro/h8qgi/buildOpts.c +++ b/src/mainboard/supermicro/h8qgi/buildOpts.c @@ -613,4 +613,3 @@ UINT8 AGESA_MEM_TABLE_HY[][sizeof (MEM_TABLE_ALIAS)] = NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; UINT8 SizeOfTableHy = sizeof (AGESA_MEM_TABLE_HY) / sizeof (AGESA_MEM_TABLE_HY[0]); - diff --git a/src/mainboard/supermicro/h8qgi/fadt.c b/src/mainboard/supermicro/h8qgi/fadt.c index 45f1555..ccbf0e7 100644 --- a/src/mainboard/supermicro/h8qgi/fadt.c +++ b/src/mainboard/supermicro/h8qgi/fadt.c @@ -171,4 +171,3 @@ void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt) header->checksum = acpi_checksum((void *)fadt, sizeof(acpi_fadt_t)); } - diff --git a/src/mainboard/supermicro/h8qgi/platform_oem.c b/src/mainboard/supermicro/h8qgi/platform_oem.c index aeb91a7..c31bf74 100644 --- a/src/mainboard/supermicro/h8qgi/platform_oem.c +++ b/src/mainboard/supermicro/h8qgi/platform_oem.c @@ -47,4 +47,3 @@ VOID OemCustomizeInitEarly(IN OUT AMD_EARLY_PARAMS *InitEarly) { //InitEarly->PlatformConfig.CoreLevelingMode = CORE_LEVEL_TWO; } - diff --git a/src/mainboard/supermicro/h8qgi/rd890_cfg.c b/src/mainboard/supermicro/h8qgi/rd890_cfg.c index 07cd3d4..9c91920 100644 --- a/src/mainboard/supermicro/h8qgi/rd890_cfg.c +++ b/src/mainboard/supermicro/h8qgi/rd890_cfg.c @@ -271,4 +271,3 @@ void rd890_cimx_config(AMD_NB_CONFIG_BLOCK *pConfig, NB_CONFIG *nbConfig, HT_CON } #endif } - diff --git a/src/mainboard/supermicro/h8qgi/romstage.c b/src/mainboard/supermicro/h8qgi/romstage.c index d95db3c..03d501d 100644 --- a/src/mainboard/supermicro/h8qgi/romstage.c +++ b/src/mainboard/supermicro/h8qgi/romstage.c @@ -138,4 +138,3 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx) print_debug("should not be here -\n"); post_code(0x54); } - diff --git a/src/mainboard/supermicro/h8qgi/sb700_cfg.c b/src/mainboard/supermicro/h8qgi/sb700_cfg.c index ff2334f..c55c13a 100644 --- a/src/mainboard/supermicro/h8qgi/sb700_cfg.c +++ b/src/mainboard/supermicro/h8qgi/sb700_cfg.c @@ -142,4 +142,3 @@ void sb700_cimx_config(AMDSBCFG *sb_config) #endif //!__PRE_RAM__ printk(BIOS_DEBUG, "SB700 - Cfg.c - sb700_cimx_config - End.\n"); } - diff --git a/src/mainboard/supermicro/h8qme_fam10/resourcemap.c b/src/mainboard/supermicro/h8qme_fam10/resourcemap.c index 4692ea0..eef1811 100644 --- a/src/mainboard/supermicro/h8qme_fam10/resourcemap.c +++ b/src/mainboard/supermicro/h8qme_fam10/resourcemap.c @@ -283,4 +283,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/supermicro/h8scm/agesawrapper.c b/src/mainboard/supermicro/h8scm/agesawrapper.c index e26dc75..ad99696 100644 --- a/src/mainboard/supermicro/h8scm/agesawrapper.c +++ b/src/mainboard/supermicro/h8scm/agesawrapper.c @@ -1187,4 +1187,3 @@ UINT32 agesawrapper_amdreadeventlog(UINT8 HeapStatus) printk(BIOS_DEBUG, "exit %s \n", __func__); return (UINT32)Status; } - diff --git a/src/mainboard/supermicro/h8scm/buildOpts.c b/src/mainboard/supermicro/h8scm/buildOpts.c index 4cc4c0e..0e9df97 100644 --- a/src/mainboard/supermicro/h8scm/buildOpts.c +++ b/src/mainboard/supermicro/h8scm/buildOpts.c @@ -517,4 +517,3 @@ UINT8 AGESA_MEM_TABLE_HY[][sizeof (MEM_TABLE_ALIAS)] = NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; UINT8 SizeOfTableHy = sizeof (AGESA_MEM_TABLE_HY) / sizeof (AGESA_MEM_TABLE_HY[0]); - diff --git a/src/mainboard/supermicro/h8scm/fadt.c b/src/mainboard/supermicro/h8scm/fadt.c index ab50e0f..30387af 100644 --- a/src/mainboard/supermicro/h8scm/fadt.c +++ b/src/mainboard/supermicro/h8scm/fadt.c @@ -171,4 +171,3 @@ void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt) header->checksum = acpi_checksum((void *)fadt, sizeof(acpi_fadt_t)); } - diff --git a/src/mainboard/supermicro/h8scm/platform_oem.c b/src/mainboard/supermicro/h8scm/platform_oem.c index aeb91a7..c31bf74 100644 --- a/src/mainboard/supermicro/h8scm/platform_oem.c +++ b/src/mainboard/supermicro/h8scm/platform_oem.c @@ -47,4 +47,3 @@ VOID OemCustomizeInitEarly(IN OUT AMD_EARLY_PARAMS *InitEarly) { //InitEarly->PlatformConfig.CoreLevelingMode = CORE_LEVEL_TWO; } - diff --git a/src/mainboard/supermicro/h8scm/rd890_cfg.c b/src/mainboard/supermicro/h8scm/rd890_cfg.c index 07cd3d4..9c91920 100644 --- a/src/mainboard/supermicro/h8scm/rd890_cfg.c +++ b/src/mainboard/supermicro/h8scm/rd890_cfg.c @@ -271,4 +271,3 @@ void rd890_cimx_config(AMD_NB_CONFIG_BLOCK *pConfig, NB_CONFIG *nbConfig, HT_CON } #endif } - diff --git a/src/mainboard/supermicro/h8scm/romstage.c b/src/mainboard/supermicro/h8scm/romstage.c index e7a1c4c..b80b4de 100644 --- a/src/mainboard/supermicro/h8scm/romstage.c +++ b/src/mainboard/supermicro/h8scm/romstage.c @@ -132,4 +132,3 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx) print_debug("should not be here -\n"); post_code(0x54); } - diff --git a/src/mainboard/supermicro/h8scm/sb700_cfg.c b/src/mainboard/supermicro/h8scm/sb700_cfg.c index c03a501..7b02eca 100644 --- a/src/mainboard/supermicro/h8scm/sb700_cfg.c +++ b/src/mainboard/supermicro/h8scm/sb700_cfg.c @@ -142,4 +142,3 @@ void sb700_cimx_config(AMDSBCFG *sb_config) #endif //!__PRE_RAM__ printk(BIOS_DEBUG, "SB700 - Cfg.c - sb700_cimx_config - End.\n"); } - diff --git a/src/mainboard/supermicro/h8scm_fam10/resourcemap.c b/src/mainboard/supermicro/h8scm_fam10/resourcemap.c index b7a4b4f..fc92f62 100644 --- a/src/mainboard/supermicro/h8scm_fam10/resourcemap.c +++ b/src/mainboard/supermicro/h8scm_fam10/resourcemap.c @@ -278,4 +278,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/supermicro/x6dai_g/irq_tables.c b/src/mainboard/supermicro/x6dai_g/irq_tables.c index 0574f05..9cdf027 100644 --- a/src/mainboard/supermicro/x6dai_g/irq_tables.c +++ b/src/mainboard/supermicro/x6dai_g/irq_tables.c @@ -37,4 +37,3 @@ unsigned long write_pirq_routing_table(unsigned long addr) { return copy_pirq_routing_table(addr, &intel_irq_routing_table); } - diff --git a/src/mainboard/supermicro/x6dai_g/mptable.c b/src/mainboard/supermicro/x6dai_g/mptable.c index 6ba5309..0efae77 100644 --- a/src/mainboard/supermicro/x6dai_g/mptable.c +++ b/src/mainboard/supermicro/x6dai_g/mptable.c @@ -86,4 +86,3 @@ unsigned long write_smp_table(unsigned long addr) v = smp_write_floating_table(addr, 0); return (unsigned long)smp_write_config_table(v); } - diff --git a/src/mainboard/supermicro/x6dai_g/watchdog.c b/src/mainboard/supermicro/x6dai_g/watchdog.c index 1b1162c..2fd3274 100644 --- a/src/mainboard/supermicro/x6dai_g/watchdog.c +++ b/src/mainboard/supermicro/x6dai_g/watchdog.c @@ -39,4 +39,3 @@ static void disable_watchdogs(void) disable_esb6300_watchdog(); print_debug("Watchdogs disabled\n"); } - diff --git a/src/mainboard/supermicro/x6dhe_g/irq_tables.c b/src/mainboard/supermicro/x6dhe_g/irq_tables.c index 594d948..0d2f563 100644 --- a/src/mainboard/supermicro/x6dhe_g/irq_tables.c +++ b/src/mainboard/supermicro/x6dhe_g/irq_tables.c @@ -37,4 +37,3 @@ unsigned long write_pirq_routing_table(unsigned long addr) { return copy_pirq_routing_table(addr, &intel_irq_routing_table); } - diff --git a/src/mainboard/supermicro/x6dhe_g/mptable.c b/src/mainboard/supermicro/x6dhe_g/mptable.c index 4504d34..ab73fc7 100644 --- a/src/mainboard/supermicro/x6dhe_g/mptable.c +++ b/src/mainboard/supermicro/x6dhe_g/mptable.c @@ -130,4 +130,3 @@ unsigned long write_smp_table(unsigned long addr) v = smp_write_floating_table(addr, 0); return (unsigned long)smp_write_config_table(v); } - diff --git a/src/mainboard/supermicro/x6dhe_g/watchdog.c b/src/mainboard/supermicro/x6dhe_g/watchdog.c index a3c55c1..1d34f7d 100644 --- a/src/mainboard/supermicro/x6dhe_g/watchdog.c +++ b/src/mainboard/supermicro/x6dhe_g/watchdog.c @@ -96,4 +96,3 @@ static void disable_watchdogs(void) // disable_jarell_frb3(); print_debug("Watchdogs disabled\n"); } - diff --git a/src/mainboard/supermicro/x6dhe_g2/irq_tables.c b/src/mainboard/supermicro/x6dhe_g2/irq_tables.c index 594d948..0d2f563 100644 --- a/src/mainboard/supermicro/x6dhe_g2/irq_tables.c +++ b/src/mainboard/supermicro/x6dhe_g2/irq_tables.c @@ -37,4 +37,3 @@ unsigned long write_pirq_routing_table(unsigned long addr) { return copy_pirq_routing_table(addr, &intel_irq_routing_table); } - diff --git a/src/mainboard/supermicro/x6dhe_g2/mptable.c b/src/mainboard/supermicro/x6dhe_g2/mptable.c index 087bb9e..a2b8c8d 100644 --- a/src/mainboard/supermicro/x6dhe_g2/mptable.c +++ b/src/mainboard/supermicro/x6dhe_g2/mptable.c @@ -131,4 +131,3 @@ unsigned long write_smp_table(unsigned long addr) v = smp_write_floating_table(addr, 0); return (unsigned long)smp_write_config_table(v); } - diff --git a/src/mainboard/supermicro/x6dhe_g2/watchdog.c b/src/mainboard/supermicro/x6dhe_g2/watchdog.c index a3c55c1..1d34f7d 100644 --- a/src/mainboard/supermicro/x6dhe_g2/watchdog.c +++ b/src/mainboard/supermicro/x6dhe_g2/watchdog.c @@ -96,4 +96,3 @@ static void disable_watchdogs(void) // disable_jarell_frb3(); print_debug("Watchdogs disabled\n"); } - diff --git a/src/mainboard/supermicro/x6dhr_ig/irq_tables.c b/src/mainboard/supermicro/x6dhr_ig/irq_tables.c index 0988cb4..72f4125 100644 --- a/src/mainboard/supermicro/x6dhr_ig/irq_tables.c +++ b/src/mainboard/supermicro/x6dhr_ig/irq_tables.c @@ -37,4 +37,3 @@ unsigned long write_pirq_routing_table(unsigned long addr) { return copy_pirq_routing_table(addr, &intel_irq_routing_table); } - diff --git a/src/mainboard/supermicro/x6dhr_ig/mptable.c b/src/mainboard/supermicro/x6dhr_ig/mptable.c index 5d0a08d..f9165d6 100644 --- a/src/mainboard/supermicro/x6dhr_ig/mptable.c +++ b/src/mainboard/supermicro/x6dhr_ig/mptable.c @@ -178,4 +178,3 @@ unsigned long write_smp_table(unsigned long addr) v = smp_write_floating_table(addr, 0); return (unsigned long)smp_write_config_table(v); } - diff --git a/src/mainboard/supermicro/x6dhr_ig/watchdog.c b/src/mainboard/supermicro/x6dhr_ig/watchdog.c index 44cfd10..a451c32 100644 --- a/src/mainboard/supermicro/x6dhr_ig/watchdog.c +++ b/src/mainboard/supermicro/x6dhr_ig/watchdog.c @@ -96,4 +96,3 @@ static void disable_watchdogs(void) // disable_jarell_frb3(); print_debug("Watchdogs disabled\n"); } - diff --git a/src/mainboard/supermicro/x6dhr_ig2/irq_tables.c b/src/mainboard/supermicro/x6dhr_ig2/irq_tables.c index 0988cb4..72f4125 100644 --- a/src/mainboard/supermicro/x6dhr_ig2/irq_tables.c +++ b/src/mainboard/supermicro/x6dhr_ig2/irq_tables.c @@ -37,4 +37,3 @@ unsigned long write_pirq_routing_table(unsigned long addr) { return copy_pirq_routing_table(addr, &intel_irq_routing_table); } - diff --git a/src/mainboard/supermicro/x6dhr_ig2/mptable.c b/src/mainboard/supermicro/x6dhr_ig2/mptable.c index b6c94d3..b5ba6b1 100644 --- a/src/mainboard/supermicro/x6dhr_ig2/mptable.c +++ b/src/mainboard/supermicro/x6dhr_ig2/mptable.c @@ -166,4 +166,3 @@ unsigned long write_smp_table(unsigned long addr) v = smp_write_floating_table(addr, 0); return (unsigned long)smp_write_config_table(v); } - diff --git a/src/mainboard/supermicro/x6dhr_ig2/watchdog.c b/src/mainboard/supermicro/x6dhr_ig2/watchdog.c index 44cfd10..a451c32 100644 --- a/src/mainboard/supermicro/x6dhr_ig2/watchdog.c +++ b/src/mainboard/supermicro/x6dhr_ig2/watchdog.c @@ -96,4 +96,3 @@ static void disable_watchdogs(void) // disable_jarell_frb3(); print_debug("Watchdogs disabled\n"); } - diff --git a/src/mainboard/supermicro/x7db8/mainboard.c b/src/mainboard/supermicro/x7db8/mainboard.c index 34a355e..1d666c9 100644 --- a/src/mainboard/supermicro/x7db8/mainboard.c +++ b/src/mainboard/supermicro/x7db8/mainboard.c @@ -34,4 +34,3 @@ static void mainboard_enable(device_t dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/technologic/ts5300/mainboard.c b/src/mainboard/technologic/ts5300/mainboard.c index 7a0e2f3..20b893e 100644 --- a/src/mainboard/technologic/ts5300/mainboard.c +++ b/src/mainboard/technologic/ts5300/mainboard.c @@ -145,4 +145,3 @@ static void mainboard_enable(struct device *dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; - diff --git a/src/mainboard/tyan/s2881/resourcemap.c b/src/mainboard/tyan/s2881/resourcemap.c index 23ab936..c699b59 100644 --- a/src/mainboard/tyan/s2881/resourcemap.c +++ b/src/mainboard/tyan/s2881/resourcemap.c @@ -261,4 +261,3 @@ static void setup_s2881_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/tyan/s2885/resourcemap.c b/src/mainboard/tyan/s2885/resourcemap.c index af0ccab..cac1b22 100644 --- a/src/mainboard/tyan/s2885/resourcemap.c +++ b/src/mainboard/tyan/s2885/resourcemap.c @@ -262,4 +262,3 @@ static void setup_s2885_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/tyan/s2891/resourcemap.c b/src/mainboard/tyan/s2891/resourcemap.c index d76f1d6..88f6b24 100644 --- a/src/mainboard/tyan/s2891/resourcemap.c +++ b/src/mainboard/tyan/s2891/resourcemap.c @@ -263,4 +263,3 @@ static void setup_s2891_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/tyan/s2912/get_bus_conf.c b/src/mainboard/tyan/s2912/get_bus_conf.c index 44e4e31..7727c4b 100644 --- a/src/mainboard/tyan/s2912/get_bus_conf.c +++ b/src/mainboard/tyan/s2912/get_bus_conf.c @@ -119,4 +119,3 @@ void get_bus_conf(void) #endif m->apicid_mcp55 = apicid_base+0; } - diff --git a/src/mainboard/tyan/s2912/resourcemap.c b/src/mainboard/tyan/s2912/resourcemap.c index b06aaf3..52bae71 100644 --- a/src/mainboard/tyan/s2912/resourcemap.c +++ b/src/mainboard/tyan/s2912/resourcemap.c @@ -280,4 +280,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/tyan/s2912_fam10/resourcemap.c b/src/mainboard/tyan/s2912_fam10/resourcemap.c index 044c674..82fa667 100644 --- a/src/mainboard/tyan/s2912_fam10/resourcemap.c +++ b/src/mainboard/tyan/s2912_fam10/resourcemap.c @@ -280,4 +280,3 @@ static void setup_mb_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/tyan/s4880/resourcemap.c b/src/mainboard/tyan/s4880/resourcemap.c index 5fa8578..f6801f1 100644 --- a/src/mainboard/tyan/s4880/resourcemap.c +++ b/src/mainboard/tyan/s4880/resourcemap.c @@ -261,4 +261,3 @@ static void setup_s4880_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/tyan/s4882/resourcemap.c b/src/mainboard/tyan/s4882/resourcemap.c index 2ee2749..a836573 100644 --- a/src/mainboard/tyan/s4882/resourcemap.c +++ b/src/mainboard/tyan/s4882/resourcemap.c @@ -261,4 +261,3 @@ static void setup_s4882_resource_map(void) max = ARRAY_SIZE(register_values); setup_resource_map(register_values, max); } - diff --git a/src/mainboard/tyan/s8226/agesawrapper.c b/src/mainboard/tyan/s8226/agesawrapper.c index 0a68979..79cc826 100644 --- a/src/mainboard/tyan/s8226/agesawrapper.c +++ b/src/mainboard/tyan/s8226/agesawrapper.c @@ -1197,4 +1197,3 @@ UINT32 agesawrapper_amdreadeventlog(UINT8 HeapStatus) printk(BIOS_DEBUG, "exit %s \n", __func__); return (UINT32)Status; } - diff --git a/src/mainboard/tyan/s8226/buildOpts.c b/src/mainboard/tyan/s8226/buildOpts.c index bb4dd2d..19ebae5 100644 --- a/src/mainboard/tyan/s8226/buildOpts.c +++ b/src/mainboard/tyan/s8226/buildOpts.c @@ -613,4 +613,3 @@ UINT8 AGESA_MEM_TABLE_HY[][sizeof (MEM_TABLE_ALIAS)] = NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; UINT8 SizeOfTableHy = sizeof (AGESA_MEM_TABLE_HY) / sizeof (AGESA_MEM_TABLE_HY[0]); - diff --git a/src/mainboard/tyan/s8226/fadt.c b/src/mainboard/tyan/s8226/fadt.c index ab50e0f..30387af 100644 --- a/src/mainboard/tyan/s8226/fadt.c +++ b/src/mainboard/tyan/s8226/fadt.c @@ -171,4 +171,3 @@ void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt) header->checksum = acpi_checksum((void *)fadt, sizeof(acpi_fadt_t)); } - diff --git a/src/mainboard/tyan/s8226/platform_oem.c b/src/mainboard/tyan/s8226/platform_oem.c index aeb91a7..c31bf74 100644 --- a/src/mainboard/tyan/s8226/platform_oem.c +++ b/src/mainboard/tyan/s8226/platform_oem.c @@ -47,4 +47,3 @@ VOID OemCustomizeInitEarly(IN OUT AMD_EARLY_PARAMS *InitEarly) { //InitEarly->PlatformConfig.CoreLevelingMode = CORE_LEVEL_TWO; } - diff --git a/src/mainboard/tyan/s8226/rd890_cfg.c b/src/mainboard/tyan/s8226/rd890_cfg.c index 07cd3d4..9c91920 100644 --- a/src/mainboard/tyan/s8226/rd890_cfg.c +++ b/src/mainboard/tyan/s8226/rd890_cfg.c @@ -271,4 +271,3 @@ void rd890_cimx_config(AMD_NB_CONFIG_BLOCK *pConfig, NB_CONFIG *nbConfig, HT_CON } #endif } - diff --git a/src/mainboard/tyan/s8226/romstage.c b/src/mainboard/tyan/s8226/romstage.c index f4befe6..8b8fa5f 100644 --- a/src/mainboard/tyan/s8226/romstage.c +++ b/src/mainboard/tyan/s8226/romstage.c @@ -137,4 +137,3 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx) print_debug("should not be here -\n"); post_code(0x54); } - diff --git a/src/mainboard/tyan/s8226/sb700_cfg.c b/src/mainboard/tyan/s8226/sb700_cfg.c index 54c139a..801bb6f 100644 --- a/src/mainboard/tyan/s8226/sb700_cfg.c +++ b/src/mainboard/tyan/s8226/sb700_cfg.c @@ -139,4 +139,3 @@ void sb700_cimx_config(AMDSBCFG *sb_config) #endif //!__PRE_RAM__ printk(BIOS_DEBUG, "SB700 - Cfg.c - sb700_cimx_config - End.\n"); } - diff --git a/src/mainboard/via/epia-m/acpi_tables.c b/src/mainboard/via/epia-m/acpi_tables.c index b174bae..20c0e6a 100644 --- a/src/mainboard/via/epia-m/acpi_tables.c +++ b/src/mainboard/via/epia-m/acpi_tables.c @@ -90,4 +90,3 @@ unsigned long write_acpi_tables(unsigned long start) printk(BIOS_INFO, "ACPI: done.\n"); return current; } - diff --git a/src/mainboard/via/epia-m700/acpi_tables.c b/src/mainboard/via/epia-m700/acpi_tables.c index fa8330f..7d95616 100644 --- a/src/mainboard/via/epia-m700/acpi_tables.c +++ b/src/mainboard/via/epia-m700/acpi_tables.c @@ -202,4 +202,3 @@ unsigned long write_acpi_tables(unsigned long start) printk(BIOS_INFO, "ACPI: done.\n"); return current; } - diff --git a/src/mainboard/via/epia-n/acpi_tables.c b/src/mainboard/via/epia-n/acpi_tables.c index 5558dcb..82dac53 100644 --- a/src/mainboard/via/epia-n/acpi_tables.c +++ b/src/mainboard/via/epia-n/acpi_tables.c @@ -183,4 +183,3 @@ unsigned long write_acpi_tables(unsigned long start) printk(BIOS_INFO, "ACPI: done.\n"); return current; } - diff --git a/src/mainboard/wyse/s50/mainboard.c b/src/mainboard/wyse/s50/mainboard.c index ee92745..89b6b37 100644 --- a/src/mainboard/wyse/s50/mainboard.c +++ b/src/mainboard/wyse/s50/mainboard.c @@ -36,4 +36,3 @@ static void mainboard_enable(struct device *dev) struct chip_operations mainboard_ops = { .enable_dev = mainboard_enable, }; -

1 0

Patch set updated for coreboot: 8382a70 vendorcode/amd/agesa: Use macros already defined in stdlib.h
by Edward O'Callaghan 07 Jul '14

07 Jul '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6199 -gerrit commit 8382a70d989963e0a23f62f7fff47cd20091a08b Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Jul 7 21:08:23 2014 +1000 vendorcode/amd/agesa: Use macros already defined in stdlib.h We already have these macros define in 'stdlib.h'. Make good use of them here to avoid redefinition conflicts of the pre-processor depending on header inclusion ordering. This has the nice side-effect of syncing up AGESA families in this particular regard. Change-Id: Icf911629a4a1a82b01062fe16af4c8f812b05717 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/vendorcode/amd/agesa/f10/Proc/Mem/mu.h | 2 +- src/vendorcode/amd/agesa/f12/Proc/GNB/Common/Gnb.h | 10 ++----- src/vendorcode/amd/agesa/f12/Proc/Mem/mu.h | 19 +------------ src/vendorcode/amd/agesa/f14/Proc/GNB/Common/Gnb.h | 9 +------ src/vendorcode/amd/agesa/f14/Proc/Mem/mu.h | 15 +---------- src/vendorcode/amd/agesa/f15/Proc/Mem/mu.h | 15 +---------- .../amd/agesa/f15tn/Proc/GNB/Common/Gnb.h | 10 ++----- src/vendorcode/amd/agesa/f15tn/Proc/Mem/mu.h | 28 +------------------ .../amd/agesa/f16kb/Proc/GNB/Common/Gnb.h | 10 ++----- src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h | 31 +--------------------- 10 files changed, 13 insertions(+), 136 deletions(-) diff --git a/src/vendorcode/amd/agesa/f10/Proc/Mem/mu.h b/src/vendorcode/amd/agesa/f10/Proc/Mem/mu.h index fc19314..9c4ad01 100644 --- a/src/vendorcode/amd/agesa/f10/Proc/Mem/mu.h +++ b/src/vendorcode/amd/agesa/f10/Proc/Mem/mu.h @@ -60,7 +60,7 @@ #define PSO_ENTRY UINT8 #endif -#define MAX(X, Y) (((X) < (Y)) ? (Y) : (X)) +#include <stdlib.h> /*---------------------------------------------------------------------------- * TYPEDEFS, STRUCTURES, ENUMS diff --git a/src/vendorcode/amd/agesa/f12/Proc/GNB/Common/Gnb.h b/src/vendorcode/amd/agesa/f12/Proc/GNB/Common/Gnb.h index 6839ba5..d249d8b 100644 --- a/src/vendorcode/amd/agesa/f12/Proc/GNB/Common/Gnb.h +++ b/src/vendorcode/amd/agesa/f12/Proc/GNB/Common/Gnb.h @@ -46,6 +46,8 @@ #ifndef _GNB_H_ #define _GNB_H_ +#include <stdlib.h> + #pragma pack (push, 1) #define GNB_DEADLOOP() \ @@ -70,14 +72,6 @@ #endif #endif -#ifndef MIN - #define MIN(x, y) (((x) > (y))? (y):(x)) -#endif - -#ifndef MAX - #define MAX(x, y) (((x) > (y))? (x):(y)) -#endif - #define OFF 0 #define PVOID UINT64 diff --git a/src/vendorcode/amd/agesa/f12/Proc/Mem/mu.h b/src/vendorcode/amd/agesa/f12/Proc/Mem/mu.h index 1a22420..335f39d 100644 --- a/src/vendorcode/amd/agesa/f12/Proc/Mem/mu.h +++ b/src/vendorcode/amd/agesa/f12/Proc/Mem/mu.h @@ -60,24 +60,7 @@ #define PSO_ENTRY UINT8 #endif -// -// Maximum value macro -// -#ifndef MAX -#define MAX(X, Y) (((X) < (Y)) ? (Y) : (X)) -#endif -// -// Minimum Value macro -// -#ifndef MIN -#define MIN(X, Y) (((X) < (Y)) ? (X) : (Y)) -#endif -// -// Absolute Value Macro -// -#define ABS(X) (((X) < 0) ? (-(X)) : (X)) - - +#include <stdlib.h> /*---------------------------------------------------------------------------- * TYPEDEFS, STRUCTURES, ENUMS diff --git a/src/vendorcode/amd/agesa/f14/Proc/GNB/Common/Gnb.h b/src/vendorcode/amd/agesa/f14/Proc/GNB/Common/Gnb.h index 8f5c179..5aa574e 100644 --- a/src/vendorcode/amd/agesa/f14/Proc/GNB/Common/Gnb.h +++ b/src/vendorcode/amd/agesa/f14/Proc/GNB/Common/Gnb.h @@ -46,6 +46,7 @@ #ifndef _GNB_H_ #define _GNB_H_ +#include <stdlib.h> #define GNB_DEADLOOP() \ { \ @@ -69,14 +70,6 @@ #endif #endif -#ifndef MIN -#define MIN(x, y) (((x) > (y))? (y):(x)) -#endif - -#ifndef MAX -#define MAX(x, y) (((x) > (y))? (x):(y)) -#endif - #define OFF 0 #define GnbLibGetHeader(x) ((AMD_CONFIG_PARAMS*) (x)->StdHeader) diff --git a/src/vendorcode/amd/agesa/f14/Proc/Mem/mu.h b/src/vendorcode/amd/agesa/f14/Proc/Mem/mu.h index 2a9067d..23925b2 100644 --- a/src/vendorcode/amd/agesa/f14/Proc/Mem/mu.h +++ b/src/vendorcode/amd/agesa/f14/Proc/Mem/mu.h @@ -62,20 +62,7 @@ #define PSO_ENTRY UINT8 #endif -// -// Maximum value macro -// -#define MAX(X, Y) (((X) < (Y)) ? (Y) : (X)) -// -// Minimum Value macro -// -#define MIN(X, Y) (((X) < (Y)) ? (X) : (Y)) -// -// Absolute Value Macro -// -#define ABS(X) (((X) < 0) ? (-(X)) : (X)) - - +#include <stdlib.h> /*---------------------------------------------------------------------------- * TYPEDEFS, STRUCTURES, ENUMS diff --git a/src/vendorcode/amd/agesa/f15/Proc/Mem/mu.h b/src/vendorcode/amd/agesa/f15/Proc/Mem/mu.h index 20d369b..c68f321 100644 --- a/src/vendorcode/amd/agesa/f15/Proc/Mem/mu.h +++ b/src/vendorcode/amd/agesa/f15/Proc/Mem/mu.h @@ -61,20 +61,7 @@ #define PSO_ENTRY UINT8 #endif -// -// Maximum value macro -// -#define MAX(X, Y) (((X) < (Y)) ? (Y) : (X)) -// -// Minimum Value macro -// -#define MIN(X, Y) (((X) < (Y)) ? (X) : (Y)) -// -// Absolute Value Macro -// -#define ABS(X) (((X) < 0) ? (-(X)) : (X)) - - +#include <stdlib.h> /*---------------------------------------------------------------------------- * TYPEDEFS, STRUCTURES, ENUMS diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Common/Gnb.h b/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Common/Gnb.h index 1a239bd..b93e164 100644 --- a/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Common/Gnb.h +++ b/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Common/Gnb.h @@ -45,6 +45,8 @@ #ifndef _GNB_H_ #define _GNB_H_ +#include <stdlib.h> + #pragma pack (push, 1) #define GNB_DEADLOOP() \ @@ -69,14 +71,6 @@ #endif #endif -#ifndef MIN - #define MIN(x, y) (((x) > (y))? (y):(x)) -#endif - -#ifndef MAX - #define MAX(x, y) (((x) > (y))? (x):(y)) -#endif - #define OFF 0 #define PVOID UINT64 diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/Mem/mu.h b/src/vendorcode/amd/agesa/f15tn/Proc/Mem/mu.h index 2933453..2c6941d 100644 --- a/src/vendorcode/amd/agesa/f15tn/Proc/Mem/mu.h +++ b/src/vendorcode/amd/agesa/f15tn/Proc/Mem/mu.h @@ -60,33 +60,7 @@ #define PSO_ENTRY UINT8 #endif -// -// Maximum value macro -// -#ifndef MAX - #define MAX(X, Y) (((X) < (Y)) ? (Y) : (X)) -#endif -// -// Minimum Value macro -// -#ifndef MIN - #define MIN(X, Y) (((X) < (Y)) ? (X) : (Y)) -#endif -// -// Absolute Value Macro -// -#ifndef ABS - #define ABS(X) (((X) < 0) ? (-(X)) : (X)) -#endif -// -// Taking ceiling of (a / b) -// -#define CEIL_DIV(a, b) (((a) + (b) - 1) / (b)) -// -// Check if value x is a power of 2 or not -// -#define IS_POWER_OF_2(x) (((x) & ((x) - 1)) == 0) - +#include <stdlib.h> /*---------------------------------------------------------------------------- * TYPEDEFS, STRUCTURES, ENUMS diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Common/Gnb.h b/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Common/Gnb.h index 100ae03..c01fd5e 100644 --- a/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Common/Gnb.h +++ b/src/vendorcode/amd/agesa/f16kb/Proc/GNB/Common/Gnb.h @@ -45,6 +45,8 @@ #ifndef _GNB_H_ #define _GNB_H_ +#include <stdlib.h> + #include "Ids.h" #pragma pack (push, 1) @@ -71,14 +73,6 @@ #endif #endif -#ifndef MIN - #define MIN(x, y) (((x) > (y))? (y):(x)) -#endif - -#ifndef MAX - #define MAX(x, y) (((x) > (y))? (x):(y)) -#endif - #define OFF 0 #define PVOID UINT32 diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h b/src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h index 1489fe8..f415e52 100644 --- a/src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h +++ b/src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h @@ -60,36 +60,7 @@ #define PSO_ENTRY UINT8 #endif -// -// Maximum value macro -// -#ifndef MAX - #define MAX(X, Y) (((X) < (Y)) ? (Y) : (X)) -#endif -// -// Minimum Value macro -// -#ifndef MIN - #define MIN(X, Y) (((X) < (Y)) ? (X) : (Y)) -#endif -// -// Absolute Value Macro -// -#ifndef ABS - #define ABS(X) (((X) < 0) ? (-(X)) : (X)) -#endif -// -// Taking ceiling of (a / b) -// -#ifndef CEIL_DIV - #define CEIL_DIV(a, b) (((a) + (b) - 1) / (b)) -#endif -// -// Check if value x is a power of 2 or not -// -#ifndef IS_POWER_OF_2 - #define IS_POWER_OF_2(x) (((x) & ((x) - 1)) == 0) -#endif +#include <stdlib.h> // // Find offset of a member variable in a struct //

1 0

Patch set updated for coreboot: e94b118 mainboard: Make use of ARRAY_SIZE in buildOpts.c on AGESA platforms
by Edward O'Callaghan 07 Jul '14

07 Jul '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6195 -gerrit commit e94b11877e2bb7078b6a1d97ec9f0a1a5f1f4b87 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Jul 7 19:58:53 2014 +1000 mainboard: Make use of ARRAY_SIZE in buildOpts.c on AGESA platforms Found using coccinelle. Change-Id: I406de6cfe25d3b471dbb6f98d9c62addae008de3 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/amd/dinar/buildOpts.c | 3 ++- src/mainboard/amd/inagua/buildOpts.c | 3 ++- src/mainboard/amd/olivehill/buildOpts.c | 3 ++- src/mainboard/amd/parmer/buildOpts.c | 3 ++- src/mainboard/amd/persimmon/buildOpts.c | 3 ++- src/mainboard/amd/south_station/buildOpts.c | 3 ++- src/mainboard/amd/thatcher/buildOpts.c | 3 ++- src/mainboard/amd/torpedo/buildOpts.c | 4 +++- src/mainboard/amd/union_station/buildOpts.c | 3 ++- src/mainboard/asrock/e350m1/buildOpts.c | 3 ++- src/mainboard/asrock/imb-a180/buildOpts.c | 3 ++- src/mainboard/asus/f2a85-m/buildOpts.c | 4 +++- src/mainboard/gizmosphere/gizmo/buildOpts.c | 4 +++- src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c | 4 +++- src/mainboard/jetway/nf81-t56n-lf/buildOpts.c | 4 +++- src/mainboard/lippert/frontrunner-af/buildOpts.c | 4 +++- src/mainboard/lippert/toucan-af/buildOpts.c | 4 +++- src/mainboard/supermicro/h8qgi/buildOpts.c | 4 +++- src/mainboard/supermicro/h8scm/buildOpts.c | 4 +++- src/mainboard/tyan/s8226/buildOpts.c | 4 +++- 20 files changed, 50 insertions(+), 20 deletions(-) diff --git a/src/mainboard/amd/dinar/buildOpts.c b/src/mainboard/amd/dinar/buildOpts.c index 41f5415..7b874f6 100644 --- a/src/mainboard/amd/dinar/buildOpts.c +++ b/src/mainboard/amd/dinar/buildOpts.c @@ -32,6 +32,7 @@ * @e sub-project: Core * @e \$Revision: 6049 $ @e \$Date: 2008-05-14 01:58:02 -0500 (Wed, 14 May 2008) $ */ +#include <stdlib.h> #include "AGESA.h" #include "CommonReturns.h" #include "Filecode.h" @@ -523,7 +524,7 @@ UINT8 AGESA_MEM_TABLE_HY[][sizeof(MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableHy = sizeof (AGESA_MEM_TABLE_HY) / sizeof (AGESA_MEM_TABLE_HY[0]); +UINT8 SizeOfTableHy = ARRAY_SIZE(AGESA_MEM_TABLE_HY); /* *************************************************************************** * Optional User code to be included into the AGESA build * These may be 32-bit call-out routines... diff --git a/src/mainboard/amd/inagua/buildOpts.c b/src/mainboard/amd/inagua/buildOpts.c index 8a93f09..5779ccd 100644 --- a/src/mainboard/amd/inagua/buildOpts.c +++ b/src/mainboard/amd/inagua/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "Filecode.h" #define FILECODE PLATFORM_SPECIFIC_OPTIONS_FILECODE @@ -439,7 +440,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/amd/olivehill/buildOpts.c b/src/mainboard/amd/olivehill/buildOpts.c index ae7f5e9..98151a2 100644 --- a/src/mainboard/amd/olivehill/buildOpts.c +++ b/src/mainboard/amd/olivehill/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "AGESA.h" //#include "CommonReturns.h" #include "Filecode.h" @@ -503,4 +504,4 @@ UINT8 AGESA_MEM_TABLE_TN[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableTN = sizeof (AGESA_MEM_TABLE_TN) / sizeof (AGESA_MEM_TABLE_TN[0]); +UINT8 SizeOfTableTN = ARRAY_SIZE(AGESA_MEM_TABLE_TN); diff --git a/src/mainboard/amd/parmer/buildOpts.c b/src/mainboard/amd/parmer/buildOpts.c index 1a23190..3db1e47 100644 --- a/src/mainboard/amd/parmer/buildOpts.c +++ b/src/mainboard/amd/parmer/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "AGESA.h" //#include "CommonReturns.h" #include "Filecode.h" @@ -496,4 +497,4 @@ UINT8 AGESA_MEM_TABLE_TN[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableTN = sizeof (AGESA_MEM_TABLE_TN) / sizeof (AGESA_MEM_TABLE_TN[0]); +UINT8 SizeOfTableTN = ARRAY_SIZE(AGESA_MEM_TABLE_TN); diff --git a/src/mainboard/amd/persimmon/buildOpts.c b/src/mainboard/amd/persimmon/buildOpts.c index c6383a2..18bc1b0 100644 --- a/src/mainboard/amd/persimmon/buildOpts.c +++ b/src/mainboard/amd/persimmon/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "Filecode.h" #define FILECODE PLATFORM_SPECIFIC_OPTIONS_FILECODE @@ -439,7 +440,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/amd/south_station/buildOpts.c b/src/mainboard/amd/south_station/buildOpts.c index 87f9b88..3cc16e3 100644 --- a/src/mainboard/amd/south_station/buildOpts.c +++ b/src/mainboard/amd/south_station/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "Filecode.h" #define FILECODE PLATFORM_SPECIFIC_OPTIONS_FILECODE @@ -439,7 +440,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/amd/thatcher/buildOpts.c b/src/mainboard/amd/thatcher/buildOpts.c index 87f0460..bc2ff12 100644 --- a/src/mainboard/amd/thatcher/buildOpts.c +++ b/src/mainboard/amd/thatcher/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "AGESA.h" //#include "CommonReturns.h" #include "Filecode.h" @@ -496,7 +497,7 @@ UINT8 AGESA_MEM_TABLE_TN[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableTN = sizeof (AGESA_MEM_TABLE_TN) / sizeof (AGESA_MEM_TABLE_TN[0]); +UINT8 SizeOfTableTN = ARRAY_SIZE(AGESA_MEM_TABLE_TN); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/amd/torpedo/buildOpts.c b/src/mainboard/amd/torpedo/buildOpts.c index 91718ed..f9cfa0a 100644 --- a/src/mainboard/amd/torpedo/buildOpts.c +++ b/src/mainboard/amd/torpedo/buildOpts.c @@ -32,6 +32,8 @@ * @e sub-project: Core * @e \$Revision: 6049 $ @e \$Date: 2008-05-14 01:58:02 -0500 (Wed, 14 May 2008) $ */ + +#include <stdlib.h> #include "AGESA.h" #include "CommonReturns.h" #include "Filecode.h" @@ -368,7 +370,7 @@ UINT8 AGESA_MEM_TABLE_LN[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableLN = sizeof (AGESA_MEM_TABLE_LN) / sizeof (AGESA_MEM_TABLE_LN[0]); +UINT8 SizeOfTableLN = ARRAY_SIZE(AGESA_MEM_TABLE_LN); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/amd/union_station/buildOpts.c b/src/mainboard/amd/union_station/buildOpts.c index 87f9b88..3cc16e3 100644 --- a/src/mainboard/amd/union_station/buildOpts.c +++ b/src/mainboard/amd/union_station/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "Filecode.h" #define FILECODE PLATFORM_SPECIFIC_OPTIONS_FILECODE @@ -439,7 +440,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/asrock/e350m1/buildOpts.c b/src/mainboard/asrock/e350m1/buildOpts.c index 19ba4f3..453d610 100644 --- a/src/mainboard/asrock/e350m1/buildOpts.c +++ b/src/mainboard/asrock/e350m1/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "AGESA.h" #include "CommonReturns.h" #include "Filecode.h" @@ -439,7 +440,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/asrock/imb-a180/buildOpts.c b/src/mainboard/asrock/imb-a180/buildOpts.c index 7c57183..520da8b 100644 --- a/src/mainboard/asrock/imb-a180/buildOpts.c +++ b/src/mainboard/asrock/imb-a180/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "AGESA.h" //#include "CommonReturns.h" #include "Filecode.h" @@ -503,4 +504,4 @@ UINT8 AGESA_MEM_TABLE_TN[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableTN = sizeof (AGESA_MEM_TABLE_TN) / sizeof (AGESA_MEM_TABLE_TN[0]); +UINT8 SizeOfTableTN = ARRAY_SIZE(AGESA_MEM_TABLE_TN); diff --git a/src/mainboard/asus/f2a85-m/buildOpts.c b/src/mainboard/asus/f2a85-m/buildOpts.c index 0c6b657..cd1c812 100644 --- a/src/mainboard/asus/f2a85-m/buildOpts.c +++ b/src/mainboard/asus/f2a85-m/buildOpts.c @@ -33,6 +33,8 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> + #include <vendorcode/amd/agesa/f15tn/AGESA.h> /* Include the files that instantiate the configuration definitions. */ @@ -492,7 +494,7 @@ UINT8 AGESA_MEM_TABLE_TN[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableTN = sizeof (AGESA_MEM_TABLE_TN) / sizeof (AGESA_MEM_TABLE_TN[0]); +UINT8 SizeOfTableTN = ARRAY_SIZE(AGESA_MEM_TABLE_TN); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/gizmosphere/gizmo/buildOpts.c b/src/mainboard/gizmosphere/gizmo/buildOpts.c index ba9a350..4a8fbc6 100755 --- a/src/mainboard/gizmosphere/gizmo/buildOpts.c +++ b/src/mainboard/gizmosphere/gizmo/buildOpts.c @@ -34,6 +34,8 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> + #include "Filecode.h" #define FILECODE PLATFORM_SPECIFIC_OPTIONS_FILECODE @@ -451,7 +453,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c b/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c index df0f8fd..bfd6383 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c +++ b/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c @@ -35,6 +35,8 @@ #include "mainboard.h" +#include <stdlib.h> + #include <vendorcode/amd/agesa/f15tn/AGESA.h> /* Include the files that instantiate the configuration definitions. */ @@ -437,4 +439,4 @@ UINT8 AGESA_MEM_TABLE_TN[][sizeof (MEM_TABLE_ALIAS)] = { NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableTN = sizeof (AGESA_MEM_TABLE_TN) / sizeof (AGESA_MEM_TABLE_TN[0]); +UINT8 SizeOfTableTN = ARRAY_SIZE(AGESA_MEM_TABLE_TN); diff --git a/src/mainboard/jetway/nf81-t56n-lf/buildOpts.c b/src/mainboard/jetway/nf81-t56n-lf/buildOpts.c index 7cf274e..8d8bbec 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/buildOpts.c +++ b/src/mainboard/jetway/nf81-t56n-lf/buildOpts.c @@ -33,6 +33,8 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> + #include <vendorcode/amd/agesa/f14/AGESA.h> /* Include the files that instantiate the configuration definitions. */ @@ -342,4 +344,4 @@ const uint8_t AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = { NBACCESS (MTEnd, 0, 0, 0, 0, 0), /* End of Table */ }; -const uint8_t SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +const uint8_t SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); diff --git a/src/mainboard/lippert/frontrunner-af/buildOpts.c b/src/mainboard/lippert/frontrunner-af/buildOpts.c index 45ffac6..10d7611 100644 --- a/src/mainboard/lippert/frontrunner-af/buildOpts.c +++ b/src/mainboard/lippert/frontrunner-af/buildOpts.c @@ -33,6 +33,8 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> + #include "Filecode.h" #define FILECODE PLATFORM_SPECIFIC_OPTIONS_FILECODE @@ -440,7 +442,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/lippert/toucan-af/buildOpts.c b/src/mainboard/lippert/toucan-af/buildOpts.c index 45ffac6..10d7611 100644 --- a/src/mainboard/lippert/toucan-af/buildOpts.c +++ b/src/mainboard/lippert/toucan-af/buildOpts.c @@ -33,6 +33,8 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> + #include "Filecode.h" #define FILECODE PLATFORM_SPECIFIC_OPTIONS_FILECODE @@ -440,7 +442,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/supermicro/h8qgi/buildOpts.c b/src/mainboard/supermicro/h8qgi/buildOpts.c index 7584e4f..9b82a5f 100644 --- a/src/mainboard/supermicro/h8qgi/buildOpts.c +++ b/src/mainboard/supermicro/h8qgi/buildOpts.c @@ -17,6 +17,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <stdlib.h> + #include "AGESA.h" #include "CommonReturns.h" #include "AdvancedApi.h" @@ -612,5 +614,5 @@ UINT8 AGESA_MEM_TABLE_HY[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableHy = sizeof (AGESA_MEM_TABLE_HY) / sizeof (AGESA_MEM_TABLE_HY[0]); +UINT8 SizeOfTableHy = ARRAY_SIZE(AGESA_MEM_TABLE_HY); diff --git a/src/mainboard/supermicro/h8scm/buildOpts.c b/src/mainboard/supermicro/h8scm/buildOpts.c index 4cc4c0e..6ca0a41 100644 --- a/src/mainboard/supermicro/h8scm/buildOpts.c +++ b/src/mainboard/supermicro/h8scm/buildOpts.c @@ -17,6 +17,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <stdlib.h> + #include "AGESA.h" #include "CommonReturns.h" #include "AdvancedApi.h" @@ -516,5 +518,5 @@ UINT8 AGESA_MEM_TABLE_HY[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableHy = sizeof (AGESA_MEM_TABLE_HY) / sizeof (AGESA_MEM_TABLE_HY[0]); +UINT8 SizeOfTableHy = ARRAY_SIZE(AGESA_MEM_TABLE_HY); diff --git a/src/mainboard/tyan/s8226/buildOpts.c b/src/mainboard/tyan/s8226/buildOpts.c index bb4dd2d..ec418fd 100644 --- a/src/mainboard/tyan/s8226/buildOpts.c +++ b/src/mainboard/tyan/s8226/buildOpts.c @@ -17,6 +17,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <stdlib.h> + #include "AGESA.h" #include "CommonReturns.h" #include "AdvancedApi.h" @@ -612,5 +614,5 @@ UINT8 AGESA_MEM_TABLE_HY[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableHy = sizeof (AGESA_MEM_TABLE_HY) / sizeof (AGESA_MEM_TABLE_HY[0]); +UINT8 SizeOfTableHy = ARRAY_SIZE(AGESA_MEM_TABLE_HY);

1 0

New patch to review for coreboot: 5e07b0f vendorcode/amd/agesa: Use macros already defined in stdlib.h
by Edward O'Callaghan 07 Jul '14

07 Jul '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6199 -gerrit commit 5e07b0f3c69827aa8db097cb4acb568bb99f2af9 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Jul 7 21:08:23 2014 +1000 vendorcode/amd/agesa: Use macros already defined in stdlib.h We already have these macros define in 'stdlib.h'. Make good use of them here to avoid redefinition conflicts of the pre-processor depending on header inclusion ordering. This has the nice side-effect of syncing up AGESA families in this particular regard. Change-Id: Icf911629a4a1a82b01062fe16af4c8f812b05717 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/vendorcode/amd/agesa/f10/Proc/Mem/mu.h | 2 +- src/vendorcode/amd/agesa/f14/Proc/Mem/mu.h | 15 +------------- src/vendorcode/amd/agesa/f15/Proc/Mem/mu.h | 15 +------------- src/vendorcode/amd/agesa/f15tn/Proc/Mem/mu.h | 28 +------------------------ src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h | 31 +--------------------------- 5 files changed, 5 insertions(+), 86 deletions(-) diff --git a/src/vendorcode/amd/agesa/f10/Proc/Mem/mu.h b/src/vendorcode/amd/agesa/f10/Proc/Mem/mu.h index fc19314..9c4ad01 100644 --- a/src/vendorcode/amd/agesa/f10/Proc/Mem/mu.h +++ b/src/vendorcode/amd/agesa/f10/Proc/Mem/mu.h @@ -60,7 +60,7 @@ #define PSO_ENTRY UINT8 #endif -#define MAX(X, Y) (((X) < (Y)) ? (Y) : (X)) +#include <stdlib.h> /*---------------------------------------------------------------------------- * TYPEDEFS, STRUCTURES, ENUMS diff --git a/src/vendorcode/amd/agesa/f14/Proc/Mem/mu.h b/src/vendorcode/amd/agesa/f14/Proc/Mem/mu.h index 2a9067d..23925b2 100644 --- a/src/vendorcode/amd/agesa/f14/Proc/Mem/mu.h +++ b/src/vendorcode/amd/agesa/f14/Proc/Mem/mu.h @@ -62,20 +62,7 @@ #define PSO_ENTRY UINT8 #endif -// -// Maximum value macro -// -#define MAX(X, Y) (((X) < (Y)) ? (Y) : (X)) -// -// Minimum Value macro -// -#define MIN(X, Y) (((X) < (Y)) ? (X) : (Y)) -// -// Absolute Value Macro -// -#define ABS(X) (((X) < 0) ? (-(X)) : (X)) - - +#include <stdlib.h> /*---------------------------------------------------------------------------- * TYPEDEFS, STRUCTURES, ENUMS diff --git a/src/vendorcode/amd/agesa/f15/Proc/Mem/mu.h b/src/vendorcode/amd/agesa/f15/Proc/Mem/mu.h index 20d369b..c68f321 100644 --- a/src/vendorcode/amd/agesa/f15/Proc/Mem/mu.h +++ b/src/vendorcode/amd/agesa/f15/Proc/Mem/mu.h @@ -61,20 +61,7 @@ #define PSO_ENTRY UINT8 #endif -// -// Maximum value macro -// -#define MAX(X, Y) (((X) < (Y)) ? (Y) : (X)) -// -// Minimum Value macro -// -#define MIN(X, Y) (((X) < (Y)) ? (X) : (Y)) -// -// Absolute Value Macro -// -#define ABS(X) (((X) < 0) ? (-(X)) : (X)) - - +#include <stdlib.h> /*---------------------------------------------------------------------------- * TYPEDEFS, STRUCTURES, ENUMS diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/Mem/mu.h b/src/vendorcode/amd/agesa/f15tn/Proc/Mem/mu.h index 2933453..2c6941d 100644 --- a/src/vendorcode/amd/agesa/f15tn/Proc/Mem/mu.h +++ b/src/vendorcode/amd/agesa/f15tn/Proc/Mem/mu.h @@ -60,33 +60,7 @@ #define PSO_ENTRY UINT8 #endif -// -// Maximum value macro -// -#ifndef MAX - #define MAX(X, Y) (((X) < (Y)) ? (Y) : (X)) -#endif -// -// Minimum Value macro -// -#ifndef MIN - #define MIN(X, Y) (((X) < (Y)) ? (X) : (Y)) -#endif -// -// Absolute Value Macro -// -#ifndef ABS - #define ABS(X) (((X) < 0) ? (-(X)) : (X)) -#endif -// -// Taking ceiling of (a / b) -// -#define CEIL_DIV(a, b) (((a) + (b) - 1) / (b)) -// -// Check if value x is a power of 2 or not -// -#define IS_POWER_OF_2(x) (((x) & ((x) - 1)) == 0) - +#include <stdlib.h> /*---------------------------------------------------------------------------- * TYPEDEFS, STRUCTURES, ENUMS diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h b/src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h index 1489fe8..f415e52 100644 --- a/src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h +++ b/src/vendorcode/amd/agesa/f16kb/Proc/Mem/mu.h @@ -60,36 +60,7 @@ #define PSO_ENTRY UINT8 #endif -// -// Maximum value macro -// -#ifndef MAX - #define MAX(X, Y) (((X) < (Y)) ? (Y) : (X)) -#endif -// -// Minimum Value macro -// -#ifndef MIN - #define MIN(X, Y) (((X) < (Y)) ? (X) : (Y)) -#endif -// -// Absolute Value Macro -// -#ifndef ABS - #define ABS(X) (((X) < 0) ? (-(X)) : (X)) -#endif -// -// Taking ceiling of (a / b) -// -#ifndef CEIL_DIV - #define CEIL_DIV(a, b) (((a) + (b) - 1) / (b)) -#endif -// -// Check if value x is a power of 2 or not -// -#ifndef IS_POWER_OF_2 - #define IS_POWER_OF_2(x) (((x) & ((x) - 1)) == 0) -#endif +#include <stdlib.h> // // Find offset of a member variable in a struct //

1 0

New patch to review for coreboot: 4e285eb include/stdlib.h: Extend common macro collection
by Edward O'Callaghan 07 Jul '14

07 Jul '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6198 -gerrit commit 4e285ebbd3c301fc85fda0d6ac122b28c2cba574 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Jul 7 20:33:09 2014 +1000 include/stdlib.h: Extend common macro collection Add the following useful macros: * Absolute Value Macro * Taking ceiling of (a / b) * Check if value x is a power of 2 or not Change-Id: I4e9a326aea3cdd963f13548d1fb63331a57d84b1 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/include/stdlib.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/include/stdlib.h b/src/include/stdlib.h index 44d7c01..9bc0ebc 100644 --- a/src/include/stdlib.h +++ b/src/include/stdlib.h @@ -12,6 +12,9 @@ #define MIN(a,b) ((a) < (b) ? (a) : (b)) #define MAX(a,b) ((a) > (b) ? (a) : (b)) +#define ABS(a) (((a) < 0) ? (-(a)) : (a)) +#define CEIL_DIV(a, b) (((a) + (b) - 1) / (b)) +#define IS_POWER_OF_2(x) (((x) & ((x) - 1)) == 0) #define min(a,b) MIN((a),(b)) #define max(a,b) MAX((a),(b))

1 0

New patch to review for coreboot: 4260dcf build system: prevent race on more tool binaries
by Patrick Georgi 07 Jul '14

07 Jul '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6197 -gerrit commit 4260dcf589fbbaf91ea3f39ef923e12367c92f54 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Mon Jul 7 12:25:30 2014 +0200 build system: prevent race on more tool binaries ifdfake is the newest tool addition that leads to build time races on highly parallel builds. Change-Id: I86289e50079da851dcc8e1c05c2536d5c03de87c Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.inc b/Makefile.inc index a6a8cbe..5e4c5c5 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -404,7 +404,7 @@ crosstools-arm: clean-for-update crossgcc-clean: clean-for-update $(MAKE) -C util/crossgcc clean -tools: $(objutil)/kconfig/conf $(objutil)/cbfstool/cbfstool $(objutil)/cbfstool/rmodtool $(objutil)/nvramtool/nvramtool $(objutil)/romcc/romcc $(objutil)/sconfig/sconfig +tools: $(objutil)/kconfig/conf $(objutil)/cbfstool/cbfstool $(objutil)/cbfstool/rmodtool $(objutil)/nvramtool/nvramtool $(ROMCC_BIN) $(objutil)/sconfig/sconfig $(IFDTOOL) $(IFDFAKE) ########################################################################### # Common recipes for all stages

1 0

Patch set updated for coreboot: 8818714 mainboard: Make use of ARRAY_SIZE in buildOpts.c on AGESA platforms
by Edward O'Callaghan 07 Jul '14

07 Jul '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6195 -gerrit commit 88187147c84d3e5323e645c07ba35779a76ab31f Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Jul 7 19:58:53 2014 +1000 mainboard: Make use of ARRAY_SIZE in buildOpts.c on AGESA platforms Found using coccinelle. Change-Id: I406de6cfe25d3b471dbb6f98d9c62addae008de3 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/amd/dinar/buildOpts.c | 3 ++- src/mainboard/amd/inagua/buildOpts.c | 3 ++- src/mainboard/amd/olivehill/buildOpts.c | 3 ++- src/mainboard/amd/parmer/buildOpts.c | 3 ++- src/mainboard/amd/persimmon/buildOpts.c | 3 ++- src/mainboard/amd/south_station/buildOpts.c | 3 ++- src/mainboard/amd/thatcher/buildOpts.c | 3 ++- src/mainboard/amd/torpedo/buildOpts.c | 4 +++- src/mainboard/amd/union_station/buildOpts.c | 3 ++- src/mainboard/asrock/e350m1/buildOpts.c | 3 ++- src/mainboard/asrock/imb-a180/buildOpts.c | 3 ++- src/mainboard/asus/f2a85-m/buildOpts.c | 4 +++- src/mainboard/gizmosphere/gizmo/buildOpts.c | 4 +++- src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c | 4 +++- src/mainboard/jetway/nf81-t56n-lf/buildOpts.c | 4 +++- src/mainboard/lippert/frontrunner-af/buildOpts.c | 4 +++- src/mainboard/lippert/toucan-af/buildOpts.c | 4 +++- src/mainboard/supermicro/h8qgi/buildOpts.c | 4 +++- src/mainboard/supermicro/h8scm/buildOpts.c | 4 +++- src/mainboard/tyan/s8226/buildOpts.c | 4 +++- 20 files changed, 50 insertions(+), 20 deletions(-) diff --git a/src/mainboard/amd/dinar/buildOpts.c b/src/mainboard/amd/dinar/buildOpts.c index 41f5415..7b874f6 100644 --- a/src/mainboard/amd/dinar/buildOpts.c +++ b/src/mainboard/amd/dinar/buildOpts.c @@ -32,6 +32,7 @@ * @e sub-project: Core * @e \$Revision: 6049 $ @e \$Date: 2008-05-14 01:58:02 -0500 (Wed, 14 May 2008) $ */ +#include <stdlib.h> #include "AGESA.h" #include "CommonReturns.h" #include "Filecode.h" @@ -523,7 +524,7 @@ UINT8 AGESA_MEM_TABLE_HY[][sizeof(MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableHy = sizeof (AGESA_MEM_TABLE_HY) / sizeof (AGESA_MEM_TABLE_HY[0]); +UINT8 SizeOfTableHy = ARRAY_SIZE(AGESA_MEM_TABLE_HY); /* *************************************************************************** * Optional User code to be included into the AGESA build * These may be 32-bit call-out routines... diff --git a/src/mainboard/amd/inagua/buildOpts.c b/src/mainboard/amd/inagua/buildOpts.c index 8a93f09..5779ccd 100644 --- a/src/mainboard/amd/inagua/buildOpts.c +++ b/src/mainboard/amd/inagua/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "Filecode.h" #define FILECODE PLATFORM_SPECIFIC_OPTIONS_FILECODE @@ -439,7 +440,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/amd/olivehill/buildOpts.c b/src/mainboard/amd/olivehill/buildOpts.c index ae7f5e9..98151a2 100644 --- a/src/mainboard/amd/olivehill/buildOpts.c +++ b/src/mainboard/amd/olivehill/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "AGESA.h" //#include "CommonReturns.h" #include "Filecode.h" @@ -503,4 +504,4 @@ UINT8 AGESA_MEM_TABLE_TN[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableTN = sizeof (AGESA_MEM_TABLE_TN) / sizeof (AGESA_MEM_TABLE_TN[0]); +UINT8 SizeOfTableTN = ARRAY_SIZE(AGESA_MEM_TABLE_TN); diff --git a/src/mainboard/amd/parmer/buildOpts.c b/src/mainboard/amd/parmer/buildOpts.c index 1a23190..3db1e47 100644 --- a/src/mainboard/amd/parmer/buildOpts.c +++ b/src/mainboard/amd/parmer/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "AGESA.h" //#include "CommonReturns.h" #include "Filecode.h" @@ -496,4 +497,4 @@ UINT8 AGESA_MEM_TABLE_TN[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableTN = sizeof (AGESA_MEM_TABLE_TN) / sizeof (AGESA_MEM_TABLE_TN[0]); +UINT8 SizeOfTableTN = ARRAY_SIZE(AGESA_MEM_TABLE_TN); diff --git a/src/mainboard/amd/persimmon/buildOpts.c b/src/mainboard/amd/persimmon/buildOpts.c index c6383a2..18bc1b0 100644 --- a/src/mainboard/amd/persimmon/buildOpts.c +++ b/src/mainboard/amd/persimmon/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "Filecode.h" #define FILECODE PLATFORM_SPECIFIC_OPTIONS_FILECODE @@ -439,7 +440,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/amd/south_station/buildOpts.c b/src/mainboard/amd/south_station/buildOpts.c index 87f9b88..3cc16e3 100644 --- a/src/mainboard/amd/south_station/buildOpts.c +++ b/src/mainboard/amd/south_station/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "Filecode.h" #define FILECODE PLATFORM_SPECIFIC_OPTIONS_FILECODE @@ -439,7 +440,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/amd/thatcher/buildOpts.c b/src/mainboard/amd/thatcher/buildOpts.c index 87f0460..bc2ff12 100644 --- a/src/mainboard/amd/thatcher/buildOpts.c +++ b/src/mainboard/amd/thatcher/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "AGESA.h" //#include "CommonReturns.h" #include "Filecode.h" @@ -496,7 +497,7 @@ UINT8 AGESA_MEM_TABLE_TN[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableTN = sizeof (AGESA_MEM_TABLE_TN) / sizeof (AGESA_MEM_TABLE_TN[0]); +UINT8 SizeOfTableTN = ARRAY_SIZE(AGESA_MEM_TABLE_TN); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/amd/torpedo/buildOpts.c b/src/mainboard/amd/torpedo/buildOpts.c index 91718ed..f9cfa0a 100644 --- a/src/mainboard/amd/torpedo/buildOpts.c +++ b/src/mainboard/amd/torpedo/buildOpts.c @@ -32,6 +32,8 @@ * @e sub-project: Core * @e \$Revision: 6049 $ @e \$Date: 2008-05-14 01:58:02 -0500 (Wed, 14 May 2008) $ */ + +#include <stdlib.h> #include "AGESA.h" #include "CommonReturns.h" #include "Filecode.h" @@ -368,7 +370,7 @@ UINT8 AGESA_MEM_TABLE_LN[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableLN = sizeof (AGESA_MEM_TABLE_LN) / sizeof (AGESA_MEM_TABLE_LN[0]); +UINT8 SizeOfTableLN = ARRAY_SIZE(AGESA_MEM_TABLE_LN); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/amd/union_station/buildOpts.c b/src/mainboard/amd/union_station/buildOpts.c index 87f9b88..3cc16e3 100644 --- a/src/mainboard/amd/union_station/buildOpts.c +++ b/src/mainboard/amd/union_station/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "Filecode.h" #define FILECODE PLATFORM_SPECIFIC_OPTIONS_FILECODE @@ -439,7 +440,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/asrock/e350m1/buildOpts.c b/src/mainboard/asrock/e350m1/buildOpts.c index 19ba4f3..453d610 100644 --- a/src/mainboard/asrock/e350m1/buildOpts.c +++ b/src/mainboard/asrock/e350m1/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "AGESA.h" #include "CommonReturns.h" #include "Filecode.h" @@ -439,7 +440,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/asrock/imb-a180/buildOpts.c b/src/mainboard/asrock/imb-a180/buildOpts.c index 7c57183..520da8b 100644 --- a/src/mainboard/asrock/imb-a180/buildOpts.c +++ b/src/mainboard/asrock/imb-a180/buildOpts.c @@ -33,6 +33,7 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> #include "AGESA.h" //#include "CommonReturns.h" #include "Filecode.h" @@ -503,4 +504,4 @@ UINT8 AGESA_MEM_TABLE_TN[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableTN = sizeof (AGESA_MEM_TABLE_TN) / sizeof (AGESA_MEM_TABLE_TN[0]); +UINT8 SizeOfTableTN = ARRAY_SIZE(AGESA_MEM_TABLE_TN); diff --git a/src/mainboard/asus/f2a85-m/buildOpts.c b/src/mainboard/asus/f2a85-m/buildOpts.c index 0c6b657..cd1c812 100644 --- a/src/mainboard/asus/f2a85-m/buildOpts.c +++ b/src/mainboard/asus/f2a85-m/buildOpts.c @@ -33,6 +33,8 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> + #include <vendorcode/amd/agesa/f15tn/AGESA.h> /* Include the files that instantiate the configuration definitions. */ @@ -492,7 +494,7 @@ UINT8 AGESA_MEM_TABLE_TN[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableTN = sizeof (AGESA_MEM_TABLE_TN) / sizeof (AGESA_MEM_TABLE_TN[0]); +UINT8 SizeOfTableTN = ARRAY_SIZE(AGESA_MEM_TABLE_TN); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/gizmosphere/gizmo/buildOpts.c b/src/mainboard/gizmosphere/gizmo/buildOpts.c index ba9a350..4a8fbc6 100755 --- a/src/mainboard/gizmosphere/gizmo/buildOpts.c +++ b/src/mainboard/gizmosphere/gizmo/buildOpts.c @@ -34,6 +34,8 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> + #include "Filecode.h" #define FILECODE PLATFORM_SPECIFIC_OPTIONS_FILECODE @@ -451,7 +453,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c b/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c index df0f8fd..bfd6383 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c +++ b/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c @@ -35,6 +35,8 @@ #include "mainboard.h" +#include <stdlib.h> + #include <vendorcode/amd/agesa/f15tn/AGESA.h> /* Include the files that instantiate the configuration definitions. */ @@ -437,4 +439,4 @@ UINT8 AGESA_MEM_TABLE_TN[][sizeof (MEM_TABLE_ALIAS)] = { NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableTN = sizeof (AGESA_MEM_TABLE_TN) / sizeof (AGESA_MEM_TABLE_TN[0]); +UINT8 SizeOfTableTN = ARRAY_SIZE(AGESA_MEM_TABLE_TN); diff --git a/src/mainboard/jetway/nf81-t56n-lf/buildOpts.c b/src/mainboard/jetway/nf81-t56n-lf/buildOpts.c index 7cf274e..8d8bbec 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/buildOpts.c +++ b/src/mainboard/jetway/nf81-t56n-lf/buildOpts.c @@ -33,6 +33,8 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> + #include <vendorcode/amd/agesa/f14/AGESA.h> /* Include the files that instantiate the configuration definitions. */ @@ -342,4 +344,4 @@ const uint8_t AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = { NBACCESS (MTEnd, 0, 0, 0, 0, 0), /* End of Table */ }; -const uint8_t SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +const uint8_t SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); diff --git a/src/mainboard/lippert/frontrunner-af/buildOpts.c b/src/mainboard/lippert/frontrunner-af/buildOpts.c index 45ffac6..10d7611 100644 --- a/src/mainboard/lippert/frontrunner-af/buildOpts.c +++ b/src/mainboard/lippert/frontrunner-af/buildOpts.c @@ -33,6 +33,8 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> + #include "Filecode.h" #define FILECODE PLATFORM_SPECIFIC_OPTIONS_FILECODE @@ -440,7 +442,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/lippert/toucan-af/buildOpts.c b/src/mainboard/lippert/toucan-af/buildOpts.c index 45ffac6..10d7611 100644 --- a/src/mainboard/lippert/toucan-af/buildOpts.c +++ b/src/mainboard/lippert/toucan-af/buildOpts.c @@ -33,6 +33,8 @@ * @e \$Revision: 23714 $ @e \$Date: 2009-12-09 17:28:37 -0600 (Wed, 09 Dec 2009) $ */ +#include <stdlib.h> + #include "Filecode.h" #define FILECODE PLATFORM_SPECIFIC_OPTIONS_FILECODE @@ -440,7 +442,7 @@ CONST UINT8 AGESA_MEM_TABLE_ON[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -CONST UINT8 SizeOfTableON = sizeof (AGESA_MEM_TABLE_ON) / sizeof (AGESA_MEM_TABLE_ON[0]); +CONST UINT8 SizeOfTableON = ARRAY_SIZE(AGESA_MEM_TABLE_ON); /* *************************************************************************** * Optional User code to be included into the AGESA build diff --git a/src/mainboard/supermicro/h8qgi/buildOpts.c b/src/mainboard/supermicro/h8qgi/buildOpts.c index 7584e4f..9b82a5f 100644 --- a/src/mainboard/supermicro/h8qgi/buildOpts.c +++ b/src/mainboard/supermicro/h8qgi/buildOpts.c @@ -17,6 +17,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <stdlib.h> + #include "AGESA.h" #include "CommonReturns.h" #include "AdvancedApi.h" @@ -612,5 +614,5 @@ UINT8 AGESA_MEM_TABLE_HY[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableHy = sizeof (AGESA_MEM_TABLE_HY) / sizeof (AGESA_MEM_TABLE_HY[0]); +UINT8 SizeOfTableHy = ARRAY_SIZE(AGESA_MEM_TABLE_HY); diff --git a/src/mainboard/supermicro/h8scm/buildOpts.c b/src/mainboard/supermicro/h8scm/buildOpts.c index 4cc4c0e..6ca0a41 100644 --- a/src/mainboard/supermicro/h8scm/buildOpts.c +++ b/src/mainboard/supermicro/h8scm/buildOpts.c @@ -17,6 +17,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <stdlib.h> + #include "AGESA.h" #include "CommonReturns.h" #include "AdvancedApi.h" @@ -516,5 +518,5 @@ UINT8 AGESA_MEM_TABLE_HY[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableHy = sizeof (AGESA_MEM_TABLE_HY) / sizeof (AGESA_MEM_TABLE_HY[0]); +UINT8 SizeOfTableHy = ARRAY_SIZE(AGESA_MEM_TABLE_HY); diff --git a/src/mainboard/tyan/s8226/buildOpts.c b/src/mainboard/tyan/s8226/buildOpts.c index bb4dd2d..ec418fd 100644 --- a/src/mainboard/tyan/s8226/buildOpts.c +++ b/src/mainboard/tyan/s8226/buildOpts.c @@ -17,6 +17,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <stdlib.h> + #include "AGESA.h" #include "CommonReturns.h" #include "AdvancedApi.h" @@ -612,5 +614,5 @@ UINT8 AGESA_MEM_TABLE_HY[][sizeof (MEM_TABLE_ALIAS)] = // TABLE END NBACCESS (MTEnd, 0, 0, 0, 0, 0), // End of Table }; -UINT8 SizeOfTableHy = sizeof (AGESA_MEM_TABLE_HY) / sizeof (AGESA_MEM_TABLE_HY[0]); +UINT8 SizeOfTableHy = ARRAY_SIZE(AGESA_MEM_TABLE_HY);

1 0

New patch to review for coreboot: 0009269 drivers/intel/fsp/fsp_util: 'long unsigned int' is 'unsigned long'
by Edward O'Callaghan 07 Jul '14

07 Jul '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6196 -gerrit commit 0009269d0efd4c75865833c79abceb71db6c0f2e Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Jul 7 20:04:41 2014 +1000 drivers/intel/fsp/fsp_util: 'long unsigned int' is 'unsigned long' This is a bit of strange way to write 'unsigned long', fix that. Change-Id: I17caf971dac840e0f35f883dacfbd5c94d8c03d6 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/drivers/intel/fsp/fsp_util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/drivers/intel/fsp/fsp_util.c b/src/drivers/intel/fsp/fsp_util.c index 4e1db6b..a9b5624 100644 --- a/src/drivers/intel/fsp/fsp_util.c +++ b/src/drivers/intel/fsp/fsp_util.c @@ -226,7 +226,7 @@ static void print_hob_mem_attributes(void *Hobptr) { printk(BIOS_SPEW, " Memory type %s (0x%x)\n", Hobmemtypenames[(u32)Hobmemtype], (u32) Hobmemtype); printk(BIOS_SPEW, " at location 0x%0lx with length 0x%0lx\n", - (long unsigned int)Hobmemaddr, (long unsigned int)Hobmemlength); + (unsigned long)Hobmemaddr, (unsigned long)Hobmemlength); } static void print_hob_resource_attributes(void *Hobptr) { @@ -263,7 +263,7 @@ static void print_hob_resource_attributes(void *Hobptr) { printk(BIOS_SPEW, " Resource %s (0x%0x) has attributes 0x%0x\n", Hobrestypestr, Hobrestype, Hobresattr); printk(BIOS_SPEW, " at location 0x%0lx with length 0x%0lx\n", - (long unsigned int)Hobresaddr, (long unsigned int)Hobreslength); + (unsigned long)Hobresaddr, (unsigned long)Hobreslength); } static const char * get_hob_type_string(void *Hobptr) {

1 0

← Newer
1
...
66
67
68
69
70
71
72
...
87
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2014