Gerd Hoffmann (kraxel(a)redhat.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3501
-gerrit
commit 96b8d23b3a111ed5b8784fe0c23e632d41faf545
Author: Gerd Hoffmann <kraxel(a)redhat.com>
Date: Tue Jun 18 23:52:26 2013 +0200
edid: fix warning
src/lib/edid.c:1177: error: ‘y’ may be used uninitialized in this function
Warning is bogus, but seems my gcc (4.4.7 as shipped by RHEL-6)
isn't clever enougth to figure this on its own. So help a bit
by explicitly initializing the variable.
Change-Id: Ia9f966c9c0a6bd92a9f41f1a4a3c8e49f258be37
Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com>
---
src/lib/edid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/edid.c b/src/lib/edid.c
index 460d68d..a794489 100644
--- a/src/lib/edid.c
+++ b/src/lib/edid.c
@@ -1174,7 +1174,7 @@ int decode_edid(unsigned char *edid, int size, struct edid *out)
printk(BIOS_SPEW, "Standard timings supported:\n");
for (i = 0; i < 8; i++) {
uint8_t b1 = edid[0x26 + i * 2], b2 = edid[0x26 + i * 2 + 1];
- unsigned int x, y, refresh;
+ unsigned int x, y = 0, refresh;
if (b1 == 0x01 && b2 == 0x01)
continue;
Nico Huber (nico.huber(a)secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3498
-gerrit
commit a0cbb80bec2a0e0f646ba13cb56767450da26e40
Author: Nico Huber <nico.h(a)gmx.de>
Date: Tue Jun 18 22:36:34 2013 +0200
intel/i82801gx: Store initial timestamp
Upgrade the ICH7 bootblock to store an initial timestamp like we do it
since Sandy Brigde. I've checked the datasheets for the used scratchpad
registers and grepped for their usage. I'm pretty sure that they aren't
used on any ICH7 based board (for anything before the usual S3-resume
indication).
Change-Id: I28a9b90d3e6f6401a8114ecd240554a5dddc0eb5
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
src/southbridge/intel/i82801ix/bootblock.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/src/southbridge/intel/i82801ix/bootblock.c b/src/southbridge/intel/i82801ix/bootblock.c
index b352fca..04ab221 100644
--- a/src/southbridge/intel/i82801ix/bootblock.c
+++ b/src/southbridge/intel/i82801ix/bootblock.c
@@ -19,6 +19,17 @@
#include <arch/io.h>
+static void store_initial_timestamp(void)
+{
+ /* On i945/ICH7 we have two 32bit scratchpad registers available:
+ * D0:F0 0xdc (SKPAD)
+ * D31:F2 0xd0 (SATA SP)
+ */
+ tsc_t tsc = rdtsc();
+ pci_write_config32(PCI_DEV(0, 0x00, 0), 0xdc, tsc.lo);
+ pci_write_config32(PCI_DEV(0, 0x1f, 2), 0xd0, tsc.hi);
+}
+
static void enable_spi_prefetch(void)
{
u8 reg8;
@@ -34,6 +45,9 @@ static void enable_spi_prefetch(void)
static void bootblock_southbridge_init(void)
{
+#if CONFIG_COLLECT_TIMESTAMPS
+ store_initial_timestamp();
+#endif
enable_spi_prefetch();
}
the following patch was just integrated into master:
commit 354066e1179e2c3ca14c5b1216d3a565fb6da813
Author: Nico Huber <nico.huber(a)secunet.com>
Date: Mon Jun 17 17:42:35 2013 +0200
libpayload: ahci: Increase timeout for signature reading
We can't read the drives signature before it's ready, i.e. spun up.
So set the timeout to the standard 30s. Also put a notice on the
console, so the user knows why the signature reading failed.
Change-Id: I2148258f9b0eb950b71544dafd95776ae70afac8
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
Reviewed-on: http://review.coreboot.org/3493
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
Reviewed-by: Dave Frodin <dave.frodin(a)se-eng.com>
Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com>
See http://review.coreboot.org/3493 for details.
-gerrit
the following patch was just integrated into master:
commit cacc58a874092bbbd680cd636ed840c1844c84a1
Author: Nico Huber <nico.huber(a)secunet.com>
Date: Tue May 14 15:25:26 2013 +0200
winbond/w83627dhg: Correct resource setting for SPI (LDN6)
The SPI logical device on the W83627DHG uses the second i/o port
register pair but not the first one. So we have to also set `io1`
(the second io_info struct) and not `io0` in the pnp_info structure.
Setting the PNP_IO1 flag without a mask in `io1` caused coreboot to
hang in pnp_enable_devices() until commit aeead274 which added a
check for an unset mask.
Change-Id: I027d279b4641fecd88afb14d40fbe1c0bfbf81bb
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
Reviewed-on: http://review.coreboot.org/3391
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com>
See http://review.coreboot.org/3391 for details.
-gerrit
the following patch was just integrated into master:
commit df8d27357f7a23a2f840b3d2af7b67229c16e42b
Author: Gerd Hoffmann <kraxel(a)redhat.com>
Date: Tue Jun 18 11:09:29 2013 +0200
qemu/q35: uncomment cache-as-ram Kconfig entries
Change-Id: I8371764e3f2d16a3a776beb1c064f461b20a4262
Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com>
Reviewed-on: http://review.coreboot.org/3496
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com>
See http://review.coreboot.org/3496 for details.
-gerrit