May 2023 - SeaBIOS - mail.coreboot.org

[PATCH] ahci: handle TFES irq correctly
by Niklas Cassel July 7, 2023

July 7, 2023

According to AHCI 1.3.1, 5.3.8.1 RegFIS:Entry, if ERR_STAT is set in the received FIS, the HBA shall jump to state ERR:FatalTaskfile, which will raise a TFES IRQ. This means that if ERR_STAT is set in the recevied FIS, PxIS.TFES will be set, without either PxIS.DHRS or PxIS.PSS being set. SeaBIOS function ahci_port_setup() will try to identify an AHCI device by sending an ATAPI identify device command. However, such a command will be aborted with ERR_STAT set for a regular (non-ATAPI) device. ahci_command() already performs the correct error recovery steps when status is correctly set, so simply modify ahci_command() to read the correct status when PxIS.TFES is set. It is safe to read PxTFD when PxIS.TFES is set, even for systems with a port multiplier, see AHCI 1.3.1, 9.3.7 PxTFD Register Information: "When a taskfile error occurs (PxIS.TFES is set to '1'), the host may refer to the values in PxTFD. The values in PxTFD at this time are guaranteed to correspond to the device that reported the taskfile error condition." Without this, each boot will be delayed by 32 seconds, waiting for the AHCI command to timeout. Signed-off-by: Niklas Cassel <niklas.cassel(a)wdc.com> --- src/hw/ahci.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/hw/ahci.c b/src/hw/ahci.c index d45b430..3fa845a 100644 --- a/src/hw/ahci.c +++ b/src/hw/ahci.c @@ -138,6 +138,12 @@ static int ahci_command(struct ahci_port_s *port_gf, int iswrite, int isatapi, intbits = ahci_port_readl(ctrl, pnr, PORT_IRQ_STAT); if (intbits) { ahci_port_writel(ctrl, pnr, PORT_IRQ_STAT, intbits); + if (intbits & 0x40000000) { + u32 tf = ahci_port_readl(ctrl, pnr, PORT_TFDATA); + status = tf & 0xff; + error = (tf & 0xff00) >> 8; + break; + } if (intbits & 0x02) { status = GET_LOWFLAT(fis->psfis[2]); error = GET_LOWFLAT(fis->psfis[3]); -- 2.40.1

5 5

[PATCH] Fix high memory zone initialization in CSM mode
by José Martínez June 13, 2023

June 13, 2023

malloc_high() cannot allocate any memory in CSM mode due to an empty ZoneHigh. SeaBIOS cannot find any disk to boot from because device initialization fails. The bug was introduced in 1.16.1 (commit dc88f9b) when the meaning of BUILD_MAX_HIGHTABLE changed but CSM code was not updated. This patch reverts to the previous behavior by using BUILD_MIN_HIGHTABLE in CSM methods. Signed-off-by: José Martínez <xose(a)google.com> --- src/fw/csm.c | 4 ++-- src/malloc.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/fw/csm.c b/src/fw/csm.c index bc14a92..579debd 100644 --- a/src/fw/csm.c +++ b/src/fw/csm.c @@ -150,9 +150,9 @@ handle_csm_0002(struct bregs *regs) for (i=0; i < csm_compat_table.E820Length / sizeof(struct e820entry); i++) e820_add(p[i].start, p[i].size, p[i].type); - if (csm_init_table->HiPmmMemorySizeInBytes > BUILD_MAX_HIGHTABLE) { + if (csm_init_table->HiPmmMemorySizeInBytes > BUILD_MIN_HIGHTABLE) { u32 hi_pmm_end = csm_init_table->HiPmmMemory + csm_init_table->HiPmmMemorySizeInBytes; - e820_add(hi_pmm_end - BUILD_MAX_HIGHTABLE, BUILD_MAX_HIGHTABLE, E820_RESERVED); + e820_add(hi_pmm_end - BUILD_MIN_HIGHTABLE, BUILD_MIN_HIGHTABLE, E820_RESERVED); } // For PCIBIOS 1ab10e diff --git a/src/malloc.c b/src/malloc.c index da84098..30b2c92 100644 --- a/src/malloc.c +++ b/src/malloc.c @@ -460,10 +460,10 @@ malloc_csm_preinit(u32 low_pmm, u32 low_pmm_size, u32 hi_pmm, u32 hi_pmm_size) { ASSERT32FLAT(); - if (hi_pmm_size > BUILD_MAX_HIGHTABLE) { + if (hi_pmm_size > BUILD_MIN_HIGHTABLE) { u32 hi_pmm_end = hi_pmm + hi_pmm_size; - alloc_add(&ZoneTmpHigh, hi_pmm, hi_pmm_end - BUILD_MAX_HIGHTABLE); - alloc_add(&ZoneHigh, hi_pmm_end - BUILD_MAX_HIGHTABLE, hi_pmm_end); + alloc_add(&ZoneTmpHigh, hi_pmm, hi_pmm_end - BUILD_MIN_HIGHTABLE); + alloc_add(&ZoneHigh, hi_pmm_end - BUILD_MIN_HIGHTABLE, hi_pmm_end); } else { alloc_add(&ZoneTmpHigh, hi_pmm, hi_pmm + hi_pmm_size); } -- 2.40.1.606.ga4b1b128d6-goog

3 3

Need Easy Instructions For Installing SeaBIOS
by Ratchet Meister May 28, 2023

May 28, 2023

...on a Chromebook. I have an Acer c740 - C4Pe, and I have already removed the WP screw and swapped out the 16GB SSD for 128GB and returned the outdated Chrome OS via USB flash drive. Now, I've been reading and watching video tutorials to get up the nerve to install this new BIOS, as I'd like to run another OS without installing and to use an external hard drive that's fully loaded with the latest version of Mint Cinnamon. I've come to the conclusion that there may be updates that won't allow me to use the Linux Developers Environment -- that never made it. Mine stopped in June of 2021. I'm having some difficulty installing with the easiest of commands. I can enter the Linux Environment and it looks like it's working, but then there are messages at the end that will say that something isn't signed, or it's old suite and other things. Help. Jane P.

1 0

[PATCH v3 0/6] misc tweaks for kvm and the 64bit pci window
by Gerd Hoffmann May 16, 2023

May 16, 2023

v3 changes: - rename variables, use u8 for CPULongMode. v2 changes: - e820 conflict fix Gerd Hoffmann (6): better kvm detection detect physical address space size move 64bit pci window to end of address space be less conservative with the 64bit pci io window qemu: log reservations in fw_cfg e820 table check for e820 conflict src/e820map.h | 1 + src/fw/paravirt.h | 2 ++ src/e820map.c | 15 +++++++++ src/fw/paravirt.c | 86 ++++++++++++++++++++++++++++++++++++++++++----- src/fw/pciinit.c | 20 ++++++++++- 5 files changed, 114 insertions(+), 10 deletions(-) -- 2.40.1

3 9

[PATCH] disable array bounds warning
by Gerd Hoffmann May 16, 2023

May 16, 2023

The segmented pointer casting magic confuses gcc, recent versions throw array bound warnings. Disable the warning. Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index c108f87de768..d3341870a760 100644 --- a/Makefile +++ b/Makefile @@ -71,6 +71,7 @@ COMMONCFLAGS += $(call cc-option,$(CC),-fno-stack-protector,) COMMONCFLAGS += $(call cc-option,$(CC),-fno-stack-protector-all,) COMMONCFLAGS += $(call cc-option,$(CC),-fstack-check=no,) COMMONCFLAGS += $(call cc-option,$(CC),-Wno-address-of-packed-member,) +COMMONCFLAGS += $(call cc-option,$(CC),-Wno-array-bounds,) COMMONCFLAGS += $(call cc-option,$(CC),-fcf-protection=none,) COMMA := , -- 2.40.1

2 2

[PATCH 0/2] print some errors to the screen
by Gerd Hoffmann May 9, 2023

May 9, 2023

Gerd Hoffmann (2): add hwerr_printf function for threads display error message for blocksizes != 512 src/output.h | 5 +++++ src/hw/blockcmd.c | 2 +- src/hw/virtio-blk.c | 4 ++-- src/output.c | 17 +++++++++++++++++ src/post.c | 4 ++++ 5 files changed, 29 insertions(+), 3 deletions(-) -- 2.40.1

2 5

[PATCH v2 0/6] misc tweaks for kvm and the 64bit pci window
by Gerd Hoffmann May 4, 2023

May 4, 2023

v2 changes: - e820 conflict fix Gerd Hoffmann (6): better kvm detection detect physical address space size move 64bit pci window to end of address space be less conservative with the 64bit pci io window qemu: log reservations in fw_cfg e820 table check for e820 conflict src/e820map.h | 1 + src/fw/paravirt.h | 2 ++ src/e820map.c | 15 +++++++++ src/fw/paravirt.c | 86 ++++++++++++++++++++++++++++++++++++++++++----- src/fw/pciinit.c | 20 ++++++++++- 5 files changed, 114 insertions(+), 10 deletions(-) -- 2.40.1

2 7