December 2017 - SeaBIOS - mail.coreboot.org

K-TEK-M275TP-FN-BL-ML USB keyboard support
by Аладышев Константин April 28, 2018

April 28, 2018

Hello! I'm having problems with K-TEK-M275TP-FN-BL-ML keyboard (http://www.key-tek.cn/Productview.asp?id=777) It is USB device with keyboard and touchpad combined. It works in OS correctly, but doesn't work in SeaBIOS. I've tried to debug this issue and found that "usb_kbd_setup" function fails on "(epdesc->wMaxPacketSize != 8)" check, cause "epdesc->wMaxPacketSize" is actually 32. I've modified this "if" statement to pass 32 value also and now function completes successfully. But it didn't help to solve my issue. There are no interrupts from keyboard, "ehci_poll_intr" always returns -1 on check: if (token & QTD_STS_ACTIVE) { // No intrs found. return -1; } I don't know what to do now. What should I check next? Does SeaBIOS support USB keyboard+touchpad devices at all?

2 5

[PATCH 0/4] RFC: add CRB TPM device
by marcandre.lureau＠redhat.com Feb. 12, 2018

Feb. 12, 2018

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, The following series implements a limited TPM CRB driver. The TIS device with a TPM 2.0 seems to be ignored by Windows 10, so I implemented a simple CRB device that I will send shortly on the qemu-devel. With the CRB device, Windows 10 correctly recognized and exchange with a TPM 2.0. As long as the device isn't in qemu, I suppose this series should remain RFC. Feedback welcome! Marc-André Lureau (4): x86: add readq() tpm: generalize init_timeout() tpm: use get_tpm_version() callback WIP: add TPM CRB device support src/hw/tpm_drivers.c | 226 ++++++++++++++++++++++++++++++++++++++++++++++++--- src/hw/tpm_drivers.h | 26 ++++++ src/x86.h | 5 ++ 3 files changed, 245 insertions(+), 12 deletions(-) -- 2.14.1.146.gd35faa819

5 12

[PATCH] paravirt: Allow both Red Hat and Amazon PCI HB subsystem vendor and device ids
by Filippo Sironi Jan. 19, 2018

Jan. 19, 2018

Signed-off-by: Filippo Sironi <sironi(a)amazon.de> --- src/fw/paravirt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/fw/paravirt.c b/src/fw/paravirt.c index 0770c47b12e7..163b70c6473f 100644 --- a/src/fw/paravirt.c +++ b/src/fw/paravirt.c @@ -83,8 +83,8 @@ static void qemu_detect(void) u16 sv = pci_config_readw(0, PCI_SUBSYSTEM_VENDOR_ID); u16 sd = pci_config_readw(0, PCI_SUBSYSTEM_ID); - if (sv != 0x1af4 || /* Red Hat, Inc */ - sd != 0x1100) /* Qemu virtual machine */ + if (!(sv == 0x1af4 && sd == 0x1100) && /* Red Hat, Inc. QEMU VM */ + !(sv == 0x1d0f && sd == 0x1237)) /* Amazon.com, Inc. i440fx VM */ return; PlatformRunningOn |= PF_QEMU; -- 2.7.4

5 4

[PATCH] Don't select SERCON when target is coreboot
by Arthur Heymans Jan. 8, 2018

Jan. 8, 2018

CONFIG_SERCON=y breaks coreboot S3 (boots into payload instead of OS reset vector). Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> diff --git a/src/Kconfig b/src/Kconfig index 55a87cb..597d4ce 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -308,6 +308,7 @@ menu "Hardware support" Support serial ports. This also enables int 14 serial port calls. config SERCON bool "Serial console" + depends on !COREBOOT default y help Support redirecting vga output to the serial console. -- 2.15.1

2 1

[PATCH 0/2] Allow creation of EK and SRK for TPM 2
by Stefan Berger Dec. 28, 2017

Dec. 28, 2017

The following two patches add functionality to create EK and SRK keys to the TPM 2 menu. We follow TCG specifications for how to create those as RSA keys. Regards, Stefan Stefan Berger (2): tcbios: Add menu item to create an EK for TPM 2 tcbios: Add menu item to create a primary storage key for TPM 2 src/std/tcg.h | 63 +++++++++++ src/tcgbios.c | 341 +++++++++++++++++++++++++++++++++++++++++++++++++++++++--- 2 files changed, 388 insertions(+), 16 deletions(-) -- 2.5.5

2 4

Re: [SeaBIOS] S3 resume fails on hp/8470p when using SeaBIOS 1.11.0
by Kevin O'Connor Dec. 24, 2017

Dec. 24, 2017

Resending this mail as it looks like I accidently dropped the mailing list. On Tue, Dec 19, 2017 at 02:25:41PM +0800, Iru Cai wrote: > Hi, > > I'm using coreboot with SeaBIOS payload on hp/8470p. I found S3 resume > fails when using the latest SeaBIOS. After testing some revisions of > SeaBIOS, I found this commit is the problem. > > commit 04db972290a6f3c61920fc7498031f477911774e > Author: Kevin O'Connor <kevin(a)koconnor.net> > Date: Tue Jul 11 12:09:57 2017 -0400 > > disk: Don't require the 'struct drive_s' to be in the f-segment > > > From the cbmem console, when after using SeaBIOS>=commit 04db972, coreboot > cannot find RSDP, thus cannot do the ACPI wakeup. That's surprising. Can you provide the cbmem log from the success case and the failure case? -Kevin

1 0

Re: [SeaBIOS] cbfstool without cloning the whole repository? Use script for <2M download
by Ivan Ivanov Dec. 23, 2017

Dec. 23, 2017

It looks like there were two typos in this wonderful script : missing " \ " at the end of two " --execute robots=off " lines Other than that, this script is still working. Below is a fixed copy, if you sometimes need cbfstool without cloning the whole coreboot you may try it out: ### SCRIPT BEGIN ### wget --recursive --no-parent --no-host-directories --cut-dirs=3 \ --user-agent="Mozilla/5.0" --execute robots=off \ https://review.coreboot.org/cgit/coreboot.git/plain/util/cbfstool/ wget --recursive --no-parent --no-host-directories --cut-dirs=3 \ --user-agent="Mozilla/5.0" --execute robots=off \ https://review.coreboot.org/cgit/coreboot.git/plain/src/commonlib/ \ --exclude-directories=/cgit/coreboot.git/plain/src/commonlib/storage/ \ --reject=configstring.c,iobuf.c,cbmem_id.h,configstring.h,coreboot_tables.h,\ fmap_serialized.h,iobuf.h,sd_mmc_ctrlr.h,sdhci.h,stdlib.h,storage.h,\ timestamp_serialized.h wget --recursive --no-parent --no-host-directories --cut-dirs=3 \ --user-agent="Mozilla/5.0" --execute robots=off \ https://review.coreboot.org/cgit/coreboot.git/plain/src/vendorcode/intel/ed… wget --recursive --no-parent --no-host-directories --cut-dirs=3 \ --user-agent="Mozilla/5.0" --execute robots=off \ https://review.coreboot.org/cgit/coreboot.git/plain/src/vendorcode/intel/fs… wget --recursive --no-parent --no-host-directories --cut-dirs=3 \ --user-agent="Mozilla/5.0" --execute robots=off \ --directory-prefix=./3rdparty/vboot/ \ https://review.coreboot.org/cgit/vboot.git/plain/firmware/2lib/ \ --reject=2api.c,2crc8.c,2hmac.c,2misc.c,2nvstorage.c,2rsa.c,2secdata.c,\ 2secdatak.c,2stub.c,2tpm_bootmode.c,2crc8.h,2hmac.h,2misc.h,\ 2nvstorage_fields.h,2nvstorage.h,2rsa.h,2secdata.h,2tpm_bootmode.h wget --recursive --no-parent --no-host-directories --cut-dirs=3 \ --user-agent="Mozilla/5.0" --execute robots=off \ --directory-prefix=./3rdparty/vboot/ \ https://review.coreboot.org/cgit/vboot.git/plain/firmware/include/vb2_api.h cd ./util/cbfstool/ make all ### SCRIPT END ### 2017-07-12 1:53 GMT+03:00 Ivan Ivanov <qmastery16(a)gmail.com>: > Dear friends, sometimes you need to do a few operations with > coreboot.rom (e.g. update its' payload) without changing > coreboot.rom's main code. If you have bad Internet connection or just > want to quickly get the latest version of cbfstool without cloning the > whole coreboot/vboot repositories - my bash script below will really > help you! > > It downloads only the files required for the successful compilation of > cbfstool - whole ./util/cbfstool directory (93 files, ~1,3M size) and > all the dependencies: > ./src/commonlib - 20 files, ~152K > ./src/vendorcode/intel/edk2/uefi_2.4/ - 26 files, 272K > ./src/vendorcode/intel/fsp/fsp1_1/IntelFspPkg/Include/FspInfoHeader.h - ~4K > > ((( I don't understand what Intel is doing here, but I can't build > without these files! ))) > > ./3rdparty/vboot/firmware/2lib/ - 17 files, 170K > ./3rdparty/vboot/firmware/include/vb2_api.h - ~1K > > In total, its 158 files and just 1.9M - less than 2M ! > And it builds OK. Hope it will be useful for you ;-) > > ### SCRIPT BEGIN ### > > wget --recursive --no-parent --no-host-directories --cut-dirs=3 \ > --user-agent="Mozilla/5.0" --execute robots=off \ > https://review.coreboot.org/cgit/coreboot.git/plain/util/cbfstool/ > > wget --recursive --no-parent --no-host-directories --cut-dirs=3 \ > --user-agent="Mozilla/5.0" --execute robots=off \ > https://review.coreboot.org/cgit/coreboot.git/plain/src/commonlib/ \ > --exclude-directories=/cgit/coreboot.git/plain/src/commonlib/storage/ \ > --reject=configstring.c,iobuf.c,cbmem_id.h,configstring.h,coreboot_tables.h,\ > fmap_serialized.h,iobuf.h,sd_mmc_ctrlr.h,sdhci.h,stdlib.h,storage.h,\ > timestamp_serialized.h > > wget --recursive --no-parent --no-host-directories --cut-dirs=3 \ > --user-agent="Mozilla/5.0" --execute robots=off \ > https://review.coreboot.org/cgit/coreboot.git/plain/src/vendorcode/intel/ed… > > wget --recursive --no-parent --no-host-directories --cut-dirs=3 \ > --user-agent="Mozilla/5.0" --execute robots=off \ > https://review.coreboot.org/cgit/coreboot.git/plain/src/vendorcode/intel/fs… > > wget --recursive --no-parent --no-host-directories --cut-dirs=3 \ > --user-agent="Mozilla/5.0" --execute robots=off > --directory-prefix=./3rdparty/vboot/ \ > https://review.coreboot.org/cgit/vboot.git/plain/firmware/2lib/ \ > --reject=2api.c,2crc8.c,2hmac.c,2misc.c,2nvstorage.c,2rsa.c,2secdata.c,\ > 2secdatak.c,2stub.c,2tpm_bootmode.c,2crc8.h,2hmac.h,2misc.h,\ > 2nvstorage_fields.h,2nvstorage.h,2rsa.h,2secdata.h,2tpm_bootmode.h > > wget --recursive --no-parent --no-host-directories --cut-dirs=3 \ > --user-agent="Mozilla/5.0" --execute robots=off > --directory-prefix=./3rdparty/vboot/ \ > https://review.coreboot.org/cgit/vboot.git/plain/firmware/include/vb2_api.h > > cd ./util/cbfstool/ > > make all > > ### SCRIPT END ###

1 0

[PATCH 0/1] add multiple usb-hid support
by Stef van Os Dec. 22, 2017

Dec. 22, 2017

The following patch adds support for multiple usb keyboards and mice to seabios. Maximum number of keyboards is configurable in Kconfig and defaults to 1 to keep current behavior. Tested on: * Qemu q35 with two usb keyboards on seperate displays * Prodrive broadwell-d platform with one Dell keyboard and one virtual KVM keyboard on Aspeed AST2500. Stef van Os (1): usb-hid: add support for multiple input devices src/Kconfig | 14 +++++++++++ src/hw/usb-hid.c | 76 ++++++++++++++++++++++++++++++++++++++++---------------- 2 files changed, 68 insertions(+), 22 deletions(-) -- 2.11.0

3 5

Re: [SeaBIOS] [PATCH 0/1] add multiple usb-hid support
by Stef van Os Dec. 22, 2017

Dec. 22, 2017

Hi Daniel, Is this a problem with the patch applied? It was tested on our hardware to function. Some questions: * What hardware platform are you using? * Does the numeric keyboard work if it is the only keyboard (or if you swap ports, which hopefully changes enumeration order) in the system, maybe the problem is elsewhere and was masked because the (normal) keyboard was enumerated first and the second (numeric) was ignored earlier. Also, the patch can be verified using qemu and two vnc inputs: qemu-system-x86_64 -m 4096 -M q35 -smp 8 \ -pflash bios.qemu.rom \ -drive format=raw,file=disk.img \ -device pci-bridge,addr=12.0,chassis_nr=2,id=head.2 \ -device nec-usb-xhci,bus=head.2,addr=0f.0,id=usb.2 \ -device VGA,id=video.1 \ -device secondary-vga,bus=head.2,addr=02.0,id=video.2 \ -display vnc=:15,id=primary,display=video.1 \ -display vnc=:16,id=secondary,display=video.2 \ -usb \ -device usb-kbd,bus=usb.2.0,port=1,display=video.1 \ -device usb-kbd,bus=usb.2.0,port=2,display=video.2 \ -serial stdio Best regards, Stef On 12/20/2017 06:20 PM, Daniel K wrote: > When I have more than 2 usb keyboards connected, SeaBIOS doesn't register keyboard input. > This persists even when I get to the disk GRUB menu. > I have to manually unplug my other keyboard to do any input during boot. > > And by other keyboard, I just mean a separate numerical keypad. > >> From: SeaBIOS <seabios-bounces(a)seabios.org> on behalf of Kevin O'Connor <kevin(a)koconnor.net> >> Sent: 20 December 2017 08:33 >> To: Stef van Os >> Cc: seabios(a)seabios.org >> Subject: Re: [SeaBIOS] [PATCH 0/1] add multiple usb-hid support >> >> On Fri, Dec 15, 2017 at 11:09:45AM +0100, Stef van Os wrote: >>> The following patch adds support for multiple usb keyboards and mice to seabios. >>> Maximum number of keyboards is configurable in Kconfig and defaults to 1 to keep >>> current behavior. >> >> Thanks. What's the use case for enabling multiple keyboards? >> >> -Kevin > > > >

2 1

Re: [SeaBIOS] [PATCH 0/1] add multiple usb-hid support
by Daniel K Dec. 20, 2017

Dec. 20, 2017

Sorry I meant more than 1 usb keyboard. So 2 or more will cause the issue. >From: SeaBIOS <seabios-bounces(a)seabios.org> on behalf of Daniel K <shambles_09(a)hotmail.com> >Sent: 20 December 2017 09:20 >To: Kevin O'Connor; Stef van Os >Cc: seabios(a)seabios.org >Subject: Re: [SeaBIOS] [PATCH 0/1] add multiple usb-hid support > > >When I have more than 2 usb keyboards connected, SeaBIOS doesn't register keyboard input. >This persists even when I get to the disk GRUB menu. >I have to manually unplug my other keyboard to do any input during boot. > >And by other keyboard, I just mean a separate numerical keypad. > >>From: SeaBIOS <seabios-bounces(a)seabios.org> on behalf of Kevin O'Connor <kevin(a)koconnor.net> >>Sent: 20 December 2017 08:33 >>To: Stef van Os >>Cc: seabios(a)seabios.org >>Subject: Re: [SeaBIOS] [PATCH 0/1] add multiple usb-hid support >> >>On Fri, Dec 15, 2017 at 11:09:45AM +0100, Stef van Os wrote: >>> The following patch adds support for multiple usb keyboards and mice to seabios. >>> Maximum number of keyboards is configurable in Kconfig and defaults to 1 to keep >>> current behavior. >> >> Thanks. What's the use case for enabling multiple keyboards? >> >> -Kevin

1 0