March 2012 - SeaBIOS - mail.coreboot.org

Re: [SeaBIOS] [SeaBIOS PATCH v3] hotplug: Add device per func in ACPI DSDT tables
by Kevin O'Connor May 11, 2012

May 11, 2012

On Tue, Dec 06, 2011 at 07:32:55PM -0500, Amos Kong wrote: > ----- Original Message ----- > > On Tue, Dec 06, 2011 at 01:39:35PM +0800, Amos Kong wrote: > > > Only func 0 is registered to guest driver (we can > > > only found func 0 in slot->funcs list of driver), > > > the other functions could not be cleaned when > > > hot-removing the whole slot. This patch adds > > > device per function in ACPI DSDT tables. > > > Notify only when func0 is added and removed. > > > > > > Have tested with linux/winxp/win7, hot-adding/hot-remving, > > > single/multiple function device, they are all fine(all > > > added devices can be removed). > > > > > This includes some bits I wrote but this is not an ack > > of the patch yet :) > > > > I find it surprising that this works: a function > > has _EJ0 so would not guest expect that ejecting > > a single one will only remove it, and not all functions? > > Removing single func is not supported by specific, and current code > (qemu/kernel pci driver) process hot-remove with the whole slot. > We could not hot-remove single func with/without this patch. > > Register _EJ0() for each func, then all the funcs will be record > into the function list of the slot. Just as an update - it's not clear to me what this patch does, and it seems like Michael had some concerns. Also, it doesn't seem right to hardcode the generation of that many devices (248) in the AML code. So, unless there are further comments I'm going to hold off on this patch. -Kevin

6 17

[PATCH 0/4] Redesign of pciinit.c (take 3)
by Alexey Korolev April 20, 2012

April 20, 2012

Hi, This patch series redesigns the existing pciinit.c code and introduces linked list operations. Changes are more about structures definitions rather than functionality. There are no more arrays of bases and counts in new implementation. The new implementation is based on dynamic allocation of pci_region_entry structures. Each pci_region_entry structure could be a PCI bar or a downstream PCI region (bridge). Each entry has a set of attributes: type (IO, MEM, PREFMEM), is64bit, size, base address, PCI device owner, and a pointer to the pci_bus it belongs to. 1. Introduce List operations 2. Add pci_region_entry and linked lists operations in place while still using the array system to do the allocations. 3. Switch to lists operations 4. Get rid of size element from bus->r structure, now we use entry->size for the same purpose src/pci.h | 5 - src/pciinit.c | 258 ++++++++++++++++++++++++++------------------------------- src/util.h | 21 +++++ 3 files changed, 137 insertions(+), 147 deletions(-)

5 19

[PATCH 2/2] acpi: clear up/down bits on interrupt
by Michael S. Tsirkin April 1, 2012

April 1, 2012

qemu added a way for bios to clear bits in the up/down register. Do this in PCNF so that we wont trigger multiple events for the same slot. This does nothing when running on an old qemu. Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> --- src/acpi-dsdt.dsl | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 15201e9..e17e0e2 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -132,6 +132,13 @@ DefinitionBlock ( B0EJ, 32, } + OperationRegion(PCCL, SystemIO, 0xae10, 0x08) + Field (PCST, DWordAcc, NoLock, WriteAsZeros) + { + PCCU, 32, + PCCD, 32, + } + Name (_CRS, ResourceTemplate () { WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode, @@ -489,6 +496,8 @@ DefinitionBlock ( Store (Zero, Local0) Store (PCIU, Local1) Store (PCID, Local2) + Store (Local1, PCCU) + Store (Local2, PCCD) While (LLess(Local0, 31)) { Increment(Local0) If (And(Local1, ShiftLeft(1, Local0))) { -- 1.7.9.111.gf3fb0

2 2

[PATCH] seabios: readd Makefile rule for ACPI
by Michael S. Tsirkin April 1, 2012

April 1, 2012

Commit 36feea9317b45abf3a540e9d82ad1723bebe3ebd removed the dependency of output file on acpi output. This means it's not rebuilt on acpi source or hex file updates. Re-introduce this dependency. Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> --- Makefile | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index a4d548d..48715bf 100644 --- a/Makefile +++ b/Makefile @@ -227,6 +227,7 @@ src/%.hex: src/%.dsl ./tools/acpi_extract_preprocess.py ./tools/acpi_extract.py $(Q)$(PYTHON) ./tools/acpi_extract.py $(OUT)$*.lst > $(OUT)$*.off $(Q)cat $(OUT)$*.off > $@ +$(OUT)ccode32flat.o: src/acpi-dsdt.hex src/ssdt-proc.hex src/ssdt-pcihp.hex ################ Kconfig rules -- 1.7.9.111.gf3fb0

3 2

[PATCH 1/2] acpi: remove unnecessary reads
by Michael S. Tsirkin March 28, 2012

March 28, 2012

Read each of the up/down registers only once and store in a local temporary. This refactoring makes it a bit easier to clear these registers, which is done by a follow-up patch. Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> --- src/acpi-dsdt.dsl | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index 4e04c48..15201e9 100644 --- a/src/acpi-dsdt.dsl +++ b/src/acpi-dsdt.dsl @@ -487,12 +487,14 @@ DefinitionBlock ( Method(PCNF, 0) { // Local0 = iterator Store (Zero, Local0) + Store (PCIU, Local1) + Store (PCID, Local2) While (LLess(Local0, 31)) { Increment(Local0) - If (And(PCIU, ShiftLeft(1, Local0))) { + If (And(Local1, ShiftLeft(1, Local0))) { PCNT(Local0, 1) } - If (And(PCID, ShiftLeft(1, Local0))) { + If (And(Local2, ShiftLeft(1, Local0))) { PCNT(Local0, 3) } } -- 1.7.9.111.gf3fb0

1 0

Re: [SeaBIOS] bootorder: iPXE or gPXE?
by Kevin O'Connor March 24, 2012

March 24, 2012

On Fri, Mar 23, 2012 at 09:25:24AM -0600, Steve Goodrich wrote: > I don't yet understand the syntax of the bootorder file, and I'm trying to > use iPXE as one of the boot sources. Could someone either: > 1. Show me how to set this up, or > 2. Point me to documentation somewhere that explains PXE boot as controlled > by SeaBIOS's bootorder file, or > 3. Show me another way to do it? As before, there is some documentation at: http://www.coreboot.org/SeaBIOS#Configuring_boot_order Basically, extract the SeaBIOS log and look for lines with "Searching bootorder for" and then put the line corresponding to the device you wish to boot from into the file. If you're still having issues, please post your log along with the bootorder file that you attempted. -Kevin

1 0

[PATCH] test-gcc: do not truncate stderr
by Ian Campbell March 24, 2012

March 24, 2012

Using "> /dev/fd/2" causes stderr to get truncated, which is mangles the log file if the user happens to have redirected it there. Use ">&2" instead which redirects to the already open stderr and doesn't truncate it. Reported-by: Tim Deegan <tim(a)xen.org> Tested-by: Tim Deegan <tim(a)xen.org> Signed-off-by: Ian Campbell <ian.campbell(a)citrix.com> --- If this could go into the next stable release that would be very nice. Thanks, Ian. --- tools/test-gcc.sh | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tools/test-gcc.sh b/tools/test-gcc.sh index 935f211..05bae29 100755 --- a/tools/test-gcc.sh +++ b/tools/test-gcc.sh @@ -30,13 +30,13 @@ EOF $CC -O -g -c $TMPFILE1 -o $TMPFILE1o > /dev/null 2>&1 $LD -T $TMPFILE1_ld $TMPFILE1o -o $TMPFILE2o > /dev/null 2>&1 if [ $? -ne 0 ]; then - echo "The version of LD on this system does not properly handle" > /dev/fd/2 - echo "alignments. As a result, this project can not be built." > /dev/fd/2 - echo "" > /dev/fd/2 - echo "The problem may be the result of this LD bug report:" > /dev/fd/2 - echo " http://sourceware.org/bugzilla/show_bug.cgi?id=12726" > /dev/fd/2 - echo "" > /dev/fd/2 - echo "Please update to a working version of binutils and retry." > /dev/fd/2 + echo "The version of LD on this system does not properly handle" >&2 + echo "alignments. As a result, this project can not be built." >&2 + echo "" >&2 + echo "The problem may be the result of this LD bug report:" >&2 + echo " http://sourceware.org/bugzilla/show_bug.cgi?id=12726" >&2 + echo "" >&2 + echo "Please update to a working version of binutils and retry." >&2 echo -1 exit 0 fi @@ -45,7 +45,7 @@ fi # support the whole-program optimization - detect that. $CC -fwhole-program -S -o /dev/null -xc /dev/null > /dev/null 2>&1 if [ $? -ne 0 ]; then - echo " Working around no -fwhole-program" > /dev/fd/2 + echo " Working around no -fwhole-program" >&2 echo 2 exit 0 fi @@ -69,7 +69,7 @@ EOF $CC -Os -c -fwhole-program $TMPFILE2 -o $TMPFILE2o > /dev/null 2>&1 $CC -nostdlib -Os $TMPFILE1o $TMPFILE2o -o $TMPFILE3o > /dev/null 2>&1 if [ $? -ne 0 ]; then - echo " Working around non-functional -fwhole-program" > /dev/fd/2 + echo " Working around non-functional -fwhole-program" >&2 echo 2 exit 0 fi @@ -104,7 +104,7 @@ $CC -O -g -fwhole-program -combine -c $TMPFILE1 $TMPFILE2 -o $TMPFILE1o > /dev/n if [ $? -eq 0 ]; then echo 0 else - echo " Working around non-functional -combine" > /dev/fd/2 + echo " Working around non-functional -combine" >&2 echo 1 fi -- 1.7.2.5

2 1

bootorder: iPXE or gPXE?
by Steve Goodrich March 23, 2012

March 23, 2012

I don't yet understand the syntax of the bootorder file, and I'm trying to use iPXE as one of the boot sources. Could someone either: 1. Show me how to set this up, or 2. Point me to documentation somewhere that explains PXE boot as controlled by SeaBIOS's bootorder file, or 3. Show me another way to do it? Thanks! -- Steve G.

1 0

[PATCH v2] Halt if number of started cpus are more then expected
by Igor Mammedov March 22, 2012

March 22, 2012

Reduce amount of consumed cpu time (i.e. don't spin forever) if number of started cpus are more then expected. And print a bug message into debug port. And it is not safe to continue to boot if CountCPUs is more than cmos_smp_count and might be still racing, due to mp/acpi could be build with still changing CountCPUs. It is safer to stop and allow user to notice and restart system rather than debug possible inxplicable bugs later. v2: extendend commit message with explanation why not continue to boot Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> --- src/smp.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/src/smp.c b/src/smp.c index 8c077a1..9933ac6 100644 --- a/src/smp.c +++ b/src/smp.c @@ -115,8 +115,14 @@ smp_probe(void) msleep(10); } else { u8 cmos_smp_count = inb_cmos(CMOS_BIOS_SMP_COUNT); - while (cmos_smp_count + 1 != readl(&CountCPUs)) + while (cmos_smp_count + 1 != readl(&CountCPUs)) { + if (cmos_smp_count + 1 < readl(&CountCPUs)) { + dprintf(1, "BUG: Expected %d cpu(s) but %d cpus started\n", + cmos_smp_count + 1, readl(&CountCPUs)); + hlt(); + } yield(); + } } // Restore memory. -- 1.7.7.6

2 2

[PATCH] update version banner
by Gerd Hoffmann March 22, 2012

March 22, 2012

This patch changes the seabios version banner printed. When building from a git repository 'git describe' is used to generate a version tag which includes the (short) commit hash and thus can be used to identify the commit used to build the binary. Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- Makefile | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index abbac8c..6577ad3 100644 --- a/Makefile +++ b/Makefile @@ -5,7 +5,18 @@ # This file may be distributed under the terms of the GNU LGPLv3 license. # Program version -VERSION=pre-1.6.4-$(shell date +"%Y%m%d_%H%M%S")-$(shell hostname) +RELEASE := pre-1.6.4 + +GIT_DESC := $(shell test -d .git && git describe --tags) +ifeq ($(GIT_DESC),) + # building from release tarball + VERSION := $(RELEASE) +else + # building from git repository + VERSION := $(GIT_DESC) +endif +VERSION += $(shell date +"%Y%m%d_%H%M%S") +VERSION += $(shell hostname) # Output directory OUT=out/ -- 1.7.1

2 2