OpenBIOS

Download

openbios@openbios.org

October 2014

2 participants
2 discussions

[commit] r1321 - trunk/openbios-devel/drivers
by repository service Oct. 21, 2014

Oct. 21, 2014

Author: mcayland Date: Tue Oct 21 21:47:33 2014 New Revision: 1321 URL: http://tracker.coreboot.org/trac/openbios/changeset/1321 Log: tcx.fs: fix size of STIP register in 8-bit mode The existing reg property sets the size of the STIP register to 1 byte in 8-bit mode which is likely wrong, and causes NetBSD 6 to fail to detect the the TCX card in 8-bit mode. Use the same STIP register size as for 24-bit mode in both 8-bit and 24-bit modes which is enough to allow NetBSD (including X) to function correctly. Reported-by: Martin Husemann <martin(a)duskware.de> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)ilande.co.uk> Modified: trunk/openbios-devel/drivers/tcx.fs Modified: trunk/openbios-devel/drivers/tcx.fs ============================================================================== --- trunk/openbios-devel/drivers/tcx.fs Wed Sep 24 20:03:55 2014 (r1320) +++ trunk/openbios-devel/drivers/tcx.fs Tue Oct 21 21:47:33 2014 (r1321) @@ -103,8 +103,7 @@ h# 1 constant /tcx-off-dfb24-8 h# 4000000 constant tcx-off-stip -h# 800000 constant /tcx-off-stip-24 -h# 1 constant /tcx-off-stip-8 +h# 800000 constant /tcx-off-stip h# 6000000 constant tcx-off-blit h# 800000 constant /tcx-off-blit @@ -129,7 +128,7 @@ \ WARNING: order is important (at least to Solaris) tcx-off-dfb8 /tcx-off-dfb8 >tcx-reg-spec tcx-off-dfb24 /tcx-off-dfb24-8 >tcx-reg-spec encode+ - tcx-off-stip /tcx-off-stip-8 >tcx-reg-spec encode+ + tcx-off-stip /tcx-off-stip >tcx-reg-spec encode+ tcx-off-blit /tcx-off-blit >tcx-reg-spec encode+ tcx-off-rdfb32 /tcx-off-rdfb32-8 >tcx-reg-spec encode+ tcx-off-rstip /tcx-off-rstip-8 >tcx-reg-spec encode+ @@ -147,7 +146,7 @@ \ WARNING: order is important (at least to Solaris) tcx-off-dfb8 /tcx-off-dfb8 >tcx-reg-spec tcx-off-dfb24 /tcx-off-dfb24-24 >tcx-reg-spec encode+ - tcx-off-stip /tcx-off-stip-24 >tcx-reg-spec encode+ + tcx-off-stip /tcx-off-stip >tcx-reg-spec encode+ tcx-off-blit /tcx-off-blit >tcx-reg-spec encode+ tcx-off-rdfb32 /tcx-off-rdfb32-24 >tcx-reg-spec encode+ tcx-off-rstip /tcx-off-rstip-24 >tcx-reg-spec encode+

1 0

[PATCH] tcx.fs: fix size of STIP register in 8-bit mode
by Mark Cave-Ayland Oct. 14, 2014

Oct. 14, 2014

The existing reg property sets the size of the STIP register to 1 byte in 8-bit mode which is likely wrong, and causes NetBSD 6 to fail to detect the the TCX card in 8-bit mode. Use the same STIP register size as for 24-bit mode in both 8-bit and 24-bit modes which is enough to allow NetBSD (including X) to function correctly. Reported-by: Martin Husemann <martin(a)duskware.de> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)ilande.co.uk> --- openbios-devel/drivers/tcx.fs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/openbios-devel/drivers/tcx.fs b/openbios-devel/drivers/tcx.fs index a377db0..af8991f 100644 --- a/openbios-devel/drivers/tcx.fs +++ b/openbios-devel/drivers/tcx.fs @@ -103,8 +103,7 @@ h# 400000 constant /tcx-off-dfb24-24 h# 1 constant /tcx-off-dfb24-8 h# 4000000 constant tcx-off-stip -h# 800000 constant /tcx-off-stip-24 -h# 1 constant /tcx-off-stip-8 +h# 800000 constant /tcx-off-stip h# 6000000 constant tcx-off-blit h# 800000 constant /tcx-off-blit @@ -129,7 +128,7 @@ h# 1 constant /tcx-off-rblit-8 \ WARNING: order is important (at least to Solaris) tcx-off-dfb8 /tcx-off-dfb8 >tcx-reg-spec tcx-off-dfb24 /tcx-off-dfb24-8 >tcx-reg-spec encode+ - tcx-off-stip /tcx-off-stip-8 >tcx-reg-spec encode+ + tcx-off-stip /tcx-off-stip >tcx-reg-spec encode+ tcx-off-blit /tcx-off-blit >tcx-reg-spec encode+ tcx-off-rdfb32 /tcx-off-rdfb32-8 >tcx-reg-spec encode+ tcx-off-rstip /tcx-off-rstip-8 >tcx-reg-spec encode+ @@ -147,7 +146,7 @@ h# 1 constant /tcx-off-rblit-8 \ WARNING: order is important (at least to Solaris) tcx-off-dfb8 /tcx-off-dfb8 >tcx-reg-spec tcx-off-dfb24 /tcx-off-dfb24-24 >tcx-reg-spec encode+ - tcx-off-stip /tcx-off-stip-24 >tcx-reg-spec encode+ + tcx-off-stip /tcx-off-stip >tcx-reg-spec encode+ tcx-off-blit /tcx-off-blit >tcx-reg-spec encode+ tcx-off-rdfb32 /tcx-off-rdfb32-24 >tcx-reg-spec encode+ tcx-off-rstip /tcx-off-rstip-24 >tcx-reg-spec encode+ -- 1.7.10.4

1 0