September 2007 - OpenBIOS - mail.coreboot.org

Re: [OpenBIOS] [Qemu-devel] Qemu and Linux 2.4
by Blue Swirl Sept. 26, 2007

Sept. 26, 2007

On 9/26/07, Alexander Voropay <alec(a)nwpi.ru> wrote: > <vlad(a)comsys.ro> wrote: > > >>> - QEMU malta emulation is not really complete, to put it mildly > >> Out of curiosity, what parts did you miss? > > Like, for example, the PCI stuff. So I can use the network card. > > PCI stuff in the QEMU/Malta works fine, but pseudo-bootrom > does not perform PCI enumeration and leaves uninitialized PCI BARs. > > Linux MIPS/Malta 2.4 can not perform PCI enumeration too. The LANCE > Ethernet driver *requres* a pre-initialized BARs. The situation even worse, > since current Linux 2.4 can't be even built with NEW_PCI and PCI_AUTO > options at all (due to linkage error). > > http://www.linux-mips.org/wiki/PCI_Subsystem > > There is the same PCI problem with NetBSD/evbmips and seems VxWorks/Malta. > > > And yes, I am aware of YAMON. > > AFAIK, YAMON may runs on the MIPS hardware only, and may not > be redistribuded in the source or binary form. > > Anyway, YAMON binary does not work on the Qemu/Malta. The Galileo > chip is far more complicated then Qemu emulation. It contains four DMA > channels, four timers e.t.c. e.t.c. > > >> I recommend to improve the Qemu Malta emulation, and make it work with > >> 2.4 Malta kernels. (ISTR it used to work, so it shouldn't need a lot to > >> get there.) > > > > I'm sure that improving the Qemu Malta emulation is a very noble goal, > > but for people that need a working 2.4 kernel NOW, my patch could be > > useful. Having the QEMU target in 2.6 surely helped me. > > The only thing we need is a good bootrom (BIOS) for the MIPS/Malta > (Free-YAMON ;) Someone could port OpenBIOS or LinuxBIOS to MIPS.

1 0

r637 - cpu/x86/pc/olpc
by svn＠openbios.org Sept. 26, 2007

Sept. 26, 2007

Author: wmb Date: 2007-09-26 04:36:53 +0200 (Wed, 26 Sep 2007) New Revision: 637 Modified: cpu/x86/pc/olpc/devices.fth Log: OLPC - Leave the EC SCI control register alone; Richard has it under control. Modified: cpu/x86/pc/olpc/devices.fth =================================================================== --- cpu/x86/pc/olpc/devices.fth 2007-09-25 04:47:24 UTC (rev 636) +++ cpu/x86/pc/olpc/devices.fth 2007-09-26 02:36:53 UTC (rev 637) @@ -246,10 +246,6 @@ fload ${BP}/cpu/x86/pc/olpc/boardrev.fth \ Board revision decoding -stand-init: Quiet SCI - sci-quiet -; - stand-init: Date to EC time&date d# 2000 - ec-date! 3drop ;

1 0

r636 - dev/geode
by svn＠openbios.org Sept. 25, 2007

Sept. 25, 2007

Author: wmb Date: 2007-09-25 06:47:24 +0200 (Tue, 25 Sep 2007) New Revision: 636 Modified: dev/geode/acpi.fth Log: Oops - fixed a typo in previous checkin. Modified: dev/geode/acpi.fth =================================================================== --- dev/geode/acpi.fth 2007-09-25 04:30:34 UTC (rev 635) +++ dev/geode/acpi.fth 2007-09-25 04:47:24 UTC (rev 636) @@ -12,13 +12,14 @@ : pm@ ( offset -- n ) pm-base + pl@ ; : pm! ( n offset -- ) pm-base + pl! ; +h# 4000.0000 constant pm-enable + : enable-power-button ( -- ) 2 acpi-w@ h# 100 or 2 acpi-w! ; : disable-power-button ( -- ) 2 acpi-w@ h# 100 invert and 2 acpi-w! ; : ignore-power-button ( -- ) 0 h# 40 pm! ; \ Shorten off delay to .5 sec : quick-power-button ( -- ) d# 32768 pm-enable or h# 40 pm! ; -h# 4000.0000 constant pm-enable : gx-power-off ( -- ) \ The rest of this will succeed in turning off the CPU, but the EC will \ stay on. The ec-power-off above turns off both the EC and CPU, so the

1 0

r635 - in dev: geode olpc/kb3700
by svn＠openbios.org Sept. 25, 2007

Sept. 25, 2007

Author: wmb Date: 2007-09-25 06:30:34 +0200 (Tue, 25 Sep 2007) New Revision: 635 Modified: dev/geode/acpi.fth dev/olpc/kb3700/ecio.fth Log: OLPC - second try to guard again bricks due to pressing the power button at the wrong time. Modified: dev/geode/acpi.fth =================================================================== --- dev/geode/acpi.fth 2007-09-19 23:58:43 UTC (rev 634) +++ dev/geode/acpi.fth 2007-09-25 04:30:34 UTC (rev 635) @@ -14,6 +14,9 @@ : enable-power-button ( -- ) 2 acpi-w@ h# 100 or 2 acpi-w! ; : disable-power-button ( -- ) 2 acpi-w@ h# 100 invert and 2 acpi-w! ; +: ignore-power-button ( -- ) 0 h# 40 pm! ; +\ Shorten off delay to .5 sec +: quick-power-button ( -- ) d# 32768 pm-enable or h# 40 pm! ; h# 4000.0000 constant pm-enable : gx-power-off ( -- ) @@ -44,7 +47,7 @@ stand-init h# 5140.000e rdmsr drop h# fff0 and to acpi-base h# 5140.000f rdmsr drop h# fff0 and to pm-base - d# 32768 pm-enable or h# 40 pm! \ Shorten off delay to .5 sec + quick-power-button ; warning ! Modified: dev/olpc/kb3700/ecio.fth =================================================================== --- dev/olpc/kb3700/ecio.fth 2007-09-19 23:58:43 UTC (rev 634) +++ dev/olpc/kb3700/ecio.fth 2007-09-25 04:30:34 UTC (rev 635) @@ -251,9 +251,8 @@ : io-spi-out ( b -- ) spicmd! spi-cmd-wait ; : io-spi-reprogrammed ( -- ) - ." Powering off..." d# 2000 ms cr - power-off -\ kbc-on + ." Restarting..." d# 2000 ms cr + kbc-on \ ." Keyboard back on" cr ; @@ -266,8 +265,8 @@ 7 to spi-us \ Measured time for "1 fea9 ec!" is 7.9 uS + ignore-power-button \ Guard against the user panicing kbc-off - disable-power-button \ Guard against the user panicing ; : use-local-ec ( -- ) ['] io-spi-start to spi-start ; use-local-ec

1 0

r634 - cpu/x86/pc/olpc
by svn＠openbios.org Sept. 19, 2007

Sept. 19, 2007

Author: wmb Date: 2007-09-20 01:58:43 +0200 (Thu, 20 Sep 2007) New Revision: 634 Modified: cpu/x86/pc/olpc/security.fth Log: OLPC security - added dispostion code to lease and devkey formats. Modified: cpu/x86/pc/olpc/security.fth =================================================================== --- cpu/x86/pc/olpc/security.fth 2007-09-19 23:57:43 UTC (rev 633) +++ cpu/x86/pc/olpc/security.fth 2007-09-19 23:58:43 UTC (rev 634) @@ -283,7 +283,7 @@ \ including serial number, UUID, and expiration time, is place. \ That string is the signed object for lease and developer key verification. -d# 65 buffer: machine-id-buf +d# 67 buffer: machine-id-buf \ get-my-sn get the machine identification info including serial number \ and UUID from the manufacturing data, placing it into machine-id-buf @@ -315,6 +315,8 @@ [char] : machine-id-buf d# 48 + c! + [char] : machine-id-buf d# 50 + c! + false ; @@ -333,10 +335,12 @@ : check-machine-signature ( sig$ expiration$ -- -1|1 ) 0 hashname c! - machine-id-buf d# 49 + swap move ( sig$ ) - machine-id-buf d# 65 2swap valid? if 1 else -1 then + machine-id-buf d# 51 + swap move ( sig$ ) + machine-id-buf d# 67 2swap valid? if 1 else -1 then ; +: set-disposition ( adr -- ) c@ machine-id-buf d# 49 + c! ; + \ check-lease checks a lease signature record in act01: format \ -1 means lease is for this machine and is invalid @@ -348,16 +352,23 @@ " Not act01:" ?lease-debug-cr 2drop -1 exit then + bl left-parse-string ( rem$ serial$ ) my-sn$ $= 0= if ( rem$ ) " is for a different system" ?lease-debug-cr 2drop 0 exit then ( rem$ ) + + \ Disposition code + bl left-parse-string 1 <> if 3drop -1 exit then ( rem$ disp-adr ) + set-disposition ( rem$ ) + bl left-parse-string ( sig$ expiration$ ) dup d# 16 <> if ( sig$ expiration$ ) " has bad expiration format" ?lease-debug-cr 4drop -1 exit then ( sig$ expiration$ ) + 2dup expired? if " expired" ?lease-debug-cr 4drop -1 exit @@ -535,6 +546,10 @@ bl left-parse-string ( rem$ serial$ ) my-sn$ $= 0= if 2drop 0 exit then ( rem$ ) + \ Disposition code + bl left-parse-string 1 <> if 3drop -1 exit then ( rem$ disp-adr ) + set-disposition ( rem$ ) + develkey$ to pubkey$ " 00000000T000000Z" check-machine-signature ;

1 0

r633 - cpu/x86/pc/olpc
by svn＠openbios.org Sept. 19, 2007

Sept. 19, 2007

Author: wmb Date: 2007-09-20 01:57:43 +0200 (Thu, 20 Sep 2007) New Revision: 633 Modified: cpu/x86/pc/olpc/fw.bth Log: OLPC build - Load sound.fth Modified: cpu/x86/pc/olpc/fw.bth =================================================================== --- cpu/x86/pc/olpc/fw.bth 2007-09-19 22:22:01 UTC (rev 632) +++ cpu/x86/pc/olpc/fw.bth 2007-09-19 23:57:43 UTC (rev 633) @@ -339,6 +339,7 @@ fload ${BP}/cpu/x86/pc/olpc/setwp.fth fload ${BP}/ofw/gui/ofpong.fth fload ${BP}/cpu/x86/pc/olpc/life.fth +fload ${BP}/cpu/x86/pc/olpc/sound.fth : olpc-power-off ( -- ) gx-power-off \ Try the nice way first d# 20 ms

1 0

r632 - cpu/x86/pc/olpc dev dev/olpc/dcon
by svn＠openbios.org Sept. 19, 2007

Sept. 19, 2007

Author: wmb Date: 2007-09-20 00:22:01 +0200 (Thu, 20 Sep 2007) New Revision: 632 Modified: cpu/x86/pc/olpc/fw.bth dev/olpc/dcon/dcon.fth dev/pckbd.fth Log: OLPC - made it possible to control screen brightness and startup sound volume from the keyboard. Modified: cpu/x86/pc/olpc/fw.bth =================================================================== --- cpu/x86/pc/olpc/fw.bth 2007-09-19 22:21:09 UTC (rev 631) +++ cpu/x86/pc/olpc/fw.bth 2007-09-19 22:22:01 UTC (rev 632) @@ -347,6 +347,39 @@ ' olpc-power-off to power-off [then] +: dimmer ( -- ) screen-ih if " dimmer" screen-ih $call-method then ; +: brighter ( -- ) screen-ih if " brighter" screen-ih $call-method then ; + +dev /8042/keyboard +0 value waiting-up? +: olpc-check-abort ( scan-code -- abort? ) \ Square pressed? + last-scan over to last-scan ( scan-code old-scan-code ) + h# e0 <> if drop false exit then ( scan-code ) + + check-abort? 0= if drop false exit then ( scan-code ) + + dup h# 7f and h# 5d <> if drop false exit then ( scan-code ) + + h# 80 and if \ Up + false to waiting-up? + false ( abort? ) + else + secure? if false else waiting-up? 0= then ( abort? ) + true to waiting-up? + then +; +patch olpc-check-abort check-abort get-scan + +: handle-volume? ( scan-code -- scan-code flag ) + dup h# 43 = if dimmer true exit then + dup h# 44 = if brighter true exit then + dup h# 57 = if softer true exit then + dup h# 58 = if louder true exit then + false +; +' handle-volume? to scan-handled? +dend + \ Eliminate 4 second delay in install console for the case where \ there is no keyboard. The delay is unnecessary because the screen \ does not go blank when the device is closed. @@ -477,14 +510,6 @@ ?usb-keyboard ; -: start-sound ( -- ) - playback-volume >r d# -9 to playback-volume - ['] load-started behavior >r - ['] noop to load-started - " rom:splash" ['] $play-wav catch if 2drop then - r> to load-started - r> to playback-volume -; : go-hook-freeze [ ' go-hook behavior compile, ] 0 " set-source" $call-screen @@ -492,11 +517,11 @@ : freeze ( -- ) ['] go-hook-freeze to go-hook ; : unfreeze ( -- ) ['] usb-quiet to go-hook ; -: ?start-sound ( -- ) - game-key-mask h# 40 and 0= if start-sound then +: ?sound ( -- ) + game-key-mask h# 40 and 0= if sound then ; : ?freeze ( -- ) - game-key-mask h# 10 and 0= if freeze then + game-key-mask h# 40 and 0= if freeze then ; : ?games ( -- ) game-key-mask h# 20 and if @@ -517,7 +542,8 @@ fast-boot? if stdout off probe-pci - ?start-sound + ?sound + open-keyboard ?freeze ['] false to interrupt-auto-boot? probe-usb @@ -528,12 +554,11 @@ [then] auto-boot screen-ih stdout ! - open-keyboard ?usb-keyboard else banner probe-pci - ?start-sound + ?sound open-keyboard ?games ?freeze Modified: dev/olpc/dcon/dcon.fth =================================================================== --- dev/olpc/dcon/dcon.fth 2007-09-19 22:21:09 UTC (rev 631) +++ dev/olpc/dcon/dcon.fth 2007-09-19 22:22:01 UTC (rev 632) @@ -117,6 +117,9 @@ : timeout! ( to -- ) 8 dcon! ; \ def: h# ffff : scanint! ( si -- ) 9 dcon! ; \ def: h# 0000 : bright! ( level -- ) d# 10 dcon! ; \ def: h# xxxF +: bright@ ( -- level ) d# 10 dcon@ ; +: brighter ( -- ) bright@ 1+ h# f min bright! ; +: dimmer ( -- ) bright@ 1- 0 max bright! ; \ Colour swizzle, AA, no passthrough, backlight : set-color ( color? -- ) Modified: dev/pckbd.fth =================================================================== --- dev/pckbd.fth 2007-09-19 22:21:09 UTC (rev 631) +++ dev/pckbd.fth 2007-09-19 22:22:01 UTC (rev 632) @@ -386,6 +386,8 @@ init-data kbd-reset 0= to keyboard-present? ; +defer scan-handled? +' false to scan-handled? headerless : check-abort ( scan-code -- flag ) \ Ctrl-break pressed? check-abort? if @@ -409,12 +411,11 @@ begin get-data? while ( scan-code ) - dup enque ( scan-code ) - \ In the following code, we must be careful to unlock the \ queue before calling user-abort, because a timer interrupt \ can occur at any time after user-abort is executed. - check-abort if + dup check-abort if ( scan-code ) + drop unlock user-abort \ Wait here for long enough to ensure that an alarm timer tick \ will happen if it is going to happen. This is the safest @@ -430,7 +431,8 @@ \ if the alarm tick is turned off. d# 20 ms exit - then + then ( scan-code ) + scan-handled? if drop else enque then ( ) repeat unlock ;

1 0

r631 - cpu/x86/pc/olpc
by svn＠openbios.org Sept. 19, 2007

Sept. 19, 2007

Author: wmb Date: 2007-09-20 00:21:09 +0200 (Thu, 20 Sep 2007) New Revision: 631 Modified: cpu/x86/pc/olpc/devices.fth Log: OLPC - set the EC date from the RTC at startup, per Quanta's request. They need the date for long-term battery-management purposes. Modified: cpu/x86/pc/olpc/devices.fth =================================================================== --- cpu/x86/pc/olpc/devices.fth 2007-09-19 22:19:21 UTC (rev 630) +++ cpu/x86/pc/olpc/devices.fth 2007-09-19 22:21:09 UTC (rev 631) @@ -117,34 +117,12 @@ devalias n nand devalias sd /sd/disk - dev /8042 [ifndef] lx-devel patch false ctlr-selftest open [then] device-end -dev /8042/keyboard -0 value waiting-up? -: olpc-check-abort ( scan-code -- abort? ) \ Square pressed? - last-scan over to last-scan ( scan-code old-scan-code ) - h# e0 <> if drop false exit then ( scan-code ) - - check-abort? 0= if drop false exit then ( scan-code ) - - dup h# 7f and h# 5d <> if drop false exit then ( scan-code ) - - h# 80 and if \ Up - false to waiting-up? - false ( abort? ) - else - waiting-up? 0= ( abort? ) - true to waiting-up? - then -; -patch olpc-check-abort check-abort get-scan -dend - 0 0 " i70" " /isa" begin-package \ Real-time clock node fload ${BP}/dev/ds1385r.fth 8 encode-int 0 encode-int encode+ " interrupts" property @@ -272,6 +250,10 @@ sci-quiet ; +stand-init: Date to EC + time&date d# 2000 - ec-date! 3drop +; + stand-init: Wireless reset [ifdef] lx-devel exit [then]

1 0

r630 - cpu/x86/pc/olpc dev/geode/ac97
by svn＠openbios.org Sept. 19, 2007

Sept. 19, 2007

Author: wmb Date: 2007-09-20 00:19:21 +0200 (Thu, 20 Sep 2007) New Revision: 630 Added: cpu/x86/pc/olpc/sound.fth Modified: dev/geode/ac97/ac97.fth Log: OLPC audio - Added persistent storage for the startup sound playback volume. Added: cpu/x86/pc/olpc/sound.fth =================================================================== --- cpu/x86/pc/olpc/sound.fth (rev 0) +++ cpu/x86/pc/olpc/sound.fth 2007-09-19 22:19:21 UTC (rev 630) @@ -0,0 +1,64 @@ +purpose: Manage startup sound, with persistent storage for its volume +\ See license at end of file + +h# -9 constant default-volume +: set-saved-volume ( volume -- ) dup h# 80 cmos! invert h# 81 cmos! ; + +: get-saved-volume ( -- volume ) + h# 80 cmos@ h# 81 cmos@ ( volume check ) + over xor h# ff <> if ( volume ) + drop default-volume set-saved-volume + default-volume + then + + dup h# 80 and if \ Sign extend + h# ffffff00 or + else + dup 0> if + drop default-volume set-saved-volume + default-volume + then + then +; + +: +volume ( increment -- ) + get-saved-volume + 0 min d# -50 max set-saved-volume + audio-ih if get-saved-volume " set-volume" $call-audio then +; +: softer ( -- ) -2 +volume ; +: louder ( -- ) 2 +volume ; + +: sound ( -- ) + get-saved-volume d# -50 <= if exit then + playback-volume >r get-saved-volume to playback-volume + ['] load-started behavior >r + ['] noop to load-started + " rom:splash" ['] $play-wav catch if 2drop then + r> to load-started + r> to playback-volume +; + + +\ LICENSE_BEGIN +\ Copyright (c) 2006 FirmWorks +\ +\ Permission is hereby granted, free of charge, to any person obtaining +\ a copy of this software and associated documentation files (the +\ "Software"), to deal in the Software without restriction, including +\ without limitation the rights to use, copy, modify, merge, publish, +\ distribute, sublicense, and/or sell copies of the Software, and to +\ permit persons to whom the Software is furnished to do so, subject to +\ the following conditions: +\ +\ The above copyright notice and this permission notice shall be +\ included in all copies or substantial portions of the Software. +\ +\ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, +\ EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +\ MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND +\ NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE +\ LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION +\ OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION +\ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. +\ +\ LICENSE_END Modified: dev/geode/ac97/ac97.fth =================================================================== --- dev/geode/ac97/ac97.fth 2007-09-19 22:17:59 UTC (rev 629) +++ dev/geode/ac97/ac97.fth 2007-09-19 22:19:21 UTC (rev 630) @@ -225,6 +225,7 @@ : set-volume ( db -- ) dup 0> if drop 0 then negate 1+ 2* 3 / dup bwjoin to volume + volume h# 38 codec! \ headphone/surround output pin gain ; : open-out ( -- )

1 0

r629 - cpu/x86/pc/olpc
by svn＠openbios.org Sept. 19, 2007

Sept. 19, 2007

Author: wmb Date: 2007-09-20 00:17:59 +0200 (Thu, 20 Sep 2007) New Revision: 629 Modified: cpu/x86/pc/olpc/setwp.fth Log: OLPC manufacturing data - new "change-tag" and "add-tag" commands. Modified: cpu/x86/pc/olpc/setwp.fth =================================================================== --- cpu/x86/pc/olpc/setwp.fth 2007-09-19 22:17:16 UTC (rev 628) +++ cpu/x86/pc/olpc/setwp.fth 2007-09-19 22:17:59 UTC (rev 629) @@ -32,10 +32,10 @@ \ Find RAM address of tag, given FLASH address : tag>ram-adr ( adr len -- ram-adr ) - drop 2+ ( adr' ) \ Address of "ww" tag + drop ( adr' ) \ Address of "ww" tag rom-pa mfg-data-offset + - ( offset ) - dup /flash-block u>= abort" Bad ww offset" \ Sanity check + dup /flash-block u>= abort" Bad tag offset" \ Sanity check mfg-data-buf + ( ram-adr ) ; @@ -44,7 +44,8 @@ : mfg-data-setup ( tag$ -- ram-adr ) get-mfg-data 2dup find-tag 0= if ." No " type ." tag" cr abort then ( tag$ adr len ) - tag>ram-adr >r ( tag$ r: ram-adr ) + \ The 2+ below skips the length bytes to the tagname field + tag>ram-adr 2+ >r ( tag$ r: ram-adr ) r@ 2 $= 0= abort" Tag mismatch in RAM" ( r: ram-adr ) r> ; @@ -69,3 +70,66 @@ board-revision h# b48 < abort" Only supported on B4 and later" set-wp ; + +: ?tagname-valid ( tagname$ -- tagname$ ) + dup 2 <> abort" Tag name must be 2 characters long" +; +: tag-setup ( tagname$ -- ram-value$ ) + ?tagname-valid + get-mfg-data + 2dup find-tag 0= if ." No " type ." tag" cr abort then ( tagname$ value$ ) + 2nip ( value$ ) + tuck tag>ram-adr swap ( ram-value$ ) +; + +: value-mismatch? ( new-value$ old-value$ -- flag ) + dup if + \ non-empty old value string + 2dup + 1- c@ 0= if ( new-value$ old-value$ ) + \ Old value ends in null character; subtract that from the count + 1- ( new-value$ old-value$' ) + then ( new-value$ old-value$ ) + rot <> ( new-adr old-adr flag ) + nip nip ( old-len new-value$ ) + else ( new-value$ old-value$ ) + \ empty old value string; new one had better be empty too + 2drop 0<> nip ( flag ) + then +; + +: $change-tag ( value$ tagname$ -- ) + tag-setup ( new-value$ old-value$ ) + 2over 2over value-mismatch? abort" New value and old value have different lengths" + drop swap move ( ) + put-mfg-data +; + +: change-tag ( "tagname" "new-value" -- ) + safe-parse-word ( tagname$ ) + 0 parse ( tagname$ new-value$ ) + 2swap $change-tag +; + +: ram-last-mfg-data ( -- adr ) + mfg-data-buf /flash-block + last-mfg-data +; + +: $add-tag ( value$ name$ -- ) + ?tagname-valid ( value$ name$ ) + 2dup find-tag abort" Tagname already exists" ( value$ name$ ) + get-mfg-data + ram-last-mfg-data >r ( value$ name$ r: adr ) + 2 pick 1+ over + 3 + ( value$ name$ record-len r: adr ) + r@ over - mfg-data-buf u<= abort" Not enough space for new tag" + r@ over - swap ?erased ( value$ name$ r: adr ) + r@ 2- swap move ( value$ r: adr ) + dup 1+ dup r@ 3 - c! invert r@ 4 - c! ( value$ r: adr ) + 0 r@ 5 - c! ( value$ r: adr ) + r> 5 - over - ( value$ data-adr ) + swap move + put-mfg-data +; + +: add-tag ( "name$" "value$" -- ) + safe-parse-word 0 parse 2swap $add-tag +;

1 0