Re: [flashrom] [PATCH 4/8] ichspi.c: preserve reserved bits in address registers
Am 28.06.2011 05:33 schrieb Stefan Tauner:
Signed-off-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>
Makes sense, but I worry that this might eventually break something. Do we (want to) report the inital address setting during programmer init, especially the reserved bits? Anyway, this is Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Regards, Carl-Daniel -- http://www.hailfinger.org/
On Fri, 01 Jul 2011 01:21:33 +0200 Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> wrote:
Am 28.06.2011 05:33 schrieb Stefan Tauner:
Signed-off-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>
Makes sense, but I worry that this might eventually break something. Do we (want to) report the inital address setting during programmer init, especially the reserved bits?
we do the usual register dumping for SPIA on ICH7 and VIA, but we dont print the equivalent FADDR in the ICH9 branch. patch appended.
Anyway, this is Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
thanks, r1362 -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner
On Thu, Jun 30, 2011 at 5:52 PM, Stefan Tauner < stefan.tauner@student.tuwien.ac.at> wrote:
On Fri, 01 Jul 2011 01:21:33 +0200 Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> wrote:
Am 28.06.2011 05:33 schrieb Stefan Tauner:
Signed-off-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>
Makes sense, but I worry that this might eventually break something. Do we (want to) report the inital address setting during programmer init, especially the reserved bits?
we do the usual register dumping for SPIA on ICH7 and VIA, but we dont print the equivalent FADDR in the ICH9 branch. patch appended.
Acked-by: David Hendricks <dhendrix@google.com> -- David Hendricks (dhendrix) Systems Software Engineer, Google Inc.
participants (3)
-
Carl-Daniel Hailfinger -
David Hendricks -
Stefan Tauner