Re: [flashrom] [PATCH] Fix NULL pointer reference in board_flash_enable.
On Fri, 12 Mar 2010, Michael Karcher wrote:
Was introduced in r926. Found by Henrik Kretzschmar <henne@nachtwindheim.de>.
Signed-off-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
Imo looks sane and should be commited. Acked-by: Maciej Pijanka <maciej.pijanka@gmail.com>
--- board_enable.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/board_enable.c b/board_enable.c index aa463bc..0e89137 100644 --- a/board_enable.c +++ b/board_enable.c @@ -1445,7 +1445,7 @@ int board_flash_enable(const char *vendor, const char *part) if (!board) board = board_match_pci_card_ids();
- if (board->status == NT) { + if (board && board->status == NT) { if (!force_boardenable) { printf("WARNING: Your mainboard is %s %s, but the mainboard-specific\n" --
-- Maciej Pijanka I don't fear computers, I fear lack of them -- Isaac Asimov
Am 11.03.2010 23:46 schrieb Maciej Pijanka:
On Fri, 12 Mar 2010, Michael Karcher wrote:
Was introduced in r926. Found by Henrik Kretzschmar <henne@nachtwindheim.de>.
Signed-off-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
Imo looks sane and should be commited.
Acked-by: Maciej Pijanka <maciej.pijanka@gmail.com>
For the record, this was committed in r930. Regards, Carl-Daniel -- http://www.hailfinger.org/
participants (2)
-
Carl-Daniel Hailfinger -
Maciej Pijanka