May 2024 - flashrom - mail.coreboot.org

Re: Support for GD25LR512ME flash chip.
by Anastasia Klimchuk Nov. 1, 2024

Nov. 1, 2024

Victor, Thank you so much for the datasheets! I did a review of the pending patch, and now it will be possible to finally finish the patch from 2021 and get the chips submitted. Also thank you for attaching the log. Not sure if the log is complete? It ends at the start of the reading operation, but there is no final message of SUCCESS or FAIL. However, importantly, I could see in the beginning of the log which platform was detected, and it is Promontory. Which means... Avinash, Most likely you are hitting a known issue, you can read more details here: https://ticket.coreboot.org/issues/370 The issue is for Promontory, and also for chips larger than 16Mbyte: which is exactly what you have. I was actually trying to get help from AMD with this issue, so it's really good to have you here on the mailing list! Maybe you can help? Someone from AMD would be in the best position to fix Promontory, you have all the datasheets available, and all the hardware. Thank you! On Sat, May 11, 2024 at 9:40 PM Vlim <vlim(a)gigadevice.com> wrote: > > Hi, Anastasia, > > Please find the attached datasheet for GD25LR256E and GD25LR512ME. > > There are actually two issues. > > the released flashrom does not support GD25LR256E and GD25LR512ME. > With my patch, the dediprog programmer works for GD25LR512ME. But the AMD internal programmer for Birman Plus Board does not work. Output file attached. > > > This is the comment about Birman Plus Board > > Now, Flashrom can detect the flash chip. > Using dediprog programmer I can read/write the flash chip successfully. > Whereas with using the internal programmer i.e. "-p internal" the read/write is failing. I am attaching the log here. > Please give your input on this. > > > Regards, > > Victor > > > ________________________________ > From: Anastasia Klimchuk <aklm(a)chromium.org> > Sent: Saturday, May 11, 2024 17:59 > To: Vlim <vlim(a)gigadevice.com>; Munduru, Avinash <avinash.munduru(a)amd.com> > Cc: flashrom(a)flashrom.org <flashrom(a)flashrom.org> > Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip. > > 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息 > This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information > > There is another thing, in addition to my previous message. > > I looked into the patch which adds chip definitions (this one > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.co…) and the reason it is > pending is there are no links to datasheets (old links are not working > anymore). > It is unfortunate that the patch is pending since 2021, but I want to > try to fix the situation now, in the year 2024. > > Victor, maybe you know, is it possible to find datasheets for > GD25LR256E and GD251R512ME? I could finish the old patch and get chips > into the tree. > > This is a separate question to Avinash's issue with internal > programmer, but for this we need the very verbose log (which is log > with -VVV option on command line). > > Thank you! > > On Thu, May 9, 2024 at 11:03 PM Anastasia Klimchuk <aklm(a)chromium.org> wrote: > > > > Avinash, I read the thread and I see you are saying "I am attaching > > the log here" but I don't see the log? maybe you can re-send it again, > > now with the mailing list? (perhaps you sent it to Victor only?) > > Yes it is also important to know your board, since you are saying the > > chip worked successfully with dediprog, but not with the internal > > programmer. > > > > Victor, thank you so much for helping! > > > > > > On Mon, May 6, 2024 at 6:42 PM Vlim <vlim(a)gigadevice.com> wrote: > > > > > > Thanks, Avinash, > > > > > > Can you advise which board are you using? > > > I have tested this patch with the USB programmer only since I do not have access to the motherboard. > > > > > > Hi, Flashrom team, > > > Can you also help on this? > > > > > > > > > Regards, > > > > > > Victor Lim > > > FAE Director > > > GigaDevice Semiconductor > > > 4088833856 > > > vlim(a)gigadevice.com > > > > > > ________________________________ > > > From: Munduru, Avinash <Avinash.Munduru(a)amd.com> > > > Sent: Monday, May 6, 2024 16:24 > > > To: Vlim <vlim(a)gigadevice.com>; flashrom(a)flashrom.org <flashrom(a)flashrom.org> > > > Subject: Re: Support for GD25LR512ME flash chip. > > > > > > You don't often get email from avinash.munduru(a)amd.com. Learn why this is important > > > 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息 > > > This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information > > > > > > [AMD Official Use Only - General] > > > > > > > > > Hi Victor, > > > > > > Thanks for sharing the patch. Here is an update after trying the shared patch. > > > > > > Now, Flashrom can detect the flash chip. > > > Using dediprog programmer I can read/write the flash chip successfully. > > > Whereas with using the internal programmer i.e. "-p internal" the read/write is failing. I am attaching the log here. > > > Please give your input on this. > > > > > > Once again! Thanks for your help! > > > > > > > > > ________________________________ > > > From: Vlim <vlim(a)gigadevice.com> > > > Sent: Sunday, May 5, 2024 1:54 PM > > > To: flashrom(a)flashrom.org <flashrom(a)flashrom.org>; Munduru, Avinash <Avinash.Munduru(a)amd.com> > > > Subject: Re: Support for GD25LR512ME flash chip. > > > > > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > > > > Hi, Avinash, > > > > > > Sorry that I am working on adding this part to Flashrom, but has not completed the entire process. > > > > > > Can you please use the attached flashchips.c and flashshchips.h and replace that in flashrom distribution? > > > > > > This is the process. > > > > > > git clone "https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.co…" > > > > > > meson setup builddir > > > meson compile -C builddir > > > meson test -C builddir > > > meson install -C builddir > > > > > > > > > Please also refer to the following link for compilation of the code. > > > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fflashrom.… > > > > > > I have a compiled version for Ubuntu Linux, if that will help, I can share with you. > > > > > > Regards, > > > > > > Victor Lim > > > GigaDevice Semiconductors Inc. > > > 4088833856 > > > vlim(a)gigadevice.com > > > > > > > > > ________________________________ > > > From: Munduru, Avinash via flashrom <flashrom(a)flashrom.org> > > > Sent: Tuesday, April 30, 2024 16:54 > > > To: flashrom(a)flashrom.org <flashrom(a)flashrom.org> > > > Subject: [flashrom] Re: Support for GD25LR512ME flash chip. > > > > > > 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息 > > > This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information > > > > > > [AMD Official Use Only - General] > > > > > > > > > + attaching the output log > > > > > > ________________________________ > > > From: Munduru, Avinash > > > Sent: Tuesday, April 30, 2024 2:04 PM > > > To: flashrom(a)flashrom.org <flashrom(a)flashrom.org> > > > Subject: Support for GD25LR512ME flash chip. > > > > > > Hi, > > > > > > Currently, flash chip support for GD25LR512ME is not supported in flashrom utility. > > > Please share a patch if it is already available. If not let me know how I can modify it. > > > > > > _______________________________________________ > > > flashrom mailing list -- flashrom(a)flashrom.org > > > To unsubscribe send an email to flashrom-leave(a)flashrom.org > > > > > > > > -- > > Anastasia. > > > > -- > Anastasia. -- Anastasia.

3 11

Adding support for a new chip
by Jean-Baptiste Skutnik June 7, 2024

June 7, 2024

Hello all, I broke my motherboard and flashrom would help me save 300$. I need to flash the BIOS chip and unfortunately, only the older version of the chip seems to be supported, so I would need to patch support in. The chip is the Winbond W25X40CL, which appears to be an upgrade over the W25X40 that flashrom supports. However, when hooking it up, the latter is detected and only the first 500K are available. I would need some guidance on what to do next. Looking through the gerrit I see the patches for new chip support add to flashchips.c and include/flashchips.h. Is there some documentation on what the fields represent in there so that I am not plugging randomly ? How does the process work when recognizing chips ? Would adding this chip create a conflict with its predecessor ? Thanks, JB

2 1

Issue with Flashrom: Failed Erase Operation
by Imed Hanchour May 16, 2024

May 16, 2024

I am writing to report an issue I encountered while attempting to use Flashrom on my system. I am currently using Flashrom version 1.4.0-devel on a Raspberry Pi running Linux 5.15.61-v7+ (armv7l). When trying to perform an erase operation on a Macronix flash chip "MX25U3235E/F" (4096 kB, SPI) using the linux_spi interface, I encountered the following error: FAILED at 0x00000000! Expected=0xff, Found=0x00, failed byte count from 0x00000000-0x003fffff: 0x3b5631 ERASE FAILED! Erase/write done from 0 to 3fffff Erase FailedYour flash chip is in an unknown state. I have attempted to troubleshoot the issue by ensuring proper connections and trying the operation multiple times without success. I have also verified that the flash chip is supported by Flashrom. Could you please provide guidance on how to resolve this issue or any additional troubleshooting steps I can take? I am eager to contribute to resolving this problem and willing to provide any further information or logs that may be needed. Thank you for your attention to this matter. I appreciate your support and assistance. Best regards Imed

1 1

RFC: removing 1 second verification delay
by Brian Norris May 12, 2024

May 12, 2024

Background: https://review.coreboot.org/c/flashrom/+/80807 A long time ago, in the pre-git times [1], flashrom added a 1 second delay to all verification, and claimed that some chips "need some time to calm down." The commit message claims it "fixes a few reports where verify directly after erase had unpleasant side effects like corrupting flash or at least getting incorrect verify results." It provides no details of what systems, chips, or programmers were involved. This delay remains in the --verify path today, and IMO, it's a big waste of time. If there are truly chips that are, say, deasserting the BUSY line before they're truly finished programming ... well, we should track those chips down and add targeted quirk flags for them. We shouldn't penalize all flashrom users in all cases for all time. Personally, I highly doubt that this delay is still relevant today -- there may have been a bug in some programmer that has since been fixed; there may have been some malfunctioning system that is no longer in use; ... or it's possible this is still hiding a real buggy chip somewhere out there. I propose: we still remove the delay. There's plenty of description in the above Gerrit link about why, and how we can handle regressions. (For one, it's relatively simple to split up a --verify operation into its constituent --write/sleep/--read operations, for debugging.) The request: 1. Tests: I've tested a few Chromebooks, but imagine this had to have been some more esoteric system. Extra testing is welcome. 2. Thoughts: does my proposal make sense? Am I missing something obvious? 3. Awareness: if nothing else, this email may serve to highlight in case we land the above patch and later hear back that there are some sketchy --verify reports from users. Thanks, Brian [1] The svn->git commit in question: commit 8ab49e72af8465d4527de2ec37b22cd44f7a1169 Date: Wed Aug 19 13:55:34 2009 +0000 Disallow erase/write for known bad chips so people won't try without a clear understanding

3 7

Re: Support for GD25LR512ME flash chip.
by Vlim May 11, 2024

May 11, 2024

Thanks, Avinash, Can you advise which board are you using? I have tested this patch with the USB programmer only since I do not have access to the motherboard. Hi, Flashrom team, Can you also help on this? Regards, Victor Lim FAE Director GigaDevice Semiconductor 4088833856 vlim(a)gigadevice.com ________________________________ From: Munduru, Avinash <Avinash.Munduru(a)amd.com> Sent: Monday, May 6, 2024 16:24 To: Vlim <vlim(a)gigadevice.com>; flashrom(a)flashrom.org <flashrom(a)flashrom.org> Subject: Re: Support for GD25LR512ME flash chip. You don't often get email from avinash.munduru(a)amd.com. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息 This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information [AMD Official Use Only - General] Hi Victor, Thanks for sharing the patch. Here is an update after trying the shared patch. Now, Flashrom can detect the flash chip. Using dediprog programmer I can read/write the flash chip successfully. Whereas with using the internal programmer i.e. "-p internal" the read/write is failing. I am attaching the log here. Please give your input on this. Once again! Thanks for your help! [cid:106c2846-2fbe-4c90-a577-2a5266807244] ________________________________ From: Vlim <vlim(a)gigadevice.com> Sent: Sunday, May 5, 2024 1:54 PM To: flashrom(a)flashrom.org <flashrom(a)flashrom.org>; Munduru, Avinash <Avinash.Munduru(a)amd.com> Subject: Re: Support for GD25LR512ME flash chip. Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Hi, Avinash, Sorry that I am working on adding this part to Flashrom, but has not completed the entire process. Can you please use the attached flashchips.c and flashshchips.h and replace that in flashrom distribution? This is the process. git clone "https://review.coreboot.org/flashrom" meson setup builddir meson compile -C builddir meson test -C builddir meson install -C builddir Please also refer to the following link for compilation of the code. https://flashrom.org/dev_guide/building_from_source.html I have a compiled version for Ubuntu Linux, if that will help, I can share with you. Regards, Victor Lim GigaDevice Semiconductors Inc. 4088833856 vlim(a)gigadevice.com ________________________________ From: Munduru, Avinash via flashrom <flashrom(a)flashrom.org> Sent: Tuesday, April 30, 2024 16:54 To: flashrom(a)flashrom.org <flashrom(a)flashrom.org> Subject: [flashrom] Re: Support for GD25LR512ME flash chip. 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息 This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information [AMD Official Use Only - General] + attaching the output log [cid:3861d565-f2f4-472d-b4f0-cadd6bc4980e] ________________________________ From: Munduru, Avinash Sent: Tuesday, April 30, 2024 2:04 PM To: flashrom(a)flashrom.org <flashrom(a)flashrom.org> Subject: Support for GD25LR512ME flash chip. Hi, Currently, flash chip support for GD25LR512ME is not supported in flashrom utility. Please share a patch if it is already available. If not let me know how I can modify it. [cid:5890692a-9560-47ca-bacb-7255839da891]

2 2

Support for GD25LR512ME flash chip.
by Munduru, Avinash May 6, 2024

May 6, 2024

[AMD Official Use Only - General] Hi, Currently, flash chip support for GD25LR512ME is not supported in flashrom utility. Please share a patch if it is already available. If not let me know how I can modify it. [cid:5890692a-9560-47ca-bacb-7255839da891]

2 2

FAILED: Acer VN7-571G
by Zatrit May 2, 2024

May 2, 2024

I have a full flash memory dump on my Raspberry Pi, which I use as a programmer, can I reboot my laptop in this case?

1 0