September 2022 - flashrom - mail.coreboot.org

GSOC'23
by Prakhar Agrawal Sept. 30, 2022

Sept. 30, 2022

Hello, My name is Prakhar Agrawal and I am a final year undergraduate student at Amrita university with a major in Electronics and Communications Engineering. (2019-23). I am really interested in contributing to the flashrom community, I have some prior internship experience with PCB designing and programming. I am new to the open source world and I will be trying for GSOC'23. Can someone please guide me on how to start contributing to the community, and share referral materials if any? Eagerly awaiting your response! Best Regards -- Prakhar Agrawal Visiting Researcher Department of Mechanical and Industrial Engineering Toronto Metropolitan University, Toronto M2B 2M2, Ontario, Canada 4th-year Undergraduate Student Department of Electronics and Communications Engineering, Amrita Vishwa Vidhyapeetham, Amritapuri Kollam 690525, India m: (+91) 9653063821 e: prakharagrawal(a)am.students.amrita.edu

2 1

No dev meetings in October, Changed meeting times
by Felix Singer Sept. 25, 2022

Sept. 25, 2022

Hello all, You might have already noticed the changed flashrom dev meeting appointments on the mailing list. Due to the changing daylight saving times, we will have no dev meetings in October, but they will continue from early November with a different time again. So, starting from November the meeting time will be as follow for the next months: 21:00 - 22:00 UTC+0 The next meeting will be on *** 2./3. November *** (depending where you are located ;)). Save the date, see you there! :) // Felix

1 0

flashrom dev meeting notes 38/2022
by Felix Singer Sept. 25, 2022

Sept. 25, 2022

# 23th Sep 2022, 6:00 - 7:00 UTC+0 Attendees: Thomas, Edward, Felix, Alex, Anastasia ## Decision summary * No decisions but a reminder: no meetings for October. Next one is 2th November at 21:00 UTC+0 ## Agenda * Programmer delay , first 3 patches [https://review.coreboot.org/c/flashrom/+/67391](https://review.coreboot.org… can unblock removing global state for 2 programmers * Patches about flashchips , what is going on with them? [https://review.coreboot.org/c/flashrom/+/66781](https://review.coreboot.org… * Sb600spi needs to be fixed, there are some patches under review. Do we need to try getting documentation? * We need to coordinate the sequence on how the patches should go: there are several patches from different people on fixing Sb600spi * [Felix] Let’s introduce a specification how programmer parameters should look like * Yes this does need a spec * Lint? Might be complicated * Maybe just a set of rules, like we have coding style for example * We need to document the rules for programmer params (for example, use underscore and not hyphen) * And also we need to write more unit tests to cover the rules. Ideally every rule has a unit test to cover this rule (could be positive and error scenario) * Everyone please write tests ! * We need to extract parsing param code into the same function in each programmer: * `parse_params` as a name? * Can this be an Easy project (one per programmer) * TODO aklm will create a ticket * REMINDER: no meetings for October. Next one is 2th November at 21:00 UTC+0

1 0

flashrom dev meeting notes 36/2022
by Felix Singer Sept. 25, 2022

Sept. 25, 2022

# 8th Sep 2022, 6:00 - 7:00 UTC+0 Attendees: Thomas, Felix, Edward, Anastasia ## Decisions Summary * Felix gets submit rights * We need to document code review & merge rules (after the release) ## Agenda * [Felix / Anastasia] Giving Felix submit rights * I am already a submitter for the coreboot project since over a year * I commented and reviewed over [200 flashrom patches](https://review.coreboot.org/q/project:flashrom+commentby:felixsing… ) since autumn 2021 * Admin and Mentor for gsoc * YES, all approved! * [Felix]: What are the rules for submitting patches? 3 days? What else? * 3 days, but also * Needs +2 * Are there any other ongoing work that maybe should be merged first? * Are all comments resolved? * If there are several ongoing streams, which one is easier to rebase, easier to test? * Look for other people’s patches who don’t have submit rights, because they cannot do themselves. They might sit and wait, and will need to rebase many times. * All the rules need to be documented. * Maybe a small update on wiki to begin with * And after the release , do the proper documentation * [Felix] Urgent: We have to unbreak our tests in CI * I think updating the Docker containers will be done later (in ~2 weeks). coreboot release got rescheduled. * We should submit [this patch](https://review.coreboot.org/c/flashrom/+/67345) (and the follow- up) now to make unit tests with Jenkins working again. I don’t think we should wait any longer. * DONE! * [quasisec]: Can we get over the hump of reviewing the remaining [https://review.coreboot.org/c/flashrom/+/66720/](https://review.coreboot.or… flashrom.c/print.c cleanups And now most critically getting the bulk of the programmer init param plumbing patches reviewed and merged in the [https://review.coreboot.org/q/topic:programmer_init_param_globals](https://… topic. Keeping in review for a long time causes rebases that effectively nullify the work but the bulk of the patches are just boring plumbing that are nop. * Bringing the tree into consistent state: * Names for init functions * Start addr+offset VS start region + end region * chipoff_t and chipsize_t defined in flash.h * Layout regions * force_boardmismatch -> maybe it can be removed from flashctx and turned into a programmer param? * Checks for internal can be moved into internal maybe? * Internal is the most dangerous, and needs lots of checks * Cli * Needs to call libflashrom programmer init instead of programmer_init * Probe flash , the same * [Felix] Customized Buildbot commands using Gerrit comments * I am thinking about some use cases for user Buildbot commands, which are triggerable from Gerrit. Basically a Buildbot command is just a Gerrit comment, but Buildbot interprets it and can do something. * For example for build-testing if the binary is reproducible it could look like “@buildbot build reproducible”, which builds a binary before and after the specific patch and compares them. * I would like to know which ideas other people have or what their use cases would be. * Can we use flashrom_tester on buildbot? * Can we use EM100? * Can we have a command to retry build again?

1 0

[PATCH] serial.c: support BAUD rates > 230400 on macOS
by Denis Ahrens Sept. 25, 2022

Sept. 25, 2022

Signed-off-by: Denis Ahrens <denis(a)h3q.com> --- serial.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/serial.c b/serial.c index 72f9ef6..0f86e41 100644 --- a/serial.c +++ b/serial.c @@ -36,6 +36,10 @@ #include "programmer.h" #include "custom_baud.h" +#ifdef __APPLE__ +#include <IOKit/serial/ioss.h> +#endif + fdtype sp_fd = SER_INV_FD; /* There is no way defined by POSIX to use arbitrary baud rates. It only defines some macros that can be used to @@ -185,6 +189,14 @@ int serialport_config(fdtype fd, int baud) return 1; } wanted = observed; +#ifdef __APPLE__ + int fakebaud = 0; + if (baud > 230400) + { + fakebaud = baud; + baud = 115200; + } +#endif if (baud >= 0) { if (use_custom_baud(baud, sp_baudtable)) { if (set_custom_baudrate(fd, baud)) { @@ -244,6 +256,18 @@ int serialport_config(fdtype fd, int baud) } // FIXME: display actual baud rate - at least if none was specified by the user. #endif + +#ifdef __APPLE__ + if (fakebaud) + { + cfmakeraw(&wanted); + if (ioctl(fd, IOSSIOSPEED, &fakebaud) == -1) { + msg_perr("[WARN] ioctl(..., IOSSIOSPEED, %d).\n", fakebaud); + msg_perr_strerror("problem with IOSSIOSPEED"); + return 1; + } + } +#endif return 0; } -- 2.37.0 (Apple Git-136)

2 1

Need help with "Easy Projects" issue
by Lakshminarayana Malyala Sept. 23, 2022

Sept. 23, 2022

Hello Flashrom dev team, I am LN and I wanted to know how to start with Easy Projects/contributions in this project . I found some (Easy Projects) <https://ticket.coreboot.org/projects/flashrom/issues?utf8=%E2%9C%93&set_fil…> on Coreboot webpage and I just wanted to know if the mentioned issues from the attached page have been resolved or if they are open for contribution? As I notice the ‘Turn variable is_laptop into an enum <https://ticket.coreboot.org/issues/416>’ issue is open on the Coreboot page and seems to be an easy issue to resolve yet it appears to be solved on this page <https://review.coreboot.org/c/flashrom/+/66891>. I will be happy if someone can point me towards more such issues that are beginner friendly or to a developer guide to set up my workspace and read more about the project structure and source code, and I appreciate your help 🙂. Thanking you, LN

2 1

Updated invitation with note: Flashrom Dev Meeting @ Every 2 weeks from 8am to 9am on Thursday (AEDT) (flashrom@flashrom.org)
by aklm＠chromium.org Sept. 23, 2022

Sept. 23, 2022

This event has been updated with a note: "Moving to southern summer / northern winter time between November and March inclusive." Changed: title, time, description Flashrom Dev Meeting Every 2 weeks from 8am to 9am on Thursday Eastern Australia Time - Sydney Join with Google Meet https://meet.google.com/iuf-mtri-zva?hs=224 Join by phone (AU) +61 2 9051 6791 PIN: 304642402 More phone numbers https://tel.meet/iuf-mtri-zva?pin=9271993818880&hs=0 Regular meeting of Flashrom project developers. Meeting notes doc: https://docs.google.com/document/d/18qKvEbfPszjsJJGJhwi8kRVDUG3GZ… Guests aklm(a)chromium.org - creator felix.singer12(a)gmail.com david.hendricks(a)gmail.com quasisec(a)google.com nico.h(a)gmx.de src(a)posteo.de martonmiklosqdev(a)gmail.com piotr.krol(a)3mdeb.com Maciej Pijanowski michal.zygowski(a)3mdeb.com th3fanbus(a)gmail.com stefan.k.reinauer(a)gmail.com nartemiev(a)google.com arthur(a)aheymans.xyz flashrom(a)flashrom.org c-d.hailfinger.devel.2006(a)gmx.net evanbenn(a)google.com gaumless(a)gmail.com View all guest info https://calendar.google.com/calendar/event?action=VIEW&eid=MThuODBxZDAwZDZj… Reply for flashrom(a)flashrom.org and view more details https://calendar.google.com/calendar/event?action=VIEW&eid=MThuODBxZDAwZDZj… Your attendance is optional. ~~//~~ Invitation from Google Calendar: https://calendar.google.com/calendar/ You are receiving this email because you are an attendee on the event. To stop receiving future updates for this event, decline this event. Forwarding this invitation could allow any recipient to send a response to the organizer, be added to the guest list, invite others regardless of their own invitation status, or modify your RSVP. Learn more https://support.google.com/calendar/answer/37135#forwarding

1 0

Updated invitation: Flashrom Dev Meeting (monthly) @ Every 2 weeks from 4pm to 5pm on Thursday from Thu Apr 7 to Wed Nov 2 (AEST) (flashrom@flashrom.org)
by aklm＠chromium.org Sept. 23, 2022

Sept. 23, 2022

This event has been updated Changed: time Flashrom Dev Meeting (monthly) Every 2 weeks from 4pm to 5pm on Thursday from Thursday Apr 7 to Wednesday Nov 2 Eastern Australia Time - Sydney Join with Google Meet https://meet.google.com/iuf-mtri-zva?hs=224 Join by phone (AU) +61 2 9051 6791 PIN: 304642402 More phone numbers https://tel.meet/iuf-mtri-zva?pin=9271993818880&hs=0 Monthly meeting of Flashrom project developers. Meeting notes doc: https://docs.google.com/document/d/18qKvEbfPszjsJJGJhwi8kRVDUG3GZ… Guests aklm(a)chromium.org - creator felix.singer12(a)gmail.com david.hendricks(a)gmail.com quasisec(a)google.com nico.h(a)gmx.de Martin Roth src(a)posteo.de martonmiklosqdev(a)gmail.com piotr.krol(a)3mdeb.com Maciej Pijanowski michal.zygowski(a)3mdeb.com th3fanbus(a)gmail.com stefan.k.reinauer(a)gmail.com nartemiev(a)google.com arthur(a)aheymans.xyz flashrom(a)flashrom.org View all guest info https://calendar.google.com/calendar/event?action=VIEW&eid=MmVscGY2cjNsdTZw… Reply for flashrom(a)flashrom.org and view more details https://calendar.google.com/calendar/event?action=VIEW&eid=MmVscGY2cjNsdTZw… Your attendance is optional. ~~//~~ Invitation from Google Calendar: https://calendar.google.com/calendar/ You are receiving this email because you are an attendee on the event. To stop receiving future updates for this event, decline this event. Forwarding this invitation could allow any recipient to send a response to the organizer, be added to the guest list, invite others regardless of their own invitation status, or modify your RSVP. Learn more https://support.google.com/calendar/answer/37135#forwarding

1 0

Updated invitation: Flashrom Dev Meeting (monthly) @ Every 2 weeks from 4pm to 5pm on Thursday from Thu Jul 28 to Wed Nov 2 (AEST) (flashrom@flashrom.org)
by aklm＠chromium.org Sept. 23, 2022

Sept. 23, 2022

This event has been updated Changed: time Flashrom Dev Meeting (monthly) Every 2 weeks from 4pm to 5pm on Thursday from Thursday Jul 28 to Wednesday Nov 2 Eastern Australia Time - Sydney Join with Google Meet https://meet.google.com/iuf-mtri-zva?hs=224 Join by phone (AU) +61 2 9051 6791 PIN: 304642402 More phone numbers https://tel.meet/iuf-mtri-zva?pin=9271993818880&hs=0 Monthly meeting of Flashrom project developers. Meeting notes doc: https://docs.google.com/document/d/18qKvEbfPszjsJJGJhwi8kRVDUG3GZ… Guests aklm(a)chromium.org - creator felix.singer12(a)gmail.com david.hendricks(a)gmail.com quasisec(a)google.com nico.h(a)gmx.de Martin Roth src(a)posteo.de martonmiklosqdev(a)gmail.com piotr.krol(a)3mdeb.com Maciej Pijanowski michal.zygowski(a)3mdeb.com th3fanbus(a)gmail.com stefan.k.reinauer(a)gmail.com nartemiev(a)google.com arthur(a)aheymans.xyz evanbenn(a)google.com flashrom(a)flashrom.org c-d.hailfinger.devel.2006(a)gmx.net View all guest info https://calendar.google.com/calendar/event?action=VIEW&eid=MmVscGY2cjNsdTZw… Reply for flashrom(a)flashrom.org and view more details https://calendar.google.com/calendar/event?action=VIEW&eid=MmVscGY2cjNsdTZw… Your attendance is optional. ~~//~~ Invitation from Google Calendar: https://calendar.google.com/calendar/ You are receiving this email because you are an attendee on the event. To stop receiving future updates for this event, decline this event. Forwarding this invitation could allow any recipient to send a response to the organizer, be added to the guest list, invite others regardless of their own invitation status, or modify your RSVP. Learn more https://support.google.com/calendar/answer/37135#forwarding

1 0

Canceled event with note: Flashrom Dev Meeting (monthly) @ Thu Oct 20, 2022 4pm - 5pm (AEDT) (flashrom@flashrom.org)
by aklm＠chromium.org Sept. 23, 2022

Sept. 23, 2022

This event has been canceled with a note: "Cancelling the meeting for October due to daylight saving changes happening at different dates during the whole month of October." Flashrom Dev Meeting (monthly) Thursday Oct 20, 2022 ⋅ 4pm – 5pm Eastern Australia Time - Sydney Join with Google Meet https://meet.google.com/iuf-mtri-zva?hs=224 Join by phone (AU) +61 2 9051 6791 PIN: 304642402 More phone numbers https://tel.meet/iuf-mtri-zva?pin=9271993818880&hs=0 Monthly meeting of Flashrom project developers. Meeting notes doc: https://docs.google.com/document/d/18qKvEbfPszjsJJGJhwi8kRVDUG3GZ… Guests aklm(a)chromium.org - creator felix.singer12(a)gmail.com david.hendricks(a)gmail.com quasisec(a)google.com nico.h(a)gmx.de Martin Roth src(a)posteo.de martonmiklosqdev(a)gmail.com piotr.krol(a)3mdeb.com Maciej Pijanowski michal.zygowski(a)3mdeb.com th3fanbus(a)gmail.com stefan.k.reinauer(a)gmail.com nartemiev(a)google.com arthur(a)aheymans.xyz evanbenn(a)google.com flashrom(a)flashrom.org c-d.hailfinger.devel.2006(a)gmx.net ~~//~~ Invitation from Google Calendar: https://calendar.google.com/calendar/ You are receiving this email because you are an attendee on the event. To stop receiving future updates for this event, decline this event. Forwarding this invitation could allow any recipient to send a response to the organizer, be added to the guest list, invite others regardless of their own invitation status, or modify your RSVP. Learn more https://support.google.com/calendar/answer/37135#forwarding

1 0