February 2017 - flashrom - mail.coreboot.org

Re: [flashrom] New SPI NOR Flash product Support
by Stefan Tauner Aug. 15, 2019

Aug. 15, 2019

On Mon, 9 May 2016 20:46:18 -0700 David Hendricks <dhendrix(a)google.com> wrote: > Hi Victor, > From Flashrom's software perspective all chips with the same ID are > indistinguishable. > > Part number often includes characteristics such as package and thermal > tolerance which do not affect software compatibility. However, we will add the new names to the in-program (and hence wiki) database so that this new information becomes public. Thanks for the heads up, Victor. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

4 4

80/100/132 column line width policy
by Carl-Daniel Hailfinger Dec. 15, 2018

Dec. 15, 2018

Hi, we're hitting the 80 column limit in our code in ways which actually reduce readability for the code. Examples are various multiline messages and complicated nested code where refactoring to a separate function doesn't make sense. Keeping the old 80 column limit is not really an option anymore. Standard terminal sizes have one of 80, 100 or 132 columns. Given the monitor resolutions many people have nowadays, I think it is safe to say that you can fit two xterms with 100 columns horizonally next to each other. 100 columns should also be sufficient for a msg_p* of roughly 80 columns of text. 132 columns provide more leeway, but IMHO that would be too wide for good readability (and my screen can't fit two xterms side-by-side anymore). Of course some files have sections where any column limit is not acceptable (board lists etc.), but the column limit violations should be limited to the affected file sections, not whole files. Comments? I'd like to get this decided today or tomorrow so we know where we need line breaks in Stefan Tauner's new struct flashchip patch. Regards, Carl-Daniel -- http://www.hailfinger.org/

7 9

[PATCH] Fix undefined behavior in OS defines
by Stefan Tauner Oct. 12, 2017

Oct. 12, 2017

Found by clang (warning introduced in r258128), reported by Idwer. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- platform.h | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/platform.h b/platform.h index c5a52ef..b58c303 100644 --- a/platform.h +++ b/platform.h @@ -24,10 +24,24 @@ #ifndef __PLATFORM_H__ #define __PLATFORM_H__ 1 -// Helper defines for operating systems -#define IS_LINUX (defined(__gnu_linux__) || defined(__linux__)) -#define IS_MACOSX (defined(__APPLE__) && defined(__MACH__)) /* yes, both. */ -#define IS_WINDOWS (defined(_WIN32) || defined(_WIN64) || defined(__WIN32__) || defined(__WINDOWS__)) +/* Helper defines for operating systems. + * This may seem complicated but the following would be undefined behavior: + * #define IS_LINUX (defined(__gnu_linux__) || defined(__linux__)) */ +#if defined(__gnu_linux__) || defined(__linux__) + #define IS_LINUX (1) +#else + #define IS_LINUX (0) +#endif +#if defined(__APPLE__) && defined(__MACH__) /* yes, both. */ + #define IS_MACOSX (1) +#else + #define IS_MACOSX (0) +#endif +#if defined(_WIN32) || defined(_WIN64) || defined(__WIN32__) || defined(__WINDOWS__) + #define IS_WINDOWS (1) +#else + #define IS_WINDOWS (0) +#endif // Likewise for target architectures #if defined (__i386__) || defined (__x86_64__) || defined(__amd64__) -- Kind regards, Stefan Tauner

3 4

Spansion S25FL128P......X
by The Raven April 24, 2017

April 24, 2017

I have a spansion S25FL128P......X chip and can do some tests. The "problem" is that i don't know if its an 0 or an 1. On the chip i see only "FL128PIF" and one line lower i see "00299012 C". Probing works (id1 0x01, id2 0x2018): Calibrating delay loop... OK. serprog: Programmer name is "serprog-duino" Found Spansion flash chip "S25FL128P......0" (16384 kB, SPI) on serprog. Found Spansion flash chip "S25FL128P......1" (16384 kB, SPI) on serprog. Found Spansion flash chip "S25FL128S......0" (16384 kB, SPI) on serprog. Found Spansion flash chip "S25FL128S......1" (16384 kB, SPI) on serprog. Found Spansion flash chip "S25FL129P......0" (16384 kB, SPI) on serprog. Found Spansion flash chip "S25FL129P......1" (16384 kB, SPI) on serprog. Multiple flash chip definitions match the detected chip(s): "S25FL128P......0", "S25FL128P......1", "S25FL128S......0", "S25FL128S......1", "S25FL129P......0", "S25FL129P......1" Please specify which chip definition to use with the -c <chipname> option. BTW: Chip was fund on a Dell-Systemboard.

3 6

FAILED: Bay Trail
by mmzhang＠wiscom.com.cn Feb. 23, 2017

Feb. 23, 2017

Dear Sir, I got a problem. A failure occured while freshing the bios. Here is the log: (1) # ./flashrom -w ok.bin -p internal flashrom v0.9.9-r1955 on Linux 3.14.42 (i686) flashrom is free software, get the source code at https://flashrom.org Calibrating delay loop... OK. Found chipset "Intel Bay Trail". Enabling flash write... Warning: BIOS region SMM protection is enabled! Warning: Setting Bios Control at 0x0 from 0x22 to 0x01 failed. New value is 0x22. OK. Found Winbond flash chip "W25Q64.W" (8192 kB, SPI) mapped at physical address 0xff800000. Reading old flash chip contents... done. Erasing and writing flash chip... Transaction error! spi_block_erase_20 failed during command execution at address 0x320000 Reading current flash chip contents... done. Looking for another erase function. Transaction error! spi_block_erase_52 failed during command execution at address 0x320000 Reading current flash chip contents... done. Looking for another erase function. Transaction error! spi_block_erase_d8 failed during command execution at address 0x320000 Reading current flash chip contents... done. Looking for another erase function. Transaction error! spi_nbyte_program failed during command execution at address 0x0 Reading current flash chip contents... done. Looking for another erase function. Transaction error! spi_nbyte_program failed during command execution at address 0x0 Looking for another erase function. No usable erase functions left. FAILED! Uh oh. Erase/write failed. Checking if anything has changed. Reading current flash chip contents... done. Apparently at least some data has changed. Your flash chip is in an unknown state. Get help on IRC at chat.freenode.net (channel #flashrom) or mail flashrom(a)flashrom.org with the subject "FAILED: <your board name>"! ------------------------------------------------------------------------------- DO NOT REBOOT OR POWEROFF! (2) #./flashrom -V flashrom v0.9.9-r1955 on Linux 3.14.42 (i686) flashrom is free software, get the source code at https://flashrom.org flashrom was built with libpci 3.2.1, GCC 4.9.2, little endian Command line (1 args): ./flashrom -V Please select a programmer with the --programmer parameter. Previously this was not necessary because there was a default set. To choose the mainboard of this computer use 'internal'. Valid choices are: internal, dummy, nic3com, nicrealtek, gfxnvidia, drkaiser, satasii, atavia, it8212, serprog, buspirate_spi, rayer_spi, pony_spi, nicintel, nicintel_spi, nicintel_eeprom, ogp_spi, satamv, linux_spi. Please help me Best Regards Daming mmzhang(a)wiscom.com.cn

1 0

Help with a BIOS
by Vinnie Sift Feb. 20, 2017

Feb. 20, 2017

Hello! I need some help with a Bios. I have a computer given to me form my school, but the security sistem fails and the computer gets locked even two years after the graduation. Well anyway. The only solution that I have is flashing the BIOS but it has SecureFlash. I heard that using your program I can bypass it, but I don't even know what to download. The computer is a Intel with a EF10MI2 - Marble Point BIOS. It has Windows 8.1, a Debian based linux called Huayra and a UEFI Internal Shell. I already have the new BIOS Files. I will welcome any help.

1 0

USB device unavailable on macOS
by Thomas Köhn Feb. 15, 2017

Feb. 15, 2017

Hi. Beginner's question probably: I cannot get flashrom 0.98 to run natively on macOS Sierra, but when I pull it through to a VM with Ubuntu and flashrom 0.92, it works. Error on macOS is "Unable to reset FTDI device (USB device unavailable).", but the FTDI cable is in fact plugged in, the device connected and correctly powered – the exact same hardware setup works in the VM. Here is the full flashrom output: flashrom v0.9.8-r1888 on Darwin 15.5.0 (x86_64) flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OK. Unable to reset FTDI device (USB device unavailable). Unable to set latency timer (USB device unavailable). Unable to set bitmode to SPI (USB device unavailable). ftdi_write_data: -666, USB device unavailable Error: Programmer initialization failed. I made sure the USB is not captured by the VM. I even closed the VM, and later on restarted my native machine. At every step, I tried to run flashrom again, but got the exact same output. Any ideas what the reason for this is? Sounds to me like the physical connection works (since the VM worked), but somehow the macOS terminal has no access to it (although macOS in general has it, as I get a New Interfaces popup and again, the VM can access it). Thanks in advance! Thomas

1 0

FlashRom DOS - Pickit2
by Chris Nother Feb. 15, 2017

Feb. 15, 2017

Hello, I am trying to use Flashrom with the Pickit2 but I get the following output within a DOS window: *C:\Users\cnoth\Downloads>flashrom -p pickit2_spi* *flashrom v0.9.9-1-stable-f5dd7ce on Windows 6.2 (x86_64)* *flashrom is free software, get the source code at https://flashrom.org <https://flashrom.org>* *Calibrating delay loop... OK.* *Could not find a PICkit2 on USB!* *Error: Programmer initialization failed.* I have checked that the Pickit2 is recognised on the USB bus by using the standalone Microchip Pickit2 programmer and by looking at the hardware ID in control panel. I haver also tried other USB ports on my Intel NUC PC. I downloaded the latest binary from the buildbot archive. Are there any particular requirements for Flashrom that I may have missed? -- Regards, Chris Nother

1 0

[PATCH] Add support for ESMT F25L004A
by Stefan Tauner Feb. 7, 2017

Feb. 7, 2017

Also, enable AAI for ESMT F25L008A. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- flashchips.c | 45 ++++++++++++++++++++++++++++++++++++++++----- flashchips.h | 1 + 2 files changed, 41 insertions(+), 5 deletions(-) diff --git a/flashchips.c b/flashchips.c index 40b6b8e..33280e6 100644 --- a/flashchips.c +++ b/flashchips.c @@ -3315,6 +3315,41 @@ const struct flashchip flashchips[] = { { .vendor = "ESMT", + .name = "F25L004A", + .bustype = BUS_SPI, + .manufacture_id = ESMT_ID, + .model_id = ESMT_F25L004A, + .total_size = 512, + .page_size = 256, + .feature_bits = FEATURE_WRSR_EITHER, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 128} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {64 * 1024, 8} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {512 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve BP2 + AAI */ + .unlock = spi_disable_blockprotect_bp2_srwd, + .write = spi_aai_write, /* AAI supported (0xAD) */ + .read = spi_chip_read, /* Fast read (0x0B) supported */ + .voltage = {2700, 3600}, + }, + + { + .vendor = "ESMT", .name = "F25L008A", .bustype = BUS_SPI, .manufacture_id = ESMT_ID, @@ -3322,7 +3357,7 @@ const struct flashchip flashchips[] = { .total_size = 1024, .page_size = 256, .feature_bits = FEATURE_WRSR_EITHER, - .tested = TEST_OK_PREW, + .tested = { .probe = OK, .read = OK, .erase = OK, .write = NT }, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = @@ -3341,10 +3376,10 @@ const struct flashchip flashchips[] = { .block_erase = spi_block_erase_c7, } }, - .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ - .unlock = spi_disable_blockprotect, - .write = spi_chip_write_1, - .read = spi_chip_read, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve BP2 + AAI */ + .unlock = spi_disable_blockprotect_bp2_srwd, + .write = spi_aai_write, /* AAI supported (0xAD) */ + .read = spi_chip_read, /* Fast read (0x0B) supported */ .voltage = {2700, 3600}, }, diff --git a/flashchips.h b/flashchips.h index 9ffb30f..2553544 100644 --- a/flashchips.h +++ b/flashchips.h @@ -216,6 +216,7 @@ #define CATALYST_CAT28F512 0xB8 #define ESMT_ID 0x8C /* Elite Semiconductor Memory Technology (ESMT) / EFST Elite Flash Storage */ +#define ESMT_F25L004A 0x2013 #define ESMT_F25L008A 0x2014 #define ESMT_F25L32PA 0x2016 #define ESMT_F25D08QA 0x2534 -- Kind regards, Stefan Tauner

1 0