February 2014 - flashrom - mail.coreboot.org

Flashrom stuck using 100% cpu while probing for a chip
by GatoLoko April 28, 2014

April 28, 2014

I've tried to run flashrom -V to see if it could identify the chip on my new board (AsRock M3A-GLAN), and it got stuck while probing for the first chip. I've tried commenting out that specific chip (AMIC A25L05PT) and then it gets stuck on the next one. Then commented out all AMIC chips, and it got stuck on the next one (the first ATMEL on the list) I've tried with an older flashrom (0.9.2-r1141). It skipped some AMD chips, then got stuck on AMIC again. Talked with "tlt" and "stefanct" on irc and they asked for a strace and a gdb backtrace. Strace produced no results. Gdb log is attached. "stefanct" tried and reproduced it on a machine with nicintel_spi, but warned it was with an unsupported nic: http://paste.flashrom.org/view.php?id=738 -- GatoLoko

4 11

PID ID for TUMPA Lite Edition in FT2232
by Jadran Puharic April 28, 2014

April 28, 2014

I have a TUMPA Lite edition it is FTDI Based Board similar to TUMPA/FT232H, but single channel: http://www.tiaowiki.com/w/TIAO_USB_Multi_Protocol_Adapter_Lite_User's_Manual You can build one from upper link, or buy cheap on ebay. And I added this to ft2232_spi.c --- ../flashrom/ft2232_spi.c 2013-09-17 19:43:16.000000000 +0200 +++ ft2232_spi.c 2014-01-24 11:57:49.000000000 +0100 @@ -43,6 +43,7 @@ #define FTDI_FT4232H_PID 0x6011 #define FTDI_FT232H_PID 0x6014 #define TIAO_TUMPA_PID 0x8a98 +#define TIAO_TUMPA_LITE_PID 0x8a99 #define AMONTEC_JTAGKEY_PID 0xCFF8 #define GOEPEL_VID 0x096C @@ -62,6 +63,7 @@ {FTDI_VID, FTDI_FT4232H_PID, OK, "FTDI", "FT4232H"}, {FTDI_VID, FTDI_FT232H_PID, OK, "FTDI", "FT232H"}, {FTDI_VID, TIAO_TUMPA_PID, OK, "TIAO", "USB Multi-Protocol Adapter"}, + {FTDI_VID, TIAO_TUMPA_LITE_PID, OK, "TIAO", "USB Multi-Protocol Adapter Lite"}, {FTDI_VID, AMONTEC_JTAGKEY_PID, OK, "Amontec", "JTAGkey"}, {GOEPEL_VID, GOEPEL_PICOTAP_PID, OK, "GOEPEL", "PicoTAP"}, {FIC_VID, OPENMOKO_DBGBOARD_PID, OK, "FIC", "OpenMoko Neo1973 Debug board (V2+)"}, @@ -208,6 +210,10 @@ /* Interface A is SPI1, B is SPI2. */ ft2232_type = TIAO_TUMPA_PID; channel_count = 2; + } else if (!strcasecmp(arg, "tumpalite")) { + /* Only one channel is used on lite edition */ + ft2232_type = TIAO_TUMPA_LITE_PID; + channel_count = 1; } else if (!strcasecmp(arg, "busblaster")) { /* In its default configuration it is a jtagkey clone */ ft2232_type = FTDI_FT2232H_PID; works as advertised. BRGDS, Jadran Puharic

2 2

Mark MCP51 variant 0x0261 as tested.
by Marcin Kościelnicki April 27, 2014

April 27, 2014

Signed-off-by: Marcin Kościelnicki <koriakin(a)0x04.net> Index: chipset_enable.c =================================================================== --- chipset_enable.c (revision 1764) +++ chipset_enable.c (working copy) @@ -1418,7 +1418,7 @@ /* Slave, should not be here, to fix known bug for A01. */ {0x10de, 0x00d3, OK, "NVIDIA", "CK804", enable_flash_ck804}, {0x10de, 0x0260, OK, "NVIDIA", "MCP51", enable_flash_ck804}, - {0x10de, 0x0261, NT, "NVIDIA", "MCP51", enable_flash_ck804}, + {0x10de, 0x0261, OK, "NVIDIA", "MCP51", enable_flash_ck804}, {0x10de, 0x0262, NT, "NVIDIA", "MCP51", enable_flash_ck804}, {0x10de, 0x0263, NT, "NVIDIA", "MCP51", enable_flash_ck804}, {0x10de, 0x0360, OK, "NVIDIA", "MCP55", enable_flash_mcp55}, /* M57SLI*/

2 1

[PATCH] CID1130009: Resource leak
by Stefan Reinauer April 26, 2014

April 26, 2014

CID1130009: Resource leak The system resource will not be reclaimed and reused, reducing the future availability of the resource. In sp_opensocket: Leak of memory or pointers to system resources Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Index: serprog.c =================================================================== --- serprog.c (revision 1763) +++ serprog.c (working copy) @@ -100,6 +100,7 @@ if (NULL == hostPtr) { hostPtr = gethostbyaddr(ip, strlen(ip), AF_INET); if (NULL == hostPtr) { + close(sock); msg_perr("Error: cannot resolve %s\n", ip); return -1; }

2 1

[PATCH] CID1130008: Resource leak
by Stefan Reinauer April 26, 2014

April 26, 2014

CID1130008: Resource leak The system resource will not be reclaimed and reused, reducing the future availability of the resource. In read_romlayout: Leak of memory or pointers to system resources Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Index: layout.c =================================================================== --- layout.c (revision 1763) +++ layout.c (working copy) @@ -65,6 +65,7 @@ if (num_rom_entries >= MAX_ROMLAYOUT) { msg_gerr("Maximum number of ROM images (%i) in layout " "file reached.\n", MAX_ROMLAYOUT); + fclose(romlayout); return 1; } if (2 != fscanf(romlayout, "%s %s\n", tempstr, rom_entries[num_rom_entries].name))

2 1

[PATCH] CID1130007: Resource leak
by Stefan Reinauer April 26, 2014

April 26, 2014

CID1130007: Resource leak The system resource will not be reclaimed and reused, reducing the future availability of the resource. In ogp_spi_init: Leak of memory or pointers to system resources Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Index: ogp_spi.c =================================================================== --- ogp_spi.c (revision 1763) +++ ogp_spi.c (working copy) @@ -120,8 +120,10 @@ ogp_reg_sck = OGA1_XP10_CPROM_SCK; } else { msg_perr("Invalid or missing rom= parameter.\n"); + free(type); return 1; } + free(type); if (rget_io_perms()) return 1;

2 1

[PATCH] CID1130011: Use after free
by Stefan Reinauer April 26, 2014

April 26, 2014

CID1130011: Use after free This could cause an immediate crash or incorrect values might be read subsequently resulting in incorrect computations. In dump_file: A pointer to freed memory is dereferenced, used as a function argument, or otherwise used Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Index: util/ich_descriptors_tool/ich_descriptors_tool.c =================================================================== --- util/ich_descriptors_tool/ich_descriptors_tool.c (revision 1763) +++ util/ich_descriptors_tool/ich_descriptors_tool.c (working copy) @@ -77,12 +77,13 @@ printf("Dumping %u bytes of the %s region from 0x%08x-0x%08x to %s... ", file_len, region_names[i], base, limit, fn); int fh = open(fn, O_WRONLY | O_CREAT, S_IRUSR | S_IWUSR); - free(fn); if (fh < 0) { fprintf(stderr, "ERROR: couldn't open(%s): %s\n", fn, strerror(errno)); + free(fn); exit(1); } + free(fn); ret = write(fh, &dump[base >> 2], file_len); if (ret != file_len) {

2 1

[PATCH] CID1130012: Double free
by Stefan Reinauer April 26, 2014

April 26, 2014

CID1130012: Double free Depending on the implementation of the deallocator function, the memory may by placed on the free list more than once. In pony_spi_init: Memory is deallocated more than once Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Index: pony_spi.c =================================================================== --- pony_spi.c (revision 1763) +++ pony_spi.c (working copy) @@ -140,6 +140,7 @@ } else if (arg && !strlen(arg)) { msg_perr("Error: Missing argument for programmer type.\n"); free(arg); + return 1; } else if (arg){ msg_perr("Error: Invalid programmer type specified.\n"); free(arg);

2 1

[PATCH] CID1130004: Nesting level does not match indentation
by Stefan Reinauer April 26, 2014

April 26, 2014

CID1130004: Nesting level does not match indentation Code that is meant to be executed conditionally may be executed unconditionally In print_supported_boards_helper: The indentation of this code suggests it is nested when it is not. Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Index: print.c =================================================================== --- print.c (revision 1763) +++ print.c (working copy) @@ -436,13 +436,14 @@ msg_ginfo("%s", b->name); for (i = 0; i < maxboardlen - strlen(b->name); i++) msg_ginfo(" "); - if (b->working == OK) - msg_ginfo("OK "); - else if (b->working == NT) - msg_ginfo("NT "); - else - msg_ginfo("BAD "); + if (b->working == OK) + msg_ginfo("OK "); + else if (b->working == NT) + msg_ginfo("NT "); + else + msg_ginfo("BAD "); + for (e = board_matches; e->vendor_name != NULL; e++) { if (strcmp(e->vendor_name, b->vendor) || strcmp(e->board_name, b->name))

2 1

[PATCH] CID1129996: Unchecked return value from library
by Stefan Reinauer April 26, 2014

April 26, 2014

CID1129996: Unchecked return value from library The function returns a value that indicates an error condition. If this is not checked, the error condition may not be handled correctly. In sp_opensocket: Value returned from a library function is not checked for errors before being used. This value may indicate an error condition. (CWE-252) Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Index: serprog.c =================================================================== --- serprog.c (revision 1763) +++ serprog.c (working copy) @@ -114,7 +114,11 @@ } /* We are latency limited, and sometimes do write-write-read * * (write-n) - so enable TCP_NODELAY. */ - setsockopt(sock, IPPROTO_TCP, TCP_NODELAY, &flag, sizeof(int)); + if (setsockopt(sock, IPPROTO_TCP, TCP_NODELAY, &flag, sizeof(int))) { + close(sock); + msg_perr("Error: serprog cannot set socket options: %s\n", strerror(errno)); + return -1; + } return sock; } #endif

2 1