Change in flashrom[master]: flashchips: Fix N25Q512 bulk erase
Jacob Creedon has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/34489 ) Change subject: flashchips: Fix N25Q512 bulk erase ...................................................................... flashchips: Fix N25Q512 bulk erase The N25Q is a stacked device, so it requires 0xC4 to perform a die erase. Signed-off-by: Jacob Creedon <jcreedon@google.com> Change-Id: Ib408fbe5633abd8b657e3907142b997e88b33f84 --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/34489/1 diff --git a/flashchips.c b/flashchips.c index e6116ae..78873eb 100644 --- a/flashchips.c +++ b/flashchips.c @@ -10613,7 +10613,7 @@ .block_erase = spi_block_erase_d8, }, { .eraseblocks = { {65536 * 1024, 1} }, - .block_erase = spi_block_erase_c7, + .block_erase = spi_block_erase_c4, } }, .printlock = spi_prettyprint_status_register_n25q, /* TODO: config, lock, flag regs */ -- To view, visit https://review.coreboot.org/c/flashrom/+/34489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib408fbe5633abd8b657e3907142b997e88b33f84 Gerrit-Change-Number: 34489 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Creedon <jcreedon@google.com> Gerrit-MessageType: newchange
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34489 ) Change subject: flashchips: Fix N25Q512 bulk erase ...................................................................... Patch Set 1: Is that in the datasheet? -- To view, visit https://review.coreboot.org/c/flashrom/+/34489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib408fbe5633abd8b657e3907142b997e88b33f84 Gerrit-Change-Number: 34489 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Creedon <jcreedon@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 23 Jul 2019 09:38:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Jacob Creedon has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34489 ) Change subject: flashchips: Fix N25Q512 bulk erase ...................................................................... Patch Set 1:
Patch Set 1:
Is that in the datasheet?
For example, in https://www.micron.com/-/media/documents/products/data-sheet/nor-flash/seria... the first page only lists subsector, sector, and die erase under erase capability. Note that the datasheet later on does provide documentation for the bulk erase functionality, however, I think this is included due to a copy paste error. Another data point is provided by TN-25-01 (https://www.micron.com/-/media/client/global/documents/products/technical-no...): page 5 outlines the different commands and describes bulk erase being for single die devices only, and die erase for stacked devices only. TN-25-05 (https://www.micron.com/-/media/client/global/documents/products/technical-no...) also goes into stacked devices, and implies that the most you can erase at a time is a single die. -- To view, visit https://review.coreboot.org/c/flashrom/+/34489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib408fbe5633abd8b657e3907142b997e88b33f84 Gerrit-Change-Number: 34489 Gerrit-PatchSet: 1 Gerrit-Owner: Jacob Creedon <jcreedon@google.com> Gerrit-Reviewer: Jacob Creedon <jcreedon@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 23 Jul 2019 16:22:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/34489 to look at the new patch set (#2). Change subject: flashchips: Fix N25Q512 bulk erase ...................................................................... flashchips: Fix N25Q512 bulk erase The N25Q is a stacked device, so it requires 0xC4 to perform a die erase. Signed-off-by: Jacob Creedon <jcreedon@google.com> Change-Id: Ib408fbe5633abd8b657e3907142b997e88b33f84 --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/34489/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/34489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib408fbe5633abd8b657e3907142b997e88b33f84 Gerrit-Change-Number: 34489 Gerrit-PatchSet: 2 Gerrit-Owner: Jacob Creedon <jcreedon@google.com> Gerrit-Reviewer: Jacob Creedon <jcreedon@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34489 ) Change subject: flashchips: Fix N25Q512 bulk erase ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/34489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib408fbe5633abd8b657e3907142b997e88b33f84 Gerrit-Change-Number: 34489 Gerrit-PatchSet: 2 Gerrit-Owner: Jacob Creedon <jcreedon@google.com> Gerrit-Reviewer: Jacob Creedon <jcreedon@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 03 Aug 2019 14:21:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/34489 ) Change subject: flashchips: Fix N25Q512 bulk erase ...................................................................... flashchips: Fix N25Q512 bulk erase The N25Q is a stacked device, so it requires 0xC4 to perform a die erase. Signed-off-by: Jacob Creedon <jcreedon@google.com> Change-Id: Ib408fbe5633abd8b657e3907142b997e88b33f84 Reviewed-on: https://review.coreboot.org/c/flashrom/+/34489 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 31a922e..1ab48ad 100644 --- a/flashchips.c +++ b/flashchips.c @@ -10612,8 +10612,8 @@ .eraseblocks = { {64 * 1024, 1024} }, .block_erase = spi_block_erase_d8, }, { - .eraseblocks = { {65536 * 1024, 1} }, - .block_erase = spi_block_erase_c7, + .eraseblocks = { {32768 * 1024, 2} }, + .block_erase = spi_block_erase_c4, } }, .printlock = spi_prettyprint_status_register_n25q, /* TODO: config, lock, flag regs */ -- To view, visit https://review.coreboot.org/c/flashrom/+/34489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib408fbe5633abd8b657e3907142b997e88b33f84 Gerrit-Change-Number: 34489 Gerrit-PatchSet: 4 Gerrit-Owner: Jacob Creedon <jcreedon@google.com> Gerrit-Reviewer: Jacob Creedon <jcreedon@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: merged
participants (3)
-
Jacob Creedon (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)