Change in flashrom[master]: Fix building with GCC 4.9
Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/36629 ) Change subject: Fix building with GCC 4.9 ...................................................................... Fix building with GCC 4.9 It doesn't like empty initializers. Change-Id: If2988e60401155f87ee3369c77f00ccf9332012c Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- M atavia.c M it8212.c M pickit2_spi.c M usbblaster_spi.c 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/29/36629/1 diff --git a/atavia.c b/atavia.c index 80bba58..fdaaa74 100644 --- a/atavia.c +++ b/atavia.c @@ -51,7 +51,7 @@ const struct dev_entry ata_via[] = { {PCI_VENDOR_ID_VIA, 0x3249, DEP, "VIA", "VT6421A"}, - {}, + {0}, }; static void atavia_chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr); diff --git a/it8212.c b/it8212.c index 70b1d9d..ac53a6f 100644 --- a/it8212.c +++ b/it8212.c @@ -26,7 +26,7 @@ const struct dev_entry devs_it8212[] = { {PCI_VENDOR_ID_ITE, 0x8212, NT, "ITE", "8212F PATA RAID"}, - {}, + {0}, }; #define IT8212_MEMMAP_SIZE (128 * 1024) diff --git a/pickit2_spi.c b/pickit2_spi.c index 784dc13..2936ee8 100644 --- a/pickit2_spi.c +++ b/pickit2_spi.c @@ -49,7 +49,7 @@ const struct dev_entry devs_pickit2_spi[] = { {0x04D8, 0x0033, OK, "Microchip", "PICkit 2"}, - {} + {0} }; static libusb_device_handle *pickit2_handle; diff --git a/usbblaster_spi.c b/usbblaster_spi.c index d6b5084..e2a0a4f 100644 --- a/usbblaster_spi.c +++ b/usbblaster_spi.c @@ -48,7 +48,7 @@ const struct dev_entry devs_usbblasterspi[] = { {ALTERA_VID, ALTERA_USBBLASTER_PID, OK, "Altera", "USB-Blaster"}, - {} + {0} }; static const struct spi_master spi_master_usbblaster; -- To view, visit https://review.coreboot.org/c/flashrom/+/36629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If2988e60401155f87ee3369c77f00ccf9332012c Gerrit-Change-Number: 36629 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: newchange
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36629 ) Change subject: Fix building with GCC 4.9 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/36629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If2988e60401155f87ee3369c77f00ccf9332012c Gerrit-Change-Number: 36629 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 05 Nov 2019 15:13:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/36629 ) Change subject: Fix building with GCC 4.9 ...................................................................... Fix building with GCC 4.9 It doesn't like empty initializers. Change-Id: If2988e60401155f87ee3369c77f00ccf9332012c Signed-off-by: Evgeny Zinoviev <me@ch1p.io> Reviewed-on: https://review.coreboot.org/c/flashrom/+/36629 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> --- M atavia.c M it8212.c M pickit2_spi.c M usbblaster_spi.c 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/atavia.c b/atavia.c index 80bba58..fdaaa74 100644 --- a/atavia.c +++ b/atavia.c @@ -51,7 +51,7 @@ const struct dev_entry ata_via[] = { {PCI_VENDOR_ID_VIA, 0x3249, DEP, "VIA", "VT6421A"}, - {}, + {0}, }; static void atavia_chip_writeb(const struct flashctx *flash, uint8_t val, chipaddr addr); diff --git a/it8212.c b/it8212.c index 70b1d9d..ac53a6f 100644 --- a/it8212.c +++ b/it8212.c @@ -26,7 +26,7 @@ const struct dev_entry devs_it8212[] = { {PCI_VENDOR_ID_ITE, 0x8212, NT, "ITE", "8212F PATA RAID"}, - {}, + {0}, }; #define IT8212_MEMMAP_SIZE (128 * 1024) diff --git a/pickit2_spi.c b/pickit2_spi.c index 784dc13..2936ee8 100644 --- a/pickit2_spi.c +++ b/pickit2_spi.c @@ -49,7 +49,7 @@ const struct dev_entry devs_pickit2_spi[] = { {0x04D8, 0x0033, OK, "Microchip", "PICkit 2"}, - {} + {0} }; static libusb_device_handle *pickit2_handle; diff --git a/usbblaster_spi.c b/usbblaster_spi.c index d6b5084..e2a0a4f 100644 --- a/usbblaster_spi.c +++ b/usbblaster_spi.c @@ -48,7 +48,7 @@ const struct dev_entry devs_usbblasterspi[] = { {ALTERA_VID, ALTERA_USBBLASTER_PID, OK, "Altera", "USB-Blaster"}, - {} + {0} }; static const struct spi_master spi_master_usbblaster; -- To view, visit https://review.coreboot.org/c/flashrom/+/36629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If2988e60401155f87ee3369c77f00ccf9332012c Gerrit-Change-Number: 36629 Gerrit-PatchSet: 2 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: merged
participants (2)
-
Evgeny Zinoviev (Code Review) -
Nico Huber (Code Review)