Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55932 ) Change subject: [RFC] spi_master: Add shutdown function in spi_master struct ...................................................................... Patch Set 2: (1 comment) Patchset: PS1:

thank you, this is actually very useful! (as usual!) […] The "few" wasn't meant literally :)

About other masters, well, it's not very obvious indeed. As always it's hard to see/show absence of something. And it turns out that the `internal` programer might actually be the only case of this: Let's see what files have a `struct programmer_entry`: $ git grep -l '^const struct programmer_entry ' *.c and which call some `register_*master()`: $ git grep -l '\<register_\([a-z_]*\)master(' *.c and compare the two: $ diff -u <(git grep -l '^const struct programmer_entry ' *.c) <(git grep -l '\<register_\([a-z_]*\)master(' *.c) Some of it is noise (opaque.c, bitbang_spi.c, programmer.c are just infrastructure). But there are some masters without a programmer entry: * ichspi.c * it85spi.c * it87spi.c * mcp6x_spi.c * sb600spi.c * wbsio_spi.c All files not touched by commit 4f5169df. And I assume all part of the `internal` programmer. -- To view, visit https://review.coreboot.org/c/flashrom/+/55932 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2dc80dceca2f8204bcd0dad1f51753d7e79f1af5 Gerrit-Change-Number: 55932 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Thomas Heijligen <src@posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Comment-Date: Wed, 30 Jun 2021 08:19:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Gerrit-MessageType: comment