Change in ...flashrom[master]: flashchips.c: SFDP-capable chip formatting
Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33834 Change subject: flashchips.c: SFDP-capable chip formatting ...................................................................... flashchips.c: SFDP-capable chip formatting To allow automated tools to manipulate flashchips.c, make the definition of SFDP-capable chip more consistent with other definitions. This involves - reordering fields to match both other entries and the definition of struct flashchip. - reformatting comments to make them consistent with other entries. Signed-off-by: Alan Green <avg@google.com> Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 --- M flashchips.c 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/33834/1 diff --git a/flashchips.c b/flashchips.c index 8ea7043..f9ad764 100644 --- a/flashchips.c +++ b/flashchips.c @@ -16578,7 +16578,8 @@ .read = read_memmapped, }, - {/* W29EE011, W29EE012, W29C010M, W29C011A do not support probe_jedec according to the datasheet, but it works for newer(?) steppings. */ + /* W29EE011, W29EE012, W29C010M, W29C011A do not support probe_jedec according to the datasheet, but it works for newer(?) steppings. */ + { .vendor = "Winbond", .name = "W29C010(M)/W29C011A/W29EE011/W29EE012", .bustype = BUS_PARALLEL, @@ -17428,21 +17429,20 @@ .bustype = BUS_SPI, .manufacture_id = GENERIC_MANUF_ID, .model_id = SFDP_DEVICE_ID, - /* We present our own "report this" text hence we do not - * want the default "This flash part has status UNTESTED..." - * text to be printed. */ + .total_size = 0, /* set by probing function */ + .page_size = 0, /* set by probing function */ + .feature_bits = 0, /* set by probing function */ + /* We present our own "report this" text hence we do not */ + /* want the default "This flash part has status UNTESTED..." */ + /* text to be printed. */ .tested = TEST_OK_PREW, .probe = probe_spi_sfdp, + .block_erasers = {}, /* set by probing function */ .unlock = spi_disable_blockprotect, /* is this safe? */ + .write = NULL, /* set by probing function */ .read = spi_chip_read, /* FIXME: some vendor extensions define this */ .voltage = {0}, - /* Everything below will be set by the probing function. */ - .write = NULL, - .total_size = 0, - .page_size = 0, - .feature_bits = 0, - .block_erasers = {}, }, { -- To view, visit https://review.coreboot.org/c/flashrom/+/33834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 Gerrit-Change-Number: 33834 Gerrit-PatchSet: 1 Gerrit-Owner: Alan Green <avg@google.com> Gerrit-MessageType: newchange
Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/33834 to look at the new patch set (#2). Change subject: flashchips.c: SFDP-capable chip formatting ...................................................................... flashchips.c: SFDP-capable chip formatting To allow automated tools to manipulate flashchips.c, make the definition of SFDP-capable chip more consistent with other definitions. This involves - reordering fields to match both other entries and the definition of struct flashchip. - reformatting comments to make them consistent with other entries. Signed-off-by: Alan Green <avg@google.com> Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 --- M flashchips.c 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/33834/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/33834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 Gerrit-Change-Number: 33834 Gerrit-PatchSet: 2 Gerrit-Owner: Alan Green <avg@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello Edward O'Callaghan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/33834 to look at the new patch set (#4). Change subject: flashchips.c: SFDP-capable chip formatting ...................................................................... flashchips.c: SFDP-capable chip formatting To allow automated tools to manipulate flashchips.c, make the definition of SFDP-capable chip more consistent with other definitions. This involves - reordering fields to match both other entries and the definition of struct flashchip. - reformatting comments to make them consistent with other entries. Signed-off-by: Alan Green <avg@google.com> Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 --- M flashchips.c 1 file changed, 8 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/33834/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/33834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 Gerrit-Change-Number: 33834 Gerrit-PatchSet: 4 Gerrit-Owner: Alan Green <avg@google.com> Gerrit-Reviewer: Alan Green <avg@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Hello Edward O'Callaghan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/33834 to look at the new patch set (#5). Change subject: flashchips.c: SFDP-capable chip formatting ...................................................................... flashchips.c: SFDP-capable chip formatting To allow automated tools to manipulate flashchips.c, make the definition of SFDP-capable chip more consistent with other definitions. This involves - reordering fields to match both other entries and the definition of struct flashchip. - reformatting comments to make them consistent with other entries. Signed-off-by: Alan Green <avg@google.com> Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 --- M flashchips.c 1 file changed, 8 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/33834/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/33834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 Gerrit-Change-Number: 33834 Gerrit-PatchSet: 5 Gerrit-Owner: Alan Green <avg@google.com> Gerrit-Reviewer: Alan Green <avg@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33834 ) Change subject: flashchips.c: Format SFDP-capable chip entry ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/33834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 Gerrit-Change-Number: 33834 Gerrit-PatchSet: 7 Gerrit-Owner: Alan Green <avg@google.com> Gerrit-Reviewer: Alan Green <avg@google.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 02 Jul 2019 01:03:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33834 ) Change subject: flashchips.c: Format SFDP-capable chip entry ...................................................................... Patch Set 7: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/33834/6/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/33834/6/flashchips.c@17435 PS6, Line 17435: /* We present our own "report this" text hence we do not */ I think we want multi-line comments to be of the following style: ``` /** * xxx */ ``` However in the interest of unifying flashchips.c with Chromium's version and getting a lot more chip support we can do this for the moment. -- To view, visit https://review.coreboot.org/c/flashrom/+/33834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 Gerrit-Change-Number: 33834 Gerrit-PatchSet: 7 Gerrit-Owner: Alan Green <avg@google.com> Gerrit-Reviewer: Alan Green <avg@google.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 02 Jul 2019 03:44:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Hello Edward O'Callaghan, Angel Pons, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/33834 to look at the new patch set (#9). Change subject: flashchips.c: Format SFDP-capable chip entry ...................................................................... flashchips.c: Format SFDP-capable chip entry To allow automated tools to manipulate flashchips.c, make the definition of SFDP-capable chip more consistent with other definitions. This involves - reordering fields to match both other entries and the definition of struct flashchip. - reformatting comments to make them consistent with other entries. Signed-off-by: Alan Green <avg@google.com> Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 --- M flashchips.c 1 file changed, 8 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/33834/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/33834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 Gerrit-Change-Number: 33834 Gerrit-PatchSet: 9 Gerrit-Owner: Alan Green <avg@google.com> Gerrit-Reviewer: Alan Green <avg@google.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33834 ) Change subject: flashchips.c: Format SFDP-capable chip entry ...................................................................... Patch Set 9: (1 comment) https://review.coreboot.org/#/c/33834/6/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/33834/6/flashchips.c@17435 PS6, Line 17435: /* We present our own "report this" text hence we do not */
I think we want multi-line comments to be of the following style: […] Yes, that was my thinking too.
-- To view, visit https://review.coreboot.org/c/flashrom/+/33834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 Gerrit-Change-Number: 33834 Gerrit-PatchSet: 9 Gerrit-Owner: Alan Green <avg@google.com> Gerrit-Reviewer: Alan Green <avg@google.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 02 Jul 2019 04:24:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org> Gerrit-MessageType: comment
Edward O'Callaghan has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33834 ) Change subject: flashchips.c: Format SFDP-capable chip entry ...................................................................... flashchips.c: Format SFDP-capable chip entry To allow automated tools to manipulate flashchips.c, make the definition of SFDP-capable chip more consistent with other definitions. This involves - reordering fields to match both other entries and the definition of struct flashchip. - reformatting comments to make them consistent with other entries. Signed-off-by: Alan Green <avg@google.com> Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 Reviewed-on: https://review.coreboot.org/c/flashrom/+/33834 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Edward O'Callaghan <quasisec@chromium.org> --- M flashchips.c 1 file changed, 8 insertions(+), 9 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 246f139..0906b1f 100644 --- a/flashchips.c +++ b/flashchips.c @@ -17458,21 +17458,20 @@ .bustype = BUS_SPI, .manufacture_id = GENERIC_MANUF_ID, .model_id = SFDP_DEVICE_ID, - /* We present our own "report this" text hence we do not - * want the default "This flash part has status UNTESTED..." - * text to be printed. */ + .total_size = 0, /* set by probing function */ + .page_size = 0, /* set by probing function */ + .feature_bits = 0, /* set by probing function */ + /* We present our own "report this" text hence we do not */ + /* want the default "This flash part has status UNTESTED..." */ + /* text to be printed. */ .tested = TEST_OK_PREW, .probe = probe_spi_sfdp, + .block_erasers = {}, /* set by probing function */ .unlock = spi_disable_blockprotect, /* is this safe? */ + .write = NULL, /* set by probing function */ .read = spi_chip_read, /* FIXME: some vendor extensions define this */ .voltage = {0}, - /* Everything below will be set by the probing function. */ - .write = NULL, - .total_size = 0, - .page_size = 0, - .feature_bits = 0, - .block_erasers = {}, }, { -- To view, visit https://review.coreboot.org/c/flashrom/+/33834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8708a11993822085b3e8d8c80532dfb935d39876 Gerrit-Change-Number: 33834 Gerrit-PatchSet: 12 Gerrit-Owner: Alan Green <avg@google.com> Gerrit-Reviewer: Alan Green <avg@google.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: merged
participants (3)
-
Alan Green (Code Review) -
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)