Mike Banon has posted comments on this change. ( https://review.coreboot.org/23261 ) Change subject: [v4,4/6] ENE EDI - print debug info like others while probing for ENE chips ...................................................................... Patch Set 2: (4 comments) https://review.coreboot.org/#/c/23261/1/edi.c File edi.c: https://review.coreboot.org/#/c/23261/1/edi.c@154 PS1, Line 154: %i <

It's a signed integer, why print it in hex? sorry, my mistake

https://review.coreboot.org/#/c/23261/1/edi.c@164 PS1, Line 164: if (chip->hwversion == hwversion && chip->ediid == ediid) {

No need to print them, they are 0 on this path. indeed. fixed

https://review.coreboot.org/#/c/23261/1/edi.c@169 PS1, Line 169: __func__, hwversion, chip->hwversion, ediid, chip->ediid);

Please add braces here too (they are not required by syntax but help […] braces added

https://review.coreboot.org/#/c/23261/1/edi.c@171 PS1, Line 171:

Actually, I'm not sure if we want this message at all. This function […] changed the debug level to msg_cdbg2, hopefully these debug messages will be useful in some cases

-- To view, visit https://review.coreboot.org/23261 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8e62bc9f6785b4bf0be0aaf0f74c8120d77c0d4 Gerrit-Change-Number: 23261 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2@gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 30 Jan 2018 23:18:45 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No