[XS] Change in flashrom[main]: flashrom_tester: Correct "WP screw" message
Attention is currently required from: Brian Norris, Evan Benn, Hsuan-ting Chen. Hello Evan Benn, Hsuan-ting Chen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/82083?usp=email to look at the new patch set (#3). Change subject: flashrom_tester: Correct "WP screw" message ...................................................................... flashrom_tester: Correct "WP screw" message flashrom_tester prints hints on how to modify hardware write protect state as follows: ...
connect the battery (and/or open the WP screw) ... disconnect the battery (and/or open the WP screw) ...
The first advice should be "[...] close the WP screw". TEST=`flashrom_tester --flashrom_binary=$(which flashrom) \ internal Erase_and_Write Fail_to_verify` Change-Id: I45f06db51e92e68bf724b13bdf5b31bba511d270 Signed-off-by: Brian Norris <briannorris@chromium.org> --- M util/flashrom_tester/src/utils.rs 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/82083/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/82083?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I45f06db51e92e68bf724b13bdf5b31bba511d270 Gerrit-Change-Number: 82083 Gerrit-PatchSet: 3 Gerrit-Owner: Brian Norris <briannorris@chromium.org> Gerrit-Reviewer: Evan Benn <evanbenn@gmail.com> Gerrit-Reviewer: Hsuan-ting Chen <roccochen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Brian Norris <briannorris@chromium.org> Gerrit-Attention: Evan Benn <evanbenn@gmail.com> Gerrit-Attention: Hsuan-ting Chen <roccochen@google.com> Gerrit-MessageType: newpatchset
participants (1)
-
Brian Norris (Code Review)