David Hendricks has posted comments on this change. ( https://review.coreboot.org/21934 ) Change subject: fixup! nicintel_eeprom: Support for I210 emulated EEprom ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/21934/1/nicintel_eeprom.c File nicintel_eeprom.c: https://review.coreboot.org/#/c/21934/1/nicintel_eeprom.c@106 PS1, Line 106: return (device_id & 0xfff0) == 0x1530;

As this was supposed to be a fixup!, I tried to anticipate what SGTM. As the file is written, your fixup! seems correct.

If needed we can follow-up with a patch to check for other possible device IDs - perhaps by checking more raw values here or by adding an enum to nics_intel_ee[] to indicate the device's family (I210, I82580, etc) and iterating thru. -- To view, visit https://review.coreboot.org/21934 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I5d3f71e4e0f77cc8793e7f395baf69e1fad930a3 Gerrit-Change-Number: 21934 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner@gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Fri, 20 Oct 2017 18:13:26 +0000 Gerrit-HasComments: Yes