Attention is currently required from: Nico Huber, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55934 ) Change subject: dediprog: Init-shutdown test for dediprog ...................................................................... Patch Set 3: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/55934/comment/2d78b895_95715f3a PS3, Line 9: This patch adds mocks for libusb functions. To avoid dependency on I expect that some of the code could be reused to test other libusb programmers. Would it make sense to have libusb mocks in a separate compilation unit? File tests/init_shutdown.c: https://review.coreboot.org/c/flashrom/+/55934/comment/710bfe4a_1e00f15d PS3, Line 98: /* dediprog_cmds CMD_READ_PROG_INFO */ Hmmm, how about making a patch that moves the dediprog definitions the tests need into a header? File tests/tests.c: https://review.coreboot.org/c/flashrom/+/55934/comment/2454c11f_9a054ff2 PS3, Line 140: 2021 Is this magic number the current year? Or does it have another meaning? -- To view, visit https://review.coreboot.org/c/flashrom/+/55934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I38508dfb6d7c24d42522f22fcae0c5e410c5f7ea Gerrit-Change-Number: 55934 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Comment-Date: Wed, 30 Jun 2021 08:11:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment