Attention is currently required from: Richard Hughes, Angel Pons, Patrick Rudolph. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 ) Change subject: libflashrom: Return progress state to the library user ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/49643/comment/19007be0_a919d018 PS4, Line 9: Include test for the dummy spi25 device. If you could elaborate more on what this commit is doing, it would be great. Maybe add a paragraph explaining the change in more details? File libflashrom.h: https://review.coreboot.org/c/flashrom/+/49643/comment/4b938cc4_968242e6 PS4, Line 106: void * Is there a reason why last argument doesn't have a name here? all other arguments have names. File libflashrom.c: https://review.coreboot.org/c/flashrom/+/49643/comment/6676a19e_d98d9810 PS4, Line 113: private This function doesn't look to be private, it is called outside of this file. File tests/spi25.c: https://review.coreboot.org/c/flashrom/+/49643/comment/c5032b8f_f4aa73cb PS4, Line 54: size_t current, Thank you for the test! Is there any way to assert what current value is? it should change (unlike total) right? -- To view, visit https://review.coreboot.org/c/flashrom/+/49643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7197572bb7f19e3bdb2bde855d70a0f50fd3854c Gerrit-Change-Number: 49643 Gerrit-PatchSet: 4 Gerrit-Owner: Richard Hughes <richard@hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Daniel Campello <campello@chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: Richard Hughes <hughsient@gmail.com> Gerrit-CC: Thomas Heijligen <src@posteo.de> Gerrit-Attention: Richard Hughes <richard@hughsie.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Patrick Rudolph <siro@das-labor.org> Gerrit-Comment-Date: Tue, 04 May 2021 06:43:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment