Attention is currently required from: Felix Singer, Thomas Heijligen. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/22567 ) Change subject: flashchips: add W25Q128JV.M ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/22567/comment/f6fc42cd_da05032c PS1, Line 8:

Please add a link to the datasheet. The datasheet is here: https://www.winbond.com/resource-files/W25Q128JV%20RevH%2003102021%20Plus.pd...

In general we avoid putting URLs in commit messages since they are prone to change. In flashrom we put URLs in print.c which (sort of) works since we can go back and change it easily. Perhaps we should add URLs to the flashchip definitions? More background on URLs in commit messages: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/message/3IRV... https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/4F47S... Patchset: PS1: The model ID (0x7018) was already added in CB:28910 -- To view, visit https://review.coreboot.org/c/flashrom/+/22567 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifce02f4cfe54214bea5916cc91477c05fb7266ef Gerrit-Change-Number: 22567 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-Attention: Felix Singer <felixsinger@posteo.net> Gerrit-Attention: Thomas Heijligen <src@posteo.de> Gerrit-Comment-Date: Sun, 10 Oct 2021 21:53:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net> Gerrit-MessageType: comment