Attention is currently required from: Anastasia Klimchuk, Miklós Márton. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84203?usp=email ) Change subject: Fix FEATURE_NO_ERASE chips and add test for them ...................................................................... Patch Set 5: (1 comment) File include/flash.h: https://review.coreboot.org/c/flashrom/+/84203/comment/3e988205_64795c4a?usp... : PS5, Line 152: * Feature indicates that the chip does not require erase before writing. : * For implementation details, see spi95.c and search for M95M02 definition in flashchips.c. That's reasonable, but I think we can spend a few more words to include much of the explanation we've done here to minimize possible confusion. Pointing to a specific part of the code also seems error-prone (if it were to change), and this flag doesn't get used much so providing more general information seems fine: users can easily search the code for uses of this flag to find the implementation. ```suggestion * Feature indicates that the chip does not require erase before writing: * write operations can set any bit to any value without first doing an erase, * but bulk erase operations may still be supported. * * EEPROMs usually behave this way (compare to Flash, which requires erase), * for example the ST M95M02. ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/84203?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I582fe00da0715e9b5e92fcc9d15d5a90a2615117 Gerrit-Change-Number: 84203 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev@gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Miklós Márton <martonmiklosqdev@gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Comment-Date: Thu, 12 Sep 2024 04:11:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No