Attention is currently required from: Angel Pons, Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69195 ) Change subject: ichspi.c: Read chip ID and use it to identify chip ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/69195/comment/4ecaa7c5_8372e272 PS2, Line 9: BUG=b:253715389,b:253713774

Out of curiosity, what are these bug tracker entries about? Yep, please include the details here Nik so the story is more complete for upstream but also the git history.

Specifically explain how CSME presents a quasi-opaque chip however you still need to understand the chip behind hwseq for things like wp. ``` /* support writeprotect. */ flash->chip->reg_bits = entry->reg_bits; flash->chip->decode_range = entry->decode_range; ``` https://review.coreboot.org/c/flashrom/+/69195/comment/4a46fa58_e39be76e PS2, Line 11: TEST=builds I think you can include this was actually tested here across the DUT pool? -- To view, visit https://review.coreboot.org/c/flashrom/+/69195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia408e1e45dc6f53c0934afd6558e301abfa48ee6 Gerrit-Change-Number: 69195 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com> Gerrit-Comment-Date: Fri, 04 Nov 2022 22:54:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment