Attention is currently required from: Aarya, DigitalDJ. Anastasia Klimchuk has posted comments on this change by DigitalDJ. ( https://review.coreboot.org/c/flashrom/+/84234?usp=email ) Change subject: erasure_layout: Fix init_eraseblock segmentation fault ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: Just for future: you don't need to vote on your own patch, we assume the author agrees with the own patch (otherwise why would you send it? :) ). In the dev guidelines we require the patch to be approved by at least one person who is not the author. Exception is when patch is co-developed by multiple authors, then they all approve that work. You don't have to change anything here, leave your vote as is, it's not an issue. That's just info for future! -- To view, visit https://review.coreboot.org/c/flashrom/+/84234?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I61bf0d93aa9f0b2b420b146be16fcd5124f0dc5d Gerrit-Change-Number: 84234 Gerrit-PatchSet: 5 Gerrit-Owner: DigitalDJ Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: DigitalDJ Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Aarya <aarya.chaumal@gmail.com> Gerrit-Attention: DigitalDJ Gerrit-Comment-Date: Sat, 07 Sep 2024 08:44:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes