Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71577 ) Change subject: internal.c: Move sio register to own object ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File superio.c: https://review.coreboot.org/c/flashrom/+/71577/comment/a7b98ff0_d32c041a PS1, Line 40: //probe_superio_smsc(); Wow, this is dead code -- To view, visit https://review.coreboot.org/c/flashrom/+/71577 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9a4c3e12bce5d22492c8d1b8f4a3f49d736dcf31 Gerrit-Change-Number: 71577 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Thomas Heijligen <src@posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Comment-Date: Mon, 02 Jan 2023 12:09:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment