David Hendricks has posted comments on this change. ( https://review.coreboot.org/23025 ) Change subject: Modify test_v2.sh to work with upstream ...................................................................... Patch Set 5: (5 comments) https://review.coreboot.org/#/c/23025/4/tests/tests_v2/test_v2.sh File tests/tests_v2/test_v2.sh: https://review.coreboot.org/#/c/23025/4/tests/tests_v2/test_v2.sh@461 PS4, Line 461: exit $EXIT_FAILURE : fi : : # : # Setup. : # : : # Naive path check : if Changed to a naive path check. https://review.coreboot.org/#/c/23025/4/tests/tests_v2/test_v2.sh@484 PS4, Line 484: exit $EXIT_FAILURE : fi : : # print $1 and store it in the script log file : print_and_log() : { : printf "$1" | tee -a "${LOCAL_TMPDIR}/${LOGS}/${SCRIPT_LOGFILE}" : } : : # Copy files from local tmpdir to remote host tmpdir : copy_to_remote() : { : for F in $@; do Removed. Logging has been supported for some time now. https://review.coreboot.org/#/c/23025/4/tests/tests_v2/test_v2.sh@740 PS4, Line 740: Not relevant to upstream (at least not yet). https://review.coreboot.org/#/c/23025/4/tests/tests_v2/test_v2.sh@783 PS4, Line 783: elif [ $REGION_MODE -eq $R --noverify-all is committed upstream https://review.coreboot.org/#/c/23025/4/tests/tests_v2/test_v2.sh@791 PS4, Line 791: fi : : if [ $SMALL_REGION -eq 1 ]; then : PA Not relevant to upstream. -- To view, visit https://review.coreboot.org/23025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ace99fdb8d779804fe1887fe49f6409f8aff02e Gerrit-Change-Number: 23025 Gerrit-PatchSet: 5 Gerrit-Owner: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 22 Jan 2018 00:49:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No