Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54147 ) Change subject: libflashrom: clear layout on flashrom_layout_release ...................................................................... Patch Set 2: (2 comments) File layout.c: https://review.coreboot.org/c/flashrom/+/54147/comment/3924dcb1_2f9d5926 PS1, Line 296: layout->entries[i].included = false;

Should this line also move into flashrom_layout_release() ? Even better, zero the whole entry.

https://review.coreboot.org/c/flashrom/+/54147/comment/df8a188a_bab782e5 PS1, Line 279: layout_cleanup_args

This function is not cleaning up the layout anymore, only args. […] It's still layout args specifically so I'd like to keep 'layout', but layout_args_cleanup seems a little better.

-- To view, visit https://review.coreboot.org/c/flashrom/+/54147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8ba4b356f2a40ccbfd4e91f81af01d5f6a6de515 Gerrit-Change-Number: 54147 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Marheine <pmarheine@chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Comment-Date: Thu, 13 May 2021 01:06:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Gerrit-MessageType: comment