Attention is currently required from: Robert Zieba, Diana Zigterman, Edward O'Callaghan, Anastasia Klimchuk, Karthik Ramasubramanian. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62909 ) Change subject: raiden_debug_spi: Add more informative error message when WP is enabled ...................................................................... Patch Set 3: (1 comment) File raiden_debug_spi.c: https://review.coreboot.org/c/flashrom/+/62909/comment/f30feb20_bb78e2a6 PS3, Line 987: /* Check if we received an error from the device. An error will have no response : data, just the packet_id and status_code. */

We follow coding style https://www.flashrom. […] While not expliticitly mentioned, even the Linux kernel accepts the condensed style, as do folks in coreboot. However, as the code around uses the longer style, I guess that's preferred here.

-- To view, visit https://review.coreboot.org/c/flashrom/+/62909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib1e8383baa9c3ea41ab1079af12e3dc8cdff90ae Gerrit-Change-Number: 62909 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Zieba <robertzieba@google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Diana Zigterman <dzigterman@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Jon Murphy <jpmurphy@google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Eric Peers <epeers@google.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: Rob Barnes <robbarnes@google.com> Gerrit-Attention: Robert Zieba <robertzieba@google.com> Gerrit-Attention: Diana Zigterman <dzigterman@google.com> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 17:37:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Gerrit-MessageType: comment