Attention is currently required from: Subrata Banik, Edward O'Callaghan, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62282 ) Change subject: ichspi: Add Jasper Lake support ...................................................................... Patch Set 8: (2 comments) Patchset: PS4:

Given the subtle differences such as `freq_str` it looks like keeping them separate was the right id […] Well it's different from EHL, but is it really new? It looks closer to the big core PCHs, looking at Figure 1 of the datasheet. The masters and regions in the SPI guide also don't look like what we print for APL/GLK. And from the CSE version it should be somewhere between Ice Point and Comet Point. I haven't looked at every single bit, but it seems 300-series compatible (renaming the enum entry is also an option, if the code matches).

File ich_descriptors.c: https://review.coreboot.org/c/flashrom/+/62282/comment/c55662d0_05398e49 PS8, Line 1061: CHIPSET_ELKHART_LAKE

I do not but this preserves the current behavior and that sounds like a another patch. […] EHL has CSSO 0x58. It's in the updated SPI Guide and was confirmed with a real-world descriptor. IIRC, David wants us to have all paths with explicit checks plus a fallback default that repeats the most recent known chipset. That would be a fixup for the ADL/MTL patches, though. Have a look how things were before your patches and you can get the idea.

-- To view, visit https://review.coreboot.org/c/flashrom/+/62282 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib942d0b8942fe0a991b2af0b187414818485153d Gerrit-Change-Number: 62282 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Sam McNally <sammc@google.com> Gerrit-Reviewer: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik@google.com> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Fri, 01 Apr 2022 18:09:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Comment-In-Reply-To: Subrata Banik <subratabanik@google.com> Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org> Gerrit-MessageType: comment